---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/
---
(Updated July 29, 2014, 8:31 p.m.)
Review request for cloudstack and Hugo
Hi Hugo,
Where can I submit the Brocade Plugin Usage document?
Thanks Regards,
Ritu S.
-Original Message-
From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers
Sent: Wednesday, July 23, 2014 2:15 AM
To: dev@cloudstack.apache.org
Cc: Ritu Sabharwal
Subject: Re: Review
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/#review48486
---
Commit 628d8e66f77053de9819436739325720710175ed in cloudstack's
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/#review48487
---
Ship it!
commit 628d8e66f77053de9819436739325720710175ed
Author:
Hey all,
Just pushed the brocade VDX code into master.
* fing bugs is not showing any issues
* decent unit test coverage
* includes functional test procedure
* majority of the functional code is contained in a plugin, minimal changes to
core
Cheers,
Hugo
On 23 jul. 2014, at 11:12, Hugo
Ritu,
Would be good to add automated tests for the procedure you have outlined.
Marvin has already similar tests and you should be able to reuse them.
Thanks
/sudha
Testing
---
*Create an isolated network; verify that the port-profile is created on
the Brocade switch.
*
Sudha,
I think those tests are in test/integration/component/test_brocade_vcs.py that
Ritu included.
Cheers,
Hugo
On 23 jul. 2014, at 14:07, Sudha Ponnaganti sudha.ponnaga...@citrix.com wrote:
Ritu,
Would be good to add automated tests for the procedure you have outlined.
Marvin has
Hi Hugo,
Thanks for reviewing and approving the Brocade VCS plugin.
Thanks Regards,
Ritu Sabharwal.
-Original Message-
From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers
Sent: Wednesday, July 23, 2014 2:15 AM
To: dev@cloudstack.apache.org
Cc: Ritu Sabharwal
Subject:
That's right Hugo.
Thanks Regards,
Ritu S.
-Original Message-
From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers
Sent: Wednesday, July 23, 2014 5:29 AM
To: dev@cloudstack.apache.org
Cc: Ritu Sabharwal
Subject: Re: Review Request 22863: CLOUDSTACK-6823 : First code drop
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/#review48356
---
The patch applies cleanly now, thanks for rebasing.
Can you have a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/
---
(Updated July 22, 2014, 7:19 p.m.)
Review request for cloudstack and Hugo
On July 22, 2014, 9:57 a.m., Hugo Trippaers wrote:
The patch applies cleanly now, thanks for rebasing.
Can you have a look at the following findbug findings:
[INFO] --- findbugs-maven-plugin:2.5.3:check (cloudstack-findbugs) @
cloud-plugin-network-vcs ---
[INFO] BugInstance size
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/
---
(Updated July 22, 2014, 9:44 p.m.)
Review request for cloudstack and Hugo
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/#review48220
---
Can you rebase on latest master as the patch currently fails to
On July 21, 2014, 2:02 p.m., Hugo Trippaers wrote:
Can you rebase on latest master as the patch currently fails to apply.
Cheers,
Hugo
patching file api/src/com/cloud/network/Network.java
Hunk #1 FAILED at 132.
Hunk #2 succeeded at 224 (offset 3 lines).
1 out of 2
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/
---
(Updated July 21, 2014, 7:25 p.m.)
Review request for cloudstack and Hugo
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/
---
(Updated July 17, 2014, 10:04 p.m.)
Review request for cloudstack and Hugo
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/
---
(Updated July 17, 2014, 11:52 p.m.)
Review request for cloudstack and Hugo
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/#review47768
---
Can you resubmit this patch without the reformatting of system.js?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/
---
(Updated July 15, 2014, 9:16 p.m.)
Review request for cloudstack and Hugo
On July 15, 2014, 11:09 a.m., Hugo Trippaers wrote:
Can you resubmit this patch without the reformatting of system.js? At the
moment it shows 4233 changes to that file, which is impossible for me to
review. I need to see only the changes you made for the brocade plugin. If
you think
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/#review47820
---
api/src/com/cloud/network/PhysicalNetwork.java
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/
---
(Updated July 15, 2014, 9:57 p.m.)
Review request for cloudstack and Hugo
On July 15, 2014, 9:30 p.m., Erik Weber wrote:
api/src/com/cloud/network/PhysicalNetwork.java, line 36
https://reviews.apache.org/r/22863/diff/4/?file=632861#file632861line36
Looks like you removed the 'N' in L3VPN
Fixed it.
- Ritu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/
---
(Updated July 11, 2014, 10:10 p.m.)
Review request for cloudstack and Hugo
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/
---
(Updated July 8, 2014, 9:30 a.m.)
Review request for cloudstack and Hugo
On June 24, 2014, 6:40 a.m., Hugo Trippaers wrote:
Hey,
There are a number of issues with this patch, i've made the commments on
the lines directly. Also where is the real functionality? The code in this
patch seems to only be the hook into the existing cloudstack code and not
On June 24, 2014, 6:40 a.m., Hugo Trippaers wrote:
Hey,
There are a number of issues with this patch, i've made the commments on
the lines directly. Also where is the real functionality? The code in this
patch seems to only be the hook into the existing cloudstack code and not
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/
---
(Updated July 4, 2014, 9:35 a.m.)
Review request for cloudstack and Hugo
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/
---
(Updated June 26, 2014, 10:25 p.m.)
Review request for cloudstack.
Changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/#review46498
---
Hey,
There are a number of issues with this patch, i've made the
Hi Hugo,
There is a separate file
From: Hugo Trippaers [mailto:nore...@reviews.apache.org] On Behalf Of Hugo
Trippaers
Sent: Monday, June 23, 2014 11:41 PM
To: Ritu Sabharwal; Hugo Trippaers; cloudstack
Subject: Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for
Brocade Network
On June 24, 2014, 6:40 a.m., Hugo Trippaers wrote:
Hey,
There are a number of issues with this patch, i've made the commments on
the lines directly. Also where is the real functionality? The code in this
patch seems to only be the hook into the existing cloudstack code and not
Hi Sebastian,
I submitted the first code drop for plugin for review. Can you please create a
new branch for Brocade plugin development.
Also, I wanted to know how do I select specific reviewers for reviewing the
request. I did not see any option to choose that while submitting the request.
34 matches
Mail list logo
