---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23192/#review78993
---
Thank you for submitting your CloudStack contribution through
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23192/#review64046
---
ping, any update on this?
- Rohit Yadav
On July 3, 2014, 11:58
Hi Hugo,
Does this make sense? Do you still think it should be part of noredist profile?
~Rajani
On 09-Jul-2014, at 10:44 am, Rajani Karuturi
rajani.karut...@citrix.commailto:rajani.karut...@citrix.com wrote:
Hi Hugo,
Even in case of windows installer, mysql-connector-java is mentioned in a
Hi Hugo,
Does this make sense? Do you still think it should be part of noredist profile?
~Rajani
On 09-Jul-2014, at 10:44 am, Rajani Karuturi
rajani.karut...@citrix.commailto:rajani.karut...@citrix.com wrote:
Hi Hugo,
Even in case of windows installer, mysql-connector-java is mentioned in a
I believe this has nothing to do with nonoss. If I understand it right, nonoss
modules are required for cloudstack to work with certain 3rd party stuff.
This one is just a helper to create a windows installer. It chose to use a mvn
command to create the installer instead of shell/bat script. It
Rajani,
That is why we renamed nonoss to noredist. It has to do with the policy of the
Apache Software Foundation regarding compatible licenses [1]. The problem in
this case is subtle, but there is a difference. The main point in the
discussion is so-called system dependencies. We know we need
Hi Hugo,
Even in case of windows installer, mysql-connector-java is mentioned in a
[spec] file. only difference being, it also mentions the download url as
windows doesn’t have a package repository and doesn’t know where to download
from.
It will not be part of the installer. The msi only tells
Hugo,
As Rajani mentioned we are not packaging the sources with MSI installer, we
are telling to installer from where to download the dependencies.
Anyhow my question is, the MSI build is already part of separate build profile
(buildw) which is not build with default profile. So still we need
Ok,
To clarify the windows MSI will not build in the default profile. I have
enabled a new profile buildw to build windows MSI installer which explicitly
we need to pass similar to nonoss?
Is that sufficient to make it nonoss or still we need to move it under nonoss
profile explicitly?
Heya,
On 7/3/14, 4:11 PM, Chip Childers chipchild...@apache.org wrote:
On Thu, Jul 03, 2014 at 02:59:55PM +0200, Hugo Trippaers wrote:
On to the actual point behind my comment, ASF policy is not very clear
about when we can or can¹t put anything in our code that points to
something with a
On Thu, Jul 03, 2014 at 03:14:30PM +, Leo Simons wrote:
It looks like that maven pom on windows _by default_ downloads and
installs a variety of non-apache-license (and/or non-mit/bsd/variant
license) software. That shouldn¹t really happen. The principle is one of
³least surprise²: As a
On Thu, Jul 3, 2014 at 12:08 PM, Chip Childers chipchild...@apache.org wrote:
On Thu, Jul 03, 2014 at 03:14:30PM +, Leo Simons wrote:
It looks like that maven pom on windows _by default_ downloads and
installs a variety of non-apache-license (and/or non-mit/bsd/variant
license) software.
On July 3, 2014, 2:18 p.m., Chip Childers wrote:
-1 to this commit until legal policy issues are resolved
Reverted the commit
commit 4607c26949b6b925fdc0eb2a5253d536dd333439
Author: Koushik Das kous...@apache.org
Date: Fri Jul 4 10:04:04 2014 +0530
Revert CLOUDSTACK-6834 : 3. Some
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23192/
---
(Updated July 3, 2014, 10:22 a.m.)
Review request for cloudstack, Abhinandan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23192/
---
(Updated July 3, 2014, 11:58 a.m.)
Review request for cloudstack, Abhinandan
On July 3, 2014, 11:58 a.m., Hugo Trippaers wrote:
I'm not sure we can actually have a dependency on the mysql connector like
this because of it's GPL license. I'll check this and get back on this
before we can accept this patch.
Hugo, I committed this patch (on master
On July 3, 2014, 11:58 a.m., Hugo Trippaers wrote:
I'm not sure we can actually have a dependency on the mysql connector like
this because of it's GPL license. I'll check this and get back on this
before we can accept this patch.
Koushik Das wrote:
Hugo, I committed this patch
Hey Koushik,
No problem, will do if required.
The review doesn’t have a “ship it” state, so thats why i assumed it was not
committed. Also a lot of folks adopted the common practice to put the commit id
in a comment after committing a review. That makes it easier to trace.
Cheers,
Hugo
On
On to the actual point behind my comment, ASF policy is not very clear about
when we can or can’t put anything in our code that points to something with a
(L)GPL license. I would like some feedback from people with a finer grasp of
the policy to see if we can actually include this dependency
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23192/#review47300
---
Ship it!
master - ce5061e107f743e52b23445fd97fcf60d8160ec6
-
I was about to give the ship it and then saw your comment. Anyways have done
it now.
On 03-Jul-2014, at 6:03 PM, Hugo Trippaers h...@apache.org wrote:
Hey Koushik,
No problem, will do if required.
The review doesn’t have a “ship it” state, so thats why i assumed it was not
committed.
On Thu, Jul 03, 2014 at 02:59:55PM +0200, Hugo Trippaers wrote:
On to the actual point behind my comment, ASF policy is not very clear
about when we can or can’t put anything in our code that points to
something with a (L)GPL license. I would like some feedback from
people with a finer grasp
On Thu, Jul 03, 2014 at 01:37:27PM +, Koushik Das wrote:
I was about to give the ship it and then saw your comment. Anyways have
done it now.
We are likely to need to revert (or at least change through a new
commit) a bunch of things introduced within the pom and msi files. See
my last
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23192/#review47301
---
-1 to this commit until legal policy issues are resolved
- Chip
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23192/
---
(Updated July 2, 2014, 12:29 p.m.)
Review request for cloudstack, Abhinandan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23192/#review47280
---
scripts/installer/windows/readme.txt
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23192/
---
Review request for cloudstack, Abhinandan Prateek and Koushik Das.
Bugs:
27 matches
Mail list logo
