---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23282/#review48208
---
Ship it!
commit 03de9cc33507400e0e06ccd84a36334a4660ef4e
Author:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23282/#review48207
---
Commit 03de9cc33507400e0e06ccd84a36334a4660ef4e in cloudstack's
Heya all,
I’ve pushed support for the NuageVSP feature just now. Technically two days
after the intended feature freeze for 4.6, but i think i can get away with it
for the following reasons:
* The feature was submitted on the review board before the feature freeze
* The feature includes
On 19 jul. 2014, at 02:49, Suresh Ramamurthy
suresh.ramamur...@nuagenetworks.net wrote:
snip
I had following questions regarding compiling only nuagevsp plugin
a) To build only nuagevsp, is below command correct.
mvn clean install -P developer,nuagevsp
Correct
b) To run client
Hi Hugo,
Thanks for reviewing NuageVsp plugin on time and making it part for
CloudStack's virtual networking solution.
Thanks,
Suresh
On Mon, Jul 21, 2014 at 1:56 AM, Hugo Trippaers h...@trippaers.nl wrote:
Heya all,
I’ve pushed support for the NuageVSP feature just now. Technically two
Hi Hugo,
I closed all your review comments. Did you get a chance to look at the
latest code changes done for NuageVsp plugin?
Thanks
Suresh
On Fri, Jul 18, 2014 at 5:49 PM, Suresh Ramamurthy
suresh.ramamur...@nuagenetworks.net wrote:
This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23282/#review48121
---
* Unit tests complete successfully
* Findbugs output reports no
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23282/
---
(Updated July 19, 2014, 12:49 a.m.)
Review request for cloudstack, Alena
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23282/#review47766
---
The patch applies cleanly on current master and i did some
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23282/
---
(Updated July 15, 2014, 11:38 a.m.)
Review request for cloudstack, Alena
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23282/#review47774
---
Suresh,
While testing the new plugin i noticed that i get a popup
On July 15, 2014, 3:01 p.m., Hugo Trippaers wrote:
Suresh,
While testing the new plugin i noticed that i get a popup telling me
Provider NuageVsp should be enabled in at least one physical network of
the zone specified even though i have not configured anything. I was just
Hi Hugo,
Could you please test the latest diffs. I have removed default NuageVspVpc
offering. This could have caused the issue.
I will also test my changes locally.
Thanks,
Suresh
On Tue, Jul 15, 2014 at 8:02 AM, Hugo Trippaers
htrippa...@schubergphilis.com wrote:
This is an
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23282/
---
(Updated July 14, 2014, 7:29 a.m.)
Review request for cloudstack and Hugo
On July 8, 2014, 10:07 a.m., Hugo Trippaers wrote:
client/tomcatconf/log4j-cloud.xml.in, line 66
https://reviews.apache.org/r/23282/diff/1/?file=624288#file624288line66
Why do you introduce a new logfile specific for Nuage? Isn't is easier
for admins if all cloudstack related
Hi Hugo,
I have updated NuageVsp plugin with you comments and also implemented your
suggesions.
Could you please review them and let me know if you have any further
comments so that i can quickly implement them and check-in the code by July
19.
Thanks for your support,
Suresh Ramamurthy
On
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23282/
---
(Updated July 15, 2014, 1:45 a.m.)
Review request for cloudstack and Hugo
On July 8, 2014, 10:07 a.m., Hugo Trippaers wrote:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java,
line 196
https://reviews.apache.org/r/23282/diff/1/?file=624333#file624333line196
I'm not really agreeing with this method of loading the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23282/#review47436
---
Hey Suresh,
Great to see this review, happy to help integrate the
On July 8, 2014, 10:07 a.m., Hugo Trippaers wrote:
client/tomcatconf/log4j-cloud.xml.in, line 66
https://reviews.apache.org/r/23282/diff/1/?file=624288#file624288line66
Why do you introduce a new logfile specific for Nuage? Isn't is easier
for admins if all cloudstack related
Hi Hugo,
Thanks for reviewing NuageVsp plugin and supporting us.
I have update the comments with my response.
Thanks,
Suresh
On Tue, Jul 8, 2014 at 3:07 AM, Hugo Trippaers
htrippa...@schubergphilis.com wrote:
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23282/
---
(Updated July 7, 2014, 6 p.m.)
Review request for cloudstack and Hugo
Hi Hugo, Sheng Yang,
I have posted the first code drop for NuageVsp network plugin in the review
board(https://reviews.apache.org/r/23282/).
Could you please review them and let me know your comments.
Also, we need a new branch to check-in the fixes once the review is done.
Could you please
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23282/
---
Review request for cloudstack and Hugo Trippaers.
Bugs: CLOUDSTACK-6845
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23282/
---
(Updated July 6, 2014, 2:02 a.m.)
Review request for cloudstack and Hugo
25 matches
Mail list logo
