RE: Disabling failed test cases (was RE: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases)

2014-07-22 Thread Santhosh Edukulla
Ponnaganti [sudha.ponnaga...@citrix.com] Sent: Monday, July 21, 2014 7:42 AM To: dev@cloudstack.apache.org Subject: RE: Disabling failed test cases (was RE: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases) Hugo, I absolutely agree with you that tests should not be disabled and fixes

RE: Disabling failed test cases (was RE: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases)

2014-07-22 Thread Sudha Ponnaganti
From: Sudha Ponnaganti [sudha.ponnaga...@citrix.com] Sent: Monday, July 21, 2014 7:42 AM To: dev@cloudstack.apache.org Subject: RE: Disabling failed test cases (was RE: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases) Hugo, I absolutely agree with you that tests should

Re: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases

2014-07-21 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23605/#review48203 --- Commit 43dffaad5fd197c87a8dab087066f677a095dee7 in cloudstack's

Re: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases

2014-07-21 Thread Hugo Trippaers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23605/#review48204 --- Why would we want to disable test cases that fail? Doesn't this

Re: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases

2014-07-21 Thread Gaurav Aradhye
On July 21, 2014, 1:03 p.m., Hugo Trippaers wrote: Why would we want to disable test cases that fail? Doesn't this mean we need to fix something else so they don't fail anymore? Hi Hugo, Whenever we found a test case failing, we create bug for that, may it be a test script issue or

Re: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases

2014-07-21 Thread Hugo Trippaers
Hey Gaurav, That doesn’t make a lot of sense to me. If the test sequence fails because of a bug it should keep failing until the bug is resolved, otherwise the tests will report that the situation is OK while in all reality it is not. These test should be in indication that Apache CloudStack

RE: Disabling failed test cases (was RE: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases)

2014-07-21 Thread Stephen Turner
: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases On July 21, 2014, 1:03 p.m., Hugo Trippaers wrote: Why would we want to disable test cases that fail? Doesn't this mean we need to fix something else so they don't fail anymore? Hi Hugo, Whenever we found a test case failing

Re: Disabling failed test cases (was RE: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases)

2014-07-21 Thread Gaurav Aradhye
is going up or down. -- Stephen Turner -Original Message- From: Gaurav Aradhye [mailto:nore...@reviews.apache.org] On Behalf Of Gaurav Aradhye Sent: 21 July 2014 09:58 To: Girish Shilamkar Cc: Gaurav Aradhye; Hugo Trippaers; cloudstack Subject: Re: Review Request 23605: CLOUDSTACK-7107

RE: Disabling failed test cases (was RE: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases)

2014-07-21 Thread Santhosh Edukulla
cases (was RE: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases) Hugo, Stephen, We have been following this practice as part of Continuous Integration changes as defined in doc [1]. I personally think that tagging test case with BugId is good idea to map the test cases with bugs

Re: Disabling failed test cases (was RE: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases)

2014-07-21 Thread Hugo Trippaers
: Girish Shilamkar Subject: Re: Disabling failed test cases (was RE: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases) Hugo, Stephen, We have been following this practice as part of Continuous Integration changes as defined in doc [1]. I personally think that tagging

RE: Disabling failed test cases (was RE: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases)

2014-07-21 Thread Sudha Ponnaganti
To: Gaurav Aradhye; Stephen Turner; Hugo Trippaers; dev@cloudstack.apache.org Cc: Girish Shilamkar Subject: RE: Disabling failed test cases (was RE: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases) All, Alex, wanted to disable test cases in between CI( continuous integration

Re: Disabling failed test cases (was RE: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases)

2014-07-21 Thread Hugo Trippaers
; Hugo Trippaers; dev@cloudstack.apache.org Cc: Girish Shilamkar Subject: RE: Disabling failed test cases (was RE: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases) All, Alex, wanted to disable test cases in between CI( continuous integration) runs for the below reason

RE: Disabling failed test cases (was RE: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases)

2014-07-21 Thread Stephen Turner
; Hugo Trippaers; cloudstack Subject: Re: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases On July 21, 2014, 1:03 p.m., Hugo Trippaers wrote: Why would we want to disable test cases that fail? Doesn't this mean we need to fix something else so they don't fail anymore? Hi

RE: Disabling failed test cases (was RE: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases)

2014-07-21 Thread Sudha Ponnaganti
+Process -Original Message- From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers Sent: Monday, July 21, 2014 3:32 AM To: dev@cloudstack.apache.org Subject: Re: Disabling failed test cases (was RE: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases) Hey Sudha

RE: Disabling failed test cases (was RE: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases)

2014-07-21 Thread Stephen Turner
:43 To: dev@cloudstack.apache.org Subject: RE: Disabling failed test cases (was RE: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases) Hugo, I absolutely agree with you that tests should not be disabled and fixes should be made before check in. As per what Alex has mentioned

Re: Disabling failed test cases (was RE: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases)

2014-07-21 Thread Hugo Trippaers
-Original Message- From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers Sent: Monday, July 21, 2014 3:32 AM To: dev@cloudstack.apache.org Subject: Re: Disabling failed test cases (was RE: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases) Hey

Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases

2014-07-17 Thread Gaurav Aradhye
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23605/ --- Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7074 and