Re: Review Request 23750: Fixed Coverity Reported Issues

2014-07-22 Thread Hugo Trippaers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23750/#review48350 --- Santosh, you can commit this directly right? Just make individual

Re: Review Request 23750: Fixed Coverity Reported Issues

2014-07-22 Thread Santhosh Edukulla
On July 22, 2014, 8:01 a.m., Hugo Trippaers wrote: Santosh, you can commit this directly right? Just make individual commits of each file/component so its easy to track down any issues later. Sure, i will commit, but please do a review and i want to be sure that no regression issues are

Re: Review Request 23750: Fixed Coverity Reported Issues

2014-07-22 Thread Santhosh Edukulla
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23750/ --- (Updated July 22, 2014, 8:34 a.m.) Review request for cloudstack, daan

Re: Review Request 23750: Fixed Coverity Reported Issues

2014-07-22 Thread Daan Hoogland
Santhosh, these coverity findings should unveil hidden regression possibilities and that's alright. I think you should just commit them with a marker like 'coverity:'. we'll have to deal with the regressions when we encounter them (and write appropriate unit tests as they come along) On Tue, Jul

Review Request 23750: Fixed Coverity Reported Issues

2014-07-21 Thread Santhosh Edukulla
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23750/ --- Review request for cloudstack, daan Hoogland, Koushik Das, and Hugo Trippaers.