Re: Review Request 24111: Coverity findings for brocade-plugin

2014-08-05 Thread Santhosh Edukulla
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24111/#review49578 --- Ship it! Ship It! - Santhosh Edukulla On July 31, 2014, 5:57

Re: Review Request 24111: Coverity findings for brocade-plugin

2014-08-05 Thread Santhosh Edukulla
On Aug. 5, 2014, 9:31 a.m., Santhosh Edukulla wrote: Ship It! Pushed to master Updated Branches: refs/heads/master 1bfb1f650 - cc725e53e - Santhosh --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 24111: Coverity findings for brocade-plugin

2014-08-03 Thread Santhosh Edukulla
On Aug. 1, 2014, 5:57 a.m., Santhosh Edukulla wrote: plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java, line 547 https://reviews.apache.org/r/24111/diff/2/?file=646948#file646948line547 It seems there is no corresponding catch here, did

Re: Review Request 24111: Coverity findings for brocade-plugin

2014-08-01 Thread Ritu Sabharwal
On Aug. 1, 2014, 5:57 a.m., Santhosh Edukulla wrote: plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java, line 547 https://reviews.apache.org/r/24111/diff/2/?file=646948#file646948line547 It seems there is no corresponding catch here, did

Re: Review Request 24111: Coverity findings for brocade-plugin

2014-07-31 Thread Ritu Sabharwal
On July 31, 2014, 4:19 a.m., Santhosh Edukulla wrote: plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java, line 482 https://reviews.apache.org/r/24111/diff/1/?file=646144#file646144line482 Message info seems to be corrected. Hi Santhosh, What

Re: Review Request 24111: Coverity findings for brocade-plugin

2014-07-31 Thread Santhosh Edukulla
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24111/#review49213 ---

Re: Review Request 24111: Coverity findings for brocade-plugin

2014-07-31 Thread Ritu Sabharwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24111/ --- (Updated July 31, 2014, 5:57 p.m.) Review request for cloudstack and Hugo

Re: Review Request 24111: Coverity findings for brocade-plugin

2014-07-31 Thread Ritu Sabharwal
On July 31, 2014, 7:01 a.m., Santhosh Edukulla wrote: plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java, line 482 https://reviews.apache.org/r/24111/diff/1/?file=646144#file646144line482 This particular try\except is for an IO exception

Re: Review Request 24111: Coverity findings for brocade-plugin

2014-07-31 Thread Santhosh Edukulla
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24111/#review49323 ---

Review Request 24111: Coverity findings for brocade-plugin

2014-07-30 Thread Ritu Sabharwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24111/ --- Review request for cloudstack and Hugo Trippaers. Bugs: CLOUDSTACK-6823

Re: Review Request 24111: Coverity findings for brocade-plugin

2014-07-30 Thread Santhosh Edukulla
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24111/#review49200 ---