Review Request 24184: CLOUDSTACK-1389 Fixing sudo access to keytool

2014-08-01 Thread Erik Weber
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24184/ --- Review request for cloudstack and edison su. Bugs: CLOUDSTACK-1389

Re: Review Request 24184: CLOUDSTACK-1389 Fixing sudo access to keytool

2014-08-01 Thread Rohit Yadav
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24184/#review49343 --- Thanks Eric for picking this up, looks good but need to test. -

Re: Review Request 24184: CLOUDSTACK-1389 Fixing sudo access to keytool

2014-08-01 Thread Hugo Trippaers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24184/#review49346 --- Ship it! Thanks for the fix! commit

Re: Review Request 24184: CLOUDSTACK-1389 Fixing sudo access to keytool

2014-08-01 Thread Hugo Trippaers
On Aug. 1, 2014, 3:07 p.m., Rohit Yadav wrote: Thanks Eric for picking this up, looks good but need to test. Sorry, didn't see your review before i committed mine. Anyway it works for me. - Hugo --- This is an automatically