Re: Review Request 25289: CLOUDSTACK-7474-Failed-to-start-MS-with-java7-version

2015-04-06 Thread Sebastien Goasguen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25289/#review78994 --- Thank you for submitting your CloudStack contribution through

Re: Review Request 25289: CLOUDSTACK-7474-Failed-to-start-MS-with-java7-version

2014-12-05 Thread Rohit Yadav
On Sept. 4, 2014, 5:21 p.m., Frank Zhang wrote: Ship It! Rohit Yadav wrote: Rayees can you please fix it and upload a second patch; don't commit on master yet please. ping. - Rohit --- This is an automatically generated

Re: Review Request 25289: CLOUDSTACK-7474-Failed-to-start-MS-with-java7-version

2014-09-04 Thread Frank Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25289/#review52323 --- Ship it! Ship It! - Frank Zhang On Sept. 3, 2014, 6:25 a.m.,

Re: Review Request 25289: CLOUDSTACK-7474-Failed-to-start-MS-with-java7-version

2014-09-04 Thread Rohit Yadav
On Sept. 3, 2014, 9:32 a.m., Rajani Karuturi wrote: client/tomcatconf/classpath.conf.in, line 37 https://reviews.apache.org/r/25289/diff/1/?file=674877#file674877line37 Can we get the JAVA_HOME from installed java instead of hardcoding it? The path may be different for different

Re: Review Request 25289: CLOUDSTACK-7474-Failed-to-start-MS-with-java7-version

2014-09-04 Thread Rohit Yadav
On Sept. 4, 2014, 5:21 p.m., Frank Zhang wrote: Ship It! Rayees can you please fix it and upload a second patch; don't commit on master yet please. - Rohit --- This is an automatically generated e-mail. To reply, visit:

Review Request 25289: CLOUDSTACK-7474-Failed-to-start-MS-with-java7-version

2014-09-03 Thread Rayees Namathponnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25289/ --- Review request for cloudstack, Frank Zhang and Hugo Trippaers. Bugs:

Re: Review Request 25289: CLOUDSTACK-7474-Failed-to-start-MS-with-java7-version

2014-09-03 Thread Rajani Karuturi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25289/#review52151 --- client/tomcatconf/classpath.conf.in

Re: Review Request 25289: CLOUDSTACK-7474-Failed-to-start-MS-with-java7-version

2014-09-03 Thread Frank Zhang
On Sept. 3, 2014, 9:32 a.m., Rajani Karuturi wrote: client/tomcatconf/classpath.conf.in, line 37 https://reviews.apache.org/r/25289/diff/1/?file=674877#file674877line37 Can we get the JAVA_HOME from installed java instead of hardcoding it? The path may be different for different

Re: Review Request 25289: CLOUDSTACK-7474-Failed-to-start-MS-with-java7-version

2014-09-03 Thread Alex Brett
On Sept. 3, 2014, 9:32 a.m., Rajani Karuturi wrote: client/tomcatconf/classpath.conf.in, line 37 https://reviews.apache.org/r/25289/diff/1/?file=674877#file674877line37 Can we get the JAVA_HOME from installed java instead of hardcoding it? The path may be different for different

Re: Review Request 25289: CLOUDSTACK-7474-Failed-to-start-MS-with-java7-version

2014-09-03 Thread David Nalley
On Wed, Sep 3, 2014 at 7:40 PM, Alex Brett alex.br...@citrix.com wrote: On Sept. 3, 2014, 9:32 a.m., Rajani Karuturi wrote: client/tomcatconf/classpath.conf.in, line 37 https://reviews.apache.org/r/25289/diff/1/?file=674877#file674877line37 Can we get the JAVA_HOME from installed

RE: Review Request 25289: CLOUDSTACK-7474-Failed-to-start-MS-with-java7-version

2014-09-03 Thread Alex Brett
On 04 September 2014 00:45, David Nalley [da...@gnsa.us] wrote: On Wed, Sep 3, 2014 at 7:40 PM, Alex Brett alex.br...@citrix.com wrote: To expand on this a little bit - in RHEL 6.3 if you have both Java 1.6 and Java 7 installed, the default behaviour with the alternatives mechanism makes 1.6

Re: Review Request 25289: CLOUDSTACK-7474-Failed-to-start-MS-with-java7-version

2014-09-03 Thread David Nalley
On Wed, Sep 3, 2014 at 8:12 PM, Alex Brett alex.br...@citrix.com wrote: On 04 September 2014 00:45, David Nalley [da...@gnsa.us] wrote: On Wed, Sep 3, 2014 at 7:40 PM, Alex Brett alex.br...@citrix.com wrote: To expand on this a little bit - in RHEL 6.3 if you have both Java 1.6 and Java 7