Re: Review Request 26482: CLOUDSTACK-7688: Do not allow various operations which breaks VM Snapshots

2014-10-15 Thread anthony xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26482/#review56739 --- Ship it! Ship It! - anthony xu On Oct. 9, 2014, 9:09 a.m.,

Re: Review Request 26482: CLOUDSTACK-7688: Do not allow various operations which breaks VM Snapshots

2014-10-13 Thread Anshul Gangwar
On Oct. 10, 2014, 6:15 p.m., anthony xu wrote: Can you explain why you remove the code? // remove diskAndMemory VM snapshots Removed code was removing VM snapshots without user knowing. Now we are not allowing user to upgrade/scale VM when it has VM snapshots. So this code will not be

Re: Review Request 26482: CLOUDSTACK-7688: Do not allow various operations which breaks VM Snapshots

2014-10-10 Thread anthony xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26482/#review56181 --- Can you explain why you remove the code? // remove diskAndMemory

Re: Review Request 26482: CLOUDSTACK-7688: Do not allow various operations which breaks VM Snapshots

2014-10-09 Thread Anshul Gangwar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26482/ --- (Updated Oct. 9, 2014, 9:09 a.m.) Review request for cloudstack, anthony xu

Review Request 26482: CLOUDSTACK-7688: Do not allow various operations which breaks VM Snapshots

2014-10-08 Thread Anshul Gangwar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26482/ --- Review request for cloudstack, anthony xu and Devdeep Singh. Bugs: