Re: Review Request 28523: CLOUDSTACK-7991: test_security_groups.py - Move config data to test_data.py and fix pep8 issues

2014-12-02 Thread Gaurav Aradhye
On Nov. 30, 2014, 10:16 p.m., Pierre-Luc Dion wrote: Cannot be merge into 4.5 branch their is conflict in ``test/integration/component/test_security_groups.py`` Gaurav Aradhye wrote: Thanks Pierre-Luc, I will check, and put rebased patch. Can you please try now? It wasn't applying

Re: Review Request 28523: CLOUDSTACK-7991: test_security_groups.py - Move config data to test_data.py and fix pep8 issues

2014-12-02 Thread Pierre-Luc Dion
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28523/#review63535 --- Pushed into master and 4.5 branches. - Pierre-Luc Dion On Nov.

Re: Review Request 28523: CLOUDSTACK-7991: test_security_groups.py - Move config data to test_data.py and fix pep8 issues

2014-11-30 Thread Pierre-Luc Dion
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28523/#review63318 --- Ship it! CLOUDSTACK-7991 - Pierre-Luc Dion On Nov. 28, 2014,

Re: Review Request 28523: CLOUDSTACK-7991: test_security_groups.py - Move config data to test_data.py and fix pep8 issues

2014-11-30 Thread Pierre-Luc Dion
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28523/#review63319 --- Ship it! Ship It! - Pierre-Luc Dion On Nov. 28, 2014, 8:55

Re: Review Request 28523: CLOUDSTACK-7991: test_security_groups.py - Move config data to test_data.py and fix pep8 issues

2014-11-30 Thread Pierre-Luc Dion
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28523/#review63320 --- Cannot be merge into 4.5 branch their is conflict in

Re: Review Request 28523: CLOUDSTACK-7991: test_security_groups.py - Move config data to test_data.py and fix pep8 issues

2014-11-30 Thread Gaurav Aradhye
On Nov. 30, 2014, 10:16 p.m., Pierre-Luc Dion wrote: Cannot be merge into 4.5 branch their is conflict in ``test/integration/component/test_security_groups.py`` Thanks Pierre-Luc, I will check, and put rebased patch. - Gaurav ---

Review Request 28523: CLOUDSTACK-7991: test_security_groups.py - Move config data to test_data.py and fix pep8 issues

2014-11-28 Thread Gaurav Aradhye
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28523/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: