Yes, this should be a noop for LibvirtStorageAdaptor. I'm not sure why
we decided to delete the pool.
On Thu, Dec 19, 2013 at 6:05 PM, Mike Tutkowski
mike.tutkow...@solidfire.com wrote:
I updated the CRs and assigned them to Marcus.
Since the issues are not related to the new iSCSI code
My notes from the initial version of the patch with instructions read:
LibvirtStorageAdaptor: need to implement dummy
connectPhysicalDisk/disconnectPhysicalDisk
I must have missed during review that the final implementation
actually did something.
On Thu, Dec 26, 2013 at 10:47 PM, Marcus
Actually, I see why now. This code that deletes storage pool used to
be in LibvirtComputingResource.java, named cleanupDisk. It was only
ever called for isos, because we only had Libvirt Storage. Now,
cleanupDisk is called for everything, so that other storage adaptors
can do their cleanup, but
Hi Mike,
I looked at your commit: 858ce766659101eb731c83c806892dd5d9baa976, seems it
will try to delete primary storage every time when stopping a VM ,which maybe
the root cause a kvm blocker bug: CLOUDSTACK-5432, KVM guest vms are crashed
during the automation test. From the agent log, I
Interesting...that commit was a combination of Marcus' and my code. We
might want to bring him in on this conversation.
I believe the idea is when a VM is stopped that we want to remove, for
example, its iSCSI connections to its data disks (just using iSCSI as an
example here). This is similar
