Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/709#issuecomment-132140803
@karuturi You should send a public key which has it's special characters (
SPACE / - % ) replaced with uri compatible escape characters. - encoding
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/709#issuecomment-132145283
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/703#issuecomment-132145192
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/188#issuecomment-132160851
Yes this was committed.
On 14-Aug-2015, at 2:48 pm, Rohit Yadav notificati...@github.com wrote:
Was this merge on master?
â
Hello,
@remi: Thanks would great if this PR can be included in master before
the release process of 4.6. Thanks.
@all (translators): New strings needs to be translated on Transifex[1].
I will make an update of the l10n properties files just before the start
of 4.6 release process.
Milamber
GitHub user radu-stefanache opened a pull request:
https://github.com/apache/cloudstack/pull/711
Typo correction
Cannnot != Cannot
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/radu-stefanache/cloudstack
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/708#issuecomment-132152921
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/708
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/711#issuecomment-132153264
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
See http://jenkins.buildacloud.org/job/build-master-noredist/4533/changes
Changes:
[radu.stefanache] Typo correction
--
[...truncated 8205 lines...]
2015-08-18 10:11:11 DEBUG Script:433 - Looking for
scripts/vm/systemvm/id_rsa.cloud in
GitHub user milamberspace opened a pull request:
https://github.com/apache/cloudstack/pull/712
CLOUDSTACK-8744 Add missing localization (l10n) for several parts in â¦
â¦the UI
- l10n for the SSH Key Pairs behavior
- l10n for Autoscaling / LB sections
- l10n for
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/709#issuecomment-132102845
LGTM.
I made the commit two years ago. However, something changed in the
following commit, so the encoding on UI is not needed any more.
See http://jenkins.buildacloud.org/job/build-master-slowbuild/2087/
--
[...truncated 25932 lines...]
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @
cloud-plugin-network-srx
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/710#issuecomment-132120109
apart from the formatting changes, are there any other changes?
Can you please make separate commits for formatting and the actual changes
with clear commit
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/696#issuecomment-132146849
LGTM
The resizing in general should be done using libvirt-java and not by
executing 'virsh' at all.
It could be that the Java bindings for libvirt are
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/707#issuecomment-132154456
LGTM to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
See http://jenkins.buildacloud.org/job/simulator-4.5-singlerun/260/
--
Started by upstream project build-4.5-simulator build number 315
originally caused by:
Started by upstream project build-4.5 build number 511
originally caused by:
Started by an SCM
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/709
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Copy thread from @users, as I am not sure where is the right place to
find right people for helping.
Forwarded Message
Subject:Re: new timestamp format for API in ACS 4.5.1
Date: Tue, 18 Aug 2015 18:04:56 +0800
From: tony_caot...@163.com
Reply-To:
Github user sailajamada commented on the pull request:
https://github.com/apache/cloudstack/pull/710#issuecomment-132122426
Hi Rajani,
There are two commits
First Commit:
1) Initial Test automation had only 37 test cases and no support for LXC.
This includes
Github user milamberspace commented on the pull request:
https://github.com/apache/cloudstack/pull/615#issuecomment-132091017
The PR #709 don't fix the issue for me. I can't add a SSH key pair without
revert the #615.
---
If your project is set up for it, you can reply to this
update the usage_event table with VM.DESTROY event for this vm.
I would say create a vm, destroy it and observer the entries in usage_event
table. create a similar entry for the manually destroyed vm.
~Rajani
On Tue, Aug 18, 2015 at 12:12 AM, raja sekhar rajsekhar@gmail.com
wrote:
Hi All,
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/705#issuecomment-132115146
Hi @karuturi
The pull analysis failure is unrelated. -- Checkstyle errors in code I
didn't touch
The errors in the master build are being
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/709#issuecomment-132121319
@borisroman excluding the cloudmonkey bit, if I make direct api call,
should I send the encoded value or the original value. Did that change from
previous version?
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/710#issuecomment-132124601
Hi @sailajamada, In both the commits, I am seeing only formatting changes
in both the commits. I am sure that I am missing the real changes in the pep8
formats.
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/705#issuecomment-132121809
ok. will check PR #707. Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user bvbharatk commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/692#discussion_r37269538
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsRedundant.py ---
@@ -96,7 +96,7 @@ def _redundant_on(self):
d =
GitHub user sailajamada opened a pull request:
https://github.com/apache/cloudstack/pull/710
Browser Based Volume and Template Upload Test Automation Modifications
CLOUDSTACK-8735
Test Browser_template_Life_cycle ... === TestName:
test_01_Browser_template_Life_cycle_tpath |
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/709#issuecomment-132121577
@milamberspace, I couldnt find registerSSHKeyPair from UI. I could only see
reset ssh key on a stopped vm. Where is this option in UI?
---
If your project is set
Github user milamberspace commented on the pull request:
https://github.com/apache/cloudstack/pull/615#issuecomment-132097141
Sorry, I clean up my browser cache, now works with the #709 fix. Thanks
@borisroman
---
If your project is set up for it, you can reply to this email and
Github user milamberspace commented on the pull request:
https://github.com/apache/cloudstack/pull/709#issuecomment-132097225
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/709#issuecomment-132123648
@karuturi go to the Accounts page, and select SSH Key pairs in the
dropdown.
---
If your project is set up for it, you can reply to this email and have your
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/709#issuecomment-132106862
@karuturi Cloudmonkey passes an single encoded public key, as it's supposed
to!
---
If your project is set up for it, you can reply to this email and have your
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/635#issuecomment-132174594
@devdeep look great. one question but LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user sailajamada commented on the pull request:
https://github.com/apache/cloudstack/pull/710#issuecomment-132195800
Hi Rajani,
To run the test:
1. Use the test data file included in the commit or add below section to
your test data file
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/700#issuecomment-132197866
Hi all,
Sorry the delay.
Well, @anshul1886 IMHO the test cases add value to the code, they are
making sure that those paths are properly
See http://jenkins.buildacloud.org/job/build-master-slowbuild/2088/changes
Changes:
[radu.stefanache] Typo correction
[Boris Schrijver] Removed double encoding of Public Key from JS.
--
[...truncated 25932 lines...]
[INFO] Nothing to compile - all
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/707#issuecomment-132175228
I seeing below errors after applying this patch. Please do a noredist build
as mentioned at
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/707#issuecomment-132187698
@karuturi I see, fixed them in a new commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/700#issuecomment-132189625
@anshul1886 I agree with your point about the purpose of unit tests. In
this case the purpose is to make sure developers don't change the paths, isn't
it? So
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/700#issuecomment-132182774
@anshul1886 if the purpose is to ensure that the path returned doesn't
change, this seems perfectly aceptable to me. If people want to change the path
in the
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/700#issuecomment-132186831
@DaanHoogland That doesn't seems to be the case here. I believe if somebody
has to change unit test with every change then that unit test is burden and
should
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/351#issuecomment-132173995
@anshul1886 if the purpose is to ensure that the path returned doesn't
change, this seems perfectly aceptable to me. If people want to change the path
in the
See http://jenkins.buildacloud.org/job/build-master-noredist/4534/
--
[...truncated 8580 lines...]
at
net.sourceforge.pmd.RuleSetReferenceId.getInputStream(RuleSetReferenceId.java:315)
at
GitHub user nitt10prashant opened a pull request:
https://github.com/apache/cloudstack/pull/713
CLOUDSTACK-8745 : verify usage after root disk migration
put storage in maintenance mode and start ha vm and check usage ... ===
TestName: test_ha_with_storage_maintenance | Status :
-0
I think there is no harm in keeping the PRs open which are not merged yet, as a
reference which can be picked up by someone over time and merged/closed later.
For example, here is an interesting PR that is more than a month old but if you
close it we risk forgetting about it:
See http://jenkins.buildacloud.org/job/build-master-slowbuild/2090/changes
Changes:
[sowmya.krishnan] CLOUDSTACK-8738: Added the two methods for enable and cancel
maintenance mode on StoragePool
[sowmya.krishnan] Fixed pep8 issues
[rene.moser] CLOUDSTACK-8740: add custom.css to make custom UI
See http://jenkins.buildacloud.org/job/build-master-slowbuild/2091/
--
[...truncated 25932 lines...]
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @
cloud-plugin-network-srx
See http://jenkins.buildacloud.org/job/build-master-slowbuild/2093/
--
[...truncated 25932 lines...]
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @
cloud-plugin-network-srx
Github user ksowmya commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/713#discussion_r37379405
--- Diff: test/integration/component/maint/test_ha_pool_maintenance.py ---
@@ -0,0 +1,229 @@
+#!/usr/bin/env python
+# Licensed to the Apache
Github user nitt10prashant commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/713#discussion_r37379426
--- Diff: test/integration/component/maint/test_ha_pool_maintenance.py ---
@@ -0,0 +1,229 @@
+#!/usr/bin/env python
+# Licensed to the
Github user ksowmya commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/713#discussion_r37379847
--- Diff: test/integration/component/maint/test_ha_pool_maintenance.py ---
@@ -0,0 +1,229 @@
+#!/usr/bin/env python
+# Licensed to the Apache
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/700#issuecomment-132438972
@rafaelweingartner @DaanHoogland If the purpose is to make sure that path
is not modified by other developer then adding note/comment on top of that line
makes
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/689#issuecomment-132442691
@DaanHoogland @kishankavala @jburwell The documentation to run and check
the plugin are in this pull request:
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack-docs-install/pull/23
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Hi All:
Does any one have any idea ? Thanks.
---
Cao Tong
On 08/18/2015 06:04 PM, tony_caot...@163.com wrote:
In ParamProcessWorker::setFieldValue() I found this lins:
case DATE:
// This piece of code is for maintaining backward
compatibility
GitHub user abhinandanprateek opened a pull request:
https://github.com/apache/cloudstack-docs-admin/pull/30
CLOUDSTACK-8592: Quota plugin usage documentation
This document provides information on configuring and running the quota
service. It also provides information on various
Github user nitt10prashant commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/713#discussion_r37379373
--- Diff: test/integration/component/maint/test_ha_pool_maintenance.py ---
@@ -0,0 +1,229 @@
+#!/usr/bin/env python
+# Licensed to the
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/707#issuecomment-132444220
build is successful now. :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user nitt10prashant commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/713#discussion_r37379748
--- Diff: test/integration/component/maint/test_ha_pool_maintenance.py ---
@@ -0,0 +1,229 @@
+#!/usr/bin/env python
+# Licensed to the
Github user devdeep commented on the pull request:
https://github.com/apache/cloudstack/pull/635#issuecomment-132439804
@remibergsma I'll close this pull request and generate a new one where the
unit tests are squashed in one commit.
---
If your project is set up for it, you can
Github user devdeep closed the pull request at:
https://github.com/apache/cloudstack/pull/635
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ksowmya commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/713#discussion_r37379183
--- Diff: test/integration/component/maint/test_ha_pool_maintenance.py ---
@@ -0,0 +1,229 @@
+#!/usr/bin/env python
+# Licensed to the Apache
Github user ksowmya commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/713#discussion_r37379122
--- Diff: test/integration/component/maint/test_ha_pool_maintenance.py ---
@@ -0,0 +1,229 @@
+#!/usr/bin/env python
+# Licensed to the Apache
Github user ksowmya commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/713#discussion_r37379467
--- Diff: test/integration/component/maint/test_ha_pool_maintenance.py ---
@@ -0,0 +1,229 @@
+#!/usr/bin/env python
+# Licensed to the Apache
Github user ksowmya commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/713#discussion_r37379515
--- Diff: test/integration/component/maint/test_ha_pool_maintenance.py ---
@@ -0,0 +1,229 @@
+#!/usr/bin/env python
+# Licensed to the Apache
GitHub user devdeep opened a pull request:
https://github.com/apache/cloudstack/pull/715
CLOUDSTACK-8687: Prepare template only on a given storage pool
Update prepare template api to seed/prepare a template only on a given
primary storage. Currently, the prepare template api will
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/714#issuecomment-132335229
@pedro-martins s_logger is a standard name for the variables and in each
class it gets the class.class as its log category. I fail to see how you
change
See http://jenkins.buildacloud.org/job/build-master-noredist/4532/changes
Changes:
[Boris Schrijver] Removed double encoding of Public Key from JS.
--
[...truncated 7827 lines...]
at
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack-docs-rn/pull/24#issuecomment-132164867
Thanks for the PR @rhosdev. Its merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack-docs-rn/pull/24
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
See http://jenkins.buildacloud.org/job/build-master-slowbuild/2092/
--
[...truncated 25929 lines...]
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @
cloud-plugin-network-srx
See http://jenkins.buildacloud.org/job/build-master-slowbuild/2094/
--
[...truncated 25932 lines...]
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @
cloud-plugin-network-srx
Github user ksowmya commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/691#discussion_r37381189
--- Diff: test/integration/component/test_persistent_networks.py ---
@@ -1459,6 +1459,135 @@ def test_delete_account(self):
return
Github user nitt10prashant commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/713#discussion_r37380762
--- Diff: test/integration/component/maint/test_ha_pool_maintenance.py ---
@@ -0,0 +1,229 @@
+#!/usr/bin/env python
+# Licensed to the
Github user nitt10prashant commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/713#discussion_r37380740
--- Diff: test/integration/component/maint/test_ha_pool_maintenance.py ---
@@ -0,0 +1,229 @@
+#!/usr/bin/env python
+# Licensed to the
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/707
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user ksowmya commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/713#discussion_r37381494
--- Diff: test/integration/component/maint/test_ha_pool_maintenance.py ---
@@ -0,0 +1,229 @@
+#!/usr/bin/env python
+# Licensed to the Apache
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack-docs-rn/pull/20
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/635#issuecomment-132237794
@devdeep Could you please make your commit message (first line) more
descriptive? Right now I cannot tell the difference between them, unless I
click on them
See http://jenkins.buildacloud.org/job/build-master-noredist/4537/
--
[...truncated 7272 lines...]
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at
Hi all,
This PR includes the ones we can close now:
https://github.com/apache/cloudstack/pull/706
Any LGTM’s so we can merge it?
Thanks,
Remi
On 17 Aug 2015, at 18:56, Rajani Karuturi
raj...@apache.orgmailto:raj...@apache.org wrote:
+1 for auto closing.
I also agree with Boris that we need
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/711
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/711#issuecomment-132228606
LGTM, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/703
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
See http://jenkins.buildacloud.org/job/build-master-noredist/4536/changes
Changes:
[sowmya.krishnan] CLOUDSTACK-8738: Added the two methods for enable and cancel
maintenance mode on StoragePool
[sowmya.krishnan] Fixed pep8 issues
--
[...truncated 7464
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/635#issuecomment-132237051
Travis error is due to timeout.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user pedro-martins opened a pull request:
https://github.com/apache/cloudstack/pull/714
Changed variable s_logger to non-static and fixed its name in
âcom.cloud.utils.component.ComponentLifecycleBaseâ and its subclasses
Hi guys,
We have noticed that every single
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/704#issuecomment-132234421
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
See http://jenkins.buildacloud.org/job/build-master-noredist/4535/changes
Changes:
[radu.stefanache] Typo correction
--
[...truncated 7918 lines...]
at
net.sourceforge.pmd.RuleSetFactory.createRuleSets(RuleSetFactory.java:114)
at
See http://jenkins.buildacloud.org/job/build-master-slowbuild/2089/
--
[...truncated 25932 lines...]
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @
cloud-plugin-network-srx
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/712#issuecomment-132229241
Thanks @milamberspace it should be possible to merge it before 4.6 RC.
Let's find some reviewers.
---
If your project is set up for it, you can reply to this
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/703#issuecomment-132234105
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/712#issuecomment-132252988
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user milamberspace commented on the pull request:
https://github.com/apache/cloudstack/pull/704#issuecomment-132252887
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
See http://jenkins.buildacloud.org/job/build-master-noredist/4538/changes
Changes:
[rene.moser] CLOUDSTACK-8740: add custom.css to make custom UI styles easier
--
[...truncated 8409 lines...]
2015-08-18 16:12:21 DEBUG Ovm3HypervisorResource:389 - override
Hi all,
Could you please have a look at the PRs we have waiting [1] and review them?
Test it, look at the code or otherwise review them. Add comments, or add a LGTM
when you think it’s OK. Even if you review just one PR per day it already helps
:-)
I’ll keep an eye on them as well and will
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/704#issuecomment-132253205
so there is nothing in this custom.css file ?
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/699#issuecomment-132253698
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/697#issuecomment-132253810
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
1 - 100 of 104 matches
Mail list logo
