[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8951: validation for con...

2015-10-13 Thread karuturi
GitHub user karuturi opened a pull request: https://github.com/apache/cloudstack/pull/929 [4.7] CLOUDSTACK-8951: validation for config param "remote.access.vpn.psk.length" throwing error for value < 8 and value > 256 right now, 8, 256 are hardcoded in the code. They should be

[GitHub] cloudstack pull request: Add all tests in /test/integration/smoke ...

2015-10-13 Thread kishankavala
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/920#issuecomment-147944007 @runseb @pvr9711 @sanjeevneelarapu Can we include all regression simulator tests also? --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: [4.7] secure and hidden config values are...

2015-10-13 Thread karuturi
GitHub user karuturi opened a pull request: https://github.com/apache/cloudstack/pull/927 [4.7] secure and hidden config values are returned as plaintext string secure and hidden config values are first unencrypted before returning them in the api. This is not desired as they

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8950 Hypervisor Paramete...

2015-10-13 Thread karuturi
GitHub user karuturi opened a pull request: https://github.com/apache/cloudstack/pull/928 [4.7] CLOUDSTACK-8950 Hypervisor Parameter check is not performed for registerTemplate and getUploadParamsForTemplate API's Any string is allowed as hypervisor type from the api.

[GitHub] cloudstack pull request: CLOUDSTACK-8934 - Default routes not conf...

2015-10-13 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/923#issuecomment-147633618 Testing now, will post results later today! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack-www pull request: Improvements to survey.html

2015-10-13 Thread runseb
Github user runseb commented on the pull request: https://github.com/apache/cloudstack-www/pull/16#issuecomment-147636042 +0 I don't think we need two LGTM etc for this. But it's automatically built, so you don't need to touch the .html. Jut edit the .md file, and

[GitHub] cloudstack pull request: Quota

2015-10-13 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41834872 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,422 @@ +//Licensed to

[GitHub] cloudstack pull request: Local cloudstack

2015-10-13 Thread sarathkouk
GitHub user sarathkouk reopened a pull request: https://github.com/apache/cloudstack/pull/919 Local cloudstack LDAP: Auto Import and Trust AD You can merge this pull request into a Git repository by running: $ git pull https://github.com/sarathkouk/cloudstack local_cloudstack

Re: [GitHub] cloudstack pull request: Add all tests in /test/integration/smoke ...

2015-10-13 Thread Sanjeev N
Hi, travis/script.sh uses following nose command to pick the tests. nosetests --with-xunit --xunit-file=integration-test-results/$suite.xml --with-marvin --marvin-config=setup/dev/advanced.cfg test/integration/$suite.py -s -a tags=advanced,required_hardware=false --zone=Sandbox-simulator

[GitHub] cloudstack-www pull request: Improvements to survey.html

2015-10-13 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack-www/pull/16#issuecomment-147637056 I didn't touch the html manually, but included the generated html in the commit. Not sure if that is necessary or not. Should I wait for a couple of

[GitHub] cloudstack-www pull request: Improvements to survey.html

2015-10-13 Thread runseb
Github user runseb commented on the pull request: https://github.com/apache/cloudstack-www/pull/16#issuecomment-147640430 you can merge. but make sure to merge in the other branch as well, otherwise it won't go live. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack-www pull request: Improvements to survey.html

2015-10-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack-www/pull/16 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack-www pull request: Improvements to survey.html

2015-10-13 Thread terbolous
GitHub user terbolous opened a pull request: https://github.com/apache/cloudstack-www/pull/16 Improvements to survey.html Made the survey.html agnostic to protocol used, previously the iframe was hardcoded with a http:// link and this breaks when visiting the site over

[GitHub] cloudstack pull request: Quota

2015-10-13 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41847054 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,397 @@ +//Licensed to the Apache Software Foundation

[GitHub] cloudstack pull request: [4.5] CLOUDSTACK-8848: ensure power state...

2015-10-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/922 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Quota

2015-10-13 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41845814 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,304 @@ +//Licensed to the Apache

Build failed in Jenkins: simulator-4.5-singlerun #274

2015-10-13 Thread jenkins
See -- Started by upstream project "build-4.5-simulator" build number 328 originally caused by: Started by upstream project "build-4.5" build number 532 originally caused by: Started by

[GitHub] cloudstack pull request: [4.5] CLOUDSTACK-8848: ensure power state...

2015-10-13 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/922#issuecomment-147663586 LGTM, merging on 4.5 as we've already merged this on master. Thanks for the PR @resmo --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: Quota

2015-10-13 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41848280 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,397 @@ +//Licensed to the Apache Software Foundation

[GitHub] cloudstack pull request: Quota

2015-10-13 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41846405 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,304 @@ +//Licensed to the Apache

[GitHub] cloudstack pull request: Quota

2015-10-13 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41847268 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,397 @@ +//Licensed to the Apache Software Foundation

[GitHub] cloudstack pull request: Quota

2015-10-13 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41848405 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,397 @@ +//Licensed to the Apache Software Foundation

[GitHub] cloudstack pull request: Quota

2015-10-13 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41848497 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,397 @@ +//Licensed to the Apache Software Foundation

[GitHub] cloudstack pull request: Quota

2015-10-13 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41844702 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,422 @@ +//Licensed to

[GitHub] cloudstack pull request: Quota

2015-10-13 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41845417 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaStatementResponse.java --- @@ -0,0 +1,130 @@ +//Licensed to

[GitHub] cloudstack pull request: Add all tests in /test/integration/smoke ...

2015-10-13 Thread runseb
Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/920#issuecomment-147706546 Sanjeev, good point, Travis only runs advanced zone tests. Maybe we should figure out a way to also run the tests with a basic config. --- If your project is set up

[GitHub] cloudstack pull request: Quota

2015-10-13 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41853484 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/ServiceOfferingDaoImpl.java --- @@ -0,0 +1,86 @@ +// Licensed to the Apache

[GitHub] cloudstack pull request: CLOUDSTACK-8934 - Default routes not conf...

2015-10-13 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/923#issuecomment-147700296 @wilderrodrigues Thanks, looking good! LGTM Tested on 2-node KVM cluster on CentOS 7. I started by running the same tests: ``` nosetests

[GitHub] cloudstack pull request: CLOUDSTACK-8793 Enable s2s VPN connection...

2015-10-13 Thread pdube
Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/879#issuecomment-147741954 Hey guys, I have been re-pushing the branch for it to build on Jenkins. It has been failing, but it doesn't seem to be related to my fixes (it seems like Jenkins

[GitHub] cloudstack pull request: CLOUDSTACK-8934 - Default routes not conf...

2015-10-13 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/923#issuecomment-147749011 thanks for running the tests @remibergsma should we merge this PR since we have two reviews from @DaanHoogland and @remibergsma ? --- If your project is set

[GitHub] cloudstack pull request: CLOUDSTACK-7984: Collect network statisti...

2015-10-13 Thread ustcweizhou
GitHub user ustcweizhou opened a pull request: https://github.com/apache/cloudstack/pull/926 CLOUDSTACK-7984: Collect network statistics for VMs on shared network (KVM implementation) For now we can get network traffic statistics from virtual router for isolated network. For

Re: 4.6 release

2015-10-13 Thread Rajani Karuturi
current status: we have 6 blockers CLOUDSTACK-8947: Load Balancer not working with Isolated Networks - Wilder Rodrigues is working on this (PR will be ready tomorrow) CLOUDSTACK-8933: SSVm and CPVM do not survive a reboot from API - unassigned ( KVM specific issue. I spent sometime on it but,

Re: Time to create 4.6 branch ?

2015-10-13 Thread Boris Schrijver
Dear Wei. In the new release process we are releasing directly from master. So no 4.6 branch will be created. As we are releasing directly from master, it is now frozen till release. -- Met vriendelijke groet / Kind regards, Boris Schrijver PCextreme B.V. http://www.pcextreme.nl/contact

Re: Time to create 4.6 branch ?

2015-10-13 Thread Sebastien Goasguen
Wei might have a point, however: 1-We still have blockers, and one is unassigned, the others are on Wilder’s plate. So there is still work to get done on the blockers and work to help Wilder. 2-If you don’t work on blockers you can start testing master as if it was RC and getting ready to

BVT Report 10/14

2015-10-13 Thread Raja Pullela
BVT Report - 10/14; No change from earlier report - 10/5 - Simulator Basic - 100% - Simulator Adv - 100% - XS Basic - 98.6%, 1 failure - XS Adv - 95.5%, 5 failures - KVM Basic - 94.2%, 4 failures - KVM Adv - 92.6%, 8 failures Working

Time to create 4.6 branch ?

2015-10-13 Thread Wei ZHOU
Guys, As I know, 4.6 will be close to RC. I am wondering if it is time to create 4.6 branch, so that we can add the upgrade path to next version and new features/improvements can be merged into master branch (to keep a clean 4.6 branch). By the way, which is the new version? 4.7 or 5.0 ? -Wei

Re: Time to create 4.6 branch ?

2015-10-13 Thread Wei ZHOU
Dear Boris, Thanks for your quick reply. so maybe no 4.6.1 in the future? 2015-10-13 20:47 GMT+01:00 Boris Schrijver : > Dear Wei. > > In the new release process we are releasing directly from master. So no 4.6 > branch will be created. > > As we are releasing directly

[GitHub] cloudstack pull request: CLOUDSTACK-8934 - Default routes not conf...

2015-10-13 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/923#issuecomment-147841813 @remibergsma @karuturi @wilderrodrigues @DaanHoogland I tested this PR today. Tests ran fine except for the cleanups (which are known by CLOUDSTACK-8935). I'll

Re: Time to create 4.6 branch ?

2015-10-13 Thread Pierre-Luc Dion
Hi, we have the same under has Boris where all new release would be done on master. Do we have any wikipage explaining the new release cycle, Wei have a good point... Cheers, On Oct 13, 2015 15:57, "Wei ZHOU" wrote: > Dear Boris, > > Thanks for your quick reply. > so

[GitHub] cloudstack pull request: CLOUDSTACK-8934 - Default routes not conf...

2015-10-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/923 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8934 - Default routes not conf...

2015-10-13 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/923#issuecomment-147780057 Let's wait for the test results of @borisroman as he said he was testing as well. @borisroman if you are no longer testing, please let us know. --- If

[GitHub] cloudstack pull request: Quota

2015-10-13 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41923847 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,301 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota

2015-10-13 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41923673 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,304 @@ +//Licensed to the Apache Software

Build failed in Jenkins: build-master-jdk18 #365

2015-10-13 Thread jenkins
See Changes: [wrodrigues] CLOUDSTACK-8934 - Add default gateway when the public interface is up again [wrodrigues] CLOUDSTACK-8934 - Adding tests to cover default routes on IsoNest and RVR nets [wrodrigues] CLOUDSTACK-8934 -

Re: Time to create 4.6 branch ?

2015-10-13 Thread Remi Bergsma
There indeed will be a 4.6 branch once 4.6RC passes and 4.6.0 is released. From this branch we will create 4.6.x releases. The process is documented here: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Release+principles+for+Apache+CloudStack+4.6+and+up Regards, Remi On 13/10/15