[GitHub] cloudstack pull request: CLOUDSTACK-9334: Support jenv and pyenv t...

Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1460#issuecomment-205228160 Jenkins has failed on RAT, but the report doesn't indicate the nature of the problem. As an attempt to debug, I was unable to replicate the failure locally

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r58355784 --- Diff: api/src/com/cloud/network/vpc/OSPFZoneConfig.java --- @@ -0,0 +1,332 @@ +// Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1444#discussion_r58375427 --- Diff: plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java --- @@ -484,6 +489,10 @@ public

[GitHub] cloudstack pull request: CLOUDSTACK-9333: Exclude clusters from OV...

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1457#issuecomment-205316122 @rafaelweingartner Ok, nice. I like that option. The only question I have about this is that if property could be changed from UI by users after inserted in

RE: Redundant Router Interfaces

Hi Wei, I implemented your modifications on a test cloud we have here and it worked well. Redundant routers in the backup state booted with public interfaces down. As you said, they also negotiated the VRRP instance over eth0 which is correct. As an aside, regarding the following code:

[GitHub] cloudstack pull request: travis: Fix simulator tests and optimize ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1461#issuecomment-205615803 ### CI RESULTS **85/85 TESTS PASS** Everything is looking pretty good from this side. **Associated Uploads**

[GitHub] cloudstack pull request: CLOUDSTACK-8611:Handle SSH if server "for...

Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1459#discussion_r58478990 --- Diff: utils/src/main/java/com/cloud/utils/ssh/SshHelper.java --- @@ -1,209 +1,306 @@ -// -// Licensed to the Apache Software

[GitHub] cloudstack pull request: CLOUDSTACK-8611:Handle SSH if server "for...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1459#issuecomment-205604082 @GabrielBrascher, since @likitha seems to have left the community, could you take over all of the changes and just commit the changes in a way that the

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

Github user swill commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1444#discussion_r58480834 --- Diff: plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java --- @@ -484,6 +489,10 @@ public

[GitHub] cloudstack pull request: CLOUDSTACK-9323: Fix cancel host maintena...

Github user abhinandanprateek commented on the pull request: https://github.com/apache/cloudstack/pull/1454#issuecomment-205624341 @swill In my environment I am using macchinina templates for testing. These are not there by default but are pretty handy in testing due to their small

[GitHub] cloudstack pull request: ui: fix typo in dashboard's fetchlatest u...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1462#issuecomment-205643191 @swill feel free to create a JIRA ticket for this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

Re: Hooking into the SecurityGroups

Hi Nux, I think ipset ‘myipset’ changes might be there in other commits. If you do not have special requirement then you can use the existing ipset which is with the vmname ex: i-2-3-VM. Except this it looks good to me. Thanks, Jayapal > On 04-Apr-2016, at 10:17 pm, Nux!

[GitHub] cloudstack pull request: CLOUDSTACK-8611:Handle SSH if server "for...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1459#issuecomment-205554379 Pretty clever the way you named the test methods, I liked it. Just another thing. The method "throwSshExceptionIfSshConnectionIsNull" you are

[GitHub] cloudstack pull request: ui: fix typo in dashboard's fetchlatest u...

Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/1462#issuecomment-205654507 @bhaisaab here you go: https://issues.apache.org/jira/browse/CLOUDSTACK-9335 please update the PR and add the issue to the title --- If your project is

[GitHub] cloudstack pull request: CLOUDSTACK-8611:Handle SSH if server "for...

Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1459#discussion_r58407383 --- Diff: utils/src/test/java/com/cloud/utils/ssh/SshHelperTest.java --- @@ -0,0 +1,131 @@ +// +// Licensed to the Apache Software

[GitHub] cloudstack pull request: CLOUDSTACK-9333: Exclude clusters from OV...

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1457#issuecomment-205409749 @serg38 and I found out a way to change this property from UI, inserting the property in "configuration" table with scope="Cluster", insert sql: INSERT

[GitHub] cloudstack pull request: CLOUDSTACK-9333: Exclude clusters from OV...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1457#issuecomment-205334162 I have just tested; the cluster_details table does not work as the configuration table in which you can add an entry there and then that parameter is

Re: Hooking into the SecurityGroups

Jayapal (or anyone else), Where I got so far is adding rules with counters against a certain ipset, e.g. I add this: execute("iptables -A " + brfw + "-OUT" + " -m physdev --physdev-is-bridged --physdev-out " + vif + " -m set --set myipset src") before execute("iptables -A " + brfw + "-OUT" + "

Re: Hooking into the SecurityGroups

Well, this is what we got working in the end. If someone has any suggestions on how to improve it, that'd be great. https://github.com/NuxRo/cloudstack/commit/de6f97367fc2dc02378f367c462eaaec8f92e234 -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message

[GitHub] cloudstack pull request: CLOUDSTACK-8611:Handle SSH if server "for...

Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1459#discussion_r58407949 --- Diff: utils/src/test/java/com/cloud/utils/ssh/SshHelperTest.java --- @@ -0,0 +1,131 @@ +// +// Licensed to the Apache Software

[GitHub] cloudstack pull request: CLOUDSTACK-9333: Exclude clusters from OV...

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1457#issuecomment-205414291 I pushed a solution with this changes, without including insert in sql schema, do you think this way could be ok? --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-9333: Exclude clusters from OV...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1457#issuecomment-205349316 @nvazquez just an update. I was going over "org.apache.cloudstack.api.command.admin.config.ListCfgsByCmd.execute()" that is used to list the cluster

[GitHub] cloudstack pull request: CLOUDSTACK-8611:Handle SSH if server "for...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1459#issuecomment-205381727 @GabrielBrascher please continue as you please. the old code has been neglected. if you want to attribute please feel free to do so in the comment for that

[GitHub] cloudstack pull request: CLOUDSTACK-9323: Fix cancel host maintena...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1454#issuecomment-205473828 ### CI RESULTS **HAS FAILURES, NEEDS WORK!** Please accress the following issue. ```

[GitHub] cloudstack pull request: ui: fix typo in dashboard's fetchlatest u...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1462#issuecomment-205452667 Works as expected, LGTM. ![screen shot 2016-04-04 at 21 05 09

[GitHub] cloudstack pull request: CLOUDSTACK-9333: Exclude clusters from OV...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1457#issuecomment-205423791 I think this is the best way to tackle the problem. You just need to add that insert into the version’s upgrade script. --- If your project is set

[GitHub] cloudstack pull request: CLOUDSTACK-8611:Handle SSH if server "for...

Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1459#discussion_r58442984 --- Diff: utils/src/test/java/com/cloud/utils/ssh/SshHelperTest.java --- @@ -0,0 +1,131 @@ +// +// Licensed to the Apache Software

[GitHub] cloudstack pull request: ui: fix typo in dashboard's fetchlatest u...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1462#issuecomment-205500155 I believe we have to be reasonable when asking/requiring functional tests. After looking at the code, I am ok with the changes and the tests executed.

[GitHub] cloudstack pull request: CLOUDSTACK-8611:Handle SSH if server "for...

Github user GabrielBrascher commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1459#discussion_r58442410 --- Diff: utils/src/test/java/com/cloud/utils/ssh/SshHelperTest.java --- @@ -0,0 +1,131 @@ +// +// Licensed to the Apache Software

[GitHub] cloudstack pull request: ui: fix typo in dashboard's fetchlatest u...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1462#issuecomment-205488087 I don't think there are any CI tests that will actually test this. Can we assume the verifications that you guys have done is good enough? Also, I see that Jenkins

[GitHub] cloudstack pull request: ui: fix typo in dashboard's fetchlatest u...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1462#issuecomment-205501305 I agree. I just want to make sure others agree with us... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: maven: Upgrade dependency versions

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1397#issuecomment-205149639 @swill I share what worked for me, I'm not saying you have to use oracle-java. The openjdk version 1.7.0_85+ causes test failures for building console proxy in my

[GitHub] cloudstack pull request: travis: Fix simulator tests and optimize ...

GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/1461 travis: Fix simulator tests and optimize default global configs - Migrate to trusty based Travis VMs - Increase tests across five build matrices - Fix xunit-reader output, include time

[GitHub] cloudstack pull request: maven: Upgrade dependency versions

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1397#issuecomment-205154145 @DaanHoogland do you want to have a look, if you can help fix the issue of building against latest openjdk and advise if bountycastle related changes are causing

[GitHub] cloudstack pull request: travis: Fix simulator tests and optimize ...

Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/1461#issuecomment-205170921 +1 LGTM based on code review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: ui: fix typo in dashboard's fetchlatest u...

GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/1462 ui: fix typo in dashboard's fetchlatest usage cc @swill @terbolous @runseb @wido @abhinandanprateek You can merge this pull request into a Git repository by running: $ git pull

monday morning reading

H, for those interested in how we get to improve, here is something I stumbled upon on reddit [1] I must admit I think most of us are already working as described but still,... it touches on some of the pitfalls we have been tripping in as a project as well. ​[1] :

[GitHub] cloudstack pull request: ui: fix typo in dashboard's fetchlatest u...

Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/1462#issuecomment-205178712 Tested this manually by patching dashboard.js and re-gzipping it. The parameter is now passed as 'fetchLatest' as it should. ![Request parameters]

[GitHub] cloudstack pull request: ui: fix typo in dashboard's fetchlatest u...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1462#issuecomment-205509785 I agree. @bhaisaab do you mind adding a Jira ticket for this just so we have a record of it. --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: ui: fix typo in dashboard's fetchlatest u...

Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1462#issuecomment-205512194 Pulled this in manually and tested it. 

[GitHub] cloudstack pull request: ui: fix typo in dashboard's fetchlatest u...

Github user eriweb commented on the pull request: https://github.com/apache/cloudstack/pull/1462#issuecomment-205507905 Would be great with a jira ticket to track it though :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-8611:Handle SSH if server "for...

Github user GabrielBrascher commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1459#discussion_r58466286 --- Diff: utils/src/test/java/com/cloud/utils/ssh/SshHelperTest.java --- @@ -0,0 +1,131 @@ +// +// Licensed to the Apache Software