[GitHub] cloudstack pull request: CLOUDSTACK-9333: Exclude clusters from OV...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1457#issuecomment-206921614 ## CI RESULTS **84/85 TESTS PASSED** The only failed test is a test that often fails in my environment and is unrelated to

[GitHub] cloudstack-cloudmonkey pull request: Update requester.py

Github user phillipkent commented on the pull request: https://github.com/apache/cloudstack-cloudmonkey/pull/11#issuecomment-206907782 @bhaisaab : Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

Re: http://cloudstackcollab.org/

We are having some issues with that URL right now. You can reach the site at: http://cloudstackcollab.net/ instead for now... We are still working on content and such, so expect some changes over the next day or two. I don't think we have a form for submitting talks yet, so for now you can

[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1441#issuecomment-206925982 ## CI RESULTS ### 84/85 TESTS PASSED The only failed test is a test that often fails in my environment and is unrelated to

[GitHub] cloudstack pull request: CLOUDSTACK-9333: Exclude clusters from OV...

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1457#issuecomment-206925844 Looks nice! Thanks @swill for testing it in your environment! --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1441#issuecomment-206932399 I think this is ready pending a code review. Can someone who has spent some time reviewing this PR with Mike please give me the go ahead on this PR.

[GitHub] cloudstack pull request: CLOUDSTACK-9305: Cloudstack Usage Breaks ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1433#issuecomment-206949345 @kiwiflyer they conflict in what sense? They change different lines of code, so I don't expect git to have an issue with them. Can you clarify? --- If your

[GitHub] cloudstack pull request: travis: Fix simulator tests and optimize ...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1461 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-9335: fix typo in dashboard's ...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1462#issuecomment-206960333 @swill I guess we have to do push -f; will do just now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-9305: Cloudstack Usage Breaks ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1433#issuecomment-206946085 @Slair1 can you please squash your commits. I will get this into my CI queue so we can get this merged... Thanks... --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-9305: Cloudstack Usage Breaks ...

Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1433#issuecomment-206947587 @swill Just FYI that this PR conflicts with https://github.com/apache/cloudstack/pull/1409#issuecomment-197771350. They fix different issues, but the

RE: http://cloudstackcollab.org/

Will do. Thanks all. Kind regards, Paul Angus From: williamstev...@gmail.com [mailto:williamstev...@gmail.com] On Behalf Of Will Stevens Sent: 07 April 2016 16:43 To: dev@cloudstack.apache.org; Paul Angus Subject: Re: http://cloudstackcollab.org/ Thanks Mike.

[GitHub] cloudstack pull request: CLOUDSTACK-9335: fix typo in dashboard's ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1462#issuecomment-206963095 Thanks @bhaisaab, sorry to keep having you do that. I know it is just semantics, but I want to avoid doing `--force` merges. I got your travis fixes merged in

[GitHub] cloudstack pull request: Remove classes with no references

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1453#issuecomment-206965225 @GabrielBrascher I'm getting a merge error on this PR to master. can you have a look and rebase if needed? --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-9251: Fix issue in scale VM to...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1363#issuecomment-206935772 Hmmm, not sure how I feel about this. My inbox can't handle a whole bunch of new findbugs issues. :) @remibergsma would you mind giving me some guidance on

[GitHub] cloudstack pull request: CLOUDSTACK-9335: fix typo in dashboard's ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1462#issuecomment-206954412 Is there a way to manually kick off travis on a specific PR, or is the only way to have the author do a `push -f`? --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-9333: Exclude clusters from OV...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1457#issuecomment-206958139 Based on @rafaelweingartner's code review and the CI results, I think this is ready to merge. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-9174: A deleted account result...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1254#issuecomment-206936718 Thank you guys. I will merge this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: [CLOUDSTACK-9215]Test to verify vm deploy...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1316#issuecomment-206934467 Since this is a net new test that I do not have the ability to test and because the tests that have been run are passing, I think this PR is ready. Are we in

[GitHub] cloudstack pull request: CLOUDSTACK-9335: fix typo in dashboard's ...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1462#issuecomment-206964457 Thanks @swill I totally understand --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: CLOUDSTACK-9335: fix typo in dashboard's ...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1462#issuecomment-206961076 @swill done *though for purely JS change we may ignore CI errors if manual testing confirm a fix) --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: CLOUDSTACK-9174: A deleted account result...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1254 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: http://cloudstackcollab.org/

I submitted my talk using the following link (provided by Pierre-Luc): https://docs.google.com/a/solidfire.com/forms/d/1wUL2_rYDdp7VEEwwEARONzNL0PSd3jEpDKRSnvFEYC4/viewform On Thu, Apr 7, 2016 at 7:05 AM -0700, "Paul Angus" > wrote:

Re: http://cloudstackcollab.org/

Thanks Mike. @Paul, please use Mike's link and I will make sure that gets onto the website. :) *Will STEVENS* Lead Developer *CloudOps* *| *Cloud Solutions Experts 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|* tw @CloudOps_ On Thu, Apr 7, 2016 at 11:38 AM, Tutkowski, Mike

Masters Thesis on False Alarms in Test Failures

Dear Developers of the Apache Accumulo project, My name is Kevin van den Bekerom and I am currently doing my Master's research on the topic of false alarms in test code. I would like to ask the input of the Cloudstack development team categorizing test code bugs. My research is based on a

[GitHub] cloudstack pull request: Refactor system VM default network creati...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1360#discussion_r58875609 --- Diff: server/test/com/cloud/consoleproxy/ConsoleProxyManagerTest.java --- @@ -87,4 +114,136 @@ public void testExisingCPVMStartFailure() throws

[GitHub] cloudstack pull request: CLOUDSTACK-8611:Handle SSH if server "for...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1459#issuecomment-206927968 I have run CI against this PR, but I am not going to post the results yet because I think my test environment likely influenced the results. I think I am trying to

[GitHub] cloudstack pull request: Refactor system VM default network creati...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1360#discussion_r58874658 --- Diff: services/secondary-storage/controller/src/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java --- @@ -521,6 +522,76

RE: http://cloudstackcollab.org/

Great, thanks. Kind regards, Paul Angus From: williamstev...@gmail.com [mailto:williamstev...@gmail.com] On Behalf Of Will Stevens Sent: 07 April 2016 15:08 To: Paul Angus Cc: dev@cloudstack.apache.org Subject: Re: http://cloudstackcollab.org/ We are having some

Re: Hooking into the SecurityGroups

Well, I've just found a problem with our modifications, if you migrate an instance, then destroy_rules is called without the vif and our cleanup fails, leaving rules behind. i.e. VM destroy issues this command and all's good: Executing:

http://cloudstackcollab.org/

Hi All, The http://cloudstackcollab.org/ site just gives me a blank page - where can I submit a talk? Kind regards, Paul Angus Regards, Paul Angus paul.an...@shapeblue.com  www.shapeblue.com 53 Chandos Place, Covent Garden, London WC2N 4HSUK @shapeblue

[GitHub] cloudstack pull request: CLOUDSTACK-8611:Handle SSH if server "for...

Github user GabrielBrascher commented on the pull request: https://github.com/apache/cloudstack/pull/1459#issuecomment-206931826 @swill thanks for the effort. Don't worry, I can wait ;) --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack-cloudmonkey pull request: Update requester.py

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack-cloudmonkey/pull/11#issuecomment-206823599 @phillipkent I hit this issue today, while passing an argument. this worked for me. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack-cloudmonkey pull request: Update requester.py

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack-cloudmonkey/pull/11 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: [ACP Doctor] What is it?

I would wait to hear from Accelerite on their intentions. I am not sure why it is publicly accessible since it was a tool for Citrix CCP support. Agreed on the value of such tools. We should add that as a topic for Collab Montreal. On Thursday, 7 April 2016, Erik Weber

[GitHub] cloudstack pull request: CLOUDSTACK-9323: Fix cancel host maintena...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1454#issuecomment-207107811 ## CI RESULTS ### 84/85 TESTS PASSED The test that failed is a test that commonly fails in my environment and has been

[GitHub] cloudstack pull request: CLOUDSTACK-9323: Fix cancel host maintena...

Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1454#discussion_r58952716 --- Diff: server/src/com/cloud/resource/ResourceManagerImpl.java --- @@ -2112,11 +2112,13 @@ private boolean doCancelMaintenance(final long

[GitHub] cloudstack pull request: CLOUDSTACK-9323: Fix cancel host maintena...

Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1454#discussion_r58953686 --- Diff: server/src/com/cloud/resource/ResourceManagerImpl.java --- @@ -2112,11 +2112,13 @@ private boolean doCancelMaintenance(final long

[GitHub] cloudstack pull request: CLOUDSTACK-9323: Fix cancel host maintena...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1454#issuecomment-207111301 I have gone through the code, it LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1263#issuecomment-207112861 Yes, I think this one is ready. I am trying to get two LGTM code reviews on every PR, so can one of @DaanHoogland or @pdube give me a LGTM, I have one from

[GitHub] cloudstack pull request: CLOUDSTACK-9323: Fix cancel host maintena...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1454#issuecomment-207109385 @abhinandanprateek tests have passed, thanks for the updates. Can you do a `push -f` to kick off a Jenkins run so we can try to get this PR all green.

[GitHub] cloudstack pull request: Removed unnecessary code from getGuestOsT...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1262#issuecomment-207113402 @rafaelweingartner yes, I think this is ready too. I am trying to get two LGTM for every PR, so can someone else from the dev list give me a review? --- If

[GitHub] cloudstack pull request: Remove classes with no references

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1453#issuecomment-206979289 @DaanHoogland, @GabrielBrascher, The merge errors are occurring because the PR has merge conflicts. A rebase should solve that.

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1365#discussion_r58906447 --- Diff: utils/src/main/java/org/apache/cloudstack/utils/volume/VirtualMachineDiskInfo.java --- @@ -39,4 +38,11 @@ public void

Re: PRs for 4.9 Release

running a new test in an environment should pass but should not require all other test being re-validated. SO what is the point of running all others? I am not saying we shouldn't regularly run all tests but in this case it adds no value AFAICT. On Thu, Apr 7, 2016 at 7:35 PM, Will Stevens

Re: PRs for 4.9 Release

If you want me to verify things in your env, you can send me a tmate and I can have a look. *Will STEVENS* Lead Developer *CloudOps* *| *Cloud Solutions Experts 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|* tw @CloudOps_ On Thu, Apr 7, 2016 at 1:54 PM,

Re: PRs for 4.9 Release

Awesome, thanks for the list Simon. Will you be actively testing these against real hardware and posting the results? Feel free to use 'upr comment' [1] if it will help you post back your results. Let me know if you have questions and I will try to get you sorted. [1]

[GitHub] cloudstack pull request: Fix concurrency issue on virtual router

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1465#issuecomment-207044590 code LGTM running integration suite --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: Lower the time we wait for interfaces to ...

GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1467 Lower the time we wait for interfaces to appear after restart Waiting for interfaces is tricky. They might never appear.. for example when we have entries in `/etc/cloudstack/ips.json`

[GitHub] cloudstack pull request: Apply static routes on change to master s...

Github user remibergsma closed the pull request at: https://github.com/apache/cloudstack/pull/1468 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: Lower the time we wait for interfaces to ...

GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1471 Lower the time we wait for interfaces to appear Waiting for interfaces is tricky. They might never appear.. for example when we have entries in `/etc/cloudstack/ips.json` that haven't been

Re: PRs for 4.9 Release

Yes, if the PR is ONLY a test and does not touch any other code then we can only run that test. I agree with you. If any code is changed outside the test, I always run the full suite. Make sense? *Will STEVENS* Lead Developer *CloudOps* *| *Cloud Solutions Experts 420 rue Guy *|* Montreal *|*

Re: PRs for 4.9 Release

Will et al, These are currently the PRs we're tracking in our merge list: https://github.com/apache/cloudstack/pull/1230 https://github.com/apache/cloudstack/pull/1462 https://github.com/apache/cloudstack/pull/1441 https://github.com/apache/cloudstack/pull/1428

[GitHub] cloudstack pull request: Fix concurrency issue on virtual router

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1465#discussion_r58927425 --- Diff: core/src/com/cloud/agent/resource/virtualnetwork/facade/AbstractConfigItemFacade.java --- @@ -104,13 +109,25 @@ public static

[GitHub] cloudstack pull request: Bump ssh retries to prevent false positiv...

GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1469 Bump ssh retries to prevent false positives of test_loadbalance No more false positives after this change. ``` [root@cs1 integration]# cat

[GitHub] cloudstack pull request: Bump ssh retries to prevent false positiv...

GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1473 Bump ssh retries to prevent false positives of test_loadbalance No more false positives after this change. ``` [root@cs1 integration]# cat

[GitHub] cloudstack pull request: Bump ssh retries to prevent false positiv...

Github user remibergsma closed the pull request at: https://github.com/apache/cloudstack/pull/1469 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: Fix concurrency issue on virtual router

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1465#discussion_r58927692 --- Diff: core/src/com/cloud/agent/resource/virtualnetwork/facade/AbstractConfigItemFacade.java --- @@ -104,13 +109,25 @@ public static

Re: PRs for 4.9 Release

Yes, we'll be testing these on real hardware. From: williamstev...@gmail.com on behalf of Will Stevens Sent: Thursday, April 7, 2016 12:59 PM To: dev@cloudstack.apache.org Subject: Re: PRs for 4.9 Release

[GitHub] cloudstack pull request: CLOUDSTACK-9305: Cloudstack Usage Breaks ...

Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1433#issuecomment-207033442 I applied 1433 and then tried to apply 1409, but 1433 changes prevent the later patch from matching previous lines. One or the other probably needs to be based

[GitHub] cloudstack pull request: CLOUDSTACK-9305: Cloudstack Usage Breaks ...

Github user Slair1 commented on the pull request: https://github.com/apache/cloudstack/pull/1433#issuecomment-207038085 @swill , i apologize, but this is my first PR. I squashed it in Github Desktop on my local copy and did a push, but it sees like it it just added additional

[GitHub] cloudstack pull request: Fix concurrency issue on virtual router

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1465#discussion_r58923375 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/vr_cfg.sh --- @@ -91,7 +91,7 @@ do done < $cfg #remove the configuration

Re: [jira] [Created] (CLOUDSTACK-9341) Cannot upload volume when using Swift as secondary storage

PLD, do we have a github PR for this one already? I thought we had a fix for this locally. On Apr 7, 2016 2:45 PM, "Pierre-Luc Dion (JIRA)" wrote: > Pierre-Luc Dion created CLOUDSTACK-9341: > --- > > Summary: Cannot upload

[GitHub] cloudstack pull request: Apply static routes on change to master s...

GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1468 Apply static routes on change to master state Refactored static routes for private gateways so they also get loaded when the router switches to master state. Otherwise they're lost and

[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1441#issuecomment-207031562 @mike-tutkowski, @swill I am ok with that --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization

GitHub user nvazquez opened a pull request: https://github.com/apache/cloudstack/pull/1466 CLOUDSTACK-9340: General DB Optimization ## Description In some production environments there were being experimented delays in most of the jobs. A search for DB optimization was taken

[GitHub] cloudstack pull request: Fix concurrency issue on virtual router

Github user remibergsma closed the pull request at: https://github.com/apache/cloudstack/pull/1465 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: Fix concurrency issue on virtual router

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1465#issuecomment-207051489 @DaanHoogland This can be pointed towards 4.7 so I will close this and open one to 4.7 instead of master. --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1365#issuecomment-207022111 I can't specifically test the VMware functionality, but I can validate that it does not break anything else. I have added this to my queue for CI. --- If your

Re: PRs for 4.9 Release

Sure it makes. On Thu, Apr 7, 2016 at 2:47 PM, Will Stevens wrote: > Yes, if the PR is ONLY a test and does not touch any other code then we can > only run that test. I agree with you. > > If any code is changed outside the test, I always run the full suite. Make >

Re: PRs for 4.9 Release

yes, makes perfect sense. I skipped 1326 for now, I just tried to build 1436 it fails in the rpm build fase. I am now going to try that ui thing to build confidence in my test environment. On Thu, Apr 7, 2016 at 7:49 PM, Rafael Weingärtner < rafaelweingart...@gmail.com> wrote: > Sure it makes. >

[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/1441#issuecomment-207031227 Thanks for the comments @rafaelweingartner and @ustcweizhou. Since canHandle is part of the infrastructure, we decided this particular PR isn't the

Re: Masters Thesis on False Alarms in Test Failures

Kevin, what you intent to do sound promising. I think you are on your own in collecting data but by the sound of it you allready have a list of 110 name/question pairs, do you? If not, how do you intent to do the collection of the data you require? On Thu, Apr 7, 2016 at 4:04 PM, Kevin van den

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1365#discussion_r58904519 --- Diff: plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java --- @@ -1363,24 +1363,17 @@ private Answer

Re: PRs for 4.9 Release

Hi Will, thanks for such a great job. I was going over the PRs we have in our merge list; I did a walk through till page 5, the others one I believe will require more work and some of the folks that have opened them, are a little bit off the community lately. I found the following to be of some

[GitHub] cloudstack pull request: CLOUDSTACK-9333: Exclude clusters from OV...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1457#issuecomment-206992288 @serg38 thats is great. So, Do I or you (@Swill) do the honors to execute the merge. --- If your project is set up for it, you can reply to this

Re: PRs for 4.9 Release

i just finished redoing 1459 but the first 5 tests failed so i aborted and am looking for a new target On Thu, Apr 7, 2016 at 7:24 PM, Will Stevens wrote: > Thanks Daan. I really wish I had the ability to label PRs because that > would make things SO much easier. > > I

[GitHub] cloudstack pull request: CLOUDSTACK-9333: Exclude clusters from OV...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1457#issuecomment-206969279 @swill, I was going to say the same. I also believe that this PR is ready to be merged. But, I would like to have heard some other committer feedback.

[GitHub] cloudstack pull request: CLOUDSTACK-9333: Exclude clusters from OV...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1457#issuecomment-206980344 @swill you are doing a marvelous job; I totally understand your workload. I hope we can get more people to help us reviewing PRs; that number has been

[GitHub] cloudstack pull request: Remove classes with no references

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1453#issuecomment-206982799 @swill thanks I did not know that you were also watching this PR. Man, you are literally everywhere; that is very good. --- If your project is

[GitHub] cloudstack pull request: Remove classes with no references

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1453#issuecomment-206983175 haha, trying to be. it is turning into a full time job... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1365#discussion_r58904980 --- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java --- @@ -5455,6 +5456,15 @@ private void encryptAndStorePassword(UserVmVO vm, String password)

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1365#discussion_r58906077 --- Diff: server/test/com/cloud/vm/UserVmManagerTest.java --- @@ -928,4 +928,13 @@ public void testUpdateVmNicIpFailure3() throws Exception {

Re: PRs for 4.9 Release

will, Fred Neubauer just helped me finalize my test environment on a fedora laptop. I will be chipping away at the pile as well. hopefully at a rate of one per day. I would like your directions as to which I can pick. of course I can go my own way but double work is a shame. On Thu, Apr 7, 2016

Re: PRs for 4.9 Release

Thanks Rafael. I have 1/2 of those on my watch list, so I will review the ones I am not already actively working on. *Will STEVENS* Lead Developer *CloudOps* *| *Cloud Solutions Experts 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|* tw @CloudOps_ On Thu, Apr 7, 2016 at

PRs for 4.9 Release

I know this is not how this usually works, but I need to crowd source some info to be more effective. I am slowly getting things rolling for the 4.9 release. My CI is chugging away and I have a queue of PRs to get tested, so I will be getting through them as quickly as I can. I have finally

[GitHub] cloudstack pull request: Remove classes with no references

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1453#issuecomment-206982108 @rafaelweingartner yes, I will be running CI on this when the merge conflicts have been resolved. nothing should be committed to master without CI run against it

[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1441#issuecomment-206981924 @swill, all of my enquiries here were answered. My only complaint was about the method name "canHandle"; it misled me during my first and second look at

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1365#discussion_r58903799 --- Diff: vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java --- @@ -2118,8 +2118,12 @@ public int getScsiDiskControllerKey(String

Re: PRs for 4.9 Release

Thanks Daan. I really wish I had the ability to label PRs because that would make things SO much easier. I have these 3 pending CI, all of which need changes the the ' helper_scripts/cloudstack/run_marvin_router_tests.sh' because they are PRs on tests, so we have to explicitly add the test to

[GitHub] cloudstack pull request: CLOUDSTACK-9333: Exclude clusters from OV...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1457#issuecomment-207014015 @serg38 awesome, thank you. I will get this merged... Yes, good new about Accelerite. I am very hopeful they will be able to add value to the ACS community

Re: PRs for 4.9 Release

I also had problems with 1459, but I was trying to run 4 CIs in the same bubble, so I thought it may have had something to do with that. I want to run it on its own so I don't have resource contention to make sure the tests are actually failing. *Will STEVENS* Lead Developer *CloudOps* *|

[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1441#issuecomment-206978195 @swill you have a failure, why do you want an LGTM, seems to me it didn't pass the tests --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-9333: Exclude clusters from OV...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1457#issuecomment-206978473 @rafaelweingartner Ya, ideally I would like to try to get two code reviews for each PR. I try to do a quick code review on each, but with the number for PRs I am

[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1441#issuecomment-206981349 @DaanHoogland I have some issues with networking when using redundant VRs in my environment. I consistently have this type of issue, and it is unrelated to the

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1365#discussion_r58903873 --- Diff: vmware-base/src/com/cloud/hypervisor/vmware/mo/GuestOsDescriptorType.java --- @@ -0,0 +1,46 @@ +// Licensed to the Apache Software

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1365#discussion_r58903775 --- Diff: vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java --- @@ -2137,7 +2141,8 @@ public int getScsiDiskControllerKey(String

[GitHub] cloudstack pull request: CLOUDSTACK-9333: Exclude clusters from OV...

Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1457#issuecomment-206989623 @swill , @rafaelweingartner I work very closely with @nvazquez. His PRs pass very rigorous testing in our Lab on physical Vmware hypervisors. I reviewed his code

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1365#discussion_r58906935 --- Diff: utils/src/test/java/org/apache/cloudstack/utils/volume/VirtualMachineDiskInfoTest.java --- @@ -0,0 +1,46 @@ +// +// Licensed to the

Re: PRs for 4.9 Release

On Thu, Apr 7, 2016 at 7:26 PM, Daan Hoogland wrote: > 1326 - master (*pending CI) ​starting​ -- Daan

  1   2   >