Build failed in Jenkins: build-systemvm64-master #784

See Changes: [syed1.mushtaq] Add ability to download templates in Swift -- [...truncated 3417 lines...] 100% [Working] 100% [Packages 28.5 MB] 100% [Packages 28.5 MB] 1

[GitHub] cloudstack pull request: [CLOUDSTACK-9215]Test to verify vm deploy...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1316#issuecomment-206751818 No, you are right. I no longer have that 'hardware' so I can rerun the test but as I stated earlier the test was basing itself on an exception not being throw

[GitHub] cloudstack pull request: CLOUDSTACK-9174: A deleted account result...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1254#issuecomment-206755482 LGTM, @swill --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] cloudstack pull request: CLOUDSTACK-9174: A deleted account result...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1254#issuecomment-206755664 LGTM, @swill based on the code --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: CLOUDSTACK-9174: A deleted account result...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1254#issuecomment-206755942 @swill @bhaisaab we should not accept an LTGM without explanation/justification --- If your project is set up for it, you can reply to this email and have you

Re: [ACP Doctor] What is it?

except that there is no link on that page to the scripts On Thu, Apr 7, 2016 at 6:32 AM, ilya wrote: > Wow, a whole one page site dedicated to this endeavor :) > > On 4/6/16 9:22 PM, Will Stevens wrote: > > FYI, It does still seem to be freely available: http://ccpdoctor.com/ > > > > *Will STEV

[GitHub] cloudstack pull request: [CLOUDSTACK-9215]Test to verify vm deploy...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1316#issuecomment-206769730 Agree with @DaanHoogland though looks like it ran no tests (skipped them) --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] cloudstack pull request: [CLOUDSTACK-9215]Test to verify vm deploy...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1316#discussion_r58840282 --- Diff: test/integration/component/maint/test_vpc.py --- @@ -0,0 +1,400 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or

[GitHub] cloudstack pull request: CLOUDSTACK-9174: A deleted account result...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1254#issuecomment-206773236 LGTM based on test/code, @DaanHoogland Abhi ( @agneya2001 ) can explain in much detail; but this fixes a NPE case and uses RoleType comparison that id comparison t

[GitHub] cloudstack pull request: CLOUDSTACK-9251: Fix issue in scale VM to...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1363#issuecomment-206785324 @swill @ustcweizhou has a point. Id say merge. I'm not going to take the time to do this now either. One point to consider is that it will up the number of fin

Re: [ACP Doctor] What is it?

I downloaded it, but I believe the license restricts me from redistributing it. There's not a whole lot of stuff it does, here is a screenshot of the help [1] I tried passing '--tune' and '--troubleshoot', but it didn't do anything besides creating a rather empty log That said, I believe there is

[GitHub] cloudstack pull request: Refactor system VM default network creati...

Github user ProjectMoon commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1360#discussion_r58852087 --- Diff: services/secondary-storage/controller/src/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java --- @@ -521,6 +522,76 @@

[GitHub] cloudstack pull request: Refactor system VM default network creati...

Github user ProjectMoon commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1360#discussion_r58852188 --- Diff: server/test/com/cloud/consoleproxy/ConsoleProxyManagerTest.java --- @@ -87,4 +114,136 @@ public void testExisingCPVMStartFailure() throws

[GitHub] cloudstack pull request: CLOUDSTACK-9174: A deleted account result...

Github user abhinandanprateek commented on the pull request: https://github.com/apache/cloudstack/pull/1254#issuecomment-206815106 @swill @bhaisaab @DaanHoogland I have done manual testing for the fix as expected. This can be merged now as there are enough LGTMs. --- If your project

[GitHub] cloudstack-cloudmonkey pull request: Update requester.py

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack-cloudmonkey/pull/11#issuecomment-206823599 @phillipkent I hit this issue today, while passing an argument. this worked for me. --- If your project is set up for it, you can reply to this email a

[GitHub] cloudstack-cloudmonkey pull request: Update requester.py

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack-cloudmonkey/pull/11 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: [ACP Doctor] What is it?

I would wait to hear from Accelerite on their intentions. I am not sure why it is publicly accessible since it was a tool for Citrix CCP support. Agreed on the value of such tools. We should add that as a topic for Collab Montreal. On Thursday, 7 April 2016, Erik Weber wrote: > I downloaded it,

Re: Hooking into the SecurityGroups

Well, I've just found a problem with our modifications, if you migrate an instance, then destroy_rules is called without the vif and our cleanup fails, leaving rules behind. i.e. VM destroy issues this command and all's good: Executing: /usr/share/cloudstack-common/scripts/vm/network/security_gr

[GitHub] cloudstack-cloudmonkey pull request: Update requester.py

Github user phillipkent commented on the pull request: https://github.com/apache/cloudstack-cloudmonkey/pull/11#issuecomment-206907782 @bhaisaab : Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] cloudstack pull request: Refactor system VM default network creati...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1360#discussion_r58874658 --- Diff: services/secondary-storage/controller/src/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java --- @@ -521,6 +522,76 @@

[GitHub] cloudstack pull request: Refactor system VM default network creati...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1360#discussion_r58875609 --- Diff: server/test/com/cloud/consoleproxy/ConsoleProxyManagerTest.java --- @@ -87,4 +114,136 @@ public void testExisingCPVMStartFailure() throws

[GitHub] cloudstack pull request: CLOUDSTACK-9333: Exclude clusters from OV...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1457#issuecomment-206921614 ## CI RESULTS **84/85 TESTS PASSED** The only failed test is a test that often fails in my environment and is unrelated to t

http://cloudstackcollab.org/

Hi All, The http://cloudstackcollab.org/ site just gives me a blank page - where can I submit a talk? Kind regards, Paul Angus Regards, Paul Angus paul.an...@shapeblue.com  www.shapeblue.com 53 Chandos Place, Covent Garden, London WC2N 4HSUK @shapeblue

Masters Thesis on False Alarms in Test Failures

Dear Developers of the Apache Accumulo project, My name is Kevin van den Bekerom and I am currently doing my Master's research on the topic of false alarms in test code. I would like to ask the input of the Cloudstack development team categorizing test code bugs. My research is based on a rec

Re: http://cloudstackcollab.org/

We are having some issues with that URL right now. You can reach the site at: http://cloudstackcollab.net/ instead for now... We are still working on content and such, so expect some changes over the next day or two. I don't think we have a form for submitting talks yet, so for now you can email

RE: http://cloudstackcollab.org/

Great, thanks. Kind regards, Paul Angus From: williamstev...@gmail.com [mailto:williamstev...@gmail.com] On Behalf Of Will Stevens Sent: 07 April 2016 15:08 To: Paul Angus Cc: dev@cloudstack.apache.org Subject: Re: http://cloudstackcollab.org/ We are having some issues with that URL right n

[GitHub] cloudstack pull request: CLOUDSTACK-9333: Exclude clusters from OV...

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1457#issuecomment-206925844 Looks nice! Thanks @swill for testing it in your environment! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1441#issuecomment-206925982 ## CI RESULTS ### 84/85 TESTS PASSED The only failed test is a test that often fails in my environment and is unrelated to t

[GitHub] cloudstack pull request: CLOUDSTACK-8611:Handle SSH if server "for...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1459#issuecomment-206927968 I have run CI against this PR, but I am not going to post the results yet because I think my test environment likely influenced the results. I think I am trying to p

[GitHub] cloudstack pull request: CLOUDSTACK-8611:Handle SSH if server "for...

Github user GabrielBrascher commented on the pull request: https://github.com/apache/cloudstack/pull/1459#issuecomment-206931826 @swill thanks for the effort. Don't worry, I can wait ;) --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1441#issuecomment-206932399 I think this is ready pending a code review. Can someone who has spent some time reviewing this PR with Mike please give me the go ahead on this PR. @rafaelweingart

[GitHub] cloudstack pull request: CLOUDSTACK-9251: Fix issue in scale VM to...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1363#issuecomment-206935772 Hmmm, not sure how I feel about this. My inbox can't handle a whole bunch of new findbugs issues. :) @remibergsma would you mind giving me some guidance on

[GitHub] cloudstack pull request: [CLOUDSTACK-9215]Test to verify vm deploy...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1316#issuecomment-206934467 Since this is a net new test that I do not have the ability to test and because the tests that have been run are passing, I think this PR is ready. Are we in agreeme

[GitHub] cloudstack pull request: CLOUDSTACK-9174: A deleted account result...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1254#issuecomment-206936718 Thank you guys. I will merge this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: CLOUDSTACK-9305: Cloudstack Usage Breaks ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1433#issuecomment-206946085 @Slair1 can you please squash your commits. I will get this into my CI queue so we can get this merged... Thanks... --- If your project is set up for it, you can r

[GitHub] cloudstack pull request: CLOUDSTACK-9305: Cloudstack Usage Breaks ...

Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1433#issuecomment-206947587 @swill Just FYI that this PR conflicts with https://github.com/apache/cloudstack/pull/1409#issuecomment-197771350. They fix different issues, but the patc

[GitHub] cloudstack pull request: CLOUDSTACK-9305: Cloudstack Usage Breaks ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1433#issuecomment-206949345 @kiwiflyer they conflict in what sense? They change different lines of code, so I don't expect git to have an issue with them. Can you clarify? --- If your project

[GitHub] cloudstack pull request: travis: Fix simulator tests and optimize ...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1461 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9335: fix typo in dashboard's ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1462#issuecomment-206954412 Is there a way to manually kick off travis on a specific PR, or is the only way to have the author do a `push -f`? --- If your project is set up for it, you can repl

[GitHub] cloudstack pull request: CLOUDSTACK-9333: Exclude clusters from OV...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1457#issuecomment-206958139 Based on @rafaelweingartner's code review and the CI results, I think this is ready to merge. --- If your project is set up for it, you can reply to this email and

Re: http://cloudstackcollab.org/

I submitted my talk using the following link (provided by Pierre-Luc): https://docs.google.com/a/solidfire.com/forms/d/1wUL2_rYDdp7VEEwwEARONzNL0PSd3jEpDKRSnvFEYC4/viewform On Thu, Apr 7, 2016 at 7:05 AM -0700, "Paul Angus" mailto:paul.an...@shapeblue.com>> wrote: Hi All, The http://cloudsta

[GitHub] cloudstack pull request: CLOUDSTACK-9335: fix typo in dashboard's ...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1462#issuecomment-206960333 @swill I guess we have to do push -f; will do just now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] cloudstack pull request: CLOUDSTACK-9335: fix typo in dashboard's ...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1462#issuecomment-206961076 @swill done *though for purely JS change we may ignore CI errors if manual testing confirm a fix) --- If your project is set up for it, you can reply to this emai

[GitHub] cloudstack pull request: CLOUDSTACK-9174: A deleted account result...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1254 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: http://cloudstackcollab.org/

Thanks Mike. @Paul, please use Mike's link and I will make sure that gets onto the website. :) *Will STEVENS* Lead Developer *CloudOps* *| *Cloud Solutions Experts 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|* tw @CloudOps_ On Thu, Apr 7, 2016 at 11:38 AM, Tutkowski, Mike

RE: http://cloudstackcollab.org/

Will do. Thanks all. Kind regards, Paul Angus From: williamstev...@gmail.com [mailto:williamstev...@gmail.com] On Behalf Of Will Stevens Sent: 07 April 2016 16:43 To: dev@cloudstack.apache.org; Paul Angus Subject: Re: http://cloudstackcollab.org/ Thanks Mike. @Paul, please use Mike's link a

[GitHub] cloudstack pull request: CLOUDSTACK-9335: fix typo in dashboard's ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1462#issuecomment-206963095 Thanks @bhaisaab, sorry to keep having you do that. I know it is just semantics, but I want to avoid doing `--force` merges. I got your travis fixes merged in today

[GitHub] cloudstack pull request: CLOUDSTACK-9335: fix typo in dashboard's ...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1462#issuecomment-206964457 Thanks @swill I totally understand --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: Remove classes with no references

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1453#issuecomment-206965225 @GabrielBrascher I'm getting a merge error on this PR to master. can you have a look and rebase if needed? --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: CLOUDSTACK-9333: Exclude clusters from OV...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1457#issuecomment-206969279 @swill, I was going to say the same. I also believe that this PR is ready to be merged. But, I would like to have heard some other committer feedback.

PRs for 4.9 Release

I know this is not how this usually works, but I need to crowd source some info to be more effective. I am slowly getting things rolling for the 4.9 release. My CI is chugging away and I have a queue of PRs to get tested, so I will be getting through them as quickly as I can. I have finally gott

[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1441#issuecomment-206978195 @swill you have a failure, why do you want an LGTM, seems to me it didn't pass the tests --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: CLOUDSTACK-9333: Exclude clusters from OV...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1457#issuecomment-206978473 @rafaelweingartner Ya, ideally I would like to try to get two code reviews for each PR. I try to do a quick code review on each, but with the number for PRs I am try

[GitHub] cloudstack pull request: Remove classes with no references

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1453#issuecomment-206979289 @DaanHoogland, @GabrielBrascher, The merge errors are occurring because the PR has merge conflicts. A rebase should solve that. @DaanHoogl

[GitHub] cloudstack pull request: CLOUDSTACK-9333: Exclude clusters from OV...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1457#issuecomment-206980344 @swill you are doing a marvelous job; I totally understand your workload. I hope we can get more people to help us reviewing PRs; that number has been

[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1441#issuecomment-206981349 @DaanHoogland I have some issues with networking when using redundant VRs in my environment. I consistently have this type of issue, and it is unrelated to the actu

[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1441#issuecomment-206981924 @swill, all of my enquiries here were answered. My only complaint was about the method name "canHandle"; it misled me during my first and second look at t

[GitHub] cloudstack pull request: Remove classes with no references

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1453#issuecomment-206982108 @rafaelweingartner yes, I will be running CI on this when the merge conflicts have been resolved. nothing should be committed to master without CI run against it IMO

[GitHub] cloudstack pull request: Remove classes with no references

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1453#issuecomment-206982799 @swill thanks I did not know that you were also watching this PR. Man, you are literally everywhere; that is very good. --- If your project is se

[GitHub] cloudstack pull request: Remove classes with no references

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1453#issuecomment-206983175 haha, trying to be. it is turning into a full time job... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1365#discussion_r58903799 --- Diff: vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java --- @@ -2118,8 +2118,12 @@ public int getScsiDiskControllerKey(String di

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1365#discussion_r58903775 --- Diff: vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java --- @@ -2137,7 +2141,8 @@ public int getScsiDiskControllerKey(String dis

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1365#discussion_r58903873 --- Diff: vmware-base/src/com/cloud/hypervisor/vmware/mo/GuestOsDescriptorType.java --- @@ -0,0 +1,46 @@ +// Licensed to the Apache Software Foundat

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1365#discussion_r58904000 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -4729,6 +4729,17 @@ private VirtualMachineGues

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1365#discussion_r58904519 --- Diff: plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java --- @@ -1363,24 +1363,17 @@ private Answer attachVolume

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1365#discussion_r58904980 --- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java --- @@ -5455,6 +5456,15 @@ private void encryptAndStorePassword(UserVmVO vm, String password) {

Re: PRs for 4.9 Release

Hi Will, thanks for such a great job. I was going over the PRs we have in our merge list; I did a walk through till page 5, the others one I believe will require more work and some of the folks that have opened them, are a little bit off the community lately. I found the following to be of some int

[GitHub] cloudstack pull request: CLOUDSTACK-9333: Exclude clusters from OV...

Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1457#issuecomment-206989623 @swill , @rafaelweingartner I work very closely with @nvazquez. His PRs pass very rigorous testing in our Lab on physical Vmware hypervisors. I reviewed his code and

[GitHub] cloudstack pull request: CLOUDSTACK-9333: Exclude clusters from OV...

Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1457#issuecomment-206990689 @rafaelweingartner On a general note we got a verbal commitment from Accelerite who bought CloudPlatform from Citrix last month to contribute more to the community

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1365#discussion_r58906077 --- Diff: server/test/com/cloud/vm/UserVmManagerTest.java --- @@ -928,4 +928,13 @@ public void testUpdateVmNicIpFailure3() throws Exception {

[GitHub] cloudstack pull request: CLOUDSTACK-9333: Exclude clusters from OV...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1457#issuecomment-206992288 @serg38 thats is great. So, Do I or you (@Swill) do the honors to execute the merge. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1365#discussion_r58906447 --- Diff: utils/src/main/java/org/apache/cloudstack/utils/volume/VirtualMachineDiskInfo.java --- @@ -39,4 +38,11 @@ public void setDiskDeviceBusName(St

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1365#discussion_r58906935 --- Diff: utils/src/test/java/org/apache/cloudstack/utils/volume/VirtualMachineDiskInfoTest.java --- @@ -0,0 +1,46 @@ +// +// Licensed to the A

Re: PRs for 4.9 Release

will, Fred Neubauer just helped me finalize my test environment on a fedora laptop. I will be chipping away at the pile as well. hopefully at a rate of one per day. I would like your directions as to which I can pick. of course I can go my own way but double work is a shame. On Thu, Apr 7, 2016 at

Re: PRs for 4.9 Release

Thanks Rafael. I have 1/2 of those on my watch list, so I will review the ones I am not already actively working on. *Will STEVENS* Lead Developer *CloudOps* *| *Cloud Solutions Experts 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|* tw @CloudOps_ On Thu, Apr 7, 2016 at 12:48

Re: PRs for 4.9 Release

Thanks Daan. I really wish I had the ability to label PRs because that would make things SO much easier. I have these 3 pending CI, all of which need changes the the ' helper_scripts/cloudstack/run_marvin_router_tests.sh' because they are PRs on tests, so we have to explicitly add the test to the

Re: PRs for 4.9 Release

i just finished redoing 1459 but the first 5 tests failed so i aborted and am looking for a new target On Thu, Apr 7, 2016 at 7:24 PM, Will Stevens wrote: > Thanks Daan. I really wish I had the ability to label PRs because that > would make things SO much easier. > > I have these 3 pending CI,

Re: PRs for 4.9 Release

On Thu, Apr 7, 2016 at 7:26 PM, Daan Hoogland wrote: > 1326 - master (*pending CI) ​starting​ -- Daan

[GitHub] cloudstack pull request: CLOUDSTACK-9333: Exclude clusters from OV...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1457#issuecomment-207014015 @serg38 awesome, thank you. I will get this merged... Yes, good new about Accelerite. I am very hopeful they will be able to add value to the ACS community

Re: PRs for 4.9 Release

1326 is just a test. it does not touch production code. Do we run regression tests against such PRs. seems a waste to me. On Thu, Apr 7, 2016 at 7:27 PM, Daan Hoogland wrote: > > On Thu, Apr 7, 2016 at 7:26 PM, Daan Hoogland > wrote: > >> 1326 - master (*pending CI) > > > ​starting​ > > > > --

[GitHub] cloudstack pull request: CLOUDSTACK-9333: Exclude clusters from OV...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1457 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: PRs for 4.9 Release

IMO, we only need to run the test and check if it works against the branch that it was created upon. On Thu, Apr 7, 2016 at 2:30 PM, Daan Hoogland wrote: > 1326 is just a test. it does not touch production code. Do we run > regression tests against such PRs. seems a waste to me. > > On Thu, Apr

Re: PRs for 4.9 Release

Yes, I want to run tests against the tests. I have found issues in some of the tests not working as expected, so I add the test to the run and run them. I think it is worth it because then we know the test is valid later. I would rather have the author fix the test now if there are problems than

Re: PRs for 4.9 Release

I also had problems with 1459, but I was trying to run 4 CIs in the same bubble, so I thought it may have had something to do with that. I want to run it on its own so I don't have resource contention to make sure the tests are actually failing. *Will STEVENS* Lead Developer *CloudOps* *| *Cloud

[GitHub] cloudstack pull request: Fix concurrency issue on virtual router

GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1465 Fix concurrency issue on virtual router The json files now have UUIDs to prevent them from getting overwritten before they've been executed. Prevents config to be pushed to the wrong router

Re: PRs for 4.9 Release

Yes, I agree we only need to run tests against the branch it was created on. It probably SHOULD be done against all branches it will be merged into, but we need to have things streamlined a bit more for that to be viable IMO. *Will STEVENS* Lead Developer *CloudOps* *| *Cloud Solutions Experts 4

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1365#issuecomment-207019005 @swill @rafaelweingartner @jburwell fixed outstanding issues and added more unit tests --- If your project is set up for it, you can reply to this email and have

Re: PRs for 4.9 Release

running a new test in an environment should pass but should not require all other test being re-validated. SO what is the point of running all others? I am not saying we shouldn't regularly run all tests but in this case it adds no value AFAICT. On Thu, Apr 7, 2016 at 7:35 PM, Will Stevens wrote

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1365#issuecomment-207022111 I can't specifically test the VMware functionality, but I can validate that it does not break anything else. I have added this to my queue for CI. --- If your proje

Re: PRs for 4.9 Release

Yes, if the PR is ONLY a test and does not touch any other code then we can only run that test. I agree with you. If any code is changed outside the test, I always run the full suite. Make sense? *Will STEVENS* Lead Developer *CloudOps* *| *Cloud Solutions Experts 420 rue Guy *|* Montreal *|*

Re: PRs for 4.9 Release

Sure it makes. On Thu, Apr 7, 2016 at 2:47 PM, Will Stevens wrote: > Yes, if the PR is ONLY a test and does not touch any other code then we can > only run that test. I agree with you. > > If any code is changed outside the test, I always run the full suite. Make > sense? > > *Will STEVENS* >

Re: PRs for 4.9 Release

Will et al, These are currently the PRs we're tracking in our merge list: https://github.com/apache/cloudstack/pull/1230 https://github.com/apache/cloudstack/pull/1462 https://github.com/apache/cloudstack/pull/1441 https://github.com/apache/cloudstack/pull/1428 https://github.com/apache/cloudstac

Re: PRs for 4.9 Release

yes, makes perfect sense. I skipped 1326 for now, I just tried to build 1436 it fails in the rpm build fase. I am now going to try that ui thing to build confidence in my test environment. On Thu, Apr 7, 2016 at 7:49 PM, Rafael Weingärtner < rafaelweingart...@gmail.com> wrote: > Sure it makes. >

Re: PRs for 4.9 Release

If you want me to verify things in your env, you can send me a tmate and I can have a look. *Will STEVENS* Lead Developer *CloudOps* *| *Cloud Solutions Experts 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|* tw @CloudOps_ On Thu, Apr 7, 2016 at 1:54 PM, Da

Re: PRs for 4.9 Release

Awesome, thanks for the list Simon. Will you be actively testing these against real hardware and posting the results? Feel free to use 'upr comment' [1] if it will help you post back your results. Let me know if you have questions and I will try to get you sorted. [1] https://github.com/cloudop

Re: PRs for 4.9 Release

Yes, we'll be testing these on real hardware. From: williamstev...@gmail.com on behalf of Will Stevens Sent: Thursday, April 7, 2016 12:59 PM To: dev@cloudstack.apache.org Subject: Re: PRs for 4.9 Release Awesome, thanks for the list Simon. Will you be

[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/1441#issuecomment-207031227 Thanks for the comments @rafaelweingartner and @ustcweizhou. Since canHandle is part of the infrastructure, we decided this particular PR isn't the p

[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1441#issuecomment-207031562 @mike-tutkowski, @swill I am ok with that --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: CLOUDSTACK-9305: Cloudstack Usage Breaks ...

Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1433#issuecomment-207033442 I applied 1433 and then tried to apply 1409, but 1433 changes prevent the later patch from matching previous lines. One or the other probably needs to be based o

[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization

GitHub user nvazquez opened a pull request: https://github.com/apache/cloudstack/pull/1466 CLOUDSTACK-9340: General DB Optimization ## Description In some production environments there were being experimented delays in most of the jobs. A search for DB optimization was taken and

  1   2   >