[GitHub] cloudstack pull request: Bug-ID: CLOUDSTACK-8870: Skip external de...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/846#issuecomment-213034173 Thank you @GabrielBrascher. @kishankavala would you mind fixing that typo? I will try to get this run though CI soon... --- If your project is set up for it, you

[GitHub] cloudstack pull request: CLOUDSTACK-9352: Test fails in Widows as ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1498#issuecomment-212985885 That is what I was looking for. Thank you sir... :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: CLOUDSTACK-9164: Prevent firefox's quick ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1271#issuecomment-212987286 @footplus Is that a LGTM? I need one more LGTM code review. @anshul1886, can you please force push to the PR again to kick of jenkins so we can get that to

[GitHub] cloudstack pull request: Bug-ID: CLOUDSTACK-8870: Skip external de...

Github user GabrielBrascher commented on the pull request: https://github.com/apache/cloudstack/pull/846#issuecomment-212999101 Although I had pointed a typo in a comment line (nothing serious), the code LGTM. --- If your project is set up for it, you can reply to this email and

Build failed in Jenkins: build-master-slowbuild #3545

See -- [...truncated 5610 lines...] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.045 sec - in com.cloud.consoleproxy.ConsoleProxyManagerTest Running

[GitHub] cloudstack pull request: Check the existence of 'forceencap' param...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1402 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-9172 Added cross zones check t...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1505 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: L10n update master 20160127

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1376#issuecomment-213100441 That is fine. @milamberspace would you mind just doing a force push again to kick off jenkins. I have seen other jenkins runs passing so I think jenkins is just

[GitHub] cloudstack pull request: Fixing an issue in Marvin around creating...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/1501#issuecomment-213104146 Thanks, everyone. Just as an FYI, the way I tested this was by running one of my Marvin tests and no longer passing in "ispublic" when creating a

[GitHub] cloudstack pull request: Test to create vpn customer gateway with ...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1308 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: [DISCUSS] Using framework level API argument validation

checked out the code, looks good Rohit. It will give us a handle to keep the API from becoming even more inconsistent, and maybe even improve. On Thu, Apr 21, 2016 at 1:07 PM, Rohit Yadav wrote: > All, > > Whenever we've to write new APIs, we end up putting a lot of

[GitHub] cloudstack pull request: Fix deleting template from UI

Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1476#issuecomment-213116347 Hey @remibergsma just noticed that you had a PR open for this. I fixed it as well with #1505 so we might be able to close this one --- If your project is set up

[GitHub] cloudstack pull request: L10n update master 20160127

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1376#issuecomment-213099792 @swill, @milamberspace sorry, the build is gone, I didn't react quick enough --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: systemvm: preserve file permissions, set ...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1420 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-9088: Update the description f...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1126 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: [CLOUDSTACK-9218]Test to verify restart n...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1323 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: Fixing an issue in Marvin around creating...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1501 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: New test to validate starting vm after ni...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1326 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-9130: Make RebootCommand simil...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1200 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: L10n update master 20160127

Github user swill commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1376#discussion_r60653156 --- Diff: tools/transifex/.tx/config --- @@ -89,3 +89,41 @@ trans.pt_BR = work-dir/messages_pt_BR.properties trans.ru_RU =

[GitHub] cloudstack pull request: CLOUDSTACK-8611. CS waits indefinitely fo...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/561 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8611:Handle SSH if server "for...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1459 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: Fix deleting template from UI

Github user remibergsma closed the pull request at: https://github.com/apache/cloudstack/pull/1476 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: Multithreaded Builds

Well the multithreaded build did complete successfully and it took. real7m3.933s user25m31.969s sys 3m2.880s Which compares to a non-multithreaded build on the same machine which takes. real10m8.288s user18m23.564s sys 1m19.215s It is not a huge improvement, but for CI

[GitHub] cloudstack pull request: Fixed: Error given when creating VPN user...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/826#issuecomment-213135751 @swill you know I always do; files from the server project have been changed. I would agree it is small and of low risk but I am not putting in the analysis to

Multithreaded Builds

Is it a reasonable expectation for ACS to be able to be built using the `-T 1C` flag? I am trying it now, but if it works once, it may not mean that it would always work. I see a lot of messages like this: [WARNING] * [WARNING] *

[GitHub] cloudstack pull request: CLOUDSTACK-9352: Test fails in Widows as ...

Github user GabrielBrascher commented on the pull request: https://github.com/apache/cloudstack/pull/1498#issuecomment-212984070 @swill it succesfully builds in windows: [build-result.txt](https://github.com/apache/cloudstack/files/230237/build-result.txt); Not sure it if

RE: Introduction

Hello, My name is Lianghwa Jou and I run the CloudPlatform engineering at Accelerite. We got several queries about our plan for CloudStack/CloudPlatform. I will try to answer the question briefly. When I think about what ACS can be or should be, I often think about AWS. AWS is a very feature

[GitHub] cloudstack pull request: CLOUDSTACK-9130: Make RebootCommand simil...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1200#issuecomment-212870271 @swill This is ready for merge, has the required LGTMs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-9104: VM naming convention in ...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1302#discussion_r60565861 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -2030,12 +2030,29 @@ int

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60573629 --- Diff: plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java --- @@ -0,0 +1,170 @@ +// Licensed to

[GitHub] cloudstack pull request: Test to create vpn customer gateway with ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1308#issuecomment-212905418 I will merge this today. Thanks... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

Re: jenkins builds are failing

Would that be related to the PR being tested? On Apr 21, 2016 7:17 AM, "Suresh Sadhu" wrote: > HI All, > > Jenkins build are failing with below licensing error "Too many files with > unapproved license: 1 " can someone please look into it. PR merge getting > delayed

[GitHub] cloudstack pull request: [CLOUDSTACK-9207] Test to verify restarti...

Github user pavanb018 commented on the pull request: https://github.com/apache/cloudstack/pull/1304#issuecomment-212892204 Done code review ,a part from the above comment , the code LGTM ! --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60570949 --- Diff: plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java --- @@ -0,0 +1,170 @@ +// Licensed

[GitHub] cloudstack pull request: CLOUDSTACK-9130: Make RebootCommand simil...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1200#issuecomment-212903509 Thanks, I will merge... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: CLOUDSTACK-9104: VM naming convention in ...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1302#issuecomment-212873785 @priyankparihar we'll need a unit test that shows that this change is backward compatible. I like that we're considering both default instance name with host name

RE: jenkins builds are failing

I don’t think it is related to the PRs Will. I have force pushed two of my PRs which are related to marvin tests. Jenkins build failed even for those two PRs. Best Regards, Sanjeev N Chief Product Engineer, Accelerite Off: +91 40 6722 9368 | EMail: sanjeev.neelar...@accelerite.com

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-212907833 @jburwell @rafaelweingartner I've added the test for checking the logged message using the gist provided by @jburwell. I've also added a `log4j.xml` because the test

[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1321#issuecomment-212868899 @nitin-maharana I checked the discussions on #823 as well. Looks like it is best to remove all tag checks for selecting offering. Also there is no usage impact

[GitHub] cloudstack pull request: CLOUDSTACK-9100: ISO.CREATE/TEMPLATE.CREA...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1157 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: [CLOUDSTACK-9218]Test to verify restart n...

Github user pavanb018 commented on the pull request: https://github.com/apache/cloudstack/pull/1323#issuecomment-212886925 @sanju1010 Have done code walk through and LGTM ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: [CLOUDSTACK-9218]Test to verify restart n...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1323#issuecomment-212902454 I think this one is ready to merge. I will add it to my merge queue... --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: BUG-ID:CLOUDSTACK-9331:added code in marv...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1458#issuecomment-212906931 I think this one is ready. I want Jenkins to be green before I merge though. I will review what is going on with Jenkins today. I will this to my merge list.

[GitHub] cloudstack pull request: CLOUDSTACK-9261: Query to traffic sentine...

Github user GabrielBrascher commented on the pull request: https://github.com/apache/cloudstack/pull/1418#issuecomment-212876630 @kansal create methods would also help to test the behavior of this code, using unit test and integration test (to verify if the methods that have unit

[GitHub] cloudstack pull request: [CLOUDSTACK-9207] Test to verify restarti...

Github user pavanb018 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1304#discussion_r60570371 --- Diff: test/integration/component/test_vpc_network.py --- @@ -2748,3 +2751,86 @@ def test_stop_start_vpc_router(self): if

Re: jenkins builds are failing

As per the build logs RAT is failing. Not sure from where this file is getting picked up. Unapproved licenses: utils/testsmallfileinactive *** From: Will Stevens Sent: Thursday, April 21, 2016

[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1321#issuecomment-212898459 @koushik-das : I also think the same. Yes, that would be better. I will raise another PR with removing the existing implementation. pinging @agneya2001

[GitHub] cloudstack pull request: [CLOUDSTACK-9337]Enhance vcenter.py to cr...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1464#issuecomment-212904531 I am fine with not running CI on this one. It would be nice if someone could post a screenshot or something to show that the code behaves as expected. We

[GitHub] cloudstack pull request: CLOUDSTACK-8751 minimise downtime of netw...

Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/866#issuecomment-212912851 @deepthimachiraju what's the downtime of network ? I think this PR is too complicated. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

Github user dmabry commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1500#discussion_r60581671 --- Diff: test/integration/component/test_volumes.py --- @@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self): "Check the

[GitHub] cloudstack pull request: New test to validate starting vm after ni...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1326#issuecomment-212910562 Thanks, I will merge this today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

Github user dmabry commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1500#discussion_r60582064 --- Diff: test/integration/component/test_volumes.py --- @@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self): "Check the

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1500#discussion_r60582658 --- Diff: test/integration/component/test_volumes.py --- @@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self): "Check the

[GitHub] cloudstack pull request: Fixing an issue in Marvin around creating...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1501#issuecomment-212908719 I am pretty confident with this one and we have the LGTM code reviews required, so I will add this to my merge queue to be merged today. Thanks... --- If your

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

Github user dmabry commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1500#discussion_r60582709 --- Diff: test/integration/component/test_volumes.py --- @@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self): "Check the

[GitHub] cloudstack pull request: CLOUDSTACK-8886: Limitations is listUsage...

Github user jayapalu commented on the pull request: https://github.com/apache/cloudstack/pull/858#issuecomment-212767005 @kansal code LGTM can you please add the API response output so that we can push this PR. --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: Fixing an issue in Marvin around creating...

Github user cloudsadhu commented on the pull request: https://github.com/apache/cloudstack/pull/1501#issuecomment-212766999 LGTM based on the code review !! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: CLOUDSTACK-8886: Limitations is listUsage...

Github user kansal commented on the pull request: https://github.com/apache/cloudstack/pull/858#issuecomment-212767205 @jayapalu Will do that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: Fixing an issue in Marvin around creating...

Github user nitt10prashant commented on the pull request: https://github.com/apache/cloudstack/pull/1501#issuecomment-212767179 LGTM based on code review @mike-tutkowski can you provide test results --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-9100: ISO.CREATE/TEMPLATE.CREA...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/1157#issuecomment-212760624 LGTM based on code review :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: CLOUDSTACK-8830 - [Vmware] VM snapshot fa...

Github user maneesha-p commented on the pull request: https://github.com/apache/cloudstack/pull/798#issuecomment-212768046 ACS CI BVT Run Sumarry: Build Number 106 Hypervisor xenserver NetworkType Advanced Passed=104 Failed=14 Skipped=4 The

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

Github user nitt10prashant commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1500#discussion_r60532285 --- Diff: test/integration/component/test_volumes.py --- @@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self): "Check

[GitHub] cloudstack pull request: Marvin test to verify that adding TCP por...

Github user pavanb018 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1183#discussion_r60532757 --- Diff: test/integration/component/test_vpn_users.py --- @@ -451,3 +453,64 @@ def test_07_add_VPN_user_domain_admin(self):

[GitHub] cloudstack pull request: CLOUDSTACK-8855 Improve Error Message for...

Github user bvbharatk commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/837#discussion_r60530964 --- Diff: server/src/com/cloud/resource/ResourceManagerImpl.java --- @@ -1148,15 +1148,16 @@ public Host cancelMaintenance(final CancelMaintenanceCmd

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

Github user nitt10prashant commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1500#discussion_r60531171 --- Diff: test/integration/component/test_volumes.py --- @@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self): "Check

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

Github user nitt10prashant commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1500#discussion_r60531417 --- Diff: test/integration/component/test_volumes.py --- @@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self): "Check

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

Github user dmabry commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1500#discussion_r60585058 --- Diff: test/integration/component/test_volumes.py --- @@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self): "Check the

[GitHub] cloudstack pull request: CLOUDSTACK-9172 Added cross zones check t...

Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1505#issuecomment-212950771 Screen shot from [before](https://issues.apache.org/jira/secure/attachment/1250/Screen%20Shot%202015-12-15%20at%2015.32.12.png) the fix After:

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

Github user dmabry commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1500#discussion_r60584441 --- Diff: test/integration/component/test_volumes.py --- @@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self): "Check the

[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...

GitHub user insom opened a pull request: https://github.com/apache/cloudstack/pull/1508 CLOUDSTACK-9362: Skip VXLANs when rewriting the bridge name for migrations From the [JIRA issue](https://issues.apache.org/jira/browse/CLOUDSTACK-9362): >

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60585031 --- Diff: plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java --- @@ -0,0 +1,170 @@ +// Licensed to

[GitHub] cloudstack pull request: [CLOUDSTACK-9207] Test to verify restarti...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1304#issuecomment-212934000 @sanju1010 can you review @pavanb018's comment. We need 1 more LGTM code review, otherwise things are looking to be in pretty good shape here. --- If your

[GitHub] cloudstack pull request: CLOUDSTACK-9172 Added cross zones check t...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1505#issuecomment-212956256 Thank you sir. This is looking pretty good now. I think this LGTM, so I will add this to the PRs to be merged today. --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-9352: Test fails in Widows as ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1498#issuecomment-212964858 I need one more LGTM and if you can post some proof this is working as expected, I will feel better about merging it. Thanks... :) --- If your project is set up

[GitHub] cloudstack pull request: Fixed: Error given when creating VPN user...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/826#issuecomment-212963691 I am pretty comfortable with this change. We have had 2 manual tests to validate the functionality and two LGTM votes. I am not sure this change warrants a full run

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

Github user dmabry commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1500#discussion_r60602140 --- Diff: test/integration/component/test_volumes.py --- @@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self): "Check the

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

Github user dmabry commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1500#discussion_r60602084 --- Diff: test/integration/component/test_volumes.py --- @@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self): "Check the

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

Github user dmabry commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1500#discussion_r60602700 --- Diff: test/integration/component/test_volumes.py --- @@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self): "Check the

[GitHub] cloudstack pull request: CLOUDSTACK-9088: Update the description f...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1126#issuecomment-212976859 We need to be doing this to more API calls, so I am happy we are starting to look at this. @DaanHoogland I don't think JSON adds much value here. I think

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1054#issuecomment-212981219 I need one more LGTM for this one and I would like to run CI to make sure nothing breaks. Otherwise I think this is in a good place. --- If your project is set up

[GitHub] cloudstack pull request: Bug-ID: CLOUDSTACK-8870: Skip external de...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/846#issuecomment-212983883 I need one more LGTM. I will add this to my CI queue. Thx... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: Test to create vpn customer gateway with ...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1308#issuecomment-212842361 @swill This is a test only PR. 2 LGTMs are there and the CI failures are unrelated to the changes. This can be merged. --- If your project is set up for it,

[GitHub] cloudstack pull request: CLOUDSTACK-9261: Query to traffic sentine...

Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/1418#issuecomment-212842771 @kansal LGTM. See if you can add an integration test. Actual response from traffic sentinel resource in the logs will also help. --- If your

[GitHub] cloudstack pull request: Cloudstack-8961: Changes related to the U...

Github user jayapalu commented on the pull request: https://github.com/apache/cloudstack/pull/1255#issuecomment-212842613 @kansal Can you please complete the localisation changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-9130: Make RebootCommand simil...

Github user rajesh-battala commented on the pull request: https://github.com/apache/cloudstack/pull/1200#issuecomment-212842649 LGTM. :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: CLOUDSTACK-8841: Storage XenMotion from X...

Github user sateesh-chodapuneedi commented on the pull request: https://github.com/apache/cloudstack/pull/815#issuecomment-212842765 >>Currently UI does not allow migration between different versions, and changing UI for this change is not elegant. @priyankparihar Why allow

[GitHub] cloudstack pull request: CLOUDSTACK-8841: Storage XenMotion from X...

Github user sateesh-chodapuneedi commented on the pull request: https://github.com/apache/cloudstack/pull/815#issuecomment-212845624 >Purpose of doing this change is if some user intentionally want to do migration from lower to higher then he can do it via API(from UI he can not do

[GitHub] cloudstack pull request: CLOUDSTACK-8841: Storage XenMotion from X...

Github user priyankparihar commented on the pull request: https://github.com/apache/cloudstack/pull/815#issuecomment-212846127 @sateesh-chodapuneedi @koushik-das I will get back to you soon. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-212852849 @jburwell I've fixed outstanding issues, including a framework level API arg validation (and removed such validations across cmd implementations) @koushik-das

[GitHub] cloudstack pull request: CLOUDSTACK-9104: VM naming convention in ...

Github user sateesh-chodapuneedi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1302#discussion_r60561591 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -2030,12 +2030,29 @@ int

[GitHub] cloudstack pull request: fake don't merge

GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/1507 fake don't merge You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudstack fake-marvin-faliing-master Alternatively you can

[GitHub] cloudstack pull request: fake don't merge

Github user bhaisaab closed the pull request at: https://github.com/apache/cloudstack/pull/1506 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

Github user nitt10prashant commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1500#discussion_r60533118 --- Diff: test/integration/component/test_volumes.py --- @@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self): "Check

[GitHub] cloudstack pull request: Marvin test to verify that adding TCP por...

Github user pavanb018 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1183#discussion_r60533545 --- Diff: test/integration/component/test_vpn_users.py --- @@ -451,3 +453,64 @@ def test_07_add_VPN_user_domain_admin(self):

[GitHub] cloudstack pull request: Fixed: Error given when creating VPN user...

Github user kansal commented on the pull request: https://github.com/apache/cloudstack/pull/826#issuecomment-212773238 @jayapalu Rebased. Please have a look now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-8841: Storage XenMotion from X...

Github user rajesh-battala commented on the pull request: https://github.com/apache/cloudstack/pull/815#issuecomment-212777172 Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: Fixed: Error given when creating VPN user...

Github user kansal commented on the pull request: https://github.com/apache/cloudstack/pull/826#issuecomment-212777128 @jayapalu attached the screenshots: https://cloud.githubusercontent.com/assets/4276209/14700575/17b9fb80-07be-11e6-84cb-b61d68816496.png;>

[GitHub] cloudstack pull request: CLOUDSTACK-9272: No option in UI to add G...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1399 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-9164: Prevent firefox's quick ...

Github user rajesh-battala commented on the pull request: https://github.com/apache/cloudstack/pull/1271#issuecomment-212780472 Looks good to me. After this patch on pressing "/" on console not showing/activating the search bar. --- If your project is set up for it, you can

  1   2   >