[GitHub] cloudstack pull request: L10n update 4.8 20160422

2016-04-29 Thread milamberspace
Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/1515#issuecomment-215645435 @swill Now the Jenkins build works, but the Travis failed with: No output has been received in the last 10m0s, this potentially indicates a stalled build

[GitHub] cloudstack pull request: L10n update 4.8 20160422

2016-04-29 Thread milamberspace
Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/1515#issuecomment-215671781 @swill after a new push to start a new Travis build, Travis and Jenkins are now green! You can merge the PR! :-) --- If your project is set up for it, you

[GitHub] cloudstack pull request: CLOUDSTACK-9350: KVM-HA- Fix CheckOnHost ...

2016-04-29 Thread abhinandanprateek
Github user abhinandanprateek commented on the pull request: https://github.com/apache/cloudstack/pull/1496#issuecomment-215651932 @swill rebased it. Thank you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

2016-04-29 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-215675646 @swill can you try again with your CI? @agneya2001 @jburwell @wido @kiwiflyer @nvazquez @DaanHoogland and others - please review and share your LGTM, thanks

[GitHub] cloudstack pull request: L10n update 4.8 20160422

2016-04-29 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1515#issuecomment-215698702 awesome, thank you sir. i will get this merged today... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

2016-04-29 Thread kiwiflyer
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-215741459 @rhtyd - We'll pull this in for functional testing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

RE: Building Ubuntu 16.04 packages

2016-04-29 Thread Wido den Hollander
> Op 27 april 2016 om 19:38 schreef Wido den Hollander : > > > > > Op 27 april 2016 om 14:19 schreef Rohit Yadav : > > > > > > Hi Wido, > > > > Thanks for starting this discussion. I'm not sure exactly how to do it > > either, but I suppose we can

Python Question (with regards to Marvin)

2016-04-29 Thread Tutkowski, Mike
Hi everyone, I received an error when trying to invoke the instance version of enableMaintenance (below). 'TypeError: enableMaintenance() takes exactly 3 arguments (2 given)\n'] I looked at base.py and it has the following with regards to maintenance mode for hosts: def

[GitHub] cloudstack pull request: CLOUDSTACK-9305: Cloudstack Usage Breaks ...

2016-04-29 Thread kiwiflyer
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1433#issuecomment-215840094 2 x LGTMs and CI complete. This is Ready to Merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...

2016-04-29 Thread kiwiflyer
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1428#issuecomment-215840702 @Slair1 @dmabry @remibergsma Could I get some review on this when you get a chance? I'd like to get this PR moving. --- If your project is set up for

[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...

2016-04-29 Thread Slair1
Github user Slair1 commented on the pull request: https://github.com/apache/cloudstack/pull/1428#issuecomment-215859262 @kiwiflyer No, we were not failing over our ACS mgmt servers. We still had both up and functional and were able to log directly into both (and of course through

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

2016-04-29 Thread nvazquez
Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1518#issuecomment-215852047 @rafaelweingartner I added test cases and the new hierarchy --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

2016-04-29 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1444#issuecomment-215832199 Just do a force push again. Jenkins is being a bit of a princess recently, so we just have to keep trying. This has been happening to a lot of PRs and it is almost

[GitHub] cloudstack pull request: Add lsb-release dependency to agent and m...

2016-04-29 Thread kiwiflyer
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1412#issuecomment-215874307 @ProjectMoon Can you open a new PR against 4.7 with this? We're really only supporting 4.7.x onward. Trivial packing change. LTGM --- If your

[GitHub] cloudstack pull request: CLOUDSTACK-9305: Cloudstack Usage Breaks ...

2016-04-29 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1433#issuecomment-215848580 Sorry, I missed the LGTMs. :) I will add this to my merge queue. Thanks @kiwiflyer for following up. --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...

2016-04-29 Thread Slair1
Github user Slair1 commented on the pull request: https://github.com/apache/cloudstack/pull/1428#issuecomment-215854412 this LGTM. we have been running this in our environment for over a month (ACS 4.8). This PR fixes the issue we had with cloudstack-mangaement not starting when

[GitHub] cloudstack pull request: Bump ssh retries to prevent false positiv...

2016-04-29 Thread kiwiflyer
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1473#issuecomment-215873345 This is a trivial config change for a smoke test. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

2016-04-29 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1444#issuecomment-215829693 @swill Jenkins is complaining about a file called "testsmallfileinactive", but I have not introduced any sort of file like that. Is that some sort of

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

2016-04-29 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-215815079 thanks @kiwiflyer --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

2016-04-29 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-215818023 LGTM for code review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

2016-04-29 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1444#issuecomment-215822574 @swill conflicts solved --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

2016-04-29 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1444#issuecomment-215833023 Ok, I will do that. I can help youwith that (If we get access to the VM). It would be nice, something like this plugin

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

2016-04-29 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1444#issuecomment-215847599 ya, that is interesting. a couple people have mentioned similar tools. once I get the repo moved to the new github org I can start look into adding such tooling...

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-04-29 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-215851189 @jburwell, that is great that we understood each other ;) Your questions is a great one, why are we discussion this, and why testing that.

[GitHub] cloudstack pull request: Followup fix for #1162: Add support for n...

2016-04-29 Thread kiwiflyer
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1330#issuecomment-215872240 Team, Where are we currently on this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...

2016-04-29 Thread kiwiflyer
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1428#issuecomment-215856646 @Slair1 Are you failing a ACS management server in addition to the MySQL instance? If so, make sure your Load Balancer is also moving the traffic to the

[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...

2016-04-29 Thread kiwiflyer
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1428#issuecomment-215860378 Interesting. I'll go digging into the code. I'm not that familiar with the console proxy (yet). --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: CLOUDSTACK-9350: KVM-HA- Fix CheckOnHost ...

2016-04-29 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1496#issuecomment-215890052 LGTM for code review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

2016-04-29 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1518#discussion_r61645464 --- Diff: plugins/hypervisors/vmware/test/com/cloud/hypervisor/vmware/resource/VmwareResourceTest.java --- @@ -117,4 +154,79 @@ public void

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-29 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-215889804 @swill fixed the issue of orderable permissions, PR is ready for testing/merge --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

2016-04-29 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1518#discussion_r61643519 --- Diff: core/src/com/cloud/agent/api/storage/StorageNfsVersionCommand.java --- @@ -0,0 +1,44 @@ +// +// Licensed to the Apache

[GitHub] cloudstack pull request: CLOUDSTACK-9350: KVM-HA- Fix CheckOnHost ...

2016-04-29 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1496#discussion_r61649158 --- Diff: server/src/com/cloud/ha/HighAvailabilityManagerImpl.java --- @@ -264,6 +265,11 @@ public void scheduleRestartForVmsOnHost(final HostVO host,

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

2016-04-29 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1518#discussion_r61646120 --- Diff: plugins/hypervisors/vmware/test/com/cloud/hypervisor/vmware/resource/VmwareResourceTest.java --- @@ -117,4 +154,79 @@ public void