Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1490#issuecomment-216228399
LGTM
tag:easypr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-216228334
The PR is ready for merge, any testing/feedback welcome /cc @swill
tag:mergeready
---
If your project is set up for it, you can reply to this email and
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1488#issuecomment-216228181
LGTM
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1486#issuecomment-216228086
@remibergsma can do a push -f again, Travis failed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1485#issuecomment-216227853
@karuturi @imduffy15 comments on the change, thanks
tag:needlove
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1483#issuecomment-216227701
@remibergsma please squash changes to a single commit, and push -f
tag:needlove
---
If your project is set up for it, you can reply to this email and have
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1482#issuecomment-216227551
@remibergsma please rebase against master and squash changes to a single
commit
tag:needlove
---
If your project is set up for it, you can reply to this
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1477#issuecomment-216227415
LGTM
A manual UI testing is needed
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1473#issuecomment-216227254
LGTM
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1124#issuecomment-216227189
I can prioritize CI on this one as it is ready otherwise. It is worth
doing a test run since a lot has happened since this was rebased. Thx...
---
If your project
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1472#issuecomment-216227202
tag:needlove
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1471#issuecomment-216227004
tag:needlove
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-216226822
Good improvement, LGTM (just code review)
tag:needlove
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1466#issuecomment-216226707
@nvazquez thanks, can you rebase and squash changes to one commit
LGTM, a CI and Travis run should confirm the fix.
tag:mergeready
---
If your
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1464#issuecomment-216226567
@sanju1010 how can we test this
tag:vmware-pickup
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1463#issuecomment-216226424
tag:needlove
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1463#issuecomment-216226409
@DaanHoogland what is the logic here, if any empty router is configured
than start baremetal-vr server?
---
If your project is set up for it, you can reply to this
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1460#issuecomment-216226297
tag:needlove
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1230#issuecomment-216226380
@kiwiflyer thank you. I will merge this today...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1440#issuecomment-216225804
LGTM, a CI testing would confirm if PR can be accepted
tag:easypr
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1444#issuecomment-216226029
@rafaelweingartner please rebase against master, and squash changes to a
single commit
tag:easypr
---
If your project is set up for it, you can reply to
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1351#issuecomment-216225603
@rhtyd & @DaanHoogland I don't have the ability to test this as I have a
KVM setup, can one of you post some test results using VMware?
---
If your project is set
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1437#issuecomment-216225500
A CI testing (one with HyperV) should confirm if this PR can be accepted
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1435#issuecomment-216225313
@pdion891 rebase against latest master and squash commits into a single
commit, thanks
LGTM
tag:easypr
---
If your project is set up for it, you
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1433#issuecomment-216225073
@Slair1 if dh ha jar is missing for example there is no db-ha deb package,
what happens?
---
If your project is set up for it, you can reply to this email and have
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1432#issuecomment-216224926
@pfarmer thanks, please rebase against latest master, squash commits to a
single commit; the version need to be changes to 4.9.0
tag:easypr
---
If your
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1428#issuecomment-216224800
tag:needlove
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1424#issuecomment-216224725
@syed please rebase and squash changes into a single commit
tag:needlove
---
If your project is set up for it, you can reply to this email and have your
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1423#issuecomment-216224619
LGTM
@syed can you do a rebase and push -f again thanks
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1421#issuecomment-216224495
LGTM
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1418#issuecomment-216224340
@kansal please rebase against latest master
tag:needlove
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1414#issuecomment-216224139
@resmo LGTM, please rebase against master and squash changes into a single
commit
tag:mergeready
---
If your project is set up for it, you can reply to
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1410#issuecomment-216223897
tag:needlove
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1412#issuecomment-216223961
@ProjectMoon please close this and open against 4.7+, thanks
tag:closeme
---
If your project is set up for it, you can reply to this email and have your
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1408#issuecomment-216223801
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1407#issuecomment-216223393
@ntavares please rebase against latest master
we'll need blessing from @milamberspace on this one
---
If your project is set up for it, you can reply to this
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1406#issuecomment-216223321
@ProjectMoon open PR against 4.7, this enhancement is feature-ish; so I
would say open against master. Thanks
---
If your project is set up for it, you can reply to
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1404#issuecomment-216222731
tag:needlove
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1403#issuecomment-216222647
@mike-tutkowski thanks, please rebase against master, squash the changes to
a single commit
tag:mergeready
---
If your project is set up for it, you can
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1401#issuecomment-216222490
Thanks @shwetaag can you modify the test case to use public URLs and if
possible add them to `.travis` (i.e. how many of tests can be run with
travis/simulator?)
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1396#issuecomment-216222336
tag:vmware-pickup
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user NuxRo commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-21627
rhtyd,
You can test via cloudmonkey, e.g.
update virtualmachine id=937daff4-7ce8-454c-bc8b-6f96b72017f5
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1385#issuecomment-21610
@DaanHoogland rebase against latest master thanks
tag:easypr
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1379#issuecomment-216222040
How do we test this, thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1378#issuecomment-216221868
LGTM @ProjectMoon please send the PR for 4.7+; the merge workflow is from
4.7+
Please close this one and open another PR against 4.7+ thanks
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1376#issuecomment-216221653
LGTM
tag:easypr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1371#issuecomment-216221516
tag:needlove
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1374#issuecomment-216221597
LGTM, @milamberspace please rebase and squash changes into to a single
commit
tag:easypr
---
If your project is set up for it, you can reply to this email
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-216221452
@agneya2001 @jburwell @DaanHoogland @sureshanaparti LGTM/review please,
thanks
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1357#issuecomment-216221247
Good idea in general.
@ustcweizhou please rebase against latest master
tag:needlove
---
If your project is set up for it, you can reply to this email
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1351#issuecomment-216221100
@DaanHoogland can you rebase it once again and push -f
Once CI tested, we should be able to merge this cc @swill
tag:easypr
---
If your project is
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-216221000
LGTM, there are some comments on cosmetics but in general we should get
this CI tested and merged cc @swill
tag:easypr
---
If your project is set up for
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1333#issuecomment-216220849
tag:easypr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1330#issuecomment-216220520
@ProjectMoon thanks, please open against master; unlikely we'll do 4.7.x
4.8.x releases
---
If your project is set up for it, you can reply to this email and have
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1321#issuecomment-216220379
@nitin-maharana thanks, please rebase the branch again.
LGTM (without testing)
tag:easypr
---
If your project is set up for it, you can reply to
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1320#issuecomment-216220179
@nitin-maharana please rebase and share screenshots of what this fixes
A manual UI testing would be needed
---
If your project is set up for it, you can
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1307#issuecomment-216220089
@kansal please rebase and push -f, thanks
Please reply to outstanding comments
---
If your project is set up for it, you can reply to this email and have
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1305#issuecomment-216219986
Thanks @sarathkouk please rebase and push -f for travis to be kicked off
advise how should we test, the default test case values are all empty
---
If your
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1304#issuecomment-216219841
@sanju1010 please rebase and push -f for travis job to be kicked off
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-216219677
@DaanHoogland rebase against master, squash changes into a single commit,
thanks
Please advise how to test this
---
If your project is set up for it, you
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1282#issuecomment-216219596
@anshul1886 rebase against latest master, thanks
Do you think a cleanup action of some sort be performed, as this will only
delete the snapshot in database
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1280#issuecomment-216219348
@anshul1886 please rebase against latest master, can you explain if this
can cause backward compatiblity issue
tag:easypr
---
If your project is set up for
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1278#issuecomment-216219194
@anshul1886 please rebase against master, thanks
an integration test would be great
---
If your project is set up for it, you can reply to this email and have
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/1152#issuecomment-216217062
@DaanHoogland sure. Will rebase and keep the default value to false.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/985#issuecomment-216216953
@rhtyd Done! Rebased against master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/1202
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1152#issuecomment-216215437
@kansal please go ahead and remove the key from the response. We'll test
run it and add fixes to tests if needed. (cc @rhtyd my last comment is still
valid)
Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/987
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/987#issuecomment-216213369
I'd rather redo it then try to port forward. Testing means validating each
command in an integration test. If unit testing is required; for each command
and
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1269#issuecomment-216212068
@anshul1886 please rebase against latest master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1266#issuecomment-216211797
@resmo has this fix merged into 4.5, and 4.6/4.7+; if so you may close
this, it's unlikely we would release for 4.4.x and below versions
tag:closeme
---
If
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1257#issuecomment-216211328
@sureshanaparti please rebase against latest master, thanks
tag:vmware-pickup
---
If your project is set up for it, you can reply to this email and have
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1255#issuecomment-216211177
@kansal thanks, interesting fix. can you rebase against latest master
We'll need some manual testing to verify this and evaluate if this is the
right place
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1253#issuecomment-216210337
@sureshanaparti please rebase against latest master, move the schema
changes to 481-490 upgrade path
tag:vmware-pickup
---
If your project is set up for
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1252#issuecomment-216210063
@sureshanaparti please rebase against latest master, how do we test your
change; additional tests would be great
---
If your project is set up for it, you can reply
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1252#issuecomment-216209760
@
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1250#issuecomment-216208859
@shwetaag can you rebase against latest master and share state of your PR,
thanks
please also use publicly accessible URLs in the testdata, those with no
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1251#issuecomment-216208899
@koushik-das can you rebase against latest master and share state of your
PR, thanks
---
If your project is set up for it, you can reply to this email and have your
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/756#issuecomment-216208745
@rhtyd, rebased against latest master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1248#issuecomment-216208737
@sureshanaparti can you rebase against latest master and share state of
your PR, thanks; squash all changes into a single commit
tag:vmware-pickup
---
If
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1246#issuecomment-216208690
@SudharmaJain can you rebase against latest master and share state of your
PR, thanks
tag:easypr
---
If your project is set up for it, you can reply to
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1245#issuecomment-216208576
@pritisarap12 please modify the test to be able to run on basic zone as
well.
rebase against master thanks
---
If your project is set up for it, you can
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1241#issuecomment-216208430
LGTM
tag:easypr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1244#issuecomment-216208493
tag:easypr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1523#issuecomment-216208431
@alexandrelimassantana, you're right, I've splitted up the 3 different test
cases.
---
If your project is set up for it, you can reply to this email and have
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1244#issuecomment-216208482
@kishankavala can you rebase against latest master and share state of your
PR, thanks; the changes also need to be moved to 481-490 schema file
---
If your project
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1230#issuecomment-216208373
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-216208175
@ustcweizhou can you rebase against latest master and share state of your
PR, thanks
LGTM, though a marvin smoke test that can run with Travis would be great
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1203#issuecomment-216207807
LGTM, not tested though
@ghxandsky can you rebase against latest master and share state of your PR,
thanks
tag:vmware-pickup
---
If your project
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1202#issuecomment-216207451
@DaanHoogland can you move them to a wiki?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1198#issuecomment-216207184
@ustcweizhou thanks, can you rebase against latest master and share state
of your PR
this looks like an interesting change we should have
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1183#issuecomment-216206911
@sanju1010 can you rebase against latest master and share state of your PR,
thanks
---
If your project is set up for it, you can reply to this email and have your
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1180#issuecomment-216206438
@harikrishna-patnala can you rebase against latest master, update on tests
etc and share state of your PR, thanks
---
If your project is set up for it, you can
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1152#issuecomment-216206238
@kansal can you rebase against latest master and share state of your PR,
thanks
@DaanHoogland @jburwell do we still have outstanding issues on PR; do we
Github user olivierlemasle commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1503#discussion_r61726860
--- Diff: server/src/com/cloud/api/ApiServer.java ---
@@ -264,10 +266,11 @@ public void handleAsyncJobPublishEvent(String
subject, String
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1148#issuecomment-216205836
LGTM, @wenwenxiong can you rebase against latest master and share state of
your PR, thanks
tag:easypr
---
If your project is set up for it, you can reply
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1124#issuecomment-216205563
@rafaelweingartner please rebase against master and update on status of
your PR?
Looks like this can be merged once CI tested by @swill
tag:easypr
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1115#issuecomment-216205142
@abhinandanprateek @agneya2001 please check that your changes has been
merged on master and close this PR, thanks
tag:closeme
---
If your project is set up
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1104#issuecomment-216204778
@wolf29 can you rebase against latest master and share state of your PR,
thanks
LGTM
tag:easypr
---
If your project is set up for it, you can
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1087#issuecomment-216204381
@PaulAngus can you rebase against latest master and share state of your PR,
thanks
---
If your project is set up for it, you can reply to this email and have your
201 - 300 of 376 matches
Mail list logo
