[GitHub] cloudstack pull request #1757: CLOUDSTACK-9583: VR: In CsDhcp.py preseed bot...

2016-11-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1757 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack issue #1711: XenServer 7 Support

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1711 Good progress :smiley: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1757: CLOUDSTACK-9583: VR: In CsDhcp.py preseed both hosta...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1757 LGTM, merging this based on code review and test results. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack issue #1554: CLOUDSTACK-9602: API: improve resource limits compre...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1554 @marcaurele if I squash while merging, the git sha of the commit will change and the PR won't be marked as 'merged'. Which is why we use the `git-pr` tool that uses a merge strategy to merge the

[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1765 LGTM, last test run looks okay. Failed tests around vpc/rvr are known intermittent issues. @abhinandanprateek can you squash your commits, thanks. --- If your project is set up for it, you

[GitHub] cloudstack issue #1762: CLOUDSTACK-9595 Transactions are not getting retried...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1762 @abhinandanprateek can you help reviewing this one, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack issue #1769: tools: fix Dockerfile

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1769 LGTM. @pdion891 would you like to review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1745: CLOUDSTACK-9503: Increased the VR script timeout. Mo...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1745 LGTM, merging this based on last test run and code reviews. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request #1745: CLOUDSTACK-9503: Increased the VR script time...

2016-11-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1745 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack issue #1753: [4.9] Latest health test run

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1753 Trillian test result (tid-415) Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 6 Total time taken: 35171 seconds Marvin logs:

[GitHub] cloudstack issue #1754: [4.10] Latest health test run

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1754 Trillian test result (tid-406) Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 42870 seconds Marvin logs:

[GitHub] cloudstack issue #1753: [4.9] Latest health test run

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1753 Trillian test result (tid-414) Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 39194 seconds Marvin logs:

[GitHub] cloudstack issue #1766: CLOUDSTACK-9598: wrong defaut gateway for the nic in...

2016-11-23 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1766 @rhtyd reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1545: CLOUDSTACK-8715: Add channel to Instances for Qemu G...

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1545 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1754: [4.10] Latest health test run

2016-11-23 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1754 @rhtyd I quickly checked. test_06_download_detached_volume failed only on last run due to errorcode : 530, errortext : u'Unable to create a link for entity at

[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1726 @yvsubhash can you reply to raised review comments? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1733: CLOUDSTACK-9563 ExtractTemplate returns malformed UR...

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1733 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1580 Thanks @prashanthvarma I'll rekick some tests and awaiting for your test results. @blueorangutan package --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1710 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1710 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1735: CLOUDSTACK-9570: Bug in listSnapshots for snapshots ...

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1735 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1733: CLOUDSTACK-9563 ExtractTemplate returns malformed UR...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1733 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1734: CLOUDSTACK-9567 Difference in the api call outputs f...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1734 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1734: CLOUDSTACK-9567 Difference in the api call outputs f...

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1734 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1735: CLOUDSTACK-9570: Bug in listSnapshots for snapshots ...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1735 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1766: CLOUDSTACK-9598: wrong defaut gateway for the nic in...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1766 @murali-reddy lgtm, can you see why the same test passed again given no change to the PR was made? Do you think this new test could become a source of intermittent failure? --- If your project

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1710 Thanks @ozhanrk I'll kick a final test round with xenserver and merge this. @blueorangutan test centos7 xenserver-65sp1 --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack issue #1706: CLOUDSTACK-9500: remove the IP from the databag if i...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1706 @vilisseranen @nathanejohnson can you consider suggestion from @remibergsma and apply suitable changes, thanks. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1664: CLOUDSTACK-8676 Deploy user instance from vm snapsho...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1664 @sateesh-chodapuneedi @yvsubhash ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1766: CLOUDSTACK-9598: wrong defaut gateway for the nic in...

2016-11-23 Thread murali-reddy
Github user murali-reddy commented on the issue: https://github.com/apache/cloudstack/pull/1766 @rhtyd it was packaging issue, in failed run my change was not picked --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack issue #1686: CLOUDSTACK-9507: ListVM response's guest_os id shoul...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1686 This PR will be on hold until next set of 4.8.x, 4.9.x, 4.10.x releases. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1754: [4.10] Latest health test run

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1754 Some new errors have popped up related to snapshots/volumes which were previously passing on xenserver: test_01_snapshot_root_disk Failure 16.19 test_snapshots.py

[GitHub] cloudstack issue #1545: CLOUDSTACK-8715: Add channel to Instances for Qemu G...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1545 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1580 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1765 @blueorangutan test centos7 xenserver-65sp1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1765 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1765 LGTM. @abhinandanprateek @murali-reddy @jburwell are we lgtm on this PR? @blueorangutan test centos7 xenserver-65sp1 --- If your project is set up for it, you can reply to this

[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1765 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1320: CLOUDSTACK-8968: UI icon over VM snapshot to deploy ...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1320 @nitin-maharana can you rebase and change PR base to 4.8+ branches. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not clea...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1740 @yvsubhash can you reply on raised review comments? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1737: CLOUDSTACK-9561 After domain/account deletion, snaps...

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1737 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1737: CLOUDSTACK-9561 After domain/account deletion, snaps...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1737 LGTM. @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1662: Fix bug juniper srx

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1662 @digitalgust ping, squash your changes and get a JIRA id for this, and use the JIRA id in the git summary, thanks. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request #1772: Fix template sync for region store.

2016-11-23 Thread syed
GitHub user syed opened a pull request: https://github.com/apache/cloudstack/pull/1772 Fix template sync for region store. When using a region store like Swift or S3 as secondary storage, the `zoneId` can be null. This causes an exception when we try to convert it to a

[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1765 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1577: CLOUDSTACK-9321 : Multiple Internal LB rules (more t...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1577 @nlivens @prashanthvarma can the new integration test be moved to smoke tests if this does not take a lot of time (say more than 20 mins)? I'll kick some tests. --- If your project is set up

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1710 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1766: CLOUDSTACK-9598: wrong defaut gateway for the nic in...

2016-11-23 Thread murali-reddy
Github user murali-reddy commented on the issue: https://github.com/apache/cloudstack/pull/1766 @rhtyd @abhinandanprateek @ustcweizhou can you please review, we have clean test pass and new test test_router_dhcp_opts passing too. --- If your project is set up for it, you can reply

[GitHub] cloudstack issue #1766: CLOUDSTACK-9598: wrong defaut gateway for the nic in...

2016-11-23 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1766 @murali-reddy @rhtyd looks good to me on code review. Marvin test is neat. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack issue #1579: CLOUDSTACK-9403 : Support for shared networks in Nua...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1579 @nlivens @prashanthvarma @singalrahul can you please squash your commits. Pending review/lgtm is requested. --- If your project is set up for it, you can reply to this email and have your reply

Re: 4.8.2.0/4.9.1.0/4.10.0.0 RC Status

2016-11-23 Thread Rohit Yadav
All, We've managed to review/merge few PRs, but we still have five more to go after which we should be able to cut RCs. We've following PRs pending from previous list: * 4.10.0.0 * 1545 (code review comments; regression tests pending) * 1577 (Jenkins failures; regression tests pending)

[GitHub] cloudstack issue #1577: CLOUDSTACK-9321 : Multiple Internal LB rules (more t...

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1577 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1577: CLOUDSTACK-9321 : Multiple Internal LB rules (more t...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1577 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1604: improvement: systemvm slow operations

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1604 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1604: improvement: systemvm slow operations

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1604 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1766: CLOUDSTACK-9598: wrong defaut gateway for the nic in...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1766 Thanks all for reviewing and testing. I'll merge this now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request #1766: CLOUDSTACK-9598: wrong defaut gateway for the...

2016-11-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1766 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack issue #1545: CLOUDSTACK-8715: Add channel to Instances for Qemu G...

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1545 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-240 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1738: CLOUDSTACK-9566 instance-id metadata for baremetal V...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1738 The changes are in baremetal subsystem, which cannot be tested by current test environments. The changes LGTM, @karuturi @koushik-das can you review/lgtm on this and confirm any test results

[GitHub] cloudstack issue #1766: CLOUDSTACK-9598: wrong defaut gateway for the nic in...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1766 LGTM. @abhinandanprateek can you review as well? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1681: CLOUDSTACK-9491: incorrect parsing of device list to...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1681 LGTM, failures related to vpc/rvr are known intermittent failures. We'll kick another test round on #1753, #1754 etc. and work towards fixing them for vmware and xenserver separately. Merging

[GitHub] cloudstack pull request #1580: CLOUDSTACK-9402 : Support for underlay featur...

2016-11-23 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1580#discussion_r89277160 --- Diff: client/tomcatconf/commands.properties.in --- @@ -0,0 +1,804 @@ +# Licensed to the Apache Software Foundation (ASF) under one --- End diff

[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1765 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1545: CLOUDSTACK-8715: Add channel to Instances for Qemu G...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1545 @wido alright, I'll initiate a final test round -- if that passes we can consider merging. /cc @jburwell --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1545: CLOUDSTACK-8715: Add channel to Instances for Qemu G...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1545 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1680: CLOUDSTACK-9498: VR CsFile search utility methods fa...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1680 LGTM. Merging this based on review and tests. Failures in vpc/rvr are known intermittent issues and will be addressed separately for xen/vmware. --- If your project is set up for it, you

[GitHub] cloudstack issue #1604: improvement: systemvm slow operations

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1604 @romain-dartigues I'll have a look at the failure, meanwhile can you see my comments against the changes https://github.com/apache/cloudstack/pull/1604/files --- If your project is set up for

[GitHub] cloudstack pull request #756: CLOUDSTACK-8781 : Superfluous field during VPC...

2016-11-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/756 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...

2016-11-23 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1765 @rhtyd squashed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1559: CLOUDSTACK-9280: System VM volumes can be expunged i...

2016-11-23 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1559 @rhtyd, in my opinion the two commits are functionally separate enough that they should remain separate (and this might have been asked for in one of the various previous incarnations of

[GitHub] cloudstack issue #1622: Adding missing bits field to TemplateResponse

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1622 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-230 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1623: CLOUDSTACK-9317: Enable/disable static NAT associate...

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1623 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-231 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1545: CLOUDSTACK-8715: Add channel to Instances for Qemu G...

2016-11-23 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1545 Yes @rhtyd, I added a check for NULL there. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1710 Do we have LGTMs on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack pull request #1580: CLOUDSTACK-9402 : Support for underlay featur...

2016-11-23 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1580#discussion_r89277386 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/api/commands/EnableNuageUnderlayVlanIpRangeCmd.java --- @@ -0,0 +1,110 @@ +// +//

[GitHub] cloudstack pull request #1580: CLOUDSTACK-9402 : Support for underlay featur...

2016-11-23 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1580#discussion_r89277508 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/api/response/NuageVlanIpRangeResponse.java --- @@ -0,0 +1,38 @@ +// +// Licensed to

[GitHub] cloudstack issue #756: CLOUDSTACK-8781 : Superfluous field during VPC creati...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/756 Thanks, merging this now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1765 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1735: CLOUDSTACK-9570: Bug in listSnapshots for snapshots ...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1735 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1735: CLOUDSTACK-9570: Bug in listSnapshots for snapshots ...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1735 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack issue #1618: Now returning os info with the list snapshot respons...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1618 @ProjectMoon thanks, can you add a JIRA id for this and also use that in your commit's PR. @blueorangutan package --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack issue #1559: CLOUDSTACK-9280: System VM volumes can be expunged i...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1559 Thanks @ProjectMoon can you squash your commits. @murali-reddy @abhinandanprateek can you help review this? --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1752: [4.8] Latest health test run

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1752 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1754: [4.10] Latest health test run

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1754 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN rang...

2016-11-23 Thread nitin-maharana
GitHub user nitin-maharana opened a pull request: https://github.com/apache/cloudstack/pull/1771 CLOUDSTACK-9611: Dedicating a Guest VLAN range to Project does not work. Description: = Trying to dedicate a guest VLAN range to an account fails. Either API

[GitHub] cloudstack issue #1545: CLOUDSTACK-8715: Add channel to Instances for Qemu G...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1545 @wido can you confirm if you've fixed the NPE issue I've shared in the comment above? java.lang.NullPointerException at java.io.File.(File.java:277) at

[GitHub] cloudstack pull request #1681: CLOUDSTACK-9491: incorrect parsing of device ...

2016-11-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1681 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack issue #1623: CLOUDSTACK-9317: Enable/disable static NAT associate...

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1623 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1566: Followup fix for #1162: Add support for not (re)star...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1566 LGTM. @ProjectMoon thanks, can you add a JIRA id for this, and also in the commit's summary --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1542 LGTM, merging based on code reviews and tests, ignoring known intermittent errors in vpc/rvr. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack issue #1766: CLOUDSTACK-9598: wrong defaut gateway for the nic in...

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1766 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-229 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

Re: WSDL for CloudStack

2016-11-23 Thread Rohit Yadav
Mauricio, As far as I'm aware, we don't have any tooling to support this but you're right such a tool would consume response from listApis call. You may want to write such a tool for your use-case and maybe publish it on github/pypi/etc. Regards. From:

[GitHub] cloudstack issue #1618: Now returning os info with the list snapshot respons...

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1618 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-232 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1710: CLOUDSTACK-9538: FIX failure in Deleting Snapshot Fr...

2016-11-23 Thread ozhanrk
Github user ozhanrk commented on the issue: https://github.com/apache/cloudstack/pull/1710 Hi @kiwiflyer @nathanejohnson i saw that you are merged this fix and using it on your ENA CloudStack branch, when you have time could you check the code for possible LGTM's please. --- If

[GitHub] cloudstack issue #1545: CLOUDSTACK-8715: Add channel to Instances for Qemu G...

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1545 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1659: CLOUDSTACK-9339 Virtual Routers don't handle Multipl...

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1659 @murali-reddy can you check why we've test failures for KVM? Also, if the integration tests don't take a lot of time (few minutes to half hour) can you move it to smoke tests? --- If your

[GitHub] cloudstack issue #1622: Adding missing bits field to TemplateResponse

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1622 Thanks @ProjectMoon @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1622: Adding missing bits field to TemplateResponse

2016-11-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1622 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1622: Adding missing bits field to TemplateResponse

2016-11-23 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1622 @ProjectMoon can you add a JIRA id for this, also in the commit's summary --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

Re: WSDL for CloudStack

2016-11-23 Thread Rafael Weingärtner
The idea to have a WSDL or a WADL is interesting. It helps in integrations between system-system (without human coding/support), and allows more sophisticated software to consume APIs. Instead of creating something to generate the API externally, why not add a plugin into CloudStack that generate

  1   2   >