Re: [DISCUSS] Moving for JDK8, this time for real!

2017-01-05 Thread Will Stevens
I agree with Rohit about not making too many changes at once. I know we both agree that we should be going to Jessie, but let's do it in phases. Going to Java 8 is a big enough step for right now, lets stabilize that and then we can look at updating the system vm template after. *Will STEVENS*

[GitHub] cloudstack issue #1888: CLOUDSTACK-9710: Switch to JRE1.8

2017-01-05 Thread mike-tutkowski
Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1888 I walked through the diffs and they LGTM. I did not actually run the code, however, because I'm in the middle of another CloudStack project and I don't have the resources available at

Re: [DISCUSS] Moving for JDK8, this time for real!

2017-01-05 Thread Erik Weber
Yes, I understood that your proposal didn't change the debian version, I suggested that it should do, since when we do update the debian version we have to test everything over again anyway. That said, I won't oppose your proposal, I'm +1 of upgrading to jdk 1.8 -- Erik tor. 5. jan. 2017 kl.

[GitHub] cloudstack pull request #1891: CLOUDSTACK-9730: [VMware] Unable to add a hos...

2017-01-05 Thread sureshanaparti
GitHub user sureshanaparti opened a pull request: https://github.com/apache/cloudstack/pull/1891 CLOUDSTACK-9730: [VMware] Unable to add a host with space in its name to existing VMware cluster Issue: Unable to add a host with space in its name to existing VMware cluster

[GitHub] cloudstack pull request #1892: CLOUDSTACK-9731: Hardcoded label appears on t...

2017-01-05 Thread sureshanaparti
GitHub user sureshanaparti opened a pull request: https://github.com/apache/cloudstack/pull/1892 CLOUDSTACK-9731: Hardcoded label appears on the Add zone wizard Hardcoded label (label.remove.this.physical.network) appears on the Add zone wizard You can merge this pull request into

[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...

2017-01-05 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue: https://github.com/apache/cloudstack/pull/1847 @karuturi Seems this is ready for merge, with code LGTMs and based on test results published by @cloudmonger ? The 4 test failures seems not relevant to this patch with code

[GitHub] cloudstack issue #1888: CLOUDSTACK-9710: Switch to JRE1.8

2017-01-05 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1888 lgtm on code review @rhtyd --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1812: CLOUDSTACK-9650: Allow starting VMs regardless of cp...

2017-01-05 Thread koushik-das
Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1812 Looks like this is ready for merge. None of the test failures are related to this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack issue #1888: CLOUDSTACK-9710: Switch to JRE1.8

2017-01-05 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1888 Trillian test result (tid-770) Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 6 Total time taken: 45108 seconds Marvin logs:

[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...

2017-01-05 Thread cloudmonger
Github user cloudmonger commented on the issue: https://github.com/apache/cloudstack/pull/1847 ### ACS CI BVT Run **Sumarry:** Build Number 204 Hypervisor xenserver NetworkType Advanced Passed=101 Failed=3 Skipped=7 _Link to logs Folder

[GitHub] cloudstack issue #1888: CLOUDSTACK-9710: Switch to JRE1.8

2017-01-05 Thread karuturi
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1888 code LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

Re: [DISCUSS] Moving for JDK8, this time for real!

2017-01-05 Thread Erik Weber
On Thu, Jan 5, 2017 at 1:11 PM, Rohit Yadav wrote: > All, > > > I've been working on moving our codebase and runtime-environment to Java 8, > and since this is a much needed big change I want your feedback and blessings > on: > >

Re: [GitHub] cloudstack issue #1888: CLOUDSTACK-9710: Switch to JRE1.8

2017-01-05 Thread Sergey Levitskiy
Code review LGTM

[GitHub] cloudstack pull request #1890: FIX issue on preshared key if we disable/enab...

2017-01-05 Thread ustcweizhou
GitHub user ustcweizhou opened a pull request: https://github.com/apache/cloudstack/pull/1890 FIX issue on preshared key if we disable/enable remote access vpn Way to reproduce the issue (1) enable remote access vpn root@r-8349-VM:~# cat /etc/ipsec.d/ipsec.any.secrets :

[DISCUSS] Moving for JDK8, this time for real!

2017-01-05 Thread Rohit Yadav
All, I've been working on moving our codebase and runtime-environment to Java 8, and since this is a much needed big change I want your feedback and blessings on: https://github.com/apache/cloudstack/pull/1888 In order for this to work, I had to make changes in our veewee-based

Re: [DISCUSS] Moving for JDK8, this time for real!

2017-01-05 Thread Rohit Yadav
Erik, The PR I've proposed does not change the base Debian distro, it's still Debian 7 (wheezy) and not Jessie. I would like to avoid making too many changes in the same PR, especially moving to Jessie which won't be straight forward as it would introduce several changes, major package

[GitHub] cloudstack issue #1888: CLOUDSTACK-9710: Switch to JRE1.8

2017-01-05 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1888 All, for transparency this comment has the build log of the new systemvmtemplate attached: [systemvm-buildlog.txt](https://github.com/apache/cloudstack/files/687704/systemvm-buildlog.txt)

[RESULT][VOTE] Apache Cloudstack 4.9.2.0 (RC2)

2017-01-05 Thread Rohit Yadav
Hi all, After 72 hours, the vote for CloudStack 4.9.2.0 *passes* with 4 PMC + 0 non-PMC votes. +1 (PMC / binding) 4 person (Wido, Bruno, Rajani, Rohit) +1 (non binding) none 0 none -1 none Thanks to everyone participating. I will now prepare the release announcement to go

Re: 4.9 api docs went missing

2017-01-05 Thread Rohit Yadav
I've fixed it now, please recheck. Regards. From: ?zhan R?zgar Karaman Sent: 04 January 2017 17:59:10 To: dev@cloudstack.apache.org Subject: Re: 4.9 api docs went missing Hi; I think they are setting up the api page for new CloudStack

Re:[RESULT][VOTE] Apache Cloudstack 4.9.2.0 (RC2)

2017-01-05 Thread Haijiao
I am not a developer, but thanks you all for this another great achievement ! Understand how hard to get all the things sorted out. Just thinking we probably need 1-2 assistants to support RM going forward, share the workload like documentation, release notes, PR tracking... These

Re: 4.9 api docs went missing

2017-01-05 Thread Özhan Rüzgar Karaman
its working again, thanks Rohit On Fri, Jan 6, 2017 at 9:58 AM, Rohit Yadav wrote: > I've fixed it now, please recheck. > > > Regards. > > > From: ?zhan R?zgar Karaman > Sent: 04 January 2017 17:59:10 > To:

[GitHub] cloudstack issue #1888: CLOUDSTACK-9710: Switch to JRE1.8

2017-01-05 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1888 Thanks @wido I'll rever that line, though the dhcp-3 is a virtual package that actually install isc-dhcp-client, see https://packages.debian.org/wheezy/dhcp3-client --- If your project is set

[GitHub] cloudstack issue #1888: CLOUDSTACK-9710: Switch to JRE1.8

2017-01-05 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1888 @rhtyd Understood, no problem, just trying to keep the changes in this PR clean. All changes should be Java 8 related. --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack issue #1888: CLOUDSTACK-9710: Switch to JRE1.8

2017-01-05 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1888 Thanks @wido I've reverted and updated the PR now, you can refresh to see the updated changes. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack issue #1888: CLOUDSTACK-9710: Switch to JRE1.8

2017-01-05 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1888 Overall the changes look good to me. But can you explain why for example you changed the dhcp package name? It doesn't seem related to Java 8. All in favor of this switch, just checking

Re: [DISCUSS] Moving for JDK8, this time for real!

2017-01-05 Thread Wido den Hollander
> Op 5 januari 2017 om 16:06 schreef Will Stevens : > > > I agree with Rohit about not making too many changes at once. I know we > both agree that we should be going to Jessie, but let's do it in phases. > Going to Java 8 is a big enough step for right now, lets

[GitHub] cloudstack issue #1888: CLOUDSTACK-9710: Switch to JRE1.8

2017-01-05 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1888 Looks good now @rhtyd LGTM for the code --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this