[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance

2017-02-27 Thread rashmidixit
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1944 @rhtyd On the contrary, I think you adding metrics as pluggable API is a good idea. However, to seriously make the feature pluggable the UI component should also load based on a plugin

[GitHub] cloudstack issue #1954: CLOUDSTACK-9795: moved logrotate from cron.daily to ...

2017-02-27 Thread dmabry
Github user dmabry commented on the issue: https://github.com/apache/cloudstack/pull/1954 @rhtyd Sure, no problem. How would you like to handle the back porting? Do you want me to open PRs against 4.8 and 4.9? --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-27 Thread DaanHoogland
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1768 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1927: ipv6: Set IPv6 CIDR and Gateway in 'nic' profile

2017-02-27 Thread karuturi
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1927 merging this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-27 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1768 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance

2017-02-27 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1944 @borisstoyanov can you see the failure in Travis with test_list_infrastructure_metrics test case? Thanks @rashmidixit you're right I added this as a plugin to keep it separate from the core

[GitHub] cloudstack issue #1886: CLOUDSTACK-9728: Fixed traffic sentinel HTTP 414 err...

2017-02-27 Thread cloudmonger
Github user cloudmonger commented on the issue: https://github.com/apache/cloudstack/pull/1886 ### ACS CI BVT Run **Sumarry:** Build Number 398 Hypervisor xenserver NetworkType Advanced Passed=104 Failed=1 Skipped=7 _Link to logs Folder

[GitHub] cloudstack issue #1972: CLOUDSTACK-9779 : Releasing secondary guest IP fails...

2017-02-27 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/1972 @niteshsarda I don't see any change in file createNetworkOffering.xml, but still there are many lines being removed and added. As there is not change in this file, please revert.

[GitHub] cloudstack pull request #1972: CLOUDSTACK-9779 : Releasing secondary guest I...

2017-02-27 Thread niteshsarda
Github user niteshsarda commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1972#discussion_r103190716 --- Diff: engine/schema/src/com/cloud/network/dao/LoadBalancerDao.java --- @@ -29,4 +30,6 @@ List

[GitHub] cloudstack pull request #1927: ipv6: Set IPv6 CIDR and Gateway in 'nic' prof...

2017-02-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1927 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: Modern template hosting

2017-02-27 Thread Wido den Hollander
> Op 27 februari 2017 om 7:17 schreef Raja Pullela > : > > > Hi will, > > I believe, we didn’t get to close ‘getting a mirror on Apache’ because we > needed someone on the Apache Infra side to close this. BTW, > cloudstack-apt.get.eu (I think Nux manages this?)

Re: Modern template hosting

2017-02-27 Thread Raja Pullela
sorry Wido… forgot… thank you for correcting! On 2/27/17, 4:50 PM, "Wido den Hollander" wrote: > Op 27 februari 2017 om 7:17 schreef Raja Pullela > : > > > Hi will, > > I believe, we didn’t get to close ‘getting a mirror on Apache’ because we >

[GitHub] cloudstack pull request #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KV...

2017-02-27 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1960#discussion_r103212914 --- Diff: api/src/org/apache/cloudstack/api/command/admin/ha/EnableHAForClusterCmd.java --- @@ -0,0 +1,114 @@ +// Licensed to the Apache

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-27 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1768 @marcaurele can we have a unit test to confirm that this does not break upgrade for older systems, also by changing the order for all older versions, the way someone would upgrade from say 4.3 to

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-27 Thread karuturi
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1768 @DaanHoogland Can you post test results? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack-docs issue #19: Updating The Nuage VSP Plugin Documentation for A...

2017-02-27 Thread prashanthvarma
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack-docs/pull/19 @rhtyd @karuturi Please do review this cloudstack-docs PR, which includes changes to the Nuage VSP Plugin documentation for ACS 4.10 release. --- If your project is set up for it,

Save The Date: Spring Meetup Of Cloudstack European User Group

2017-02-27 Thread Steve Roles
Hi guys, The next meetup is Wednesday, April 12, hosted by Interoute Prague. As always, there will be some great speakers, the chance to meet and collaborate with other CloudStack users, and an informal gathering afterwards over a drink! Agenda and speakers: TBC; Venue: Interoute Czech s.r.o.

[GitHub] cloudstack pull request #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KV...

2017-02-27 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1960#discussion_r103210828 --- Diff: api/src/org/apache/cloudstack/api/command/admin/ha/DisableHAForClusterCmd.java --- @@ -0,0 +1,114 @@ +// Licensed to the Apache

[GitHub] cloudstack pull request #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KV...

2017-02-27 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1960#discussion_r103207344 --- Diff: .travis.yml --- @@ -42,13 +42,18 @@ env: smoke/test_dynamicroles smoke/test_global_settings

[GitHub] cloudstack pull request #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KV...

2017-02-27 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1960#discussion_r103212736 --- Diff: api/src/org/apache/cloudstack/api/command/admin/ha/DisableHAForZoneCmd.java --- @@ -0,0 +1,115 @@ +// Licensed to the Apache

[GitHub] cloudstack pull request #1954: CLOUDSTACK-9795: moved logrotate from cron.da...

2017-02-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1954 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack-docs issue #19: Updating The Nuage VSP Plugin Documentation for A...

2017-02-27 Thread prashanthvarma
Github user prashanthvarma commented on the issue: https://github.com/apache/cloudstack-docs/pull/19 These changes in the documentation are in accordance with our merged feature support (including bug fix) PRs. Here are some of our merged feature support PRs:

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-27 Thread marcaurele
Github user marcaurele commented on the issue: https://github.com/apache/cloudstack/pull/1768 @rhtyd I don't see how I could write such a test case. My point is exactly what you're saying, the upgrade would be different today for anyone who comes from an older version, which I don't

[GitHub] cloudstack pull request #:

2017-02-27 Thread nitin-maharana
Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/commit/fa85151be962824cc88776a0264e1ac6ef90560c#commitcomment-21082376 In server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java: In

[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance

2017-02-27 Thread rashmidixit
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1944 @rhtyd I guess this is fine for now. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1975: Fix build failure on master

2017-02-27 Thread koushik-das
Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1975 ping @karuturi --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack pull request #1975: Fix build failure on master

2017-02-27 Thread koushik-das
GitHub user koushik-das opened a pull request: https://github.com/apache/cloudstack/pull/1975 Fix build failure on master You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accelerite/cloudstack build-failure Alternatively you can

[GitHub] cloudstack issue #1824: CLOUDSTACK-9657: Fixed security group ipset issues w...

2017-02-27 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1824 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

Re: Modern template hosting

2017-02-27 Thread Chiradeep Vittal
The cloud templates provided by Ubuntu and CentOS (Debian doesn't provide one) can work out of the box if we support http://1692.254.169.254/ as a metadata URL. I believe this is as simple as adding this IP to the VR (+ a DNAT rule in the VR?) for advanced zone. For Basic Zone the default router

[GitHub] cloudstack pull request #:

2017-02-27 Thread pdion891
Github user pdion891 commented on the pull request: https://github.com/apache/cloudstack/commit/fa85151be962824cc88776a0264e1ac6ef90560c#commitcomment-21080945 In server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java: In

[GitHub] cloudstack pull request #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubu...

2017-02-27 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1950#discussion_r103382438 --- Diff: debian/control --- @@ -16,14 +16,15 @@ Description: A common package which contains files which are shared by several C Package:

Re: Modern template hosting

2017-02-27 Thread Pierre-Luc Dion
hi! I think we should work with distro provider to have their cloud builds work with cloudstack. Good example is CoreOS, it work out of the box from their channel builds. it shouldn't be too complicated to have centos, ubuntu and debian, unless ... For our systemvm templates, can we just change

[GitHub] cloudstack issue #1919: CLOUDSTACK-9763: set ssh public key when creating vm...

2017-02-27 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1919 This is usefull when using VPC. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #847: Bug-ID: CLOUDSTACK-8880: calculate free memory on hos...

2017-02-27 Thread ramkatru
Github user ramkatru commented on the issue: https://github.com/apache/cloudstack/pull/847 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cloudstack issue #1779: CLOUDSTACK-9610: Disabled Host Keeps Being up status...

2017-02-27 Thread priyankparihar
Github user priyankparihar commented on the issue: https://github.com/apache/cloudstack/pull/1779 >can you run internal CI and post @cloudmonger test results? @karuturi running. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance

2017-02-27 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1944 @rashmidixit the current UI does not support support pluggability of components within UI like the backend does. We can have a separate tab but not the implementation that the current metrics

[GitHub] cloudstack pull request #1944: CLOUDSTACK-9783: Improve metrics view perform...

2017-02-27 Thread rhtyd
GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/1944 CLOUDSTACK-9783: Improve metrics view performance This improves the metrics view feature by improving the rendering performance of metrics view tables, by re-implementing the logic at the

[GitHub] cloudstack pull request #1944: CLOUDSTACK-9783: Improve metrics view perform...

2017-02-27 Thread rhtyd
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1944 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request #:

2017-02-27 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/commit/fa85151be962824cc88776a0264e1ac6ef90560c#commitcomment-21082422 In server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java: In

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-27 Thread karuturi
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1768 Actually, BVT is not going to verify this as this is db upgrade related and travis would have tested it. I am merging this. --- If your project is set up for it, you can reply to this

[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier

2017-02-27 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/669 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack pull request #1976: Revert "Merge pull request #1829 from syed/hv...

2017-02-27 Thread karuturi
GitHub user karuturi opened a pull request: https://github.com/apache/cloudstack/pull/1976 Revert "Merge pull request #1829 from syed/hvm-volume-attach-restart-fix" This reverts commit d9bd01266ffb23f591283c058beff6e65d1cc4aa, reversing changes made to

[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance

2017-02-27 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1944 Thanks @rashmidixit @karuturi this is ready for merge, as soon as Travis passes. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request #1976: Revert "Merge pull request #1829 from syed/hv...

2017-02-27 Thread karuturi
Github user karuturi closed the pull request at: https://github.com/apache/cloudstack/pull/1976 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack issue #1976: Revert "Merge pull request #1829 from syed/hvm-volum...

2017-02-27 Thread karuturi
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1976 This is not going to fix the build issue. The issue is different. I will open a new PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack issue #1829: CLOUDSTACK-9363: Fix HVM VM restart bug in XenServer

2017-02-27 Thread karuturi
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1829 Both #1829 and #1941 are merged and is causing build failures. I am creating new PR with the revert. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1975: Fix build failure on master

2017-02-27 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1975 LGTM, found the build failure locally today. Introduced in `a2428508`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1958: CLOUDSTACK-5806: add presetup to storage types that ...

2017-02-27 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1958 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request #1977: fixed the merge conflict on merging #1941

2017-02-27 Thread karuturi
Github user karuturi closed the pull request at: https://github.com/apache/cloudstack/pull/1977 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack issue #1977: fixed the merge conflict on merging #1941

2017-02-27 Thread karuturi
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1977 PR #1975 has the same fix. closing this in favour of #1975 as jenkins already passed there. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request #1975: Fix build failure on master

2017-02-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1975 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-27 Thread DaanHoogland
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1768 @rhtyd I don't see how your concern is more true for the new code by @marcaurele then it is true for old code. cleanup is still going to be executed after the scripts, is it? only directly

[GitHub] cloudstack issue #1977: fixed the merge conflict on merging #1941

2017-02-27 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1977 LGTM. This change occurs due to code around that are gets diverged in master and 4.9 with merge of PR #1727. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1977: fixed the merge conflict on merging #1941

2017-02-27 Thread karuturi
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1977 Thanks for the review anshul. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-27 Thread DaanHoogland
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1768 [1768.network.results.txt](https://github.com/apache/cloudstack/files/805988/1768.network.results.txt)

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-27 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1768 @marcaurele I appreciate the cleanup, it should have been like this from the beginning but since we've the workflow to execute all the upgrades first and then the cleanup. In

master is broken

2017-02-27 Thread Rajani Karuturi
FYI, master is broken due to a merge conflict. I created PR https://github.com/apache/cloudstack/pull/1977 to fix the same. Will merge it ASAP. ~ Rajani http://cloudplatform.accelerite.com/

[GitHub] cloudstack pull request #1768: CLOUDSTACK 9601: Upgrade: change logic for up...

2017-02-27 Thread marcaurele
Github user marcaurele commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1768#discussion_r103394277 --- Diff: engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java --- @@ -424,27 +421,9 @@ protected void upgrade(CloudStackVersion

[GitHub] cloudstack issue #1883: CLOUDSTACK-9723: Enable unique mac address across th...

2017-02-27 Thread srinivas-gandikota
Github user srinivas-gandikota commented on the issue: https://github.com/apache/cloudstack/pull/1883 LGTM Reviewed code -- looks good I see even the BVTs have passed without any failures --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request #1977: fixed the merge conflict on merging #1941

2017-02-27 Thread karuturi
GitHub user karuturi opened a pull request: https://github.com/apache/cloudstack/pull/1977 fixed the merge conflict on merging #1941 You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accelerite/cloudstack build-fix Alternatively

[GitHub] cloudstack pull request #1768: CLOUDSTACK 9601: Upgrade: change logic for up...

2017-02-27 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1768#discussion_r103388263 --- Diff: engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java --- @@ -424,27 +421,9 @@ protected void upgrade(CloudStackVersion dbVersion,

[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

2017-02-27 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1951 Thanks @rhtyd for confirming. LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request #1962: CLOUDSTACK-9798 - Resizing root disk fails wh...

2017-02-27 Thread syed
Github user syed closed the pull request at: https://github.com/apache/cloudstack/pull/1962 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack issue #1962: CLOUDSTACK-9798 - Resizing root disk fails when usin...

2017-02-27 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1962 @mike-tutkowski If you already have incorporated these changes, I'll close this one. If possible, please add me as reviewer when you open the other PR --- If your project is set up for it, you

Re: Modern template hosting

2017-02-27 Thread Nathan Johnson
Paul Angus wrote: > Hi Nathan, > > Ideally, if you put the template location in (or use a template defined > in) test_data.py then the actual location can be overridden by anyone > testing. > > For Trillian, we've copied all of the templates that people have define

Re: Modern template hosting

2017-02-27 Thread Chiradeep Vittal
What steps are needed to set up a mirror? What does Infra need to do? Has anybody filed a ticket with Infra? On Sun, Feb 26, 2017 at 10:17 PM, Raja Pullela wrote: > Hi will, > > I believe, we didn’t get to close ‘getting a mirror on Apache’ because we > needed

[GitHub] cloudstack issue #1941: CLOUDSTACK-8663: Fixed various issues to allow VM sn...

2017-02-27 Thread kiwiflyer
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1941 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

Re: Modern template hosting

2017-02-27 Thread Will Stevens
We haven't opened a ticket yet because we don't have a strategy yet. What do you guys think of this: - We setup a new github repo in the 'apache' org which consists of a single file with a list of active/supported mirrors. - I write a small web server, distributed as a binary, which can be hosted

[GitHub] cloudstack issue #1829: CLOUDSTACK-9363: Fix HVM VM restart bug in XenServer

2017-02-27 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1829 @rhtyd @anshul1886 I suggest merging this first as the changes here are very limited and tested. We can refactor the change out from #1941 --- If your project is set up for it, you can reply to

Re: Modern template hosting

2017-02-27 Thread Chiradeep Vittal
Sounds workable. The downloader code in the SSVM won't follow redirects I think. https://github.com/apache/cloudstack/blob/5511065fc20787619d9cd0444a65a3155fc9c921/core/src/com/cloud/storage/template/HttpTemplateDownloader.java#L93 https://goo.gl/dSi0r5 Might need to add

Re: Modern template hosting

2017-02-27 Thread Chiradeep Vittal
The alternative foolproof way is to simply not provide the automatic download. Just document the mirror list URL where the templates can be found. I don't know why people reject this option. https://shankerbalan.net/blog/seed-cloudstack-templates-offline/ On Mon, Feb 27, 2017 at 10:15 AM, Will

Re: Modern template hosting

2017-02-27 Thread Chiradeep Vittal
My bad. A few lines down, this has been added recently: this.request.setFollowRedirects(true); On Mon, Feb 27, 2017 at 10:15 AM, Will Stevens wrote: > OK. Thanks for the heads up. > > On Feb 27, 2017 1:08 PM, "Chiradeep Vittal" wrote: > > >

[GitHub] cloudstack issue #1940: CLOUDSTACK-9781:ACS records ID in events tables inst...

2017-02-27 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1940 Trillian test result (tid-901) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 30078 seconds Marvin logs:

Re: Modern template hosting

2017-02-27 Thread Will Stevens
OK. Thanks for the heads up. On Feb 27, 2017 1:08 PM, "Chiradeep Vittal" wrote: > Sounds workable. The downloader code in the SSVM won't follow redirects I > think. > https://github.com/apache/cloudstack/blob/5511065fc20787619d9cd0444a65a3 >

[GitHub] cloudstack issue #815: CLOUDSTACK-8841: Storage XenMotion from XS 6.2 to XS ...

2017-02-27 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue: https://github.com/apache/cloudstack/pull/815 @karuturi This seems to be ready for merge. It has 2 LGTMs and tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....

2017-02-27 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1950 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1725: CLOUDSTACK-9559 Why allow deleting zone without dele...

2017-02-27 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/1725 LGTM on the code changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....

2017-02-27 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1950 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1949: Automated Cloudstack bugs 9277 9276 9275 9274 9273 9...

2017-02-27 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1949 @shwetaag I see some new failures in Travis around component tests, can you close and reopen this PR to rekick Travis tests? If Travis fails again, please see the failed tests and fix them. ---

[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

2017-02-27 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1961 @serg38 okay, we can add this to test_data /cc @PaulAngus --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KV...

2017-02-27 Thread rhtyd
GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/1960 [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA provider Host-HA offers investigation, fencing and recovery mechanisms for host that for any reason are malfunctioning. It uses Activity

[GitHub] cloudstack pull request #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KV...

2017-02-27 Thread rhtyd
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1960 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack issue #1948: [CLOUDSTACK-9793] Faster IP in subnet check

2017-02-27 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1948 LGTM, @karuturi can this be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1810: CLOUDSTACK-9647: NIC adapter type becomes e1000 , ev...

2017-02-27 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/1810 LGTM for code changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....

2017-02-27 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1950 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-538 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...

2017-02-27 Thread priyankparihar
Github user priyankparihar commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1813#discussion_r103154553 --- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java --- @@ -3520,27 +3520,17 @@ public UserVmVO doInTransaction(TransactionStatus status)

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-02-27 Thread priyankparihar
Github user priyankparihar commented on the issue: https://github.com/apache/cloudstack/pull/1813 @borisstoyanov as far as i can see test failures are not happening because of this change. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack issue #1965: CLOUDSTACK-9727 Password reset discrepancy in RVR wh...

2017-02-27 Thread cloudmonger
Github user cloudmonger commented on the issue: https://github.com/apache/cloudstack/pull/1965 ### ACS CI BVT Run **Sumarry:** Build Number 400 Hypervisor xenserver NetworkType Advanced Passed=105 Failed=0 Skipped=7 _Link to logs Folder

Re: Modern template hosting

2017-02-27 Thread Will Stevens
so this is what I am looking to do. Please let me know if you have suggestions for me or think I should be solving the problem a different way. - We request a new Github repository from the ASF at: 'apache/cloudstack-mirror-list' - In this repository we track a text file in the 'gh-pages' branch

[GitHub] cloudstack pull request #1974: CLOUDSTACK-9795: moved logrotate from cron.da...

2017-02-27 Thread dmabry
GitHub user dmabry opened a pull request: https://github.com/apache/cloudstack/pull/1974 CLOUDSTACK-9795: moved logrotate from cron.daily to cron.hourly for vpcrouter [BACKPORT PR1954] moved logrotate from cron.daily to cron.hourly for vpcrouter in cloud-early-config.

[GitHub] cloudstack issue #1954: CLOUDSTACK-9795: moved logrotate from cron.daily to ...

2017-02-27 Thread dmabry
Github user dmabry commented on the issue: https://github.com/apache/cloudstack/pull/1954 @rhtyd I have created PRs for 4.8 and 4.9. They are PR #1973 and PR #1974 respectively. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack issue #1974: CLOUDSTACK-9795: moved logrotate from cron.daily to ...

2017-02-27 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack/pull/1974 @dmabry what about using `git cherry-pick` to introduce the changes that were already merged into master in 4.9? Then, we can maintain the same commit hash. This would facilitate

Re: GSoC projects

2017-02-27 Thread Syed Ahmed
I've added another project to the list. CLOUDSTACK-9804 : Add Cinder as a storage driver to Cloudstack The idea is to add cinder support for managed storage. Cinder is *The* platform for doing Software defined storage. Every vendor has plugged in their device to Cinder. We can run Cinder

Re: Modern template hosting

2017-02-27 Thread Will Stevens
@rafael: Yes, I think it makes sense to support sub-paths. It will make things a lot easier to work with. The security question is an interesting one. I am not sure I would be the best person to answer that. I would say that we would want to have the MD5s hosted in the same repo as the mirror

Re: Modern template hosting

2017-02-27 Thread Will Stevens
I think we almost need a two pronged approach. 1) Get a solution in place which will enable us to document and serve templates for legacy systems. I will work on this. 2) Discuss and understand how we SHOULD be handling this problem in the future and in what release we can expect it. I think we

Re: Modern template hosting

2017-02-27 Thread Rafael Weingärtner
Agree with you. We need to support the current working flow. And then, define the first version that will start using the new approach. On Mon, Feb 27, 2017 at 5:36 PM, Will Stevens wrote: > I think we almost need a two pronged approach. > > 1) Get a solution in place

[GitHub] cloudstack issue #1962: CLOUDSTACK-9798 - Resizing root disk fails when usin...

2017-02-27 Thread mike-tutkowski
Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1962 @syed Yes, I can include you as a reviewer for the relevant PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

Re: Modern template hosting

2017-02-27 Thread Rafael Weingärtner
Will, I think we could support different path structures. This can facilitate different deployment of mirrors based on the structure the host has. Could I add something else to the discussion? Have we discussed the security impacts of setting up this mirrors approach? I mean, if any of the

Re: Modern template hosting

2017-02-27 Thread Chiradeep Vittal
Hashes are checked (md5 IIRC) today. But given the issues, I think the project should steer away from hosting templates except the systemvm template. On Mon, Feb 27, 2017 at 1:31 PM, Rafael Weingärtner < rafaelweingart...@gmail.com> wrote: > Will, I think we could support different path

[GitHub] cloudstack issue #1973: CLOUDSTACK-9795: moved logrotate from cron.daily to ...

2017-02-27 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack/pull/1973 @dmabry as I posted on the other PR, I only suggested `git cherry-pick` because I thought it would preserve the commit hash. It was a misunderstanding from me. The git hash is

  1   2   >