[GitHub] [cloudstack-primate] andrijapanicsb merged pull request #609: Fixes for vapps

2020-09-07 Thread GitBox
andrijapanicsb merged pull request #609: URL: https://github.com/apache/cloudstack-primate/pull/609 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [cloudstack-primate] andrijapanicsb commented on pull request #667: vApps: Send configuration ID

2020-09-07 Thread GitBox
andrijapanicsb commented on pull request #667: URL: https://github.com/apache/cloudstack-primate/pull/667#issuecomment-688089025 testing in master. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack-primate] andrijapanicsb merged pull request #667: vApps: Send configuration ID

2020-09-07 Thread GitBox
andrijapanicsb merged pull request #667: URL: https://github.com/apache/cloudstack-primate/pull/667 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [cloudstack-primate] andrijapanicsb commented on pull request #667: vApps: Send configuration ID

2020-09-07 Thread GitBox
andrijapanicsb commented on pull request #667: URL: https://github.com/apache/cloudstack-primate/pull/667#issuecomment-688093090 @nvazquez can you explain (in case I need to understand) what does this one do? thx This is an

[GitHub] [cloudstack-primate] rhtyd merged pull request #663: missing tooltips

2020-09-07 Thread GitBox
rhtyd merged pull request #663: URL: https://github.com/apache/cloudstack-primate/pull/663 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack-primate] rhtyd commented on pull request #665: Adding events for async job completion

2020-09-07 Thread GitBox
rhtyd commented on pull request #665: URL: https://github.com/apache/cloudstack-primate/pull/665#issuecomment-688157263 LGTM, I need to test it before merging though This is an automated message from the Apache Git Service.

[GitHub] [cloudstack-primate] rhtyd commented on pull request #666: Deployvm improvements

2020-09-07 Thread GitBox
rhtyd commented on pull request #666: URL: https://github.com/apache/cloudstack-primate/pull/666#issuecomment-688156775 @utchoang can you review and test this? Thanks This is an automated message from the Apache Git Service

[GitHub] [cloudstack-primate] rhtyd commented on pull request #662: Refresh data every 30 seconds

2020-09-07 Thread GitBox
rhtyd commented on pull request #662: URL: https://github.com/apache/cloudstack-primate/pull/662#issuecomment-688157910 @davidjumani if we've https://github.com/apache/cloudstack-primate/pull/665 can we close this? This is

[GitHub] [cloudstack-primate] rhtyd commented on pull request #664: deployvm: Showing additoinal fields in infocard

2020-09-07 Thread GitBox
rhtyd commented on pull request #664: URL: https://github.com/apache/cloudstack-primate/pull/664#issuecomment-688157651 @davidjumani I think we did not include those details to limit the height of the infocard - check on smaller screen if we scroll it well? @utchoang can you review and

[GitHub] [cloudstack-primate] rhtyd commented on pull request #658: Fixes reload of page on session expiry

2020-09-07 Thread GitBox
rhtyd commented on pull request #658: URL: https://github.com/apache/cloudstack-primate/pull/658#issuecomment-688158054 @Pearl1594 cc @davidjumani - is this ready for review/testing? This is an automated message from the Apa

[GitHub] [cloudstack-primate] rhtyd commented on pull request #657: vm wizard: add MAC Address validator

2020-09-07 Thread GitBox
rhtyd commented on pull request #657: URL: https://github.com/apache/cloudstack-primate/pull/657#issuecomment-688158205 LGTM @davidjumani can you review and test this? This is an automated message from the Apache Git Ser

[GitHub] [cloudstack-primate] rhtyd commented on pull request #649: Filter vms based on zones for attaching volumes

2020-09-07 Thread GitBox
rhtyd commented on pull request #649: URL: https://github.com/apache/cloudstack-primate/pull/649#issuecomment-688158597 @davidjumani @Pearl1594 - can you advise if this works/break for a project view, thnx This is a

[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #649: Filter vms based on zones for attaching volumes

2020-09-07 Thread GitBox
Pearl1594 commented on pull request #649: URL: https://github.com/apache/cloudstack-primate/pull/649#issuecomment-688159561 @rhtyd it works now for project view too This is an automated message from the Apache Git Service. T

[GitHub] [cloudstack-primate] davidjumani commented on pull request #664: deployvm: Showing additoinal fields in infocard

2020-09-07 Thread GitBox
davidjumani commented on pull request #664: URL: https://github.com/apache/cloudstack-primate/pull/664#issuecomment-688166831 @rhtyd The user can scroll on the Infocard. The reason I added this was so that the user can see the host & compute resources allocated on the side rather than scr

[GitHub] [cloudstack-primate] davidjumani commented on pull request #662: Refresh data every 30 seconds

2020-09-07 Thread GitBox
davidjumani commented on pull request #662: URL: https://github.com/apache/cloudstack-primate/pull/662#issuecomment-688168438 @rhtyd I prefer having this rather than #665 since that is for a specific case (We can use parts of that such as the event when an async job has been completed to

[GitHub] [cloudstack-primate] utchoang commented on a change in pull request #664: deployvm: Showing additoinal fields in infocard

2020-09-07 Thread GitBox
utchoang commented on a change in pull request #664: URL: https://github.com/apache/cloudstack-primate/pull/664#discussion_r484284975 ## File path: src/components/view/InfoCard.vue ## @@ -280,6 +280,19 @@ + + Network(s) Revi

[GitHub] [cloudstack-primate] davidjumani commented on pull request #664: deployvm: Showing additoinal fields in infocard

2020-09-07 Thread GitBox
davidjumani commented on pull request #664: URL: https://github.com/apache/cloudstack-primate/pull/664#issuecomment-688190562 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #664: deployvm: Showing additoinal fields in infocard

2020-09-07 Thread GitBox
blueorangutan commented on pull request #664: URL: https://github.com/apache/cloudstack-primate/pull/664#issuecomment-688191304 @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. -

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #664: deployvm: Showing additoinal fields in infocard

2020-09-07 Thread GitBox
blueorangutan commented on pull request #664: URL: https://github.com/apache/cloudstack-primate/pull/664#issuecomment-688196818 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/664 (JID-3

[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #658: Fixes reload of page on session expiry

2020-09-07 Thread GitBox
Pearl1594 commented on pull request #658: URL: https://github.com/apache/cloudstack-primate/pull/658#issuecomment-688215588 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [cloudstack-primate] andrijapanicsb opened a new issue #668: [FEATURE] Disable values starting with a space

2020-09-07 Thread GitBox
andrijapanicsb opened a new issue #668: URL: https://github.com/apache/cloudstack-primate/issues/668 ![image](https://user-images.githubusercontent.com/45762285/92383657-08a42500-f10f-11ea-88b9-131ec74af753.png) Copying the global setting value (or some other value from UI), adds

[GitHub] [cloudstack-primate] andrijapanicsb opened a new issue #669: [BUG] VM Deployment wizard not listing existing "Instance Groups"

2020-09-07 Thread GitBox
andrijapanicsb opened a new issue #669: URL: https://github.com/apache/cloudstack-primate/issues/669 Perhaps for discussion... We can create Instance Groups (a dedicated menu in Priamte, while missing in old UI) = but it seems existing groups are not listed (to be able to select som

[GitHub] [cloudstack-primate] shwstppr commented on issue #668: [FEATURE] Disable values starting with a space

2020-09-07 Thread GitBox
shwstppr commented on issue #668: URL: https://github.com/apache/cloudstack-primate/issues/668#issuecomment-688273991 @rhtyd @davidjumani can we have textinput to trim entered text while submitting the form? This is an auto

[GitHub] [cloudstack-primate] andrijapanicsb opened a new issue #670: [BUG] Sensitive vcenter info should be hidden from the "user" role

2020-09-07 Thread GitBox
andrijapanicsb opened a new issue #670: URL: https://github.com/apache/cloudstack-primate/issues/670 had volume, deleted it withOUT expinging it, recovered it, tried to attach it again - and got the error (could reproduce it this way twice) - beside being ACS bug, we should not expose vCen

[GitHub] [cloudstack-primate] andrijapanicsb opened a new issue #671: [BUG] Refresh list of systemVMs if some are starting/stopping/destroying

2020-09-07 Thread GitBox
andrijapanicsb opened a new issue #671: URL: https://github.com/apache/cloudstack-primate/issues/671 ![image](https://user-images.githubusercontent.com/45762285/92391082-5411-f11c-11ea-8d10-2ad2ba417407.png) there are circles going around the blue buttons, but in reality no API c

[GitHub] [cloudstack-primate] utchoang commented on issue #668: [FEATURE] Disable values starting with a space

2020-09-07 Thread GitBox
utchoang commented on issue #668: URL: https://github.com/apache/cloudstack-primate/issues/668#issuecomment-688590543 @rhtyd I think we need to trim text input after entered? This is an automated message from the Apache Git

[GitHub] [cloudstack-primate] davidjumani commented on issue #671: [BUG] Refresh list of systemVMs if some are starting/stopping/destroying

2020-09-07 Thread GitBox
davidjumani commented on issue #671: URL: https://github.com/apache/cloudstack-primate/issues/671#issuecomment-688618385 Can be fixed by tweaking https://github.com/apache/cloudstack-primate/pull/662 This is an automated me

[GitHub] [cloudstack-primate] davidjumani commented on issue #670: [BUG] Sensitive vcenter info should be hidden from the "user" role

2020-09-07 Thread GitBox
davidjumani commented on issue #670: URL: https://github.com/apache/cloudstack-primate/issues/670#issuecomment-688618766 @andrijapanicsb Primate just displays the error thrown by the backend. This will require a backend fix

[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #657: vm wizard: add MAC Address validator

2020-09-07 Thread GitBox
davidjumani commented on a change in pull request #657: URL: https://github.com/apache/cloudstack-primate/pull/657#discussion_r484653718 ## File path: src/views/compute/wizard/NetworkConfiguration.vue ## @@ -26,16 +26,40 @@ :scroll="{ y: 225 }" > - + +

[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #657: vm wizard: add MAC Address validator

2020-09-07 Thread GitBox
davidjumani commented on a change in pull request #657: URL: https://github.com/apache/cloudstack-primate/pull/657#discussion_r484653718 ## File path: src/views/compute/wizard/NetworkConfiguration.vue ## @@ -26,16 +26,40 @@ :scroll="{ y: 225 }" > - + +

[GitHub] [cloudstack-primate] davidjumani commented on issue #668: [FEATURE] Disable values starting with a space

2020-09-07 Thread GitBox
davidjumani commented on issue #668: URL: https://github.com/apache/cloudstack-primate/issues/668#issuecomment-688624774 We can do it both ways, but it would be better to trim it during the submit, to reduce the code changes introduced

[GitHub] [cloudstack-primate] utchoang commented on a change in pull request #657: vm wizard: add MAC Address validator

2020-09-07 Thread GitBox
utchoang commented on a change in pull request #657: URL: https://github.com/apache/cloudstack-primate/pull/657#discussion_r484670978 ## File path: src/views/compute/wizard/NetworkConfiguration.vue ## @@ -26,16 +26,40 @@ :scroll="{ y: 225 }" > - + +

[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #657: vm wizard: add MAC Address validator

2020-09-07 Thread GitBox
davidjumani commented on a change in pull request #657: URL: https://github.com/apache/cloudstack-primate/pull/657#discussion_r484683859 ## File path: src/views/compute/wizard/NetworkConfiguration.vue ## @@ -26,16 +26,40 @@ :scroll="{ y: 225 }" > - + +