Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/919#issuecomment-147171622
@sarathkouk Thanks for the PR! See my comments on the code. Small issues,
and please make it PEP8 compliant. Also, add a Jira issue and be more
descriptive in
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-147174211
Hi @remibergsma , The rebase is committed. Thanks.
(The cloudstack-pull-requests jenkins project is disabled though?)
---
If your project is set up
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-147179219
@remibergsma OK done now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/919#discussion_r41707251
--- Diff: tools/marvin/marvin/config/test_data.py ---
@@ -1617,19 +1617,28 @@
"password": "password",
},
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/919#discussion_r41707263
--- Diff: test/integration/component/test_ldap.py ---
@@ -151,13 +156,18 @@ def test_02_validateldapsecuritypatch(self):
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/787#issuecomment-147172170
@anshul1886 Thanks! Would it be possible to write a Marvin test for this so
that we can include in BVT? You already documented the manual steps so that is
nice.
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/919#discussion_r41707304
--- Diff: test/integration/component/test_ldap_autoImport.py ---
@@ -0,0 +1,663 @@
+
+from marvin.cloudstackTestCase import cloudstackTestCase
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/919#discussion_r41707299
--- Diff: test/integration/component/test_ldap_autoImport.py ---
@@ -0,0 +1,663 @@
+
+from marvin.cloudstackTestCase import cloudstackTestCase
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/919#discussion_r41707306
--- Diff: test/integration/component/test_ldap_autoImport.py ---
@@ -0,0 +1,663 @@
+
+from marvin.cloudstackTestCase import cloudstackTestCase
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/919#discussion_r41707292
--- Diff: test/integration/component/test_ldap_autoImport.py ---
@@ -0,0 +1,663 @@
+
+from marvin.cloudstackTestCase import cloudstackTestCase
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/919#discussion_r41707297
--- Diff: test/integration/component/test_ldap_autoImport.py ---
@@ -0,0 +1,663 @@
+
+from marvin.cloudstackTestCase import cloudstackTestCase
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/684#issuecomment-147172068
@pritisarap12 Please squash the commits, as there are now 2 merge commits
and I cannot proceed like this. Make sure it has a single commit. Ping me if
you need
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41709296
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaBalanceCmd.java
---
@@ -0,0 +1,132 @@
+//Licensed to the Apache Software
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/919#discussion_r41707277
--- Diff: test/integration/component/test_ldap_autoImport.py ---
@@ -0,0 +1,663 @@
+
+from marvin.cloudstackTestCase import cloudstackTestCase
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/919#discussion_r41707291
--- Diff: test/integration/component/test_ldap_autoImport.py ---
@@ -0,0 +1,663 @@
+
+from marvin.cloudstackTestCase import cloudstackTestCase
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/919#discussion_r41707273
--- Diff: test/integration/component/test_ldap.py ---
@@ -21,13 +21,18 @@
#!/usr/bin/env python
from marvin.cloudstackTestCase import
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/919#discussion_r41707274
--- Diff: test/integration/component/test_ldap.py ---
@@ -21,13 +21,18 @@
#!/usr/bin/env python
from marvin.cloudstackTestCase import
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/919#discussion_r41707287
--- Diff: test/integration/component/test_ldap_autoImport.py ---
@@ -0,0 +1,663 @@
+
+from marvin.cloudstackTestCase import cloudstackTestCase
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/888#issuecomment-147171964
@svenvogel Thanks for getting back to me. As far as I know, there is no
such thing as a ShapeBlue release. They provide packages which make it easy to
install
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/919#discussion_r41707148
--- Diff: test/integration/component/test_ldap_autoImport.py ---
@@ -0,0 +1,663 @@
+
+from marvin.cloudstackTestCase import cloudstackTestCase
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-147175350
Thanks @KrisSterckx but please remove the merge commit (using `rebase -i`)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41709306
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaBalanceCmd.java
---
@@ -0,0 +1,132 @@
+//Licensed to the Apache Software
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41709319
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaCreditsCmd.java
---
@@ -0,0 +1,147 @@
+//Licensed to the Apache Software
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41709314
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaCreditsCmd.java
---
@@ -0,0 +1,147 @@
+//Licensed to the Apache Software
GitHub user resmo opened a pull request:
https://github.com/apache/cloudstack/pull/922
[4.5] CLOUDSTACK-8848: ensure power state is up to date for missing
PowerState handling
1:1 cherry-picks, see #909
You can merge this pull request into a Git repository by running:
$ git
GitHub user wilderrodrigues opened a pull request:
https://github.com/apache/cloudstack/pull/923
CLOUDSTACK-8934 - Default routes not configured for rVPC and RVR
This PR fixes the default routes for redundant VPCs and isolated networks.
New tests were introduced in order to make
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/923#issuecomment-147205805
overall code looks good, not sure if I need to test something special,
@wilderrodrigues
---
If your project is set up for it, you can reply to this email and
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/923#issuecomment-147191452
Ping @remibergsma @karuturi @DaanHoogland @miguelaferreira @bvbharat @wido
@borisroman
All, the tests were executed successfully! We still have the
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/915#issuecomment-147193430
LGTM(code review).
As @remibergsma said on pr #912 this should be included in 4.6
since it already has two reviews with Daan testing it, I am going to merge
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/923#discussion_r41711315
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -123,24 +129,29 @@ def add_rule(self, cidr):
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/915
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/915#issuecomment-147202774
Thanks @milamberspace @karuturi @bhaisaab @DaanHoogland..
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user SudharmaJain commented on the pull request:
https://github.com/apache/cloudstack/pull/883#issuecomment-147233273
@remibergsma @koushik-das I have made the changes and have removed
reimplementation of XenServer 6.0.2 resource. I have added changes to patch
file for
Github user SudharmaJain commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/880#discussion_r41722125
--- Diff: setup/db/db/schema-452to460.sql ---
@@ -413,3 +413,4 @@ CREATE TABLE `cloud`.`ldap_trust_map` (
UNIQUE KEY
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-147289439
@pdion891 @remibergsma we already have a jenkins systemvm build which takes
git branch as parameter.
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/873#discussion_r41721892
--- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
@@ -1736,7 +1737,10 @@ public boolean
storagePoolHasEnoughSpace(List volumes,
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/916#issuecomment-147295409
@bhaisaab Sure will check about the back-porting of the issue. Apart from
that, the previous values stored incorrectly need to be corrected in the
database. I think
37 matches
Mail list logo
