[GitHub] cloudstack pull request: Quota: consolidated lockable account chec...

2016-03-22 Thread bvbharatk
Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/1350#issuecomment-200186297 ### ACS CI BVT Run **Sumarry:** Build Number 121 Hypervisor xenserver NetworkType Advanced Passed=104 Failed=14 Skipped=4

[GitHub] cloudstack pull request: CLOUDSTACK-8958: release dedicated ip ran...

2016-03-22 Thread kishankavala
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/1357#issuecomment-200185858 @DaanHoogland Failed tests are the ones which we should be looking at. integration.smoke.test_privategw_acl.TestPrivateGwACL is the only failed test in

[GitHub] cloudstack pull request: Vmdk findbugs

2016-03-22 Thread bvbharatk
Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/1351#issuecomment-200074256 ### ACS CI BVT Run **Sumarry:** Build Number 120 Hypervisor xenserver NetworkType Advanced Passed=106 Failed=12 Skipped=4

Apache CloudStack Event in Montreal (wannabe CCCNA16)

2016-03-22 Thread Pierre-Luc Dion
CloudOps is hosting a Apache CloudStack conference event from June 1-3, 2016 with developers and users to regroup and evolve the software and its functionality. It has been a while since our wider community has gotten together to collaborate and learn, and our aim is to get everyone together over

Re: New label to be translated

2016-03-22 Thread Tutkowski, Mike
Maybe one of the people who works on the GUI more than I do can answer why we have two files for that now. We used to only have one. I think you can just put your key/value pairs in one or the other. Sent from my iPhone > On Mar 22, 2016, at 11:44 AM, Patrick Dube

Re: New label to be translated

2016-03-22 Thread Patrick Dube
Thanks for the info. I have added the message to the messages.properties file I found under /resources, then rebuilt and restarted the server and it worked . I also added the keys in both dictionary files, but why do we have 2 dictionary files? On Tue, Mar 22, 2016 at 1:25 PM, Tutkowski, Mike

[GitHub] cloudstack pull request: Changed Void Methods to void

2016-03-22 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1439#issuecomment-199926708 @rodrigo93 have you built this PR successfully? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-9317: Enable/disable static NA...

2016-03-22 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1450#discussion_r57031859 --- Diff: server/src/com/cloud/network/IpAddressManagerImpl.java --- @@ -1714,8 +1714,13 @@ public boolean applyStaticNats(List staticNats,

Re: New label to be translated

2016-03-22 Thread Tutkowski, Mike
I don't do a ton of front-end work on CloudStack, but I believe you're looking for dictionary.jsp and/or dictionary2.jsp. I think the relevant properties files for translations can be located here: client/WEB-INF/classes/resources/*.properties From:

New label to be translated

2016-03-22 Thread Patrick Dube
Hi all, I am working on something that requires a new label to be added, which should be translated. I am probably looking on the wrong folders, but where can I add the new label, and it's translations? Thanks, Patrick

[GitHub] cloudstack pull request: Refactor test_vpc_vpn, add test for multi...

2016-03-22 Thread bvbharatk
Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/1355#issuecomment-199912335 ### ACS CI BVT Run **Sumarry:** Build Number 119 Hypervisor xenserver NetworkType Advanced Passed=105 Failed=13 Skipped=4

[GitHub] cloudstack pull request: Fixed Profiler's unit tests bugs.

2016-03-22 Thread pdube
Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1445#issuecomment-199858341 Built and ran the unit tests. LGTM [INFO] Apache CloudStack Developer Tools - Checkstyle Configuration SUCCESS [ 1.106 s] [INFO] Apache CloudStack

[GitHub] cloudstack pull request: maven: Upgrade dependency versions

2016-03-22 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1397#discussion_r56989840 --- Diff: pom.xml --- @@ -65,58 +61,68 @@ 0.5 3.0 -4.11 +4.12 1.3 -1.46 -0.1.51

[GitHub] cloudstack pull request: maven: Upgrade dependency versions

2016-03-22 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1397#discussion_r56989049 --- Diff: pom.xml --- @@ -65,58 +61,68 @@ 0.5 3.0 -4.11 +4.12 1.3 -1.46 -0.1.51

[GitHub] cloudstack pull request: maven: Upgrade dependency versions

2016-03-22 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1397#discussion_r56987982 --- Diff: pom.xml --- @@ -65,58 +61,68 @@ 0.5 3.0 -4.11 +4.12 1.3 -1.46 -0.1.51

[GitHub] cloudstack pull request: maven: Upgrade dependency versions

2016-03-22 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1397#discussion_r56978327 --- Diff: pom.xml --- @@ -65,58 +61,68 @@ 0.5 3.0 -4.11 +4.12 1.3 -1.46 -0.1.51

[GitHub] cloudstack pull request: CLOUDSTACK-9285 for 4.7.x

2016-03-22 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1430#issuecomment-199787555 @swill dear RM, can we merge this in 4.7 and merge forward --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-9285 for 4.7.x

2016-03-22 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1430#issuecomment-199787161 LGTM based on field experience and code inspection --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-9285 for 4.7.x

2016-03-22 Thread kiwiflyer
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1430#issuecomment-199787118 Test log for reconnect scenerio: Agent throws an exception that can never be recovered from when the agent attempts to reconnect and is sent a RST. This

[GitHub] cloudstack pull request: maven: Upgrade dependency versions

2016-03-22 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1397#issuecomment-199781638 @bhaisaab I see you upgraded gson. Last time i tried that the integration tests started failing massively. I wasted a couple of day back then. did you verify

Re: [GitHub] cloudstack pull request: CLOUDSTACK-8958: release dedicated ip ran...

2016-03-22 Thread Daan Hoogland
Bharat et al, >From this report, I find it difficult to get a feel for the quality of the pr. Clearly some of the failures are not related to this PR but are some related? Can you give some guidance as to how to read the report? Biligual auto correct use. Read at your own risico Op 22 mrt.

[GitHub] cloudstack pull request: maven: Upgrade dependency versions

2016-03-22 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1397#issuecomment-199775804 @swill rebased against latest master /cc @DaanHoogland --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-8958: release dedicated ip ran...

2016-03-22 Thread bvbharatk
Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/1357#issuecomment-199767590 ### ACS CI BVT Run **Sumarry:** Build Number 118 Hypervisor xenserver NetworkType Advanced Passed=105 Failed=13 Skipped=4

[GitHub] cloudstack pull request: speedup iptables setup

2016-03-22 Thread kollyma
Github user kollyma commented on the pull request: https://github.com/apache/cloudstack/pull/1449#issuecomment-199709347 The third time is the charm,all checks have passed now! the first time Jenkins failed and strangely enough the second time Travis failed. --- If your project is