[GitHub] cloudstack pull request: Quota: consolidated lockable account chec...

[bvbharatk]

Github user bvbharatk commented on the pull request:

https://github.com/apache/cloudstack/pull/1350#issuecomment-200186297
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 121
 Hypervisor xenserver
 NetworkType Advanced
 Passed=104
 Failed=14
 Skipped=4

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**
* :setup Failed

* integration.smoke.test_privategw_acl.TestPrivateGwACL

 * test_01_vpc_privategw_acl Failed


**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_deploy_vgpu_enabled_vm
test_06_copy_template
test_06_copy_iso

**Passed test suits:**
integration.smoke.test_deploy_vm_with_userdata.TestDeployVmWithUserData

integration.smoke.test_affinity_groups_projects.TestDeployVmWithAffinityGroup
integration.smoke.test_portable_publicip.TestPortablePublicIPAcquire
integration.smoke.test_over_provisioning.TestUpdateOverProvision
integration.smoke.test_global_settings.TestUpdateConfigWithScope
integration.smoke.test_scale_vm.TestScaleVm
integration.smoke.test_service_offerings.TestCreateServiceOffering
integration.smoke.test_loadbalance.TestLoadBalance
integration.smoke.test_routers.TestRouterServices
integration.smoke.test_reset_vm_on_reboot.TestResetVmOnReboot
integration.smoke.test_snapshots.TestSnapshotRootDisk

integration.smoke.test_deploy_vms_with_varied_deploymentplanners.TestDeployVmWithVariedPlanners
integration.smoke.test_network.TestDeleteAccount
integration.smoke.test_non_contigiousvlan.TestUpdatePhysicalNetwork
integration.smoke.test_deploy_vm_iso.TestDeployVMFromISO
integration.smoke.test_public_ip_range.TestDedicatePublicIPRange
integration.smoke.test_multipleips_per_nic.TestDeployVM
integration.smoke.test_regions.TestRegions
integration.smoke.test_affinity_groups.TestDeployVmWithAffinityGroup
integration.smoke.test_network_acl.TestNetworkACL
integration.smoke.test_pvlan.TestPVLAN
integration.smoke.test_volumes.TestCreateVolume
integration.smoke.test_ssvm.TestSSVMs
integration.smoke.test_nic.TestNic
integration.smoke.test_deploy_vm_root_resize.TestDeployVM
integration.smoke.test_resource_detail.TestResourceDetail
integration.smoke.test_secondary_storage.TestSecStorageServices
integration.smoke.test_vm_life_cycle.TestDeployVM
integration.smoke.test_disk_offerings.TestCreateDiskOffering


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8958: release dedicated ip ran...

[kishankavala]

Github user kishankavala commented on the pull request:

https://github.com/apache/cloudstack/pull/1357#issuecomment-200185858
  
@DaanHoogland 
Failed tests are the ones which we should be looking at. 
integration.smoke.test_privategw_acl.TestPrivateGwACL is the only failed test 
in this case. 
Manual run of this particular test will help in assessing the quality of 
this PR.
@bvbharatk please correct me,  if my understanding is not correct.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Vmdk findbugs

[bvbharatk]

Github user bvbharatk commented on the pull request:

https://github.com/apache/cloudstack/pull/1351#issuecomment-200074256
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 120
 Hypervisor xenserver
 NetworkType Advanced
 Passed=106
 Failed=12
 Skipped=4

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**

**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_deploy_vgpu_enabled_vm
test_06_copy_template
test_06_copy_iso

**Passed test suits:**
integration.smoke.test_deploy_vm_with_userdata.TestDeployVmWithUserData

integration.smoke.test_affinity_groups_projects.TestDeployVmWithAffinityGroup
integration.smoke.test_portable_publicip.TestPortablePublicIPAcquire
integration.smoke.test_over_provisioning.TestUpdateOverProvision
integration.smoke.test_global_settings.TestUpdateConfigWithScope
integration.smoke.test_guest_vlan_range.TestDedicateGuestVlanRange
integration.smoke.test_scale_vm.TestScaleVm
integration.smoke.test_service_offerings.TestCreateServiceOffering
integration.smoke.test_loadbalance.TestLoadBalance
integration.smoke.test_routers.TestRouterServices
integration.smoke.test_reset_vm_on_reboot.TestResetVmOnReboot
integration.smoke.test_snapshots.TestSnapshotRootDisk

integration.smoke.test_deploy_vms_with_varied_deploymentplanners.TestDeployVmWithVariedPlanners
integration.smoke.test_network.TestDeleteAccount
integration.smoke.test_non_contigiousvlan.TestUpdatePhysicalNetwork
integration.smoke.test_deploy_vm_iso.TestDeployVMFromISO
integration.smoke.test_public_ip_range.TestDedicatePublicIPRange
integration.smoke.test_multipleips_per_nic.TestDeployVM
integration.smoke.test_regions.TestRegions
integration.smoke.test_affinity_groups.TestDeployVmWithAffinityGroup
integration.smoke.test_network_acl.TestNetworkACL
integration.smoke.test_pvlan.TestPVLAN
integration.smoke.test_volumes.TestCreateVolume
integration.smoke.test_ssvm.TestSSVMs
integration.smoke.test_nic.TestNic
integration.smoke.test_deploy_vm_root_resize.TestDeployVM
integration.smoke.test_resource_detail.TestResourceDetail
integration.smoke.test_secondary_storage.TestSecStorageServices
integration.smoke.test_vm_life_cycle.TestDeployVM
integration.smoke.test_disk_offerings.TestCreateDiskOffering


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Apache CloudStack Event in Montreal (wannabe CCCNA16)

[Pierre-Luc Dion]

CloudOps is hosting a Apache CloudStack conference event from June
1-3, 2016 with
developers and users to regroup and evolve the software and its
functionality. It has been a while since our wider community has gotten
together to collaborate and learn, and our aim is to get everyone together
over a few days in Montreal. Part talks, part workshops, this event will
present a great opportunity for attendees and sponsors alike.



One thing that would be really helpful is to have a hackathon focus on
Continuous Integration Tests and solve questions about GitHub pull requests.

If you are interested in presenting at the event, please submit your ideas
here [1]. Cut off date for talk submissions is Friday, May 6th for now.



Our proposed schedule is as follows. Feel free to add your comments if
anything should be changed. It’s our goal to make this event as
collaborative as possible:



Wednesday, June 1st:

  - afternoon hackathon

  - happy hour

Thursday, June 2nd:

  - presentation sessions

Friday, June 3rd:

  - round tables sessions

  -  hackathon



Please be in touch should you require any additional information. We look
forward to seeing you in Montreal!



[1] https://goo.gl/r5Wmjk



Pierre-Luc

Re: New label to be translated

[Tutkowski, Mike]

Maybe one of the people who works on the GUI more than I do can answer why we 
have two files for that now. We used to only have one.

I think you can just put your key/value pairs in one or the other.

Sent from my iPhone

> On Mar 22, 2016, at 11:44 AM, Patrick Dube  wrote:
> 
> Thanks for the info. I have added the message to the messages.properties
> file I found under /resources, then rebuilt and restarted the server and it
> worked . I also added the keys in both dictionary files, but why do we have
> 2 dictionary files?
> 
> On Tue, Mar 22, 2016 at 1:25 PM, Tutkowski, Mike 
> wrote:
> 
>> I don't do a ton of front-end work on CloudStack, but I believe you're
>> looking for dictionary.jsp and/or dictionary2.jsp.
>> 
>> I think the relevant properties files for translations can be located here:
>> 
>> client/WEB-INF/classes/resources/*.properties
>> 
>> From: Patrick Dube 
>> Sent: Tuesday, March 22, 2016 11:19 AM
>> To: dev@cloudstack.apache.org
>> Subject: New label to be translated
>> 
>> Hi all,
>> 
>> I am working on something that requires a new label to be added, which
>> should be translated. I am probably looking on the wrong folders, but where
>> can I add the new label, and it's translations?
>> 
>> Thanks,
>> 
>> Patrick
>> 

Re: New label to be translated

[Patrick Dube]

Thanks for the info. I have added the message to the messages.properties
file I found under /resources, then rebuilt and restarted the server and it
worked . I also added the keys in both dictionary files, but why do we have
2 dictionary files?

On Tue, Mar 22, 2016 at 1:25 PM, Tutkowski, Mike 
wrote:

> I don't do a ton of front-end work on CloudStack, but I believe you're
> looking for dictionary.jsp and/or dictionary2.jsp.
>
> I think the relevant properties files for translations can be located here:
>
> client/WEB-INF/classes/resources/*.properties
> 
> From: Patrick Dube 
> Sent: Tuesday, March 22, 2016 11:19 AM
> To: dev@cloudstack.apache.org
> Subject: New label to be translated
>
> Hi all,
>
> I am working on something that requires a new label to be added, which
> should be translated. I am probably looking on the wrong folders, but where
> can I add the new label, and it's translations?
>
> Thanks,
>
> Patrick
>

[GitHub] cloudstack pull request: Changed Void Methods to void

[rafaelweingartner]

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1439#issuecomment-199926708
  
@rodrigo93 have you built this PR successfully?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9317: Enable/disable static NA...

[rafaelweingartner]

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1450#discussion_r57031859
  
--- Diff: server/src/com/cloud/network/IpAddressManagerImpl.java ---
@@ -1714,8 +1714,13 @@ public boolean applyStaticNats(List staticNats, boolean con
 return true;
 }
 
-// get the list of public ip's owned by the network
-List userIps = 
_ipAddressDao.listByAssociatedNetwork(network.getId(), null);
+// get the list of public ip's that need to be applied for the 
static NAT. manipulating only these
+// ips prevents concurrency issues when disabling static nat at 
the same time.
+List userIps = new ArrayList<>();
--- End diff --

Hi @ProjectMoon, what about creating a method that returns the userIps 
list. This new method would contain lines 1719-1722. Then, you would be able to 
write a unit test and add lines 1717-1718 as its java documentation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: New label to be translated

[Tutkowski, Mike]

I don't do a ton of front-end work on CloudStack, but I believe you're looking 
for dictionary.jsp and/or dictionary2.jsp.

I think the relevant properties files for translations can be located here:

client/WEB-INF/classes/resources/*.properties

From: Patrick Dube 
Sent: Tuesday, March 22, 2016 11:19 AM
To: dev@cloudstack.apache.org
Subject: New label to be translated

Hi all,

I am working on something that requires a new label to be added, which
should be translated. I am probably looking on the wrong folders, but where
can I add the new label, and it's translations?

Thanks,

Patrick

New label to be translated

[Patrick Dube]

Hi all,

I am working on something that requires a new label to be added, which
should be translated. I am probably looking on the wrong folders, but where
can I add the new label, and it's translations?

Thanks,

Patrick

[GitHub] cloudstack pull request: Refactor test_vpc_vpn, add test for multi...

[bvbharatk]

Github user bvbharatk commented on the pull request:

https://github.com/apache/cloudstack/pull/1355#issuecomment-199912335
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 119
 Hypervisor xenserver
 NetworkType Advanced
 Passed=105
 Failed=13
 Skipped=4

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**

**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_deploy_vgpu_enabled_vm
test_06_copy_template
test_06_copy_iso

**Passed test suits:**
integration.smoke.test_deploy_vm_with_userdata.TestDeployVmWithUserData

integration.smoke.test_affinity_groups_projects.TestDeployVmWithAffinityGroup
integration.smoke.test_portable_publicip.TestPortablePublicIPAcquire
integration.smoke.test_over_provisioning.TestUpdateOverProvision
integration.smoke.test_global_settings.TestUpdateConfigWithScope
integration.smoke.test_scale_vm.TestScaleVm
integration.smoke.test_service_offerings.TestCreateServiceOffering
integration.smoke.test_loadbalance.TestLoadBalance
integration.smoke.test_routers.TestRouterServices
integration.smoke.test_reset_vm_on_reboot.TestResetVmOnReboot
integration.smoke.test_snapshots.TestSnapshotRootDisk

integration.smoke.test_deploy_vms_with_varied_deploymentplanners.TestDeployVmWithVariedPlanners
integration.smoke.test_network.TestDeleteAccount
integration.smoke.test_non_contigiousvlan.TestUpdatePhysicalNetwork
integration.smoke.test_deploy_vm_iso.TestDeployVMFromISO
integration.smoke.test_public_ip_range.TestDedicatePublicIPRange
integration.smoke.test_multipleips_per_nic.TestDeployVM
integration.smoke.test_regions.TestRegions
integration.smoke.test_affinity_groups.TestDeployVmWithAffinityGroup
integration.smoke.test_network_acl.TestNetworkACL
integration.smoke.test_pvlan.TestPVLAN
integration.smoke.test_volumes.TestCreateVolume
integration.smoke.test_ssvm.TestSSVMs
integration.smoke.test_nic.TestNic
integration.smoke.test_deploy_vm_root_resize.TestDeployVM
integration.smoke.test_resource_detail.TestResourceDetail
integration.smoke.test_secondary_storage.TestSecStorageServices
integration.smoke.test_vm_life_cycle.TestDeployVM
integration.smoke.test_disk_offerings.TestCreateDiskOffering


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fixed Profiler's unit tests bugs.

[pdube]

Github user pdube commented on the pull request:

https://github.com/apache/cloudstack/pull/1445#issuecomment-199858341
  
Built and ran the unit tests. LGTM

[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  
SUCCESS [  1.106 s]
[INFO] Apache CloudStack . SUCCESS [  0.975 
s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [  1.918 
s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [  1.485 
s]
[INFO] Apache CloudStack Utils ... SUCCESS [ 11.555 
s]
[INFO] Apache CloudStack Framework ... SUCCESS [  0.047 
s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [  1.561 
s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [  1.210 
s]
[INFO] Apache CloudStack API . SUCCESS [ 12.870 
s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [  0.644 
s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [  0.640 
s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [  0.030 
s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [  3.529 
s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [  0.499 
s]
[INFO] Apache CloudStack Core  SUCCESS [  4.886 
s]
[INFO] Apache CloudStack Agents .. SUCCESS [  1.546 
s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [  1.026 
s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [  0.332 
s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [ 10.903 
s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [  2.049 
s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [  
0.551 s]
[INFO] Apache CloudStack Server .. SUCCESS [ 25.862 
s]
[INFO] Apache CloudStack Framework - Quota ... SUCCESS [  1.987 
s]
[INFO] Apache CloudStack Usage Server  SUCCESS [  1.694 
s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS [  
0.648 s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [  0.016 
s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [  0.125 
s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [  0.678 
s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [  5.129 
s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [  0.588 
s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [  0.472 
s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [  
0.592 s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [  0.545 
s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [  
3.074 s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [  0.567 
s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [  0.596 
s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [  0.266 
s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [  3.276 
s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[  0.485 s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  
SUCCESS [  0.574 s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [  0.483 
s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [  1.377 
s]
[INFO] Apache CloudStack Plugin - ACL Static Role Based .. SUCCESS [  0.497 
s]
[INFO] Apache CloudStack Plugin - Host Anti-Affinity Processor  SUCCESS [  
0.428 s]
[INFO] Apache CloudStack Plugin - Explicit Dedication Processor  SUCCESS [  
0.404 s]
[INFO] Apache CloudStack Plugin - User Concentrated Pod Deployment Planner  
SUCCESS [  0.429 s]
[INFO] Apache CloudStack Plugin - User Dispersing Deployment Planner  
SUCCESS [  0.424 s]
[INFO] Apache CloudStack Plugin - Implicit Dedication Planner  SUCCESS [  
2.820 s]
[INFO] Apache CloudStack Plugin - Skip Heurestics Planner  SUCCESS [  0.635 
s]
[INFO] Apache CloudStack Plugin - Host Allocator Random .. SUCCESS [  0.483 
s]
[INFO] Apache CloudStack Plugin - Dedicated Resources  SUCCESS [  2.748 
s]
[INFO] Apache CloudStack Plugin - Hypervisor OracleVM  SUCCESS [  0.560 
s]
[INFO] Apache CloudStack Plugin - Open vSwitch ... SUCCESS [  0.566 
s]
[INFO] Apache CloudStack Plugin - Hypervisor XenServer ... SUCCESS [ 21.803 
s]
[INFO] Apache CloudStack Plugin - Hypervisor KVM . SUCCESS [  3.487 
s]
[INFO] Apache CloudStack Plugin - RabbitMQ Event Bus . SUCCESS [  0.526 
s]
[INFO] Apache CloudStack Plugin - 

[GitHub] cloudstack pull request: maven: Upgrade dependency versions

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1397#discussion_r56989840
  
--- Diff: pom.xml ---
@@ -65,58 +61,68 @@
 0.5
 3.0
 
-4.11
+4.12
 1.3
-1.46
-0.1.51
-2.1.0
+1.54
+0.1.53
+2.1.1
 1.9.2
-1.0.0-build217
-2.6.9
+1.0.0-build220
+2.6.11
 1.7.2
--- End diff --

yes, i should have caught the 'except' but I also could have sworn seeing a 
'2' near 'gson' I think I confused it with the saml version.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: maven: Upgrade dependency versions

[bhaisaab]

Github user bhaisaab commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1397#discussion_r56989049
  
--- Diff: pom.xml ---
@@ -65,58 +61,68 @@
 0.5
 3.0
 
-4.11
+4.12
 1.3
-1.46
-0.1.51
-2.1.0
+1.54
+0.1.53
+2.1.1
 1.9.2
-1.0.0-build217
-2.6.9
+1.0.0-build220
+2.6.11
 1.7.2
--- End diff --

@DaanHoogland :) 
Perhaps my PR message confused you? Here I mean to say that we're not 
updating following:

> Updated most dependencies to latest minor releases, except:
> 
> Gson 2.x
> Major spring framework version
> Servlet version
> Embedded jetty version
> Mockito version (beta)
> Mysql lib minor version upgrade (breaks mysql-ha plugin)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: maven: Upgrade dependency versions

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1397#discussion_r56987982
  
--- Diff: pom.xml ---
@@ -65,58 +61,68 @@
 0.5
 3.0
 
-4.11
+4.12
 1.3
-1.46
-0.1.51
-2.1.0
+1.54
+0.1.53
+2.1.1
 1.9.2
-1.0.0-build217
-2.6.9
+1.0.0-build220
+2.6.11
 1.7.2
--- End diff --

I am getting blind. Don't mind me for a while. I'm useless


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: maven: Upgrade dependency versions

[bhaisaab]

Github user bhaisaab commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1397#discussion_r56978327
  
--- Diff: pom.xml ---
@@ -65,58 +61,68 @@
 0.5
 3.0
 
-4.11
+4.12
 1.3
-1.46
-0.1.51
-2.1.0
+1.54
+0.1.53
+2.1.1
 1.9.2
-1.0.0-build217
-2.6.9
+1.0.0-build220
+2.6.11
 1.7.2
--- End diff --

@DaanHoogland see here ^^, gson version is not changed at all


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9285 for 4.7.x

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1430#issuecomment-199787555
  
@swill dear RM, can we merge this in 4.7 and merge forward


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9285 for 4.7.x

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1430#issuecomment-199787161
  
LGTM based on field experience and code inspection


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9285 for 4.7.x

[kiwiflyer]

Github user kiwiflyer commented on the pull request:

https://github.com/apache/cloudstack/pull/1430#issuecomment-199787118
  
Test log for reconnect scenerio:

Agent throws an exception that can never be recovered from when the agent 
attempts to reconnect and is sent a RST. This case occurs when a load balancer 
(haproxy) is proxying the traffic and there is no management server active to 
serve the request on the backend.

Original issue logs from agent.log:

2016-03-03 17:15:36,527 INFO utils.nio.NioClient (logid:) NioClient 
connection closed
2016-03-03 17:15:36,527 INFO cloud.agent.Agent (logid:) Reconnecting...
2016-03-03 17:15:36,527 INFO utils.nio.NioClient (logid:) Connecting to 
10.103.0.154:8250
2016-03-03 17:15:36,540 ERROR utils.nio.NioConnection (logid:) Unable to 
initialize the threads.
java.io.IOException: Connection closed with -1 on reading size.
at com.cloud.utils.nio.Link.doHandshake(Link.java:513)
at com.cloud.utils.nio.NioClient.init(NioClient.java:80)
at com.cloud.utils.nio.NioConnection.start(NioConnection.java:88)
at com.cloud.agent.Agent.reconnect(Agent.java:413)
at com.cloud.agent.Agent$ServerHandler.doTask(Agent.java:868)
at com.cloud.utils.nio.Task.call(Task.java:83)
at com.cloud.utils.nio.Task.call(Task.java:29)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
2016-03-03 17:15:36,545 INFO utils.exception.CSExceptionErrorCode (logid:) 
Could not find exception: com.cloud.utils.exception.NioConnectionException in 
error code list for exceptions
After the patch is applied:

2016-03-03 17:50:05,190 INFO utils.nio.NioClient (logid:) NioClient 
connection closed
2016-03-03 17:50:05,190 INFO cloud.agent.Agent (logid:) Reconnecting...
2016-03-03 17:50:05,190 INFO utils.nio.NioClient (logid:) Connecting to 
10.103.0.154:8250
2016-03-03 17:50:05,206 ERROR utils.nio.NioConnection (logid:) Unable to 
initialize the threads.
java.io.IOException: Connection closed with -1 on reading size.
at com.cloud.utils.nio.Link.doHandshake(Link.java:513)
at com.cloud.utils.nio.NioClient.init(NioClient.java:80)
at com.cloud.utils.nio.NioConnection.start(NioConnection.java:88)
at com.cloud.agent.Agent.reconnect(Agent.java:413)
at com.cloud.agent.Agent$ServerHandler.doTask(Agent.java:869)
at com.cloud.utils.nio.Task.call(Task.java:83)
at com.cloud.utils.nio.Task.call(Task.java:29)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
2016-03-03 17:50:05,210 INFO utils.exception.CSExceptionErrorCode (logid:) 
Could not find exception: com.cloud.utils.exception.NioConnectionException in 
error code list for exceptions
2016-03-03 17:50:05,211 INFO cloud.agent.Agent (logid:) Attempted to 
connect to the server, but received an unexpected exception, trying again...
2016-03-03 17:50:10,211 INFO cloud.agent.Agent (logid:) Reconnecting...
2016-03-03 17:50:10,211 INFO utils.nio.NioClient (logid:) Connecting to 
10.103.0.154:8250

This has been tested on 4.7.1 and master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: maven: Upgrade dependency versions

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1397#issuecomment-199781638
  
@bhaisaab I see you upgraded gson. Last time i tried that the integration 
tests started failing massively. I wasted a couple of day back then. did you 
verify this? gson is being used for internal communication of commands and has 
refactorred it's use of exclusion filters.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] cloudstack pull request: CLOUDSTACK-8958: release dedicated ip ran...

[Daan Hoogland]

Bharat et al,

>From this report,  I find it difficult to get a feel for the quality of the
pr. Clearly some of the failures are not related to this PR but are some
related? Can you give some guidance as to how to read the report?

Biligual auto correct use.  Read at your own risico
Op 22 mrt. 2016 12:23 PM schreef "bvbharatk" :

> Github user bvbharatk commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/1357#issuecomment-199767590
>
> ### ACS CI BVT Run
>  **Sumarry:**
>  Build Number 118
>  Hypervisor xenserver
>  NetworkType Advanced
>  Passed=105
>  Failed=13
>  Skipped=4
>
> **The follwing tests have known issues**
> test_03_rvpc_privategw_static_routes
> ContextSuite context=TestDeployVM>:setup
> test_01_primary_storage_iscsi
> test_04_change_offering_small
> test_07_list_default_iso
> test_04_extract_template
> test_01_test_vm_volume_snapshot
> test_04_extract_Iso
> test_02_vpc_privategw_static_routes
> test02_internallb_haproxy_stats_on_all_interfaces
> test_vpc_remote_access_vpn
> ContextSuite context=TestNiciraContoller>:setup
> test_vpc_site2site_vpn
> test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80
> test_dedicateGuestVlanRange
>
> _Link to logs Folder (search by build_no):_
> https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
>
>
> **Failed tests:**
> * integration.smoke.test_privategw_acl.TestPrivateGwACL
>
>  * test_01_vpc_privategw_acl Failing since 5 runs
>
>
> **Skipped tests:**
> test_vm_nic_adapter_vmxnet3
> test_deploy_vgpu_enabled_vm
> test_06_copy_template
> test_06_copy_iso
>
> **Passed test suits:**
> integration.smoke.test_deploy_vm_with_userdata.TestDeployVmWithUserData
>
> integration.smoke.test_affinity_groups_projects.TestDeployVmWithAffinityGroup
> integration.smoke.test_portable_publicip.TestPortablePublicIPAcquire
> integration.smoke.test_over_provisioning.TestUpdateOverProvision
> integration.smoke.test_global_settings.TestUpdateConfigWithScope
> integration.smoke.test_guest_vlan_range.TestDedicateGuestVlanRange
> integration.smoke.test_scale_vm.TestScaleVm
> integration.smoke.test_service_offerings.TestCreateServiceOffering
> integration.smoke.test_loadbalance.TestLoadBalance
> integration.smoke.test_routers.TestRouterServices
> integration.smoke.test_reset_vm_on_reboot.TestResetVmOnReboot
> integration.smoke.test_snapshots.TestSnapshotRootDisk
>
> integration.smoke.test_deploy_vms_with_varied_deploymentplanners.TestDeployVmWithVariedPlanners
> integration.smoke.test_network.TestDeleteAccount
> integration.smoke.test_non_contigiousvlan.TestUpdatePhysicalNetwork
> integration.smoke.test_deploy_vm_iso.TestDeployVMFromISO
> integration.smoke.test_public_ip_range.TestDedicatePublicIPRange
> integration.smoke.test_multipleips_per_nic.TestDeployVM
> integration.smoke.test_regions.TestRegions
> integration.smoke.test_affinity_groups.TestDeployVmWithAffinityGroup
> integration.smoke.test_network_acl.TestNetworkACL
> integration.smoke.test_pvlan.TestPVLAN
> integration.smoke.test_volumes.TestCreateVolume
> integration.smoke.test_ssvm.TestSSVMs
> integration.smoke.test_nic.TestNic
> integration.smoke.test_deploy_vm_root_resize.TestDeployVM
> integration.smoke.test_resource_detail.TestResourceDetail
> integration.smoke.test_secondary_storage.TestSecStorageServices
> integration.smoke.test_vm_life_cycle.TestDeployVM
> integration.smoke.test_disk_offerings.TestCreateDiskOffering
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

[GitHub] cloudstack pull request: maven: Upgrade dependency versions

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1397#issuecomment-199775804
  
@swill rebased against latest master /cc @DaanHoogland 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8958: release dedicated ip ran...

[bvbharatk]

Github user bvbharatk commented on the pull request:

https://github.com/apache/cloudstack/pull/1357#issuecomment-199767590
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 118
 Hypervisor xenserver
 NetworkType Advanced
 Passed=105
 Failed=13
 Skipped=4

**The follwing tests have known issues**
test_03_rvpc_privategw_static_routes
ContextSuite context=TestDeployVM>:setup
test_01_primary_storage_iscsi
test_04_change_offering_small
test_07_list_default_iso
test_04_extract_template
test_01_test_vm_volume_snapshot
test_04_extract_Iso
test_02_vpc_privategw_static_routes
test02_internallb_haproxy_stats_on_all_interfaces
test_vpc_remote_access_vpn
ContextSuite context=TestNiciraContoller>:setup
test_vpc_site2site_vpn
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80
test_dedicateGuestVlanRange

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**
* integration.smoke.test_privategw_acl.TestPrivateGwACL

 * test_01_vpc_privategw_acl Failing since 5 runs


**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_deploy_vgpu_enabled_vm
test_06_copy_template
test_06_copy_iso

**Passed test suits:**
integration.smoke.test_deploy_vm_with_userdata.TestDeployVmWithUserData

integration.smoke.test_affinity_groups_projects.TestDeployVmWithAffinityGroup
integration.smoke.test_portable_publicip.TestPortablePublicIPAcquire
integration.smoke.test_over_provisioning.TestUpdateOverProvision
integration.smoke.test_global_settings.TestUpdateConfigWithScope
integration.smoke.test_guest_vlan_range.TestDedicateGuestVlanRange
integration.smoke.test_scale_vm.TestScaleVm
integration.smoke.test_service_offerings.TestCreateServiceOffering
integration.smoke.test_loadbalance.TestLoadBalance
integration.smoke.test_routers.TestRouterServices
integration.smoke.test_reset_vm_on_reboot.TestResetVmOnReboot
integration.smoke.test_snapshots.TestSnapshotRootDisk

integration.smoke.test_deploy_vms_with_varied_deploymentplanners.TestDeployVmWithVariedPlanners
integration.smoke.test_network.TestDeleteAccount
integration.smoke.test_non_contigiousvlan.TestUpdatePhysicalNetwork
integration.smoke.test_deploy_vm_iso.TestDeployVMFromISO
integration.smoke.test_public_ip_range.TestDedicatePublicIPRange
integration.smoke.test_multipleips_per_nic.TestDeployVM
integration.smoke.test_regions.TestRegions
integration.smoke.test_affinity_groups.TestDeployVmWithAffinityGroup
integration.smoke.test_network_acl.TestNetworkACL
integration.smoke.test_pvlan.TestPVLAN
integration.smoke.test_volumes.TestCreateVolume
integration.smoke.test_ssvm.TestSSVMs
integration.smoke.test_nic.TestNic
integration.smoke.test_deploy_vm_root_resize.TestDeployVM
integration.smoke.test_resource_detail.TestResourceDetail
integration.smoke.test_secondary_storage.TestSecStorageServices
integration.smoke.test_vm_life_cycle.TestDeployVM
integration.smoke.test_disk_offerings.TestCreateDiskOffering


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: speedup iptables setup

[kollyma]

Github user kollyma commented on the pull request:

https://github.com/apache/cloudstack/pull/1449#issuecomment-199709347
  
The third time is the charm,all checks have passed now! the first time 
Jenkins failed and strangely enough the second time Travis failed. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---