Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-215310531
BTW, I built with `-T 2C`, if that is relevant to help you understand why
it failed...
---
If your project is set up for it, you can reply to this email and have
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/1371#issuecomment-215310296
+ TMP=/tmp
+ CLOUDDIR=/root/cloudstack_shapeblue
+ mkdir -p /tmp/simulator/smoke/misc
+ nosetests --with-xunit
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-215309861
Failed to build.
```
---
T E S T S
---
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/1304#issuecomment-215309683
Thanks @swill , I will fix the error and update the PR. Thanks for taking
your time and running it on your CI.
---
If your project is set up for it, you can
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/1500#issuecomment-215308516
LGTM for test code based on code review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1454#issuecomment-215303942
Sorry for the delay on this one guys. I think this one is ready now...
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-215291402
The CI results show this PR to be in pretty good shape. We have one LGTM
and lots of commentary. Can we get a summary of any concerns and get our code
reviews in?
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-215290621
### CI RESULTS
```
Tests Run: 100
Skipped: 1
Failed: 0
Errors: 0
```
**Associated Uploads**
I opened the following ticket:
https://issues.apache.org/jira/browse/CLOUDSTACK-9371
From: Tutkowski, Mike
Sent: Wednesday, April 27, 2016 7:12 PM
To: dev@cloudstack.apache.org
Subject: Re: Resizing a volume
It appears the
It appears the offending code was added here:
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;h=d6e21f74163212b198731ddf23dd48bc4c787b84
From: Tutkowski, Mike
Sent: Wednesday, April 27, 2016 5:33 PM
To:
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1455#issuecomment-215266469
I have tested this and I think we are ready. Can you please do a force
push to kick off jenkins again so we can get this PR all green? Thanks...
---
If your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1455#issuecomment-215266162
### CI RESULTS
```
Tests Run: 4
Skipped: 0
Failed: 0
Errors: 0
```
**Associated Uploads**
I see the problem.
It's in storage.js
if (jsonObj.hypervisor == "KVM" || jsonObj.hypervisor == "XenServer" ||
jsonObj.hypervisor == "VMware") {
if (jsonObj.state == "Ready" || jsonObj.state == "Allocated") {
allowedActions.push("resize");
}
Here's a pic:
http://imgur.com/2k380Yd
It's for a volume on KVM, but I see the same behavior on XenServer and VMware,
too.
I'm logged in as a regular user.
From: Tutkowski, Mike
Sent: Wednesday, April 27, 2016 4:23 PM
To:
Excellent, good job, you've made me curious. :)
--
Sent from the Delta quadrant using Borg technology!
Nux!
www.nux.ro
- Original Message -
> From: "Sebastien Goasguen"
> To: dev@cloudstack.apache.org
> Sent: Wednesday, 27 April, 2016 19:15:42
> Subject: Re: CaaS in
Hi Wido,
I'm referring to the commands.properties file, where you can set permissions
for a given API.
However, I see volumeResize has the following setting, which should enable
users to access it:
resizeVolume=15
Perhaps there's just a bug in the GUI not showing the button?
Talk to you
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1522#issuecomment-215248091
@nathanejohnson This is a nice addition that will enable easier tracing of
events as we pull them into logstash. So those out there using async job calls
should
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1230#issuecomment-215242253
Manual testing against a 4.8 hardware lab with Ceph Primary Storage.
2 volume snapshots triggered:
rbd snap ls -p rbdnjcloudhost
That is probably some misconfigurations at the Maven of the Jenkins’ VM.
That seems to be a username and password configuration to access some
cache/local repository that is under the ASF premises.
Does anyone have access to those VMs? So we could login and fix it.
I also noticed the Java 8,
I just asked the dev list the same thing. Here are two more examples #1515
and #1522:
https://builds.apache.org/job/cloudstack-pr-analysis/1057/console
https://builds.apache.org/job/cloudstack-pr-analysis/1056/console
One other thing that I noticed is that Jenkins is building with Java 8,
which
Seeing a few jobs with this result recently.
[cloudstack-pr-analysis] $
/home/jenkins/jenkins-slave/tools/hudson.tasks.Maven_MavenInstallation/maven-3.3.3/bin/mvn
clean --projects=org.apache.cloudstack:cloudstack
org.apache.rat:apache-rat-plugin:0.10:check[ERROR] Error executing
Maven.[ERROR] 1
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1515#issuecomment-215227139
I see another PR with the same error, so I doubt it is your PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1515#issuecomment-215226141
Well Jenkins just does not like us today. Can you review the error and see
if it is a valid error and try again?
---
If your project is set up for it, you can
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1304#issuecomment-215224845
Don't worry about the connectivity issues, that seems to be my environment
right now. The ERROR you do need to fix because that is a problem. Cheers...
---
If
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1304#discussion_r61333278
--- Diff: test/integration/component/test_vpc_network.py ---
@@ -2683,6 +2687,65 @@ def setUp(self):
def tearDown(self):
return
I am aware that there have been some transient issues with Jenkins, but I
am repeatedly seeing this error and I suspect this might be something
different:
Unpacking
https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.3.3/apache-maven-3.3.3-bin.zip
to
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1304#issuecomment-215221441
### CI RESULTS
```
Tests Run: 92
Skipped: 0
Failed: 4
Errors: 1
```
**Summary of the problem(s):**
```
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1408#issuecomment-215217268
@wido I tested your original PR and the current updated PR, the locking
never happened on my test env (Ubuntu x64).
I read the manpage, and found that when
Github user milamberspace commented on the pull request:
https://github.com/apache/cloudstack/pull/1515#issuecomment-215215852
@swill re-done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user nathanejohnson opened a pull request:
https://github.com/apache/cloudstack/pull/1522
Log asynchronous responses in the api log
Currently API responses for synchronous calls are logged, but asynchronous
call responses are not. This pull request makes a minor
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-215197356
Rebased against latest master, please consider this for merge
Performed final rounds of testing:
- Build/maven, unit and integration tests
- Upgrade
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1521#issuecomment-215191105
@DaanHoogland I'm not sure about others, but gradle has become most popular
and widely-support in modern java development
@jburwell agree, the discussion here is
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1348#issuecomment-215185737
Ok perfect. I will add this to my merge queue. Thanks for clarifying
guys...
---
If your project is set up for it, you can reply to this email and have your
reply
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1417#issuecomment-215184791
@nitt10prashant I have to admit, I am confused on this one. I have the
latest Marvin installed that is generated when building this PR.
```
Installing
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1521#issuecomment-215183202
+ 1 for moving away from maven. How about sbt?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1348#issuecomment-215182527
No it won't. the fix in here is valid whichever way we go.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1348#issuecomment-215179261
Thanks guys. I am fine with merging it as is, but does it make sense to
wait a bit to see what the discussion brings up in the #1521 PR? Or will it
not affect this
> On Apr 27, 2016, at 4:06 PM, Nux! wrote:
>
> Hello,
>
> Very nice, but I am somewhat surprised! I thought we were not going after
> docker/containers/etc and let others (CoreOS etc) do it?
> What has changed?
>
Nothing has changed,
The solution we developed is based on
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1521#issuecomment-215177976
@rhtyd +1 for Gradle though it would be a large undertaking. Since
Gradle's Java plugin natively supports Maven's directory structure, such a
transition would
let me reply on dev@ to avoid cross posting.
> On Apr 27, 2016, at 4:06 PM, Nux! wrote:
>
> Hello,
>
> Very nice, but I am somewhat surprised! I thought we were not going after
> docker/containers/etc and let others (CoreOS etc) do it?
> What has changed?
>
> Lucian
>
> --
>
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1521#issuecomment-215176727
@rhtyd I agree we should. At the moment we are already in an intermediate
state. Some projects were moved to maven standard (I only know utils by head
and the
This thread is primarily to work out the logistical details with the ASF
Infra team for making this move.
I thought I had members of the ASF Infra team CC'ed earlier, but that was
not the case, so I appologize if this was not on your radar until now.
I have CC'ed in both the ACS dev@ list and
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1521#issuecomment-215172757
In my experience when you are doing a lot of backporting or forward-porting
work, if a plugin/module has got its filesystem structure (for example, due to
moving to
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-215171740
@koushik-das I don't understand how adoption of this feature differs from
any other feature. A user deploys the release into a test/pilot environment
and
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1348#issuecomment-215170748
@swill yes that was a good to have suggestion; keep large string based test
data separated from test, though since this request is cosmetic in nature I'm
okay if we
> Op 27 april 2016 om 14:19 schreef Rohit Yadav :
>
>
> Hi Wido,
>
> Thanks for starting this discussion. I'm not sure exactly how to do it
> either, but I suppose we can exploit post installation step to write custom
> scripts that setup initd or systemd scripts
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-215165382
@mlsorensen
- presently, setting bitmask to 0 in commands.properties does not disable
the API but that no roles would have that API; though if an API through its
Github user remibergsma closed the pull request at:
https://github.com/apache/cloudstack/pull/1475
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user mlsorensen commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-215147096
@koushik-das -- I'd say yes, that testing is good enough. If a test can
determine that the default roles allow the expected access to the APIs then
we're good.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1520#issuecomment-215143364
Great, thanks @remibergsma. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1520#issuecomment-215143007
@swill more details here:
https://github.com/MissionCriticalCloud/cosmic-plugin-hypervisor-kvm/pull/16
---
If your project is set up for it, you can reply to
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1408#issuecomment-215138161
@rhtyd The lock does not have to be released. It is done when the script
exists. This is usually within 100ms or so.
---
If your project is set up for it, you can
There has been quite some differences between what features that
are supported on different hypervisors.
Does anyone know If the feature support matrix is up to date? In particular
I am interested in what features we do (and don't) support with KVM
Erik
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1521#issuecomment-215131396
@swil @rhtyd this is the follow up of #1348. The initial rat failure was
genuine but next files where found that are .gitignored. not sure what happened
---
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1520#issuecomment-215124694
@NuxRo can you do a force push to kick off jenkins and travis again. Also,
can you show this change fixes the behavior with a screenshot or something. I
don't
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/1521
Kvm plugin restructure
test and project restructure without functional implications
You can merge this pull request into a Git repository by running:
$ git pull
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1230#issuecomment-215122706
@kiwiflyer Thank you sir. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1444#issuecomment-215122425
I would like to get at least one LGTM in this PR. The code is basically
the same as the previous one other than the fixes to the potential NPE issues.
I think we
Perfect. That is what I was looking for. Thanks... :)
*Will STEVENS*
Lead Developer
*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_
On Wed, Apr 27, 2016 at 11:07 AM, Prashanth Manthena <
Github user dmabry commented on the pull request:
https://github.com/apache/cloudstack/pull/1500#issuecomment-215120369
OK, all checks have passed! ;) Looking for another LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1230#issuecomment-215118770
I'm building this now and I'll give it a final manual test. Then we'll do a
CI run against a hardware lab.
---
If your project is set up for it, you can reply
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1518#issuecomment-215116783
@nvazquez I believe so.
This way we can reduce a little bit of code.
---
If your project is set up for it, you can reply to this email and have your
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1518#issuecomment-215116050
Thanks @rafaelweingartner, I like the idea, I think the best way would be
leave hierarchy like this:
- Command
-- NEW CLASS
Hi all,
Thanks for your cheers, it means a lot for us.
Anshul, thanks for asking. We are very excited about the project, our plan
is to add new algorithms. Also, We foresee the need to use/add other types
of agents. All of that is going to be done as our research goes forward.
That is great that
Hi Will,
1) will run a, b, c
2) will run only b
3) will run only c
Nosetests will run all the testcases that match attribute (tags)
combination you specify in the command.
Default (no tag(s) specified): It will run all the testcases.
With regards,
Prashanth
On Wed, Apr 27, 2016 at 4:30 PM,
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1444#issuecomment-215111745
@swill, I am so sorry, I had forgotten this PR. I opened the email to help
in a review thinking that this was from someone else.
Are you sure we
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1444#issuecomment-215109078
Ran the usage tests to make sure everything is passing. Don't worry about
the snapshot issue, it is not related to this PR.
I think this PR is ready if I
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1515#issuecomment-215109976
@milamberspace and again. :P sorry...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1444#issuecomment-215108116
### CI RESULTS
```
Tests Run: 18
Skipped: 0
Failed: 0
Errors: 2
```
**Summary of the problem(s):**
```
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1500#issuecomment-215103065
@koushik-das can I get your code review on this? Thanks. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user dmabry commented on the pull request:
https://github.com/apache/cloudstack/pull/1500#issuecomment-215103808
Yea, I saw that jenkins failed pulling 4.7 branch, so I kicked it off
again. I'm going to keep an eye on travis and jenkins. There is no reason
those tests should
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1500#issuecomment-215102785
Thanks @kiwiflyer. :) I was about to ask you to re-push to kick off the
runs again and you did it as I was typing. ð
---
If your project is set up for it,
If this is about KVM and ovs vifdriver (we use NSX which uses ovs) then an
issue we recently fixed may be the same issue as you have here.
https://github.com/MissionCriticalCloud/cosmic-plugin-hypervisor-kvm/pull/14
When I find some spare time I can look into backporting it.
Regards, Remi
So I see a few different ways in which tests are defined.
For example, here are a few different attribute configurations:
a) @attr(tags=["advanced", "intervlan"])
b) @attr(tags=["advanced", "intervlan"], required_hardware="true")
c) @attr(tags=["advanced", "intervlan"],
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1500#issuecomment-215099770
Tested this patch manually on a KVM 4.8 lab. We also ran the new Marvin
unit tests successfully against the simulator, bubble instance and a hardware
lab. Works
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1414#issuecomment-215097877
@bvbharatk I am guessing you are still having some environment issues in
your CI or are these results correct? Thanks...
---
If your project is set up for it, you
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-215095216
The test that failed is one that periodically fails in my env, so I don't
think we can assume it is related to this PR.
---
If your project is set up for it, you
Hello,
Very nice, but I am somewhat surprised! I thought we were not going after
docker/containers/etc and let others (CoreOS etc) do it?
What has changed?
Lucian
--
Sent from the Delta quadrant using Borg technology!
Nux!
www.nux.ro
- Original Message -
> From: "Sebastien Goasguen"
Rafael
This is very exciting to see, congrats in getting your project out of the gate
Kind Regards
Giles
Regards,
Giles Sirett
giles.sir...@shapeblue.com
www.shapeblue.com
53 Chandos Place, Covent Garden, London WC2N 4HSUK
@shapeblue
-Original Message-
From: Rafael Weingärtner
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1444#issuecomment-215094461
The issues that we see here are environment issues that sometimes show up.
They are not related to this PR.
I am running another set of usage specific
Simon Weller (who added a comment on the ticket itself) said the following
: "According to the 4.8 docs, OVS and KVM VPC doesn't currently work. I'm
not aware of any work that has changed this in master.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1444#issuecomment-215090037
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 3
Errors: 0
```
**Summary of the problem(s):**
```
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-215089828
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 1
Errors: 0
```
**Summary of the problem(s):**
```
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1348#issuecomment-215087562
That's correct. I am doing the restructure now based on this PR's source
branch and will make a new PR shortly. If it gets tested before this one I will
close
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1500#issuecomment-215087358
Thank you for the results. I think that is all we need from a CI
perspective. Jenkins and Travis have been kicked off again as well, so that is
good. Hopefully we
Github user dmabry commented on the pull request:
https://github.com/apache/cloudstack/pull/1500#issuecomment-215084188
[test_volumes_NV6XFO.zip](https://github.com/apache/cloudstack/files/238694/test_volumes_NV6XFO.zip)
Here is the zip file containing the test results.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1348#issuecomment-215084100
So if I am following this correctly, we are all set. @rhtyd requested a
change to move the test data to an overridable location, but did not require
this change for
Github user dmabry commented on the pull request:
https://github.com/apache/cloudstack/pull/1500#issuecomment-215083560
Ok, I have run this through my lab again and specifically ran the
test_volumes.py file. All tests passed. See below. I have also attached the
results dir as a
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1510#issuecomment-215081538
Thank you gentlemen. I think this one is ready now. ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1280#issuecomment-215080256
Looking for one more LGTM for this one... Thx...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1356#issuecomment-215079521
I am not seeing the issue on master. It appears that your issue may be
related to the Host(9) being unreachable. I would validate the connectivity is
all working
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1517#issuecomment-215077801
Thanks for the validation discussion. I think this is ready...
---
If your project is set up for it, you can reply to this email and have your
reply appear on
It looks like your host(9) is unreachable. Can you verify that the
connectivity is all setup correctly?
*Will STEVENS*
Lead Developer
*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_
On Wed, Apr 27, 2016 at 8:31 AM,
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1348#issuecomment-215075290
@rhtyd as a part of loading from resource I am restructuring the project
layout to adhere to maven standards. Doing so it seems not appropriate to
include
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1280#issuecomment-215070344
LGTM. Verified on a simulator setup. Also the test failures from CI run are
unrelated to this change.
---
If your project is set up for it, you can reply to
Hi All,
I am seeing the following issue on master:
https://issues.apache.org/jira/browse/CLOUDSTACK-9370.
Is anyone else seeing this issue on master ?
Let me know, if you need more information from my side.
With regards,
Prashanth
Hi Wido,
Thanks for starting this discussion. I'm not sure exactly how to do it either,
but I suppose we can exploit post installation step to write custom scripts
that setup initd or systemd scripts at suitable locations. For this we include
both init/systemd scripts in the package (let say
Same thing, pr for the right master :)
https://github.com/apache/cloudstack/pull/1520
--
Sent from the Delta quadrant using Borg technology!
Nux!
www.nux.ro
- Original Message -
> From: "Nux!"
> To: dev@cloudstack.apache.org
> Sent: Wednesday, 27 April, 2016 10:59:37
>
GitHub user NuxRo opened a pull request:
https://github.com/apache/cloudstack/pull/1520
CPU socket count reporting correction
CPU socket count reporting correction
From
https://github.com/MissionCriticalCloud/cosmic-plugin-hypervisor-kvm/pull/16
You can merge this pull request
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1510#issuecomment-215048942
LGTM, i had run the tests as well, with no more then the usual problems
&*%(^%. Note that part of the change is mine when you take my lgtm for it;)
---
If
1 - 100 of 118 matches
Mail list logo