Re: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

2016-05-22 Thread Prashant Mishra 
Congrats Will!


On 5/19/16, 2:02 PM, "Jayapal Uradi"  wrote:

>Congrats Will.
>
>Thanks,
>Jayapal
>> On 19-May-2016, at 1:54 pm, Rohit Yadav 
>>wrote:
>>
>> Congrats Will.
>>
>> Regards,
>> Rohit Yadav
>>
>>
>> rohit.ya...@shapeblue.com
>> www.shapeblue.com
>> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
>> @shapeblue
>>
>>
>> On May 19 2016, at 12:26 pm, Sebastien Goasguen 
>>wrote:
>>
>> Morning Everyone,
>>
>> Yesterday at the ASF board meeting, the board passed the resolution
>>making Will Stevens the new Vice President of the Apache CloudStack
>>project.
>>
>> Join me in congratulating Will on this appointment, wish him luck and
>>bring your unwavering support !
>>
>> You may have noticed that Will took on RM duties for the new releases
>>going forward and has also taken a very active role to finish bringing
>>us to github based workflow and CI. Will has some updates on that front
>>that I am sure you will all like.
>>
>> -Sebastien
>> Former VP CloudStack
>
>
>
>
>DISCLAIMER
>==
>This e-mail may contain privileged and confidential information which is
>the property of Accelerite, a Persistent Systems business. It is intended
>only for the use of the individual or entity to which it is addressed. If
>you are not the intended recipient, you are not authorized to read,
>retain, copy, print, distribute or use this message. If you have received
>this communication in error, please notify the sender and delete all
>copies of this message. Accelerite, a Persistent Systems business does
>not accept any liability for virus infected mails.




DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

2016-05-22 Thread remibergsma 
Github user remibergsma commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1297#discussion_r64153911
  
--- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java ---
@@ -2451,6 +2455,21 @@ public UserVm updateVirtualMachine(long id, String 
displayName, String group, Bo
 isDynamicallyScalable = vm.isDynamicallyScalable();
 }
 
+// Get default guest network in Basic zone
+DataCenterVO zone = _dcDao.findById(vm.getDataCenterId());
+Network defaultNetwork = 
_networkModel.getExclusiveGuestNetwork(zone.getId());
+
+boolean isVmWare = (vm.getHypervisorType() == 
HypervisorType.VMware);
--- End diff --

Small detail: Please check the spelling of VMware, I see lots of different 
variations and believe VMware is the right one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...

2016-05-22 Thread remibergsma 
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1482#issuecomment-220845474
  
@swill Some parts need to be rewritten so that won't be on time I'm afraid.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Remove unused code at "com.cloud.vm.UserV...

2016-05-22 Thread GabrielBrascher 
GitHub user GabrielBrascher opened a pull request:

https://github.com/apache/cloudstack/pull/1558

Remove unused code at "com.cloud.vm.UserVmManagerImpl"

# Summary
All changes in this PR started by removing unused methods from the 
"UserVmManagerImpl". That results in changing  two (2) of its implemented 
interfaces ("UserVmManager" and "UserVmService").

Also, the "UserVmManagerImplTest" class had small changes.

One unused interface was removed ("BareMetalVmService").

# Detailed work
Changes at the interface "com.cloud.vm.UserVmManager":
- removed method "com.cloud.vm.UserVmManager.getVirtualMachines(long)"
that is not used at the class that implements this interface;
- removed method "com.cloud.vm.UserVmManager.stopVirtualMachine(long,
long)" as it is not used at the "UserVmManagerImpl" class;

Changes at the class "com.cloud.vm.UserVmManagerImpl":
- "com.cloud.vm.UserVmManagerImpl.UserVmCloneType" enum access level
from public to private;
- removed unused method
"com.cloud.vm.UserVmManagerImpl.getVirtualMachines(long)";
- removed unused method
"com.cloud.vm.UserVmManagerImpl.stopVirtualMachine(long, long)";
- removed unused method
"com.cloud.vm.UserVmManagerImpl.deletePrivateTemplateRecord(Long)";
- removed unused method
"com.cloud.vm.UserVmManagerImpl.getHypervisorTypeOfUserVM(long)";
- removed unused method
"com.cloud.vm.UserVmManagerImpl.createVirtualMachine(DeployVMCmd)";
- removed unused method
"com.cloud.vm.UserVmManagerImpl.isDisplayResourceEnabled(Long)";
- changed access level certain global variables to protected or private
(if possible);
- removed duplicated injected dependencies;
- removed null atributions to dependency injection objects (as by);
- removed unused variables.

Class "com.cloud.vm.UserVmManagerImpl.VmIpAddrFetchThread":
- changed variables access from public to private.

Class "com.cloud.vm.UserVmManagerTest":
- Used @InjectMocks to inject all
"com.cloud.vm.UserVmManagerTest._userVmMgr" dependencies, allowing the
cleaning of "manual injections" at the @Before block code
("com.cloud.vm.UserVmManagerTest.setup()").

It was removed the unused interface "com.cloud.vm.BareMetalVmService".

Interface "com.cloud.vm.UserVmService":
- removed the
"com.cloud.vm.UserVmService.deletePrivateTemplateRecord(Long)" method
that is unused at the class implementing this interface
("UserVmManagerImpl")
- removed the unused method
"com.cloud.vm.UserVmService.isDisplayResourceEnabled(Long)";
- removed the unused method
"com.cloud.vm.UserVmService.getHypervisorTypeOfUserVM(long)";
- removed the unused method
"com.cloud.vm.UserVmService.createVirtualMachine(DeployVMCmd)";

Changes at the class "com.cloud.vm.UserVmManagerImpl.VmAndCountDetails":
- removed unused method
"com.cloud.vm.UserVmManagerImpl.VmAndCountDetails.setRetrievalCount(int)";
- removed unused method
"com.cloud.vm.UserVmManagerImpl.VmAndCountDetails.setVmId(long)";

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/GabrielBrascher/cloudstack lrg-cs-hackday-026

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1558.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1558


commit 40ba1d267e0c73f7526b9d2d3c0706bc8fce89e9
Author: gabrascher 
Date:   2016-05-22T14:48:03Z

Remove unused code (begining from) "com.cloud.vm.UserVmManagerImpl"

Changes at the interface "com.cloud.vm.UserVmManager":
- remove method "com.cloud.vm.UserVmManager.getVirtualMachines(long)"
that is not used at the class that implements this interface;
- remove method "com.cloud.vm.UserVmManager.stopVirtualMachine(long,
long)" as it is not used at the "UserVmManagerImpl" class;

Changes at the class "com.cloud.vm.UserVmManagerImpl":
- "com.cloud.vm.UserVmManagerImpl.UserVmCloneType" enum access level
from public to private;
- remove unused method
"com.cloud.vm.UserVmManagerImpl.getVirtualMachines(long)";
- remove unused method
"com.cloud.vm.UserVmManagerImpl.stopVirtualMachine(long, long)";
- remove unused method
"com.cloud.vm.UserVmManagerImpl.deletePrivateTemplateRecord(Long)";
- remove unused method
"com.cloud.vm.UserVmManagerImpl.getHypervisorTypeOfUserVM(long)";
- remove unused method
"com.cloud.vm.UserVmManagerImpl.createVirtualMachine(DeployVMCmd)";
- remove unused method
"com.cloud.vm.UserVmManagerImpl.isDisplayResourceEnabled(Long)";
- change access level certain global variables to protected or private
(if possible);