Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1597
@vcharmcaster it looks like your commit still did not fix the problems. Can
you check the problems I mentioned in my previous comments. There are some
trailing spaces and tabs which need to be
Github user vcharmcaster commented on the issue:
https://github.com/apache/cloudstack/pull/1597
@swill @syed updated formatting. Let me know if i missed something.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Rohit,
Simon and his team is in the final push getting their next internal
production release ready to ship, so their testing of 4.9 has paused while
they get that ready. I suspect he and his team will have limited time to
dedicate to this in this week.
Just figured I would pass that along if he
Hi Simon,
Thanks for sharing. I'm continuing the discussion from a PR
(https://github.com/apache/cloudstack/pull/1549#issuecomment-229070969) here
wrt NIO ssl agent connection. Are you using latest master, and are you able to
consistently reproduce the issue? Make sure that both management
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1549
@swill close to two months now. Can you add the mgmt server logs, heap dump
and any other dumps which can help me fix the issue.
@swill @kiwiflyer Can you please open a JIRA issue where you
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1598
Good enough. Thanks... :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1598
@swill. I've fixed the whitespaces and rebased everything. Should be good
now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1547
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1598
@syed, can you do a once through and clean up some of the white space
issues in this diff. I have highlighted a couple. The method indent is the
most important, but there are a few other cases
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1598#discussion_r68779423
--- Diff: core/src/com/cloud/storage/template/VhdProcessor.java ---
@@ -91,27 +97,58 @@ public long getVirtualSize(File file) throws
IOException {
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1598#discussion_r68779079
--- Diff: core/src/com/cloud/storage/template/VhdProcessor.java ---
@@ -91,27 +97,58 @@ public long getVirtualSize(File file) throws
IOException {
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1596
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1581
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1597
Should the result of the splits be stripped of whitespace to make sure
there is no extra whitespace being saved into variables?
---
If your project is set up for it, you can reply to this email
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1595
LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1597
Looks like there are some trailing space problems. Can you please fix that
@vcharmcaster
```
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1598
This is coming back clean. Since it fixes issues in 4.9, I think it should
be merged...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1596
Ok, this is coming back clean. Do you guys agree I should merge this into
4.9 as it fixes issues? Thanks...
---
If your project is set up for it, you can reply to this email and have your
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1596
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 0
Errors: 0
Duration: 4h 02m 49s
```
**Associated Uploads**
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1598
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 0
Errors: 0
Duration: 4h 07m 10s
```
**Associated Uploads**
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1549
This was shared in the "4.9/master Testing Coordination" thread. Simon
Weller and his team at ENA have run into this on the latest master in both of
their hardware labs while testing master for
All,
I've made few changes which allows for a standalone Marvin. We currently have
Marvin in the CloudStack repository because of the 'cloudstackAPI' code
generation that is done during build time. Marvin allows 'cloudstackAPI' to be
generated at runtime if a URL end-point is provided.
Some
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1599
/cc @swill @jburwell @abhinandanprateek @murali-reddy @DaanHoogland @wido
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user rhtyd opened a pull request:
https://github.com/apache/cloudstack/pull/1599
Independent marvin
The aim is to make marvin independent of CloudStack. I had started this
work few months ago, but recently resumed it after working on Trillian.
- The aim is to show
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1549#discussion_r68709839
--- Diff: utils/src/main/java/com/cloud/utils/nio/NioConnection.java ---
@@ -125,7 +125,7 @@ public boolean isStartup() {
public Boolean call()
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1549
@swill may I have the mgmt server and agent logs when the failures were
intercepted. This is to make sure it's not your environment specific issue.
I'll also need the JRE version in use (openjdk,
26 matches
Mail list logo
