Removing old entries from storage in database

2016-08-24 Thread Marty Godsey
Hello,

I have some entries in my database for storage arrays that are no longer in 
use. WHats the best way to go about removing these? The ones that have no GUID 
do not show in the UI and the one that does (id 5) wont let me delete it even 
though the XenServers cant mount it.

http://tinypic.com/r/25f85dw/9

Regards,
Marty Godsey



Re: JuniperSRX firewall configure plugin source bug

2016-08-24 Thread Gust

I submitted PR:

https://github.com/apache/cloudstack/pull/1662


> 在 2016年8月24日,20:36,Will Stevens  写道:
> 
> Hey Gust,
> Here are the details for contributing.
> 
> https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md
> 
> You need to fork cloudstack and the the change in your fork. Then you
> create a pull request from your fork to ACS.
> 
> Let us know if you have problems following that guide.
> 
> Cheers,
> 
> Will
> 
> On Aug 24, 2016 4:09 AM, "Gust"  wrote:
> 
>> 
>> Hi, Jayapal
>> 
>> why not submit a PR, in github desktop prompt:
>> 
>> You may not have permission to access cloudstack. Check Preferences to
>> make sure you’re still logged in.
>> 
>> I ensure i loved in.
>> 
>> 
>> 
>>> 在 2016年8月24日,12:52,Jayapal Uradi  jayapal.ur...@accelerite.com>> 写道:
>>> 
>>> Hi Gust,
>>> 
>>> The changes look good  please go head and raise a PR for it.
>>> 
>>> Thanks,
>>> Jayapal
 On Aug 24, 2016, at 8:14 AM, Gust  digitalg...@163.com>> wrote:
 
 Hi , all
 
 There is a bug in com.cloud.network.resource.JuniperSrxResource
 
 It will report syntax error when configure  outgress rule to Juniper
>> srx hardware firewall.
 
 
 begin line 2830 :
 
if (type.equals(SecurityPolicyType.
>> SECURITYPOLICY_EGRESS_DEFAULT)) {
if (defaultEgressAction == false) {
//for default policy is false add default
>> deny rules
action = "";
} else {
action = "";
}
 
} else {
if (defaultEgressAction == true) {
//configure egress rules to deny the traffic
>> when default egress is allow
action = "";
} else {
action = "";
}
 //error here
xml = replaceXmlValue(xml, "action", action);
 
}
 
 fix:
 
if (type.equals(SecurityPolicyType.
>> SECURITYPOLICY_EGRESS_DEFAULT)) {
if (defaultEgressAction == false) {
//for default policy is false add default
>> deny rules
action = "";
} else {
action = "";
}
 
} else {
if (defaultEgressAction == true) {
//configure egress rules to deny the traffic
>> when default egress is allow
action = "";
} else {
action = "";
}
}
 //move replace  out
xml = replaceXmlValue(xml, "action", action);
 
 
 
 gust
 
 Being china.
 2016-08-24
 
 
 
 
>>> 
>>> 
>>> 
>>> 
>>> DISCLAIMER
>>> ==
>>> This e-mail may contain privileged and confidential information which is
>> the property of Accelerite, a Persistent Systems business. It is intended
>> only for the use of the individual or entity to which it is addressed. If
>> you are not the intended recipient, you are not authorized to read, retain,
>> copy, print, distribute or use this message. If you have received this
>> communication in error, please notify the sender and delete all copies of
>> this message. Accelerite, a Persistent Systems business does not accept any
>> liability for virus infected mails.
>> 
>> 




[GitHub] cloudstack pull request #1662: Fix bug juniper srx

2016-08-24 Thread digitalgust
GitHub user digitalgust opened a pull request:

https://github.com/apache/cloudstack/pull/1662

Fix bug juniper srx

if the public interface has marked untagged ,the vlan is
“vlan://untagged” ,but old source is “untagged” , so it will raise a
exception : Unable to parse VLAN tag: vlan://untagged

%action% not replaced. It will report syntax error when configure
outgress rule to Juniper srx hardware firewall.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/digitalgust/cloudstack fix_bug_juniper_srx

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1662.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1662


commit 49ff456c583bb1a00437b067521942440690240a
Author: digitalgust 
Date:   2016-08-25T02:29:05Z

hardware firewall operation bug

if the public interface has marked untagged ,the vlan is
“vlan://untagged” ,but old source is “untagged” , so it will raise a
exception : Unable to parse VLAN tag: vlan://untagged

%action% not replaced. It will report syntax error when configure
outgress rule to Juniper srx hardware firewall.

commit 7f7af0aad23ec88a25a5e86a19959fc15aeec414
Author: digitalgust 
Date:   2016-08-25T02:51:35Z

Revert "hardware firewall operation bug"

This reverts commit 49ff456c583bb1a00437b067521942440690240a.

commit 42135f0ba5605b56615e0c923f1e47918be3663e
Author: digitalgust 
Date:   2016-08-25T03:13:05Z

Revert "Revert "hardware firewall operation bug""

This reverts commit 7f7af0aad23ec88a25a5e86a19959fc15aeec414.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1605: CLOUDSTACK-9428: Fix for CLOUDSTACK-9211 - Improve p...

2016-08-24 Thread serg38
Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1605
  
LGTM for testing.  Vmware ESX 5.5 and 6.0 hypervisors, advanced networking, 
RHEL 6 management servers

[root@ussarlabcsmgt41 ~]# cat 
/tmp//MarvinLogs/test_volumes_930LZ3/results.txt|grep -v ok
test DeployVM in anti-affinity groups for project ... === TestName: 
test_DeployVmAntiAffinityGroup_in_project | Status : SUCCESS ===
test DeployVM in anti-affinity groups ... === TestName: 
test_DeployVmAntiAffinityGroup | Status : SUCCESS ===
Test Deploy Virtual Machine ... SKIP: Skipping test because suitable 
hypervisor/host notpresent
Test Deploy Virtual Machine from ISO ... === TestName: 
test_deploy_vm_from_iso | Status : SUCCESS ===
Test deploy virtual machine with root resize ... === TestName: 
test_00_deploy_vm_root_resize | Status : SUCCESS ===
Test proper failure to deploy virtual machine with rootdisksize of 0 ... 
=== TestName: test_01_deploy_vm_root_resize | Status : SUCCESS ===
Test proper failure to deploy virtual machine with rootdisksize less than 
template size ... === TestName: test_02_deploy_vm_root_resize | Status : 
SUCCESS ===
Test to deploy vm with a first fit offering ... === TestName: 
test_deployvm_firstfit | Status : SUCCESS ===
Test deploy VMs using user concentrated planner ... === TestName: 
test_deployvm_userconcentrated | Status : SUCCESS ===
Test deploy VMs using user dispersion planner ... === TestName: 
test_deployvm_userdispersing | Status : SUCCESS ===
Test userdata as GET, size > 2k ... === TestName: test_deployvm_userdata | 
Status : SUCCESS ===
Test userdata as POST, size > 2k ... === TestName: 
test_deployvm_userdata_post | Status : SUCCESS ===
Test to create disk offering ... === TestName: test_01_create_disk_offering 
| Status : SUCCESS ===
Test to create  a sparse type disk offering ... === TestName: 
test_02_create_sparse_type_disk_offering | Status : SUCCESS ===
Test to create  a sparse type disk offering ... === TestName: 
test_04_create_fat_type_disk_offering | Status : SUCCESS ===
Test to update existing disk offering ... === TestName: 
test_02_edit_disk_offering | Status : SUCCESS ===
Test to delete disk offering ... === TestName: test_03_delete_disk_offering 
| Status : SUCCESS ===
Test to ensure 4 default roles cannot be deleted ... SKIP: Dynamic 
Role-Based API checker not enabled, skipping test
Test to check role, role permissions and account life cycles ... SKIP: 
Dynamic Role-Based API checker not enabled, skipping test
Test for role-rule enforcement in case of multiple mgmt servers ... SKIP: 
Dynamic Role-Based API checker not enabled, skipping test
Test to ensure role in use cannot be deleted ... SKIP: Dynamic Role-Based 
API checker not enabled, skipping test
Tests normal lifecycle operations for roles ... SKIP: Dynamic Role-Based 
API checker not enabled, skipping test
Tests role update ... SKIP: Dynamic Role-Based API checker not enabled, 
skipping test
Tests that default four roles exist ... SKIP: Dynamic Role-Based API 
checker not enabled, skipping test
Tests role update ... SKIP: Dynamic Role-Based API checker not enabled, 
skipping test
Tests role update when role is in use by an account ... SKIP: Dynamic 
Role-Based API checker not enabled, skipping test
Tests concurrent order updation of role permission ... SKIP: Dynamic 
Role-Based API checker not enabled, skipping test
Tests creation of role permission ... SKIP: Dynamic Role-Based API checker 
not enabled, skipping test
Tests deletion of role permission ... SKIP: Dynamic Role-Based API checker 
not enabled, skipping test
Tests listing of default role's permission ... SKIP: Dynamic Role-Based API 
checker not enabled, skipping test
Tests order updation of role permission ... SKIP: Dynamic Role-Based API 
checker not enabled, skipping test
test update configuration setting at zone level scope ... === TestName: 
test_UpdateConfigParamWithScope | Status : SUCCESS ===
Test guest vlan range dedication ... === TestName: 
test_dedicateGuestVlanRange | Status : SUCCESS ===
Test create public & private ISO ... === TestName: test_01_create_iso | 
Status : SUCCESS ===
Test Edit ISO ... === TestName: test_02_edit_iso | Status : SUCCESS ===
Test delete ISO ... === TestName: test_03_delete_iso | Status : SUCCESS ===
Test for extract ISO ... === TestName: test_04_extract_Iso | Status : 
SUCCESS ===
Update & Test for ISO permissions ... === TestName: test_05_iso_permissions 
| Status : SUCCESS ===
Test for copy ISO from one zone to another ... SKIP: Not enough zones 
available to perform copy template
Test delete ISO ... === TestName: test_07_list_default_iso | Status : 
SUCCESS ===
Test listing Volumes using 'ids' parameter ... === TestName: 
test_01_list_volumes | Status : SUCCESS ===
Test listing Templates using 

[GitHub] cloudstack-docs-admin issue #40: index.po and ui.po translated in FR

2016-08-24 Thread pdion891
Github user pdion891 commented on the issue:

https://github.com/apache/cloudstack-docs-admin/pull/40
  
@lmrv if you have a chance to update all files copyright header, to must 
have the apache2 v2 license header.

Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack-docs-admin issue #40: index.po and ui.po translated in FR

2016-08-24 Thread pdion891
Github user pdion891 commented on the issue:

https://github.com/apache/cloudstack-docs-admin/pull/40
  
@lmrv This is a great start! 

I'm willing to merge this PR, but it's a work in progress so it will not be 
visible on the main site until the translation is mostly completed.

At least the frame work is in place which is very great! 

Thanks a lot.  It's going to be awesome to have the full translation. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1645: On snapshot backup, this converts the rbd raw format...

2016-08-24 Thread nathanejohnson
Github user nathanejohnson commented on the issue:

https://github.com/apache/cloudstack/pull/1645
  
@jburwell as an update, the smoke test has completed successfully, and I'll 
let the component tests run overnight.  Hopefully they will have finished by 
the morning.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1605: CLOUDSTACK-9428: Fix for CLOUDSTACK-9211 - Improve p...

2016-08-24 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack/pull/1605
  
@nv, I am sorry, my bad; last time I read the code, I overlooked the method 
com.cloud.hypervisor.vmware.mo.VirtualMachineMO.getAllDeviceList(). Having said 
that, how do you feel about extracting the try/catch block to 
“getAllDeviceList”, then this method would not need to throw a checked 
exception. It could re-throw a runtime exception such as the CloudRuntime.

From my understanding the test method “testStartVm3dgpuEnabled” is used 
to test the method “configureVideoCard”, right? What about changing that 
method name to “testConfigureVideoCard”?

Moreover, do not you think that the method “configureVideoCard” needs 
at least two test cases? One that is already written, and the other to test the 
condition in which the  call 
“vmSpec.getDetails().containsKey(VmDetailConstants.SVGA_VRAM_SIZE)” returns 
false, and then the method “setNewVRamSizeVmVideoCard” is never called.

The same happens for the method “modifyVmVideoCardVRamSize”, I think it 
has another condition “videoCard.getVideoRamSizeInKB().longValue() == 
svgaVmramSize” to be tested.

And finally, for the test method 
“testConfigureSpecVideoCardNewVRamSize”, what about using the 
“Mockito.InOrder” to assure that the methods are being called in the proper 
order. If someone changes that order of call in the future, that can affect the 
method behavior.

I also have one small comment about the title of the PR and the commit 
message. “Improve performance” seems a little too vague for a title. The 
idea is very well explained on the PR, but the title does not reflect much. 
What about, “improve the performance of cloud-plugin-hypervisor-vmware” or 
something like that.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1605: CLOUDSTACK-9428: Fix for CLOUDSTACK-9211 - Improve p...

2016-08-24 Thread nvazquez
Github user nvazquez commented on the issue:

https://github.com/apache/cloudstack/pull/1605
  
Thanks @rafaelweingartner for your review! I've been working on it and 
pushed changes based on your comments!
The only thing I need to mention is that actually I can't remove `throws 
Exception` from `setNewVRamSizeVmVideoCard` method, as `getAllDeviceList` 
method throws Exception and that's the reason for catch block on 
`configureVideoCard`. Do you agree with this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1645: On snapshot backup, this converts the rbd raw format...

2016-08-24 Thread jburwell
Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1645
  
@nathanejohnson excellent.  I will keep any eye out for your updates.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: CS 4.9 NIO Selector wait time PR-1601

2016-08-24 Thread Rohit Yadav
Martin,


Were you able to fix your issue after installing packages from the repo Will 
shared and restarting the services?

I've not personally tested the apt-get.eu repo, but I had earlier built this 
repo which I'm personally using in my local KVM-trusty based cloud: 
http://packages.shapeblue.com/cloudstack/upstream/debian/4.9/


If you're still getting the error, can you share the JRE version you're 
running, both on the mgmt server and on the KVM hosts? You can run java 
-version, or share output of "dpkg --get-selections | grep -e 'jdk' -e 'java'". 
Are you running CloudStack with any additional plugins?


From the logs, looks like there are mixed jar files, NioConnectionException 
class was not found -- something's wrong with your installation. there must be 
a cloud-utils jar file make sure your installation don't have multiple 
copies/versions of jars (somewhere) in the in /usr/share/cloudstack-common and 
in /usr/share/cloudstack-management/webapps/client/ paths:

Could not find exception:
com.cloud.utils.exception.NioConnectionException in error code list for
exceptions

The error "Unable to initialize the threads." suggests, JVM was not able to 
spawn threads. I would like to know your JRE version and any other settings 
configured in /etc/cloudstack/management/classpath.conf (and there are bunch of 
other files where JAVA_OPTS might have been overridden). Note: For now you 
should only be using JRE1.7.


Regards.


From: martin kolly 
Sent: 24 August 2016 19:53:26
To: dev@cloudstack.apache.org; Rohit Yadav
Subject: Re: CS 4.9 NIO Selector wait time PR-1601

Thanks Will!

yes the repo is pointing to 4.9 release for all KVMs and for the management 
server:
cloudstack:~# cat /etc/apt/sources.list.d/cloudstack.list
deb http://cloudstack.apt-get.eu/ubuntu trusty 4.9

All KVM agents and the mgmt server are upgraded to release 4.9 based on the 
documentation.We have restarted all the cloudstack-agents and the 
cloudstack-management service as well.

Network traces are showing packets from KVM <-> Mgmt on port 8250. there is no 
security device in between.

thanks
fanfarlo




On 08/24/2016 04:13 PM, Will Stevens wrote:

@rohit, I am guessing they should be installing the cloudstack-agent using
the following repo right?  That is what is described in the upgrade (trusty
instead of precise though).

http://cloudstack.apt-get.eu/ubuntu/dists/trusty/4.9/

@fanfarlo, are your repo's setup to point to the new 4.9 version?

cheers,

will

On Wed, Aug 24, 2016 at 9:46 AM, Rohit Yadav 

wrote:



The PR and fix already exists in 4.9.0 release. Please make sure to
upgrade all of your management server(s) and KVM agents and then also
restart them after the upgrade.


If you are seeing SSL handshake failures, it could be due to network or
security issue and most likely due to mismatch between CloudStack mgmt
server and KVM agent version.


Regards.

rohit.ya...@shapeblue.com
www.shapeblue.com
@shapeblue



--
*From:* Will Stevens 
*Sent:* 24 August 2016 18:17:17
*To:* dev@cloudstack.apache.org; Rohit Yadav
*Subject:* Re: CS 4.9 NIO Selector wait time PR-1601


That PR is already merged, so you don't have to do anything to get that
code, you already have it.

@rohit, can you review this?  I think this is a similar to the issue Simon
reported earlier.

Will

On Aug 24, 2016 6:56 AM, "fanfarlo" 
 wrote:



hi all

We have the following environment:
- OS: Debian 14.04 (hypervisors and management)
- 4 KVM Hosts
- Cloudstack Release 4.9 with local database

Since we upgraded to Release 4.9 the KVM hosts no longer connect to the
management Server. Upgrade procedure was followed as described:
http://docs.cloudstack.apache.org/projects/cloudstack-releas
e-notes/en/4.9.0/upgrade/upgrade-4.8.html


On the KVM hosts we have the following error message:
/2016-08-24 10:42:49,678 INFO  [utils.exception.CSExceptionErrorCode]
(main:null) (logid:) Could not find exception:
com.cloud.utils.exception.NioConnectionException in error code list for
exceptions
2016-08-24 10:42:49,678 WARN  [cloud.agent.Agent] (main:null) (logid:)
NIO Connection Exception
com.cloud.utils.exception.NioConnectionException: SSL Handshake failed
while connecting to host: 10.100.12.10 port: 8250
2016-08-24 10:42:49,678 INFO  [cloud.agent.Agent] (main:null) (logid:)
Attempted to connect to the server, but received an unexpected
exception, trying again...
2016-08-24 10:42:54,679 INFO  [utils.nio.NioClient] (main:null) (logid:)
Connecting to 10.100.12.10:8250
2016-08-24 10:42:54,684 WARN  [utils.nio.Link] (main:null) (logid:) This
SSL engine was forced to close inbound due to end of stream.
2016-08-24 10:42:54,684 

[GitHub] cloudstack issue #1635: CLOUDSTACK-9451

2016-08-24 Thread kiwiflyer
Github user kiwiflyer commented on the issue:

https://github.com/apache/cloudstack/pull/1635
  
I'll let him comment on this, but If I recall, it had more to do with 
implementation of force stopping with KVM rather than the lack of the parameter 
being passing into the VM Manager.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1635: CLOUDSTACK-9451

2016-08-24 Thread ProjectMoon
Github user ProjectMoon commented on the issue:

https://github.com/apache/cloudstack/pull/1635
  
All hypervisors are affected by this, since the parameter is just not 
passed into the VM Manager. That means its effects don't work at all anywhere. 
:) I will try to review it to tomorrow.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1635: CLOUDSTACK-9451

2016-08-24 Thread kiwiflyer
Github user kiwiflyer commented on the issue:

https://github.com/apache/cloudstack/pull/1635
  
@ProjectMoon Jeff, could you help review this, as I believe you were the 
first to point it out on the list.

From talking to Nathan, it sounds like we're not sure KVM is actually 
affected by this bug. He was in the process of doing some digging. Regardless 
of that, it probably affects other hypervisors.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1661: Export UUID for zone creation event completio...

2016-08-24 Thread ProjectMoon
GitHub user ProjectMoon opened a pull request:

https://github.com/apache/cloudstack/pull/1661

Export UUID for zone creation event completion.

Action events have support for exporting their "first class entities" over 
the event bus, if it's turned on. This works mostly for BaseAsyncCmds and any 
synchronous command that operates on already-existing entities. They are 
populated by the ApiServer and found by ActionEventUtils.

Where it tends to falter is when dealing with synchronous creation 
commands. This commit makes createZone export the zone UUID over the event bus 
once the zone has been created.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/greenqloud/cloudstack 
pr-zone-ids-action-events

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1661.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1661


commit fb7f5dfa37d76de66de52b0d8a10470b436fdf1a
Author: jeff 
Date:   2016-08-24T16:19:16Z

Export UUID for zone creation event completion.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Virtio vs IDE emulation, per OS - where is this info ?

2016-08-24 Thread Simon Weller
Andrija,


It's actually hard coded and based on the template namethis really needs to 
be reworked.


https://github.com/apache/cloudstack/blob/3a81a4498f6b56eb7330bc992f0c89f6cba86cb3/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java#L2885


- Si





From: Andrija Panic 
Sent: Wednesday, August 24, 2016 9:39 AM
To: dev@cloudstack.apache.org
Subject: Virtio vs IDE emulation, per OS - where is this info ?

Hi all,

Im trying to build the simple table for our support guys, which OS type (as
seen in ACS) is virtio emualted, and which is IDE/Intel emulation.

I dont seem to find this in DB, except the list of OS types, families etc.

Can someone give some info, where should I find if OS is supposed to be
virtio or ide/intel/emulated ?

Thanks,

--

Andrija Panic

--

Andrija Panic


Virtio vs IDE emulation, per OS - where is this info ?

2016-08-24 Thread Andrija Panic
Hi all,

Im trying to build the simple table for our support guys, which OS type (as
seen in ACS) is virtio emualted, and which is IDE/Intel emulation.

I dont seem to find this in DB, except the list of OS types, families etc.

Can someone give some info, where should I find if OS is supposed to be
virtio or ide/intel/emulated ?

Thanks,

-- 

Andrija Panić

-- 

Andrija Panić


[GitHub] cloudstack issue #1658: Added an additional JSON diff output to the ApiXmlDo...

2016-08-24 Thread swill
Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1658
  
I don't think this implementation should change.  This simply outputs the 
results to a JSON object (which is unordered by definition).  The generation of 
the documentation is separate and that code will have its own pull request as a 
helper script against the `cloudstack-docs-rn` repo.  I can add the ordering 
logic to the generation script if we would like it.

This PR is the foundation for being able to use scripting to generate the 
API change docs, so this is a dependency for the other PR (not yet opened).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: CS 4.9 NIO Selector wait time PR-1601

2016-08-24 Thread martin kolly
Thanks Will!

yes the repo is pointing to 4.9 release for all KVMs and for the
management server:
/cloudstack:~# cat /etc/apt/sources.list.d/cloudstack.list //
//deb http://cloudstack.apt-get.eu/ubuntu trusty 4.9/

All KVM agents and the mgmt server are upgraded to release 4.9 based on
the documentation.We have restarted all the cloudstack-agents and the
cloudstack-management service as well.

Network traces are showing packets from KVM <-> Mgmt on port 8250. there
is no security device in between.

thanks
fanfarlo




On 08/24/2016 04:13 PM, Will Stevens wrote:
> @rohit, I am guessing they should be installing the cloudstack-agent using
> the following repo right?  That is what is described in the upgrade (trusty
> instead of precise though).
>
> http://cloudstack.apt-get.eu/ubuntu/dists/trusty/4.9/
>
> @fanfarlo, are your repo's setup to point to the new 4.9 version?
>
> cheers,
>
> will
>
> On Wed, Aug 24, 2016 at 9:46 AM, Rohit Yadav 
> wrote:
>
>> The PR and fix already exists in 4.9.0 release. Please make sure to
>> upgrade all of your management server(s) and KVM agents and then also
>> restart them after the upgrade.
>>
>>
>> If you are seeing SSL handshake failures, it could be due to network or
>> security issue and most likely due to mismatch between CloudStack mgmt
>> server and KVM agent version.
>>
>>
>> Regards.
>>
>> rohit.ya...@shapeblue.com
>> www.shapeblue.com
>> @shapeblue
>>
>>
>>
>> --
>> *From:* Will Stevens 
>> *Sent:* 24 August 2016 18:17:17
>> *To:* dev@cloudstack.apache.org; Rohit Yadav
>> *Subject:* Re: CS 4.9 NIO Selector wait time PR-1601
>>
>>
>> That PR is already merged, so you don't have to do anything to get that
>> code, you already have it.
>>
>> @rohit, can you review this?  I think this is a similar to the issue Simon
>> reported earlier.
>>
>> Will
>>
>> On Aug 24, 2016 6:56 AM, "fanfarlo"  wrote:
>>
>>> hi all
>>>
>>> We have the following environment:
>>> - OS: Debian 14.04 (hypervisors and management)
>>> - 4 KVM Hosts
>>> - Cloudstack Release 4.9 with local database
>>>
>>> Since we upgraded to Release 4.9 the KVM hosts no longer connect to the
>>> management Server. Upgrade procedure was followed as described:
>>> http://docs.cloudstack.apache.org/projects/cloudstack-releas
>>> e-notes/en/4.9.0/upgrade/upgrade-4.8.html
>>>
>>>
>>> On the KVM hosts we have the following error message:
>>> /2016-08-24 10:42:49,678 INFO  [utils.exception.CSExceptionErrorCode]
>>> (main:null) (logid:) Could not find exception:
>>> com.cloud.utils.exception.NioConnectionException in error code list for
>>> exceptions
>>> 2016-08-24 10:42:49,678 WARN  [cloud.agent.Agent] (main:null) (logid:)
>>> NIO Connection Exception
>>> com.cloud.utils.exception.NioConnectionException: SSL Handshake failed
>>> while connecting to host: 10.100.12.10 port: 8250
>>> 2016-08-24 10:42:49,678 INFO  [cloud.agent.Agent] (main:null) (logid:)
>>> Attempted to connect to the server, but received an unexpected
>>> exception, trying again...
>>> 2016-08-24 10:42:54,679 INFO  [utils.nio.NioClient] (main:null) (logid:)
>>> Connecting to 10.100.12.10:8250
>>> 2016-08-24 10:42:54,684 WARN  [utils.nio.Link] (main:null) (logid:) This
>>> SSL engine was forced to close inbound due to end of stream.
>>> 2016-08-24 10:42:54,684 ERROR [utils.nio.NioClient] (main:null) (logid:)
>>> SSL Handshake failed while connecting to host: 10.100.12.10 port: 8250
>>> 2016-08-24 10:42:54,685 ERROR [utils.nio.NioConnection] (main:null)
>>> (logid:) Unable to initialize the threads.
>>> java.io.IOException: SSL Handshake failed while connecting to host:
>>> 10.100.12.10 port: 8250
>>> at com.cloud.utils.nio.NioClient.init(NioClient.java:67)
>>> at com.cloud.utils.nio.NioConnection.start(NioConnection.java:88)
>>> at com.cloud.agent.Agent.start(Agent.java:237)
>>> at com.cloud.agent.AgentShell.launchAgent(AgentShell.java:399)
>>> at
>>> com.cloud.agent.AgentShell.launchAgentFromClassInfo(AgentShell.java:367)
>>> at com.cloud.agent.AgentShell.launchAgent(AgentShell.java:351)
>>> at com.cloud.agent.AgentShell.start(AgentShell.java:456)
>>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>>> at
>>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAcce
>>> ssorImpl.java:57)
>>> at
>>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMe
>>> thodAccessorImpl.java:43)
>>> at java.lang.reflect.Method.invoke(Method.java:606)
>>> at
>>> org.apache.commons.daemon.support.DaemonLoader.start(DaemonL
>>> oader.java:243)
>>> 2016-08-24 10:42:54,685 INFO  [utils.exception.CSExceptionErrorCode]
>>> (main:null) (logid:) Could not find exception:
>>> com.cloud.utils.exception.NioConnectionException in error code list for
>>> exceptions
>>> 2016-08-24 10:42:54,685 WARN  [cloud.agent.Agent] (main:null) (logid:)
>>> NIO Connection Exception
>>> 

Re: CS 4.9 NIO Selector wait time PR-1601

2016-08-24 Thread Will Stevens
@rohit, I am guessing they should be installing the cloudstack-agent using
the following repo right?  That is what is described in the upgrade (trusty
instead of precise though).

http://cloudstack.apt-get.eu/ubuntu/dists/trusty/4.9/

@fanfarlo, are your repo's setup to point to the new 4.9 version?

cheers,

will

On Wed, Aug 24, 2016 at 9:46 AM, Rohit Yadav 
wrote:

> The PR and fix already exists in 4.9.0 release. Please make sure to
> upgrade all of your management server(s) and KVM agents and then also
> restart them after the upgrade.
>
>
> If you are seeing SSL handshake failures, it could be due to network or
> security issue and most likely due to mismatch between CloudStack mgmt
> server and KVM agent version.
>
>
> Regards.
>
> rohit.ya...@shapeblue.com
> www.shapeblue.com
> @shapeblue
>
>
>
> --
> *From:* Will Stevens 
> *Sent:* 24 August 2016 18:17:17
> *To:* dev@cloudstack.apache.org; Rohit Yadav
> *Subject:* Re: CS 4.9 NIO Selector wait time PR-1601
>
>
> That PR is already merged, so you don't have to do anything to get that
> code, you already have it.
>
> @rohit, can you review this?  I think this is a similar to the issue Simon
> reported earlier.
>
> Will
>
> On Aug 24, 2016 6:56 AM, "fanfarlo"  wrote:
>
>> hi all
>>
>> We have the following environment:
>> - OS: Debian 14.04 (hypervisors and management)
>> - 4 KVM Hosts
>> - Cloudstack Release 4.9 with local database
>>
>> Since we upgraded to Release 4.9 the KVM hosts no longer connect to the
>> management Server. Upgrade procedure was followed as described:
>> http://docs.cloudstack.apache.org/projects/cloudstack-releas
>> e-notes/en/4.9.0/upgrade/upgrade-4.8.html
>>
>>
>> On the KVM hosts we have the following error message:
>> /2016-08-24 10:42:49,678 INFO  [utils.exception.CSExceptionErrorCode]
>> (main:null) (logid:) Could not find exception:
>> com.cloud.utils.exception.NioConnectionException in error code list for
>> exceptions
>> 2016-08-24 10:42:49,678 WARN  [cloud.agent.Agent] (main:null) (logid:)
>> NIO Connection Exception
>> com.cloud.utils.exception.NioConnectionException: SSL Handshake failed
>> while connecting to host: 10.100.12.10 port: 8250
>> 2016-08-24 10:42:49,678 INFO  [cloud.agent.Agent] (main:null) (logid:)
>> Attempted to connect to the server, but received an unexpected
>> exception, trying again...
>> 2016-08-24 10:42:54,679 INFO  [utils.nio.NioClient] (main:null) (logid:)
>> Connecting to 10.100.12.10:8250
>> 2016-08-24 10:42:54,684 WARN  [utils.nio.Link] (main:null) (logid:) This
>> SSL engine was forced to close inbound due to end of stream.
>> 2016-08-24 10:42:54,684 ERROR [utils.nio.NioClient] (main:null) (logid:)
>> SSL Handshake failed while connecting to host: 10.100.12.10 port: 8250
>> 2016-08-24 10:42:54,685 ERROR [utils.nio.NioConnection] (main:null)
>> (logid:) Unable to initialize the threads.
>> java.io.IOException: SSL Handshake failed while connecting to host:
>> 10.100.12.10 port: 8250
>> at com.cloud.utils.nio.NioClient.init(NioClient.java:67)
>> at com.cloud.utils.nio.NioConnection.start(NioConnection.java:88)
>> at com.cloud.agent.Agent.start(Agent.java:237)
>> at com.cloud.agent.AgentShell.launchAgent(AgentShell.java:399)
>> at
>> com.cloud.agent.AgentShell.launchAgentFromClassInfo(AgentShell.java:367)
>> at com.cloud.agent.AgentShell.launchAgent(AgentShell.java:351)
>> at com.cloud.agent.AgentShell.start(AgentShell.java:456)
>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>> at
>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAcce
>> ssorImpl.java:57)
>> at
>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMe
>> thodAccessorImpl.java:43)
>> at java.lang.reflect.Method.invoke(Method.java:606)
>> at
>> org.apache.commons.daemon.support.DaemonLoader.start(DaemonL
>> oader.java:243)
>> 2016-08-24 10:42:54,685 INFO  [utils.exception.CSExceptionErrorCode]
>> (main:null) (logid:) Could not find exception:
>> com.cloud.utils.exception.NioConnectionException in error code list for
>> exceptions
>> 2016-08-24 10:42:54,685 WARN  [cloud.agent.Agent] (main:null) (logid:)
>> NIO Connection Exception
>> com.cloud.utils.exception.NioConnectionException: SSL Handshake failed
>> while connecting to host: 10.100.12.10 port: 8250
>> 2016-08-24 10:42:54,686 INFO  [cloud.agent.Agent] (main:null) (logid:)
>> Attempted to connect to the server, but received an unexpected
>> exception, trying again.../
>>
>>
>> Port is open on the management server, there is no firewall in between.
>> We found that there was a bug report here:
>> https://issues.apache.org/jira/browse/CLOUDSTACK-9348. There is a PR
>> changing the NIO Selector wait time:
>> https://github.com/apache/cloudstack/pull/1601 which was merged into
>> master branch.
>>
>> Since we installed Release 4.9 we probably need to patch the
>> NioConection.class as 

[GitHub] cloudstack issue #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper affectin...

2016-08-24 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1660
  
Thanks, this looks interesting. I'll try to get back to you on this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: CS 4.9 NIO Selector wait time PR-1601

2016-08-24 Thread Rohit Yadav
The PR and fix already exists in 4.9.0 release. Please make sure to upgrade all 
of your management server(s) and KVM agents and then also restart them after 
the upgrade.


If you are seeing SSL handshake failures, it could be due to network or 
security issue and most likely due to mismatch between CloudStack mgmt server 
and KVM agent version.


Regards.


From: Will Stevens 
Sent: 24 August 2016 18:17:17
To: dev@cloudstack.apache.org; Rohit Yadav
Subject: Re: CS 4.9 NIO Selector wait time PR-1601


That PR is already merged, so you don't have to do anything to get that code, 
you already have it.

@rohit, can you review this?  I think this is a similar to the issue Simon 
reported earlier.

Will

On Aug 24, 2016 6:56 AM, "fanfarlo" 
> wrote:
hi all

We have the following environment:
- OS: Debian 14.04 (hypervisors and management)
- 4 KVM Hosts
- Cloudstack Release 4.9 with local database

Since we upgraded to Release 4.9 the KVM hosts no longer connect to the
management Server. Upgrade procedure was followed as described:
http://docs.cloudstack.apache.org/projects/cloudstack-release-notes/en/4.9.0/upgrade/upgrade-4.8.html


On the KVM hosts we have the following error message:
/2016-08-24 10:42:49,678 INFO  [utils.exception.CSExceptionErrorCode]
(main:null) (logid:) Could not find exception:
com.cloud.utils.exception.NioConnectionException in error code list for
exceptions
2016-08-24 10:42:49,678 WARN  [cloud.agent.Agent] (main:null) (logid:)
NIO Connection Exception
com.cloud.utils.exception.NioConnectionException: SSL Handshake failed
while connecting to host: 10.100.12.10 port: 8250
2016-08-24 10:42:49,678 INFO  [cloud.agent.Agent] (main:null) (logid:)
Attempted to connect to the server, but received an unexpected
exception, trying again...
2016-08-24 10:42:54,679 INFO  [utils.nio.NioClient] (main:null) (logid:)
Connecting to 10.100.12.10:8250
2016-08-24 10:42:54,684 WARN  [utils.nio.Link] (main:null) (logid:) This
SSL engine was forced to close inbound due to end of stream.
2016-08-24 10:42:54,684 ERROR [utils.nio.NioClient] (main:null) (logid:)
SSL Handshake failed while connecting to host: 10.100.12.10 port: 8250
2016-08-24 10:42:54,685 ERROR [utils.nio.NioConnection] (main:null)
(logid:) Unable to initialize the threads.
java.io.IOException: SSL Handshake failed while connecting to host:
10.100.12.10 port: 8250
at com.cloud.utils.nio.NioClient.init(NioClient.java:67)
at com.cloud.utils.nio.NioConnection.start(NioConnection.java:88)
at com.cloud.agent.Agent.start(Agent.java:237)
at com.cloud.agent.AgentShell.launchAgent(AgentShell.java:399)
at
com.cloud.agent.AgentShell.launchAgentFromClassInfo(AgentShell.java:367)
at com.cloud.agent.AgentShell.launchAgent(AgentShell.java:351)
at com.cloud.agent.AgentShell.start(AgentShell.java:456)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at
org.apache.commons.daemon.support.DaemonLoader.start(DaemonLoader.java:243)
2016-08-24 10:42:54,685 INFO  [utils.exception.CSExceptionErrorCode]
(main:null) (logid:) Could not find exception:
com.cloud.utils.exception.NioConnectionException in error code list for
exceptions
2016-08-24 10:42:54,685 WARN  [cloud.agent.Agent] (main:null) (logid:)
NIO Connection Exception
com.cloud.utils.exception.NioConnectionException: SSL Handshake failed
while connecting to host: 10.100.12.10 port: 8250
2016-08-24 10:42:54,686 INFO  [cloud.agent.Agent] (main:null) (logid:)
Attempted to connect to the server, but received an unexpected
exception, trying again.../


Port is open on the management server, there is no firewall in between.
We found that there was a bug report here:
https://issues.apache.org/jira/browse/CLOUDSTACK-9348. There is a PR
changing the NIO Selector wait time:
https://github.com/apache/cloudstack/pull/1601 which was merged into
master branch.

Since we installed Release 4.9 we probably need to patch the
NioConection.class as described in PR1601 , right?

kvm03# unzip -v /usr/share/cloudstack-agent/lib/cloud-utils-4.9.0.jar  |
grep NioConnection
3923  Defl:N 1778  55% 2016-08-02 09:28 05aaf7d5
com/cloud/utils/nio/NioConnection$1.class
 881  Defl:N  495  44% 2016-08-02 09:28 e378984c
com/cloud/utils/nio/NioConnection$ChangeRequest.class
   15410  Defl:N 7130  54% 2016-08-02 09:28 b3281f5a
com/cloud/utils/nio/NioConnection.class
1134  Defl:N  584  49% 2016-08-02 09:28 8d5cb4a8
com/cloud/utils/exception/NioConnectionException.class

Due to a lack of java expertise we have some basic questions:
- Is there a patched jar file available ? public build server?
- Do we need to create 

[GitHub] cloudstack issue #1660: CLOUDSTACK-9470: [BLOCKER] Fix for test_network_acl,...

2016-08-24 Thread serg38
Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1660
  
Also we wrote a tester for SshHelper.sshExecute method. It was returning 
output of SSHexecute command as it gets received by sshExecute. Here they are 
100 sequential runs (success if result is 100) :
Before the fix:

[root@ussarlabcsmgt41 t_vazqnadmin]# for i in `seq 1 100`;do curl 
"http://10.144.31.41:8096/client/api?command=testNicoSSHCommand=10.140.32.220=echo%20success;
 2>/dev/null|head -1|grep success;done|wc -l
## **58**

[root@ussarlabcsmgt41 t_vazqnadmin]# for i in `seq 1 100`;do curl 
"http://10.144.31.41:8096/client/api?command=testNicoSSHCommand=10.140.32.220=pwd;
 2>/dev/null|head -1|grep '/root';done|wc -l
## **49**

[root@ussarlabcsmgt41 t_vazqnadmin]# for i in `seq 1 100`;do curl 
"http://10.144.31.41:8096/client/api?command=testNicoSSHCommand=10.140.32.220=ls%20/proc/sys/net/ipv4/conf;
 2>/dev/null|grep eth;done|wc -l
## **0**


After the fix:
[root@ussarlabcsmgt41 t_vazqnadmin]# for i in `seq 1 100`;do curl 
"http://10.144.31.41:8096/client/api?command=testNicoSSHCommand=10.140.32.220=echo%20success;
 2>/dev/null|head -1|grep success;done|wc -l
## **100**
 
 
[levitssadmin@ussclpdadubh001 ~]$ for i in `seq 1 100`;do curl 
"http://10.144.31.41:8096/client/api?command=testNicoSSHCommand=10.140.32.220=pwd;
 2>/dev/null|head -1|grep '/root';done|wc -l
## **100**
 
[root@ussarlabcsmgt41 t_vazqnadmin]# for i in `seq 1 100`;do curl 
"http://10.144.31.41:8096/client/api?command=testNicoSSHCommand=10.140.32.220=ls%20/proc/sys/net/ipv4/conf;
 2>/dev/null|grep eth0;done|wc -l
## **100**


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1660: CLOUDSTACK-9470: [BLOCKER] Fix for test_network_acl,...

2016-08-24 Thread serg38
Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1660
  
LGTM for the test.
Exception in network_acl_test **before the fix**
[root@ussarlabcsmgt41 cloudstack]# cat /tmp//MarvinLogs//NB313W/results.txt
Test network ACL lists and items in VPC ... === TestName: test_network_acl 
| Status : EXCEPTION ===
ERROR

==
ERROR: Test network ACL lists and items in VPC
--
Traceback (most recent call last):
  File 
"/home/t_vazqnadmin/cloudstack/test/integration/smoke/exclude/test_network_acl.py",
 line 81, in test_network_acl
domainid=self.domain.id
  File "/usr/local/lib/python2.7/site-packages/marvin/lib/base.py", line 
4311, in create
return VPC(apiclient.createVPC(cmd).__dict__)
  File 
"/usr/local/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py",
 line 2210, in createVPC
response = self.connection.marvinRequest(command, 
response_type=response, method=method)
  File 
"/usr/local/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 
379, in marvinRequest
raise e
Exception: Job failed: {jobprocstatus : 0, created : 
u'2016-08-24T05:52:23-0700', jobresult : {errorcode : 530, errortext : u'Failed 
to create VPC'}, cmd : 
u'org.apache.cloudstack.api.command.admin.vpc.CreateVPCCmdByAdmin', userid : 
u'd557133a-3fcc-11e5-9c45-005056ad45b7', jobstatus : 2, jobid : 
u'bc8fb5de-94de-43bf-befd-a2b450ab571c', jobresultcode : 530, jobresulttype : 
u'object', jobinstancetype : u'None', accountid : 
u'd556f1dc-3fcc-11e5-9c45-005056ad45b7'}
 >> begin captured stdout << -
=== TestName: test_network_acl | Status : EXCEPTION ===


- >> end captured stdout << --
. (NOT INCLUDED)
 >> begin captured logging << 


- >> end captured logging << -

--
Ran 1 test in 115.185s

FAILED (errors=1)

**After fix is deployed:**

[root@ussarlabcsmgt41 Aug_23_2016_16_49_32_8HYYKG]# tail results.txt
Test network ACL lists and items in VPC ... === TestName: test_network_acl 
| Status : SUCCESS ===
ok
 
--
Ran 1 test in 211.968s
 
OK
 
 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: CS 4.9 NIO Selector wait time PR-1601

2016-08-24 Thread Will Stevens
That PR is already merged, so you don't have to do anything to get that
code, you already have it.

@rohit, can you review this?  I think this is a similar to the issue Simon
reported earlier.

Will

On Aug 24, 2016 6:56 AM, "fanfarlo"  wrote:

> hi all
>
> We have the following environment:
> - OS: Debian 14.04 (hypervisors and management)
> - 4 KVM Hosts
> - Cloudstack Release 4.9 with local database
>
> Since we upgraded to Release 4.9 the KVM hosts no longer connect to the
> management Server. Upgrade procedure was followed as described:
> http://docs.cloudstack.apache.org/projects/cloudstack-
> release-notes/en/4.9.0/upgrade/upgrade-4.8.html
>
>
> On the KVM hosts we have the following error message:
> /2016-08-24 10:42:49,678 INFO  [utils.exception.CSExceptionErrorCode]
> (main:null) (logid:) Could not find exception:
> com.cloud.utils.exception.NioConnectionException in error code list for
> exceptions
> 2016-08-24 10:42:49,678 WARN  [cloud.agent.Agent] (main:null) (logid:)
> NIO Connection Exception
> com.cloud.utils.exception.NioConnectionException: SSL Handshake failed
> while connecting to host: 10.100.12.10 port: 8250
> 2016-08-24 10:42:49,678 INFO  [cloud.agent.Agent] (main:null) (logid:)
> Attempted to connect to the server, but received an unexpected
> exception, trying again...
> 2016-08-24 10:42:54,679 INFO  [utils.nio.NioClient] (main:null) (logid:)
> Connecting to 10.100.12.10:8250
> 2016-08-24 10:42:54,684 WARN  [utils.nio.Link] (main:null) (logid:) This
> SSL engine was forced to close inbound due to end of stream.
> 2016-08-24 10:42:54,684 ERROR [utils.nio.NioClient] (main:null) (logid:)
> SSL Handshake failed while connecting to host: 10.100.12.10 port: 8250
> 2016-08-24 10:42:54,685 ERROR [utils.nio.NioConnection] (main:null)
> (logid:) Unable to initialize the threads.
> java.io.IOException: SSL Handshake failed while connecting to host:
> 10.100.12.10 port: 8250
> at com.cloud.utils.nio.NioClient.init(NioClient.java:67)
> at com.cloud.utils.nio.NioConnection.start(NioConnection.java:88)
> at com.cloud.agent.Agent.start(Agent.java:237)
> at com.cloud.agent.AgentShell.launchAgent(AgentShell.java:399)
> at
> com.cloud.agent.AgentShell.launchAgentFromClassInfo(AgentShell.java:367)
> at com.cloud.agent.AgentShell.launchAgent(AgentShell.java:351)
> at com.cloud.agent.AgentShell.start(AgentShell.java:456)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:
> 57)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(
> DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at
> org.apache.commons.daemon.support.DaemonLoader.start(
> DaemonLoader.java:243)
> 2016-08-24 10:42:54,685 INFO  [utils.exception.CSExceptionErrorCode]
> (main:null) (logid:) Could not find exception:
> com.cloud.utils.exception.NioConnectionException in error code list for
> exceptions
> 2016-08-24 10:42:54,685 WARN  [cloud.agent.Agent] (main:null) (logid:)
> NIO Connection Exception
> com.cloud.utils.exception.NioConnectionException: SSL Handshake failed
> while connecting to host: 10.100.12.10 port: 8250
> 2016-08-24 10:42:54,686 INFO  [cloud.agent.Agent] (main:null) (logid:)
> Attempted to connect to the server, but received an unexpected
> exception, trying again.../
>
>
> Port is open on the management server, there is no firewall in between.
> We found that there was a bug report here:
> https://issues.apache.org/jira/browse/CLOUDSTACK-9348. There is a PR
> changing the NIO Selector wait time:
> https://github.com/apache/cloudstack/pull/1601 which was merged into
> master branch.
>
> Since we installed Release 4.9 we probably need to patch the
> NioConection.class as described in PR1601 , right?
>
> kvm03# unzip -v /usr/share/cloudstack-agent/lib/cloud-utils-4.9.0.jar  |
> grep NioConnection
> 3923  Defl:N 1778  55% 2016-08-02 09:28 05aaf7d5
> com/cloud/utils/nio/NioConnection$1.class
>  881  Defl:N  495  44% 2016-08-02 09:28 e378984c
> com/cloud/utils/nio/NioConnection$ChangeRequest.class
>15410  Defl:N 7130  54% 2016-08-02 09:28 b3281f5a
> com/cloud/utils/nio/NioConnection.class
> 1134  Defl:N  584  49% 2016-08-02 09:28 8d5cb4a8
> com/cloud/utils/exception/NioConnectionException.class
>
> Due to a lack of java expertise we have some basic questions:
> - Is there a patched jar file available ? public build server?
> - Do we need to create the jar from sources ? procedure?
> - How do we apply the patch ?
>
> many thanks!
> fanfarlo
>


[GitHub] cloudstack pull request #1660: CLOUDSTACK-9470: [BLOCKER] Fix for test_netwo...

2016-08-24 Thread nvazquez
GitHub user nvazquez opened a pull request:

https://github.com/apache/cloudstack/pull/1660

CLOUDSTACK-9470: [BLOCKER] Fix for test_network_acl, SshHelper

## Problem
In a Vmware environment, running `test_network_acl` we examined why 
sometimes it failed and sometimes it passed. It was discovered that issue was 
on `VmwareResource`:

```java
private int findRouterEthDeviceIndex(String domrName, String routerIp, 
String mac) throws Exception {
VmwareManager mgr = 
getServiceContext().getStockObject(VmwareManager.CONTEXT_STOCK_NAME);

s_logger.info("findRouterEthDeviceIndex. mac: " + mac);

// TODO : this is a temporary very inefficient solution, will 
refactor it later
Pair result = SshHelper.sshExecute(routerIp, 
DefaultDomRSshPort, "root", mgr.getSystemVMKeyFile(), null, "ls 
/proc/sys/net/ipv4/conf");
...
}
```

Command sent to router returned a pair which its first parameter was always 
true but second parameter sometimes it was null and sometimes the correct 
output for given command.

## Solution
Examining `SshHelper` we discovered that cases in which second parameter in 
result was null, didn't consume stdout properly

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nvazquez/cloudstack sshhelperissue

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1660.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1660


commit ade0a795e51bdceb65311d9e8bcc81853335ffe5
Author: nvazquez 
Date:   2016-08-24T12:32:55Z

CLOUDSTACK-9470: Fix for SshHelper




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: JuniperSRX firewall configure plugin source bug

2016-08-24 Thread Will Stevens
Hey Gust,
Here are the details for contributing.

https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md

You need to fork cloudstack and the the change in your fork. Then you
create a pull request from your fork to ACS.

Let us know if you have problems following that guide.

Cheers,

Will

On Aug 24, 2016 4:09 AM, "Gust"  wrote:

>
> Hi, Jayapal
>
> why not submit a PR, in github desktop prompt:
>
> You may not have permission to access cloudstack. Check Preferences to
> make sure you’re still logged in.
>
> I ensure i loved in.
>
>
>
> > 在 2016年8月24日,12:52,Jayapal Uradi > 写道:
> >
> > Hi Gust,
> >
> > The changes look good  please go head and raise a PR for it.
> >
> > Thanks,
> > Jayapal
> >> On Aug 24, 2016, at 8:14 AM, Gust > wrote:
> >>
> >> Hi , all
> >>
> >> There is a bug in com.cloud.network.resource.JuniperSrxResource
> >>
> >> It will report syntax error when configure  outgress rule to Juniper
> srx hardware firewall.
> >>
> >>
> >> begin line 2830 :
> >>
> >>   if (type.equals(SecurityPolicyType.
> SECURITYPOLICY_EGRESS_DEFAULT)) {
> >>   if (defaultEgressAction == false) {
> >>   //for default policy is false add default
> deny rules
> >>   action = "";
> >>   } else {
> >>   action = "";
> >>   }
> >>
> >>   } else {
> >>   if (defaultEgressAction == true) {
> >>   //configure egress rules to deny the traffic
> when default egress is allow
> >>   action = "";
> >>   } else {
> >>   action = "";
> >>   }
> >> //error here
> >>   xml = replaceXmlValue(xml, "action", action);
> >>
> >>   }
> >>
> >> fix:
> >>
> >>   if (type.equals(SecurityPolicyType.
> SECURITYPOLICY_EGRESS_DEFAULT)) {
> >>   if (defaultEgressAction == false) {
> >>   //for default policy is false add default
> deny rules
> >>   action = "";
> >>   } else {
> >>   action = "";
> >>   }
> >>
> >>   } else {
> >>   if (defaultEgressAction == true) {
> >>   //configure egress rules to deny the traffic
> when default egress is allow
> >>   action = "";
> >>   } else {
> >>   action = "";
> >>   }
> >>   }
> >> //move replace  out
> >>   xml = replaceXmlValue(xml, "action", action);
> >>
> >>
> >>
> >> gust
> >>
> >> Being china.
> >> 2016-08-24
> >>
> >>
> >>
> >>
> >
> >
> >
> >
> > DISCLAIMER
> > ==
> > This e-mail may contain privileged and confidential information which is
> the property of Accelerite, a Persistent Systems business. It is intended
> only for the use of the individual or entity to which it is addressed. If
> you are not the intended recipient, you are not authorized to read, retain,
> copy, print, distribute or use this message. If you have received this
> communication in error, please notify the sender and delete all copies of
> this message. Accelerite, a Persistent Systems business does not accept any
> liability for virus infected mails.
>
>


[GitHub] cloudstack issue #1645: On snapshot backup, this converts the rbd raw format...

2016-08-24 Thread nathanejohnson
Github user nathanejohnson commented on the issue:

https://github.com/apache/cloudstack/pull/1645
  
@jburwell 

I'm hoping that I can spend a good part of today on the requests you've 
made on my three open pull requests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...

2016-08-24 Thread vincentbernat
Github user vincentbernat commented on the issue:

https://github.com/apache/cloudstack/pull/1647
  
Otherwise, I think the change to be compatible with 12.04 is OK (no Upstart 
script should ever be provided in this case).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...

2016-08-24 Thread vincentbernat
Github user vincentbernat commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1647#discussion_r76039128
  
--- Diff: debian/rules ---
@@ -5,18 +5,9 @@ PACKAGE = $(shell dh_listpackages|head -n 1|cut -d '-' -f 
1)
 SYSCONFDIR = "/etc"
 DESTDIR = "debian/tmp"
 
-ifeq ($(shell lsb_release -sr), 14.04)
-SUBSTVARS = -Vjre:Depends="openjdk-7-jre-headless" 
-Vjdk:Depends="openjdk-7-jdk" -Vinit:"Depends:jsvc"
-else
-SUBSTVARS = -Vjre:Depends="openjdk-8-jre-headless" 
-Vjdk:Depends="openjdk-8-jdk" -Vinit:"Depends:systemd"
-endif
-
--- End diff --

I would have kept something like that but using init-system-helpers instead 
of systemd. It is not unheard of for people to not install recommends. However, 
init-system-helpers is likely to be installed on the target system already 
(since everything that comes with a systemd unit pulls it). So, it's a bit 
nitpicking.

About Java, you can change the dependency to:

```
default-jre-headless (>= 1:1.8) | java8-runtime-headless | java8-runtime
```

This would enable people to use Oracle JRE instead. Most packages for 
non-OpenJDK JRE are providing `java8-runtime-headless` or `java8-runtime`. For 
JDK, this would be:

```
default-jdk-headless (>= 1:1.8) | java8-sdk | java8-jdk
```

The normal virtual package is `java8-sdk` but some unofficial packages are 
using `java8-jdk` instead.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1640: CLOUDSTACK-9458: Fix HA bug when VMs are stopped on ...

2016-08-24 Thread marcaurele
Github user marcaurele commented on the issue:

https://github.com/apache/cloudstack/pull/1640
  
@koushik-das which is IMHO wrong.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...

2016-08-24 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1647
  
@wido actually on a fresh system it would first attempt to find and install 
openjdk8, on existing ones if openjdk7 is installed then it won't force 
openjdk8 by default. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...

2016-08-24 Thread wido
Github user wido commented on the issue:

https://github.com/apache/cloudstack/pull/1647
  
@rhtyd Seems good, but it would still not force the install of Java 8 on 
Ubuntu 16.04

However, I don't think that's a blocker.

LGTM for me


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


CS 4.9 NIO Selector wait time PR-1601

2016-08-24 Thread fanfarlo
hi all

We have the following environment:
- OS: Debian 14.04 (hypervisors and management)
- 4 KVM Hosts
- Cloudstack Release 4.9 with local database

Since we upgraded to Release 4.9 the KVM hosts no longer connect to the
management Server. Upgrade procedure was followed as described:
http://docs.cloudstack.apache.org/projects/cloudstack-release-notes/en/4.9.0/upgrade/upgrade-4.8.html


On the KVM hosts we have the following error message:
/2016-08-24 10:42:49,678 INFO  [utils.exception.CSExceptionErrorCode]
(main:null) (logid:) Could not find exception:
com.cloud.utils.exception.NioConnectionException in error code list for
exceptions
2016-08-24 10:42:49,678 WARN  [cloud.agent.Agent] (main:null) (logid:)
NIO Connection Exception 
com.cloud.utils.exception.NioConnectionException: SSL Handshake failed
while connecting to host: 10.100.12.10 port: 8250
2016-08-24 10:42:49,678 INFO  [cloud.agent.Agent] (main:null) (logid:)
Attempted to connect to the server, but received an unexpected
exception, trying again...
2016-08-24 10:42:54,679 INFO  [utils.nio.NioClient] (main:null) (logid:)
Connecting to 10.100.12.10:8250
2016-08-24 10:42:54,684 WARN  [utils.nio.Link] (main:null) (logid:) This
SSL engine was forced to close inbound due to end of stream.
2016-08-24 10:42:54,684 ERROR [utils.nio.NioClient] (main:null) (logid:)
SSL Handshake failed while connecting to host: 10.100.12.10 port: 8250
2016-08-24 10:42:54,685 ERROR [utils.nio.NioConnection] (main:null)
(logid:) Unable to initialize the threads.
java.io.IOException: SSL Handshake failed while connecting to host:
10.100.12.10 port: 8250
at com.cloud.utils.nio.NioClient.init(NioClient.java:67)
at com.cloud.utils.nio.NioConnection.start(NioConnection.java:88)
at com.cloud.agent.Agent.start(Agent.java:237)
at com.cloud.agent.AgentShell.launchAgent(AgentShell.java:399)
at
com.cloud.agent.AgentShell.launchAgentFromClassInfo(AgentShell.java:367)
at com.cloud.agent.AgentShell.launchAgent(AgentShell.java:351)
at com.cloud.agent.AgentShell.start(AgentShell.java:456)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at
org.apache.commons.daemon.support.DaemonLoader.start(DaemonLoader.java:243)
2016-08-24 10:42:54,685 INFO  [utils.exception.CSExceptionErrorCode]
(main:null) (logid:) Could not find exception:
com.cloud.utils.exception.NioConnectionException in error code list for
exceptions
2016-08-24 10:42:54,685 WARN  [cloud.agent.Agent] (main:null) (logid:)
NIO Connection Exception 
com.cloud.utils.exception.NioConnectionException: SSL Handshake failed
while connecting to host: 10.100.12.10 port: 8250
2016-08-24 10:42:54,686 INFO  [cloud.agent.Agent] (main:null) (logid:)
Attempted to connect to the server, but received an unexpected
exception, trying again.../


Port is open on the management server, there is no firewall in between.
We found that there was a bug report here:
https://issues.apache.org/jira/browse/CLOUDSTACK-9348. There is a PR
changing the NIO Selector wait time:
https://github.com/apache/cloudstack/pull/1601 which was merged into
master branch.

Since we installed Release 4.9 we probably need to patch the
NioConection.class as described in PR1601 , right?

kvm03# unzip -v /usr/share/cloudstack-agent/lib/cloud-utils-4.9.0.jar  |
grep NioConnection
3923  Defl:N 1778  55% 2016-08-02 09:28 05aaf7d5 
com/cloud/utils/nio/NioConnection$1.class
 881  Defl:N  495  44% 2016-08-02 09:28 e378984c 
com/cloud/utils/nio/NioConnection$ChangeRequest.class
   15410  Defl:N 7130  54% 2016-08-02 09:28 b3281f5a 
com/cloud/utils/nio/NioConnection.class
1134  Defl:N  584  49% 2016-08-02 09:28 8d5cb4a8 
com/cloud/utils/exception/NioConnectionException.class

Due to a lack of java expertise we have some basic questions:
- Is there a patched jar file available ? public build server?
- Do we need to create the jar from sources ? procedure?
- How do we apply the patch ?

many thanks!
fanfarlo


[GitHub] cloudstack pull request #1659: CLOUDSTACK-9339 Virtual Routers don't handle ...

2016-08-24 Thread murali-reddy
GitHub user murali-reddy opened a pull request:

https://github.com/apache/cloudstack/pull/1659

CLOUDSTACK-9339 Virtual Routers don't handle Multiple Public Interfaces 
correctly for non-vpc networks

As pointed out in CLOUDSTACK-9339, in case of multiple public IP's from 
different public IP ranges are associated with VR, VR functionality is broken. 
Below are the brief list of problems specific to non VPC networks addressed in 
the PR.

- revere traffic for the connections accepted on the eth3 and above public 
interfaces are getting blocked. Need a rule for e.g "-A FORWARD -i  eth3 -o 
eth0 -m state --state RELATED,ESTABLISHED -j ACCEPT" in the filter table to 
permit reverse path traffic

- outbound public traffic from eth0 to eth3 (and above) needs rule to run 
through FW_OUTBOUND chain in the filter table

- network stats on public interfaces eth3 are getting gathered

- default gateway is missing in the device specific routing table, 
resulting in traffic to be looked up in main routing table

- reating a device specific route table is generating "from all lookup 
Table_eth3" in the
ip rules, resulting in traffic getting blocked.

Picked few commits from #1519 from dsclose 
(https://github.com/apache/cloudstack/pull/1519) submitted for 4.7

Marvin tests are added to test below

- Static NAT works on the public interfaces above eth2, in case non-vpc 
networks
- Portforwarding works on the public interfaces above eth2, in case non-vpc 
networks
- Route tables are configured as expected for the device specific table for 
the public interfaces above eth2, in case non-vpc networks
- IP tables rules are as expected for the traffic from and to the public 
interfaces above eth2, in case non-vpc networks



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/murali-reddy/cloudstack 
multiple_public_ip_ranges_non_vpc

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1659.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1659


commit af55d84a0954a50d88387660a47c5eb3be09c8c0
Author: dean.close 
Date:   2016-04-27T09:08:23Z

CLOUDSTACK-9339: Allow forwarding and collect network stats on any public 
interface.

commit 7a2334d5c642a61f9275da240f834411ece5ced1
Author: Murali Reddy 
Date:   2016-08-23T21:41:36Z

only mark packets arriving on public interfaces. On guest networ interfaces
mark only when they are part of static nat. this will ensure device specific
routing table will be used

commit e85a638c751c8c5fab234176c1772e22a16d4431
Author: dean.close 
Date:   2016-04-27T08:49:25Z

CLOUDSTACK-9339: Add default gateway to device-specific routing tables.

commit fa2d3332b6b953341604091c005bec64224585c9
Author: Murali Reddy 
Date:   2016-08-23T21:46:04Z

smoke tests for multiple public ip ranges for non-vpc network scenarios




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1658: Added an additional JSON diff output to the ApiXmlDo...

2016-08-24 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1658
  
Great idea, LGTM (based on the api-changes urls). @swill can we also sort 
the list of new APIs by name.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...

2016-08-24 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1647
  
@vincentbernat I made some changes, built packages and was able to install 
and run agent and usage server on both Ubuntu 12.04, 14.04 using the same 
packages. 
@wido @vincentbernat can you review my change and if it's okay, based on 
installation tests we can merge this.

Additional notes: on fresh installation the /etc/default/cloudstack-{agent, 
usage} files use JAVA_HOME path for 1.8 jre which does not exist and needed 
manually fixing. This was the only thing I had to do and can be documented in 
install/upgrade and release notes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1511: 4.9/master bountycastle changes

2016-08-24 Thread bvbharatk
Github user bvbharatk commented on the issue:

https://github.com/apache/cloudstack/pull/1511
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 50
 Hypervisor xenserver
 NetworkType Advanced
 Passed=100
 Failed=1
 Skipped=3

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**
* test_non_contigiousvlan.py

 * test_extendPhysicalNetworkVlan Failing since 4 runs


**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_ssvm.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1640: CLOUDSTACK-9458: Fix HA bug when VMs are stopped on ...

2016-08-24 Thread koushik-das
Github user koushik-das commented on the issue:

https://github.com/apache/cloudstack/pull/1640
  
@marcaurele 

> What is the reason to try fencing off VMs when the MS is not able to 
determine its state? I cannot see a good reason so far but you seem to think 
there is at least one. Can you explain it?

If MS is able to determine VM state as up or down why do you need fencing? 
Fencing is tried only when the state cannot be determined.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1651: Marvin Tests: fix expected return string for success...

2016-08-24 Thread koushik-das
Github user koushik-das commented on the issue:

https://github.com/apache/cloudstack/pull/1651
  
@rhtyd Please go through #1563 as mentioned in my previous comment to get 
the context. As @serg38 also mentioned the response differs between debian and 
centos which needs to be addressed, leave aside osx. Also the comment about 
"100% packet loss" needs to be addressed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...

2016-08-24 Thread vincentbernat
Github user vincentbernat commented on the issue:

https://github.com/apache/cloudstack/pull/1647
  
it is not possible to have systemd support and build on 12.04 at the same 
time. dh-systemd doesn't exist on 12.04 and its actions are quite important. If 
you remove it and just install the units manually, they won't start on boot or 
on upgrade.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

2016-08-24 Thread NuxRo
Github user NuxRo commented on the issue:

https://github.com/apache/cloudstack/pull/1653
  
Understood, thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: JuniperSRX firewall configure plugin source bug

2016-08-24 Thread Gust

Hi, Jayapal 

why not submit a PR, in github desktop prompt:

You may not have permission to access cloudstack. Check Preferences to make 
sure you’re still logged in.

I ensure i loved in.



> 在 2016年8月24日,12:52,Jayapal Uradi  > 写道:
> 
> Hi Gust,
> 
> The changes look good  please go head and raise a PR for it.
> 
> Thanks,
> Jayapal
>> On Aug 24, 2016, at 8:14 AM, Gust > > wrote:
>> 
>> Hi , all
>> 
>> There is a bug in com.cloud.network.resource.JuniperSrxResource
>> 
>> It will report syntax error when configure  outgress rule to Juniper srx 
>> hardware firewall.
>> 
>> 
>> begin line 2830 :
>> 
>>   if 
>> (type.equals(SecurityPolicyType.SECURITYPOLICY_EGRESS_DEFAULT)) {
>>   if (defaultEgressAction == false) {
>>   //for default policy is false add default deny 
>> rules
>>   action = "";
>>   } else {
>>   action = "";
>>   }
>> 
>>   } else {
>>   if (defaultEgressAction == true) {
>>   //configure egress rules to deny the traffic when 
>> default egress is allow
>>   action = "";
>>   } else {
>>   action = "";
>>   }
>> //error here
>>   xml = replaceXmlValue(xml, "action", action);
>> 
>>   }
>> 
>> fix:
>> 
>>   if 
>> (type.equals(SecurityPolicyType.SECURITYPOLICY_EGRESS_DEFAULT)) {
>>   if (defaultEgressAction == false) {
>>   //for default policy is false add default deny 
>> rules
>>   action = "";
>>   } else {
>>   action = "";
>>   }
>> 
>>   } else {
>>   if (defaultEgressAction == true) {
>>   //configure egress rules to deny the traffic when 
>> default egress is allow
>>   action = "";
>>   } else {
>>   action = "";
>>   }
>>   }
>> //move replace  out
>>   xml = replaceXmlValue(xml, "action", action);
>> 
>> 
>> 
>> gust
>> 
>> Being china.
>> 2016-08-24
>> 
>> 
>> 
>> 
> 
> 
> 
> 
> DISCLAIMER
> ==
> This e-mail may contain privileged and confidential information which is the 
> property of Accelerite, a Persistent Systems business. It is intended only 
> for the use of the individual or entity to which it is addressed. If you are 
> not the intended recipient, you are not authorized to read, retain, copy, 
> print, distribute or use this message. If you have received this 
> communication in error, please notify the sender and delete all copies of 
> this message. Accelerite, a Persistent Systems business does not accept any 
> liability for virus infected mails.



[GitHub] cloudstack issue #1652: Marvin Tests: Fix VPC network offering selection .

2016-08-24 Thread fmaximus
Github user fmaximus commented on the issue:

https://github.com/apache/cloudstack/pull/1652
  
I will make the change. I also plan to only create the vpc offering if 
there are Nuage VSP devices configured, which makes more sense for the users of 
CloudStack that do not use our plugin.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...

2016-08-24 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1647
  
Thanks @wido that makes sense.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...

2016-08-24 Thread rhtyd
Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1647#discussion_r76007356
  
--- Diff: debian/rules ---
@@ -5,8 +5,17 @@ PACKAGE = $(shell dh_listpackages|head -n 1|cut -d '-' -f 
1)
 SYSCONFDIR = "/etc"
 DESTDIR = "debian/tmp"
 
+ifeq ($(shell lsb_release -sr), 14.04)
+SUBSTVARS = -Vjre:Depends="openjdk-7-jre-headless" 
-Vjdk:Depends="openjdk-7-jdk" -Vinit:"Depends:jsvc"
+else
+SUBSTVARS = -Vjre:Depends="openjdk-8-jre-headless" 
-Vjdk:Depends="openjdk-8-jdk" -Vinit:"Depends:systemd"
--- End diff --

Thanks @wido I'll try to build experimental packages to test if it just 
might work.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1657: [lts/blocker] CLOUDSTACK-9467: Add symlink to...

2016-08-24 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1657


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1656: CLOUDSTACK-9466: Fix fk constraint failure in...

2016-08-24 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1656


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1656: CLOUDSTACK-9466: Fix fk constraint failure in upgrad...

2016-08-24 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1656
  
Thanks @serg38 @abhinandanprateek for the review. With enough lgtms and 
(manual) test result against a large pre-4.1 db, I'll proceed with merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1657: [lts/blocker] CLOUDSTACK-9467: Add symlink to key fi...

2016-08-24 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1657
  
Thanks @abhinandanprateek @serg38  for the review. With enough lgtms and 
travis/manual tests, I'll merge this (failing Travis tests are not due to this 
change, but due to a tearDown issue). 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...

2016-08-24 Thread wido
Github user wido commented on the issue:

https://github.com/apache/cloudstack/pull/1647
  
@rhtyd When this one merges and is merged forward I will send a PR for 
master to remove 12.04 support.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...

2016-08-24 Thread wido
Github user wido commented on the issue:

https://github.com/apache/cloudstack/pull/1647
  
@rhtyd Why another PR for against master? I thought we were merging forward?

This stuff is really starting to confuse me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...

2016-08-24 Thread wido
Github user wido commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1647#discussion_r76006449
  
--- Diff: debian/rules ---
@@ -5,8 +5,17 @@ PACKAGE = $(shell dh_listpackages|head -n 1|cut -d '-' -f 
1)
 SYSCONFDIR = "/etc"
 DESTDIR = "debian/tmp"
 
+ifeq ($(shell lsb_release -sr), 14.04)
+SUBSTVARS = -Vjre:Depends="openjdk-7-jre-headless" 
-Vjdk:Depends="openjdk-7-jdk" -Vinit:"Depends:jsvc"
+else
+SUBSTVARS = -Vjre:Depends="openjdk-8-jre-headless" 
-Vjdk:Depends="openjdk-8-jdk" -Vinit:"Depends:systemd"
--- End diff --

That might be possible, I am not sure. I think we could do it. Haven't 
tried that.

I'm however very, very short on time these weeks, so I won't be able to 
work on it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1656: CLOUDSTACK-9466: Fix fk constraint failure in upgrad...

2016-08-24 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue:

https://github.com/apache/cloudstack/pull/1656
  
LGTM on code review, the fix is taking care of the removed column, thereby 
maintaining the constraints.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1657: [lts/blocker] CLOUDSTACK-9467: Add symlink to key fi...

2016-08-24 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue:

https://github.com/apache/cloudstack/pull/1657
  
LGTM on code review, this will fix the broken symlink for usage server


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1651: Marvin Tests: fix expected return string for success...

2016-08-24 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1651
  
@PaulAngus please squash you commits, thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1651: Marvin Tests: fix expected return string for success...

2016-08-24 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1651
  
LGTM
@koushik-das All tests are written to be execute on a Linux based 
environment, though if you look at the test it does ssh into the guest VM and 
then executes the ping. Afaik, we don't run osx/mac vms on cloudstack for 
integration testing yet.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1591: Updating Alert codes

2016-08-24 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1591
  
@dcarbone can you squash your commits and rebase against latest, thanks. 
Please also amend git commit message to include the JIRA ID.
@jburwell I did not start my analysis, I'll do that once we've sorted out 
above.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1656: CLOUDSTACK-9466: Fix fk constraint failure in...

2016-08-24 Thread rhtyd
Github user rhtyd closed the pull request at:

https://github.com/apache/cloudstack/pull/1656


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1656: CLOUDSTACK-9466: Fix fk constraint failure in...

2016-08-24 Thread rhtyd
GitHub user rhtyd reopened a pull request:

https://github.com/apache/cloudstack/pull/1656

CLOUDSTACK-9466: Fix fk constraint failure in upgrade path

In the 4.1.0-4.2.0 db upgrade path, it creates new tables to store secondary
(nfs) storage in image_store table and volumes in volume_store_ref table. In
the upgrade path, it first tries to migrate NFS storage pool where it 
excludes
storage pools which have been removed, but it migrates all the volumes 
without
checking if their storage pools have been removed. This causes fk constraint
failure as the volume/row being inserted refers to a storage pool which does
not exist in the image_store table.

The fix migrates all the nfs storage pools to image_store including removed
storage pools and in doing so migrates with the 'removed' field. This fixes
db upgrade for old pre-4.0 and 4.0/4.1 CloudStack clouds.

/cc @jburwell @PaulAngus @karuturi @abhinandanprateek @murali-reddy 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack 4.9-fk410to420fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1656.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1656


commit 7530f4b6dd98c18bceda3e1bf7790c0689ff5441
Author: Rohit Yadav 
Date:   2016-08-23T07:53:18Z

CLOUDSTACK-9466: Fix fk constraint failure in upgrade path

In the 4.1.0-4.2.0 db upgrade path, it creates new tables to store secondary
(nfs) storage in image_store table and volumes in volume_store_ref table. In
the upgrade path, it first tries to migrate NFS storage pool where it 
excludes
storage pools which have been removed, but it migrates all the volumes 
without
checking if their storage pools have been removed. This causes fk constraint
failure as the volume/row being inserted refers to a storage pool which does
not exist in the image_store table.

The fix migrates all the nfs storage pools to image_store including removed
storage pools and in doing so migrates with the 'removed' field. This fixes
db upgrade for old pre-4.0 and 4.0/4.1 CloudStack clouds.

Signed-off-by: Rohit Yadav 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...

2016-08-24 Thread rhtyd
Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1647#discussion_r76004158
  
--- Diff: debian/rules ---
@@ -5,8 +5,17 @@ PACKAGE = $(shell dh_listpackages|head -n 1|cut -d '-' -f 
1)
 SYSCONFDIR = "/etc"
 DESTDIR = "debian/tmp"
 
+ifeq ($(shell lsb_release -sr), 14.04)
+SUBSTVARS = -Vjre:Depends="openjdk-7-jre-headless" 
-Vjdk:Depends="openjdk-7-jdk" -Vinit:"Depends:jsvc"
+else
+SUBSTVARS = -Vjre:Depends="openjdk-8-jre-headless" 
-Vjdk:Depends="openjdk-8-jdk" -Vinit:"Depends:systemd"
--- End diff --

@wido should this be written like:   `-Vinit:Depends="systemd"`. Would it 
be possible to support both systemd/initd environments by adding the dependency 
like `systemd | jsvc` -- this way it would try to install both? On (systemd 
based) Ubuntu 16.04 systemd will be already installed, we can install jsvc for 
all systems -- so why not just depend on jsvc alone? On 14.04, the pkgs can 
continue to use jsvc/initd script and on 16.04 it can uses systemd, both using 
the same packages.

I want us to avoid hosting two separate deb repositories (one for 
non-systemd based and one for systemd based) if possible. Thoughts?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...

2016-08-24 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1647
  
@wido based on the ML discussion, I've removed the specific change that 
removed 12.04 support. Can you send another PR for master for removing support 
for 12.04.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1634: [blocker] CLOUDSTACK-9452: add python-argpars...

2016-08-24 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1634


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1657: [lts/blocker] CLOUDSTACK-9467: Add symlink to key fi...

2016-08-24 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1657
  
@jburwell no this is PR is related to packaging, while 1593 fixes something 
different. The Travis build failure has been fixed at #1648, the failures are 
unrelated to this PR. Since this is a packaging fix, built packages confirm 
that packaging is not broken. Further, Trillian tests confirm regression 
testing (though due to an infra issue the tests have not been commented here).

Manual installation confirmed the fix, usage server started without any 
issue.
># /etc/init.d/cloudstack-usage status
> * cloudstack-usage is running



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1634: [blocker] CLOUDSTACK-9452: add python-argparse depen...

2016-08-24 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1634
  
Merging based on lgtms and test results (the failures are due to env 
issues, and failing tests not related to the pkging fix).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1648: test/integration: fix tearDown order in list_acl_ te...

2016-08-24 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1648
  
@jburwell can you review/lgtm now? thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1656: CLOUDSTACK-9466: Fix fk constraint failure in upgrad...

2016-08-24 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1656
  
There are no upgrade tests to confirm the fix as all the changes are in an 
older 4.1.0->4.2.0 upgrade path. After this fix, here are manual test results 
to show that db upgrade finished cleanly without breaking with foreign key 
constraint issue:

> 2016-08-23 13:55:06,886 DEBUG [c.c.u.d.Upgrade410to420] (main:null) 
(logid:) Migrating secondary storage to image store 
> 2016-08-23 13:55:06,896 DEBUG [c.c.u.d.Upgrade410to420] (main:null) 
(logid:) Checking if we need to migrate NFS secondary storage to image store or 
staging store 
> 2016-08-23 13:55:06,896 DEBUG [c.c.u.d.Upgrade410to420] (main:null) 
(logid:) Migrating NFS secondary storage to Image store 
> 2016-08-23 13:55:06,921 DEBUG [c.c.u.d.Upgrade410to420] (main:null) 
(logid:) Marking NFS secondary storage in host table as removed
> 2016-08-23 13:55:06,934 DEBUG [c.c.u.d.Upgrade410to420] (main:null) 
(logid:) Completed migrating secondary storage to image store 
> 2016-08-23 13:55:06,934 DEBUG [c.c.u.d.Upgrade410to420] (main:null) 
(logid:) Updating volume_store_ref table from volume_host_ref table 
> 2016-08-23 13:55:06,957 DEBUG [c.c.u.d.Upgrade410to420] (main:null) 
(logid:) Insert modified 22 rows
> 2016-08-23 13:55:06,958 DEBUG [c.c.u.d.Upgrade410to420] (main:null) 
(logid:) Update modified 0 rows
> 2016-08-23 13:55:06,958 DEBUG [c.c.u.d.Upgrade410to420] (main:null) 
(logid:) Completed updating volume_store_ref table from volume_host_ref table 
> 2016-08-23 13:55:06,958 DEBUG [c.c.u.d.Upgrade410to420] (main:null) 
(logid:) Updating template_store_ref table from template_host_ref table 
> 2016-08-23 13:55:07,445 DEBUG [c.c.u.d.Upgrade410to420] (main:null) 
(logid:) Insert modified 6622 rows
> 2016-08-23 13:55:07,479 DEBUG [c.c.u.d.Upgrade410to420] (main:null) 
(logid:) Update modified 3666 rows
> 2016-08-23 13:55:07,479 DEBUG [c.c.u.d.Upgrade410to420] (main:null) 
(logid:) Completed updating template_store_ref table from template_host_ref 
table 
> 2016-08-23 13:55:07,479 DEBUG [c.c.u.d.Upgrade410to420] (main:null) 
(logid:) Updating snapshot_store_ref table from snapshots table 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1656: CLOUDSTACK-9466: Fix fk constraint failure in upgrad...

2016-08-24 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1656
  
@jburwell fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---