[GitHub] cloudstack issue #1667: CLOUDSTACK-9481: Convert MyISAM table to InnoDB for ...

2016-08-30 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1667 @rhtyd created another PR for 4.9 https://github.com/apache/cloudstack/pull/1670 --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request #1670: CLOUDSTACK-9481: Convert MyISAM table to Inno...

2016-08-30 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/1670 CLOUDSTACK-9481: Convert MyISAM table to InnoDB for consistency You can merge this pull request into a Git repository by running: $ git pull

Re: Few tables in cloudstack schema use MyISAM engine

2016-08-30 Thread Abhinandan Prateek
Thanks, Koushik. Have created a PR to make the engine type consistent for all tables. InnoDB allows for replication, that is all the more reason that we change the engine type of these few tables to InnoDB. Regards, -abhi PR: https://github.com/apache/cloudstack/pull/1667 From: Koushik Das

[GitHub] cloudstack issue #1669: Make CloudStack JSP-free

2016-08-30 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1669 During build step, the l10n JS files are built: > [INFO] --- exec-maven-plugin:1.2.1:exec (generate-sources) @ cloud-client-ui --- > Exporting compiled dictionary:

[GitHub] cloudstack issue #1667: CLOUDSTACK-9481: Convert MyISAM table to InnoDB for ...

2016-08-30 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1667 LGTM. @abhinandanprateek can you edit the base branch of this PR to 4.9. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request #1663: [LTS/blocker] CLOUDSTACK-6432: Prevent DNS re...

2016-08-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1663 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request #1669: Make CloudStack JSP-free

2016-08-30 Thread rhtyd
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1669 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request #1669: Make CloudStack JSP-free

2016-08-30 Thread rhtyd
GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/1669 Make CloudStack JSP-free CLOUDSTACK-9842: Make UI JSP Free We use some JSP file just for translation of strings in the UI. This is achievable purely in JavaScript. This

[GitHub] cloudstack issue #1663: [LTS/blocker] CLOUDSTACK-6432: Prevent DNS reflectio...

2016-08-30 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1663 Thanks all, based on the test results and reviews from this PR with the marvin test and the original PR #1653 from where the main changes were taken, I'll go ahead and merge this now. --- If

[GitHub] cloudstack pull request #1668: Fixing test_router_dhcp outside ping response...

2016-08-30 Thread borisstoyanov
Github user borisstoyanov closed the pull request at: https://github.com/apache/cloudstack/pull/1668 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack issue #1668: Fixing test_router_dhcp outside ping response as it ...

2016-08-30 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1668 Yes @serg38 you're tight. Closing it now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper affectin...

2016-08-30 Thread nvazquez
Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1660 Thanks @rhtyd! I rebased branch '4.9' and pushed some changes based on your last comment. I had to change visibility of `com.cloud.utils.stringUtils.UTF8` from private to public. I

Re: CCC Brasil

2016-08-30 Thread Will Stevens
Marco, I heard rumors that you were trying to reschedule for November. If that is the case, I would suggest you push the reschedule farther in the future for a couple reasons: - ApacheCon is in November already in Europe so that makes travel to both events very difficult. - People traveling from

ApacheCon Seville CFP closes September 9th

2016-08-30 Thread Rich Bowen
It's traditional. We wait for the last minute to get our talk proposals in for conferences. Well, the last minute has arrived. The CFP for ApacheCon Seville closes on September 9th, which is less than 2 weeks away. It's time to get your talks in, so that we can make this the best ApacheCon yet.

[GitHub] cloudstack issue #1663: [LTS/blocker] CLOUDSTACK-6432: Prevent DNS reflectio...

2016-08-30 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1663 Thanks @borisstoyanov --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1668: Fixing test_router_dhcp outside ping response as it ...

2016-08-30 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1668 @borisstoyanov This PR can be probably closed since the issue with correct ping responses is being addressed globally in PR1651 --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request #1669: Make CloudStack JSP-free

2016-08-30 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1669 Make CloudStack JSP-free CLOUDSTACK-9842: Make UI JSP Free We use some JSP file just for translation of strings in the UI. This is achievable purely in JavaScript. This

[GitHub] cloudstack issue #1663: [LTS/blocker] CLOUDSTACK-6432: Prevent DNS reflectio...

2016-08-30 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1663 LGTM, I was able to build and test the PR. Found a little issue with the tests and fixed it. Here are the tests results: ``` $ nosetests --with-xunit

[GitHub] cloudstack pull request #1621: [CLOUDSTACK-9444] Fix a little issue from PR1...

2016-08-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1621 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack issue #1621: [CLOUDSTACK-9444] Fix a little issue from PR1610 if ...

2016-08-30 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1621 Thanks @milamberspace for the PR, I'll merge it now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

Re: Few tables in cloudstack schema use MyISAM engine

2016-08-30 Thread Koushik Das
I cannot think of any. Most probably in all cases the engine was not explicitly specified and the default got used. As per below default was myisam before mysql 5.5.5. https://dev.mysql.com/doc/refman/5.5/en/storage-engine-setting.html Thanks, Koushik From: Abhinandan Prateek

[GitHub] cloudstack issue #1640: CLOUDSTACK-9458: Fix HA bug when VMs are stopped on ...

2016-08-30 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1640 @marcaurele @koushik-das When the MS thinks that the VM is down, it issues a stop command. This is done to clear up the resources on management server db tied up for that VM. Now it

[GitHub] cloudstack issue #1667: CLOUDSTACK-9481: Convert MyISAM table to InnoDB for ...

2016-08-30 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1667 @abhinandanprateek can you reopen this for 4.9 branch, since it's a bugfix. LTS users should all be on innodb to avoid any replication issues, please also move the changes suitably to

Few tables in cloudstack schema use MyISAM engine

2016-08-30 Thread Abhinandan Prateek
Hi, Was there any specific reason that some tables in cloudstack schema use MyISAM engine. I know of “ quota_account” that I created and put in the diff table type unknowingly. I assume such is the case with other such tables – load_balancer_cert_map, monitoring_services, nic_ip_alias,

[GitHub] cloudstack pull request #1667: CLOUDSTACK-9481: Convert MyISAM table to Inno...

2016-08-30 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/1667 CLOUDSTACK-9481: Convert MyISAM table to InnoDB for consistency You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request #1621: [CLOUDSTACK-9444] Fix a little issue from PR1...

2016-08-30 Thread milamberspace
Github user milamberspace closed the pull request at: https://github.com/apache/cloudstack/pull/1621 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request #1621: [CLOUDSTACK-9444] Fix a little issue from PR1...

2016-08-30 Thread milamberspace
GitHub user milamberspace reopened a pull request: https://github.com/apache/cloudstack/pull/1621 [CLOUDSTACK-9444] Fix a little issue from PR1610 if the db.properties file hasn't EOL c… …haracter at the end of file And some improvements about the dir/file using

[GitHub] cloudstack issue #1665: Changes database upgrade script names to be consiste...

2016-08-30 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1665 With new db schema/versioning and upgrade changes in #1654 we can merge this with some additional changes once #1654 is merged and fwd-merged. --- If your project is set up for it, you can reply

[GitHub] cloudstack issue #1666: CLOUDSTACK-9480: Egress Firewall: Incorrect use of A...

2016-08-30 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1666 LGTM. @jburwell we should have this in 4.9.1.0-RC1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1666: CLOUDSTACK-9480: Egress Firewall: Incorrect use of A...

2016-08-30 Thread murali-reddy
Github user murali-reddy commented on the issue: https://github.com/apache/cloudstack/pull/1666 Test test_07_1_egress_fr7 failure was VM deploy failure. Re-run this particular test again, to enusre it succeeds. --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack issue #1645: On snapshot backup, this converts the rbd raw format...

2016-08-30 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1645 @kiwiflyer That seems good indeed. If we are not setting a source format this looks good indeed. LGTM --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1666: CLOUDSTACK-9480: Egress Firewall: Incorrect use of A...

2016-08-30 Thread murali-reddy
Github user murali-reddy commented on the issue: https://github.com/apache/cloudstack/pull/1666 @JayapalUradi could you please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request #1666: CLOUDSTACK-9480: Egress Firewall: Incorrect u...

2016-08-30 Thread murali-reddy
GitHub user murali-reddy opened a pull request: https://github.com/apache/cloudstack/pull/1666 CLOUDSTACK-9480: Egress Firewall: Incorrect use of Allow/Deny for ICMP When 'default egress policy' is set to 'allow' in the network offering, any egress rule that is added will 'deny'

[GitHub] cloudstack issue #1654: Updating pom.xml version numbers for release 4.8.2.0...

2016-08-30 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1654 @jburwell I've fixed the issue failing db upgrade, it was a minor comparison issue in the beginning of the upgrade process. On my local env the upgrade worked as expected. LGTM. --- If your

[GitHub] cloudstack issue #1636: Fix a quote issue with Spanish L10N (from transifex ...

2016-08-30 Thread milamberspace
Github user milamberspace commented on the issue: https://github.com/apache/cloudstack/pull/1636 Thanks for reply @rhtyd I will wait the merge of #1654 before force to re-check this PR by travis/jenkins --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1654: Updating pom.xml version numbers for release 4.8.2.0...

2016-08-30 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1654 @rhtyd I have updated this patch to properly support four position version numbers, as well as, remove the requirement that all versions have a ``DbUpgrade`` class defined and/or an upgrade