[GitHub] cloudstack issue #1939: CLOUDSTACK-8886: Limitations is listUsageRecords out...

2017-02-13 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1939 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1939: CLOUDSTACK-8886: Limitations is listUsageRecords out...

2017-02-13 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1939 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request #1907: Fix public IPs not being removed from the VR ...

2017-02-13 Thread ustcweizhou
Github user ustcweizhou commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1907#discussion_r100969281 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py --- @@ -659,7 +663,10 @@ def is_guest_gateway(self, bag, ip): gw

[GitHub] cloudstack issue #1741: Updated StrongSwan VPN Implementation

2017-02-13 Thread deepthimachiraju
Github user deepthimachiraju commented on the issue: https://github.com/apache/cloudstack/pull/1741 @swill Would do some basic testing of the PR and update the results. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

2017-02-13 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1727 @karuturi This one is ready for merging. Two LGTMs + tests passing on all 3 hypervisors --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack issue #1918: Management Server UI (VM statistics page) CPU Utiliz...

2017-02-13 Thread jayakarteek
Github user jayakarteek commented on the issue: https://github.com/apache/cloudstack/pull/1918 HI raferweingartner, nvazquez, Yes as specified in mail, The issue is specific to VMware. --JayaKarteek From: Nicolas Vazquez

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

2017-02-13 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1727 Trillian test result (tid-817) Environment: vmware-60u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43428 seconds Marvin logs:

Re: PRs for 4.10

2017-02-13 Thread Will Stevens
Not sure, I will see if I can find some time tomorrow to look at this. Thanks... *Will STEVENS* Lead Developer On Mon, Feb 13, 2017 at 11:58 PM, Rajani Karuturi wrote: > Thanks Will. I will take a look at this today and merge. > > Is it possible to

Re: PRs for 4.10

2017-02-13 Thread Rajani Karuturi
Thanks Will. I will take a look at this today and merge. Is it possible to add a systemvmtemplate job on builds.apachecloudstack.net (https://builds.cloudstack.org/) similar to http://jenkins.buildacloud.org/job/build-systemvm64-master/ ? Thanks, ~ Rajani http://cloudplatform.accelerite.com/

[GitHub] cloudstack issue #1860: CLOUDSTACK-9703: Fixed Start VM does not honor clust...

2017-02-13 Thread cloudmonger
Github user cloudmonger commented on the issue: https://github.com/apache/cloudstack/pull/1860 ### ACS CI BVT Run **Sumarry:** Build Number 320 Hypervisor xenserver NetworkType Advanced Passed=104 Failed=0 Skipped=7 _Link to logs Folder

[GitHub] cloudstack issue #1939: CLOUDSTACK-8886: Limitations is listUsageRecords out...

2017-02-13 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1939 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

2017-02-13 Thread swill
Github user swill commented on the issue: https://github.com/apache/cloudstack-www/pull/34 Beauty. Good job. Thanks for doing that. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack-www issue #25: Updated list with makewholist.py

2017-02-13 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack-www/pull/25 Before this PR reaches its one year of age, I will merge this tomorrow if no one objects. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

2017-02-13 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack-www/pull/34 Merged; the good part is that I followed the new tutorial we developed, and it worked like a charm ;) --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack-www pull request #34: Remove link to “planet.apache.org” and ...

2017-02-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack-www/pull/34 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack issue #1918: Management Server UI (VM statistics page) CPU Utiliz...

2017-02-13 Thread nvazquez
Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1918 Hi @jayakarteek @rafaelweingartner, I confirm issue, I tested using an instance with 1 CPU 500Mhz. I'll add screenshots for cases when CPU utilization is low and high: First,

Re: Build Failure on Master

2017-02-13 Thread Tutkowski, Mike
Thanks! > On Feb 13, 2017, at 2:52 PM, Sergey Levitskiy > wrote: > > Thankfully @rhtyd maintains a repo of all dependencies > >>> > @serg38 I've been maintaining the non-oss libs here: > https://github.com/rhtyd/cloudstack-nonoss >You can get the

[GitHub] cloudstack issue #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC ...

2017-02-13 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack/pull/1878 Hi @sureshanaparti Would you mind extracting the code at lines 1967-1972 to a specific method? Then, it allows you to write test cases for the newly created method and proper

Re: Build Failure on Master

2017-02-13 Thread Sergey Levitskiy
Thankfully @rhtyd maintains a repo of all dependencies >> @serg38 I've been maintaining the non-oss libs here: https://github.com/rhtyd/cloudstack-nonoss You can get the latest v12.1 library that is Java8 compatible from above, it also includes the install-non-oss.sh script, you

Re: Build Failure on Master

2017-02-13 Thread Rafael Weingärtner
Yes, it is. This plugin is not on Maven central repo. You have to install it manually on your local maven repo. On Mon, Feb 13, 2017 at 4:41 PM, Tutkowski, Mike wrote: > Hi, > > I may have missed it in recent e-mails, but is this a known issue and, if > so, how can I

Build Failure on Master

2017-02-13 Thread Tutkowski, Mike
Hi, I may have missed it in recent e-mails, but is this a known issue and, if so, how can I get around it? [ERROR] Failed to execute goal on project cloud-plugin-network-f5: Could not resolve dependencies for project org.apache.cloudstack:cloud-plugin-network-f5:jar:4.10.0.0-SNAPSHOT: Could

[GitHub] cloudstack issue #927: secure and hidden config values are returned as plain...

2017-02-13 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/927 @karuturi Smoke test test_internal_lb.py uses a value of network.loadbalancer.haproxy.stats.auth which is encrypted for haproxy checks. settings["username"],

[GitHub] cloudstack pull request #1907: Fix public IPs not being removed from the VR ...

2017-02-13 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1907#discussion_r100904660 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py --- @@ -659,7 +663,10 @@ def is_guest_gateway(self, bag, ip):

[GitHub] cloudstack pull request #1907: Fix public IPs not being removed from the VR ...

2017-02-13 Thread swill
Github user swill commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1907#discussion_r100902927 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py --- @@ -659,7 +663,10 @@ def is_guest_gateway(self, bag, ip): gw =

[GitHub] cloudstack issue #927: secure and hidden config values are returned as plain...

2017-02-13 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/927 Trillian test result (tid-816) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 34139 seconds Marvin logs:

[GitHub] cloudstack issue #1881: CLOUDSTACK-9721: Remove deprecated/unused global con...

2017-02-13 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack/pull/1881 @sureshanaparti Thanks for the cleanup. LGTM @sateesh-chodapuneedi this is a good question. The changes here remove an attribute of an Enum that is not referenced anywhere. In my

[GitHub] cloudstack issue #1886: CLOUDSTACK-9728: Fixed traffic sentinel HTTP 414 err...

2017-02-13 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack/pull/1886 @jayapalu you changed the request type to `POST`. Is the server side (the bit that will handle/deliver this request) expecting `POST` requests as well? Also, how do you feel

[GitHub] cloudstack pull request #1907: Fix public IPs not being removed from the VR ...

2017-02-13 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1907#discussion_r100897492 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py --- @@ -659,7 +663,10 @@ def is_guest_gateway(self, bag, ip):

[GitHub] cloudstack issue #1918: Management Server UI (VM statistics page) CPU Utiliz...

2017-02-13 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack/pull/1918 @jayakarteek this problem is happening only for VMware, right? @nvazquez could you confirm this problem here? I believe you have access to an ACS system that orchestrates

[GitHub] cloudstack issue #1919: CLOUDSTACK-9763: set ssh public key when creating vm...

2017-02-13 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack/pull/1919 @serbaut I would only like to make a few questions to see if I understood the issue here, before evaluating the code any further. When you first deploy the VM, the keys are

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

2017-02-13 Thread swill
Github user swill commented on the issue: https://github.com/apache/cloudstack-www/pull/34 Yes, I think we are good to go to merge this change. On Mon, Feb 13, 2017 at 1:45 PM, Rafael Weingärtner < notificati...@github.com> wrote: > I agree with you @swill

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

2017-02-13 Thread nvazquez
Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1727 Great, thanks @borisstoyanov! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

2017-02-13 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack-www/pull/34 I agree with you @swill So, if we intend to change this working flow, we will have a detailed discussion somewhere else. Can I assume we ok to go here, and merge this PR?

[GitHub] cloudstack issue #1934: [CLOUDSTACK-9772] Template: perform a HEAD request t...

2017-02-13 Thread remibergsma
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1934 What about signed S3 urls that people may supply? If you want to register a template and have it download from a S3 bucket, you need to specify a signed url to provide the authentication.

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

2017-02-13 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1727 There you go @nvazquez, results should come up in 6-8 hours. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

2017-02-13 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1727 @blueorangutan test centos7 vmware-60u2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

2017-02-13 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1727 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + vmware-60u2) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your

Re: PRs for 4.10

2017-02-13 Thread Will Stevens
At this point, I think 1741 is ready to merge. I think we need one more LGTM though... *Will STEVENS* Lead Developer On Wed, Feb 8, 2017 at 11:32 AM, Will Stevens wrote: > @Daan: In order for the tests to pass with 1741, the tests have to be run

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

2017-02-13 Thread nvazquez
Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1727 Thanks @borisstoyanov! Can we test it against Vmware? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack issue #1934: [CLOUDSTACK-9772] Template: perform a HEAD request t...

2017-02-13 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1934 Trillian test result (tid-815) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 27420 seconds Marvin logs:

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

2017-02-13 Thread swill
Github user swill commented on the issue: https://github.com/apache/cloudstack-www/pull/34 Yes @rafaelweingartner, that is also my concern. It **probably** would be fine because the `.gitignore` would handle the problem cases with the merges (I hope), but it would make it less

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

2017-02-13 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack-www/pull/34 @swill the procedure you described seems to be the way to go. However, as our discussion regarding the Jenkins idea, I am not convinced about the benefits of the change in

[GitHub] cloudstack-www pull request #34: Remove link to “planet.apache.org” and ...

2017-02-13 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack-www/pull/34#discussion_r100827279 --- Diff: content/about.html --- @@ -79,7 +78,7 @@ Get Involved Developers

[GitHub] cloudstack-www pull request #34: Remove link to “planet.apache.org” and ...

2017-02-13 Thread swill
Github user swill commented on a diff in the pull request: https://github.com/apache/cloudstack-www/pull/34#discussion_r100826211 --- Diff: content/about.html --- @@ -79,7 +78,7 @@ Get Involved Developers Mailing

[GitHub] cloudstack-www pull request #34: Remove link to “planet.apache.org” and ...

2017-02-13 Thread pdion891
Github user pdion891 commented on a diff in the pull request: https://github.com/apache/cloudstack-www/pull/34#discussion_r100800298 --- Diff: content/about.html --- @@ -79,7 +78,7 @@ Get Involved Developers Mailing

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

2017-02-13 Thread swill
Github user swill commented on the issue: https://github.com/apache/cloudstack-www/pull/34 So how would this work? We would have a `.gitignore` tracked in `master` which would make the `content` folder untracked? The `.gitignore` tracked in the `asf-site` branch would not include

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

2017-02-13 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack-www/pull/34 Let's change the model but not in this PR ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

2017-02-13 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack-www/pull/34 @pdion891, got your idea; but, for this PR do we keep with the current "working model, versioning the `content` folder in `master` branch" or you would like to change this? --- If

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

2017-02-13 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack-www/pull/34 sorry, so yeah, no html in the PR, only in asf-site when merge is aprouve, than html generated by the commiter merging the PR. make sense? since `content` folder already exist, no need

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

2017-02-13 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack-www/pull/34 @pdion891, you have a double negation in the sentence, but I am reading as "we should not include *.html files in the PR. We should only generate and send them (HTML files) to

[GitHub] cloudstack issue #1818: CLOUDSTACK-9655 The template which is registered in ...

2017-02-13 Thread ustcweizhou
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1818 related to this PR, I doubt the action in deleteTemplate on UI (from a zone). ``` if (!args.context.templates[0].crossZones){

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

2017-02-13 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack-www/pull/34 I haven't follow this whole thread but shouldn't we not include .html files in PR and master branch and only push them in the asf-site branch once approved ? this would make master and PR

[GitHub] cloudstack issue #1885: CLOUDSTACK-9724: Fixed missing additional public ip ...

2017-02-13 Thread ustcweizhou
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1885 The issue can be reproduced and fixed by this PR. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1939: CLOUDSTACK-8886: Limitations is listUsageRecords out...

2017-02-13 Thread ustcweizhou
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1939 code LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cloudstack pull request #1938: CLOUDSTACK-9780: Fixed the default JAVA_HOME ...

2017-02-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1938 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack issue #1938: CLOUDSTACK-9780: Fixed the default JAVA_HOME value t...

2017-02-13 Thread karuturi
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1938 good point @swill. Thanks @borisstoyanov. Since the fix is no different from the earlier version for 1.7, I am assuming it should work for 1.8 as well on ubuntu. merging this now ---

[GitHub] cloudstack issue #1939: CLOUDSTACK-8886: Limitations is listUsageRecords out...

2017-02-13 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1939 ``` [INFO] Apache CloudStack Plugin - F5 . SUCCESS [2.778s] [INFO] Apache CloudStack Plugin - Juniper SRX FAILURE [0.107s] [INFO] Apache

[GitHub] cloudstack issue #1939: CLOUDSTACK-8886: Limitations is listUsageRecords out...

2017-02-13 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1939 Packaging result: ✖centos6 ✖centos7 ✖debian. JID-482 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request #1876: CLOUDSTACK-9715: Update somaxconn value to de...

2017-02-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1876 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request #928: CLOUDSTACK-8950 Hypervisor Parameter check is ...

2017-02-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/928 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack issue #1876: CLOUDSTACK-9715: Update somaxconn value to default v...

2017-02-13 Thread karuturi
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1876 travis failure not related. merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #927: secure and hidden config values are returned as plain...

2017-02-13 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/927 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #927: secure and hidden config values are returned as plain...

2017-02-13 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/927 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1939: CLOUDSTACK-8886: Limitations is listUsageRecords out...

2017-02-13 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1939 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #927: secure and hidden config values are returned as plain...

2017-02-13 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/927 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-481 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1939: CLOUDSTACK-8886: Limitations is listUsageRecords out...

2017-02-13 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1939 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #927: secure and hidden config values are returned as plain...

2017-02-13 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/927 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #927: secure and hidden config values are returned as plain...

2017-02-13 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/927 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1818: CLOUDSTACK-9655 The template which is registered in ...

2017-02-13 Thread sureshanaparti
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1818 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cloudstack issue #858: CLOUDSTACK-8886: Limitations is listUsageRecords outp...

2017-02-13 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/858 created new #PR 1939 for this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request #1939: CLOUDSTACK-8886: Limitations is listUsageReco...

2017-02-13 Thread jayapalu
GitHub user jayapalu opened a pull request: https://github.com/apache/cloudstack/pull/1939 CLOUDSTACK-8886: Limitations is listUsageRecords output, listUsageRec… As @kansal is inactive created new branch and raised the PR. This is continuation of PR#858

[GitHub] cloudstack pull request #1818: CLOUDSTACK-9655 The template which is registe...

2017-02-13 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1818#discussion_r100771599 --- Diff: ui/scripts/templates.js --- @@ -1447,7 +1447,11 @@ label:

[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...

2017-02-13 Thread karuturi
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1847 @anshul1886 can you and @nvazquez work together and create a single PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #927: secure and hidden config values are returned as plain...

2017-02-13 Thread sureshanaparti
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/927 Code changes looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1885: CLOUDSTACK-9724: Fixed missing additional public ip ...

2017-02-13 Thread koushik-das
Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1885 Code changes LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack pull request #1885: CLOUDSTACK-9724: Fixed missing additional pub...

2017-02-13 Thread koushik-das
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1885#discussion_r100767709 --- Diff: server/src/com/cloud/network/IpAddressManagerImpl.java --- @@ -460,6 +460,12 @@ boolean checkIfIpAssocRequired(Network network, boolean

[GitHub] cloudstack issue #1876: CLOUDSTACK-9715: Update somaxconn value to default v...

2017-02-13 Thread karuturi
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1876 merging. simple config change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request #843: Security group ingress/egress issues with xens...

2017-02-13 Thread jayapalu
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/843#discussion_r100766384 --- Diff: scripts/vm/hypervisor/xenserver/vmops --- @@ -356,18 +356,25 @@ def allow_egress_traffic(session): return 'false'

[GitHub] cloudstack pull request #1183: Marvin test to verify that adding TCP ports 5...

2017-02-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1183 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack issue #1183: Marvin test to verify that adding TCP ports 500,4500...

2017-02-13 Thread karuturi
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1183 failures are note related. merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request #1416: CLOUDSTACK-8717: Failed to start instance aft...

2017-02-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1416 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack issue #1855: CLOUDSTACK-9697: Better error message if user tries ...

2017-02-13 Thread sadhugit
Github user sadhugit commented on the issue: https://github.com/apache/cloudstack/pull/1855 tested on my setup and Looks good to me. Need to handle on API side so please update the Bug description by adding UI only --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request #669: Made the adding new keyboard language support ...

2017-02-13 Thread anshul1886
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/669 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request #669: Made the adding new keyboard language support ...

2017-02-13 Thread anshul1886
GitHub user anshul1886 reopened a pull request: https://github.com/apache/cloudstack/pull/669 Made the adding new keyboard language support easier https://issues.apache.org/jira/browse/CLOUDSTACK-8665 This branch has implemented following improvements in console proxy

[GitHub] cloudstack pull request #928: CLOUDSTACK-8950 Hypervisor Parameter check is ...

2017-02-13 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/928#discussion_r100753379 --- Diff: server/src/com/cloud/template/TemplateAdapterBase.java --- @@ -293,9 +298,15 @@ public TemplateProfile prepare(GetUploadParamsForTemplateCmd

[GitHub] cloudstack issue #1934: [CLOUDSTACK-9772] Template: perform a HEAD request t...

2017-02-13 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1934 OK @marcaurele, if you're 100% sure it works as expected it could be that we need to redesign the test itself, I guess it needs deeper investigation of the failure itself.

[GitHub] cloudstack issue #1934: [CLOUDSTACK-9772] Template: perform a HEAD request t...

2017-02-13 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1934 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1938: CLOUDSTACK-9780: Fixed the default JAVA_HOME value t...

2017-02-13 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1938 @karuturi unfortunately we've hit an issue with the ubuntu images, didn't manage to deploy the Trillian env.. --- If your project is set up for it, you can reply to this email and have

Re: [PROPOSAL] Extra DHCP options

2017-02-13 Thread Kris Sterckx
Hi all Comparing storing a set of DHCP options as extra json info in nic details with a new formal specification in sql, I would judge the formal approach as long-term preferred ? I understand everything can be modeled in json as well - i just want to understand better the arguments pro that