[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

[karuturi]

Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1994
  
@nvazquez any update? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1582: CLOUDSTACK-9408 for the move away from download.clou...

[karuturi]

Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1582
  
@DaanHoogland any update? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Welcoming Wido as the new ACS VP

[Rajani Karuturi]

Thank you Will for all the great work.

Congratulations Wido.

~ Rajani

http://cloudplatform.accelerite.com/

On March 16, 2017 at 10:30 PM, Will Stevens (sw...@apache.org)
wrote:

Hello Everyone,
It has been a pleasure working with you as the ACS VP over the
past year.
I would like to say Thank You to everyone who has supported me
in this role
and have supported the project as a whole.

It is my pleasure to announce that Wido den Hollander has been
voted in to
replace me as the Apache Cloudstack VP in our annual VP
rotation. Wido has
a long history with the project and we are happy welcome him
into this new
role.

Be sure to join us at CCC in Miami [1] so we can initiate him
correctly
over many beers. :)

Cheers,

*Will Stevens*

​[1] http://us.cloudstackcollab.org/​ 
( http://us.cloudstackcollab.org/%E2%80%8B )

Re: Welcoming Wido as the new ACS VP

[Nicolas Vazquez]

Congratulations Wido! Thanks Will for your hard work!

2017-03-16 23:58 GMT-03:00 Raja Pullela :

> Thank you Will for all the great work!
>
> cheers!
> Raja Pullela
> Engineering Team,
> Accelerite, 2055 Laurelwood Road,
> Santa Clara, CA, 95054
>
> On 3/16/17, 10:30 PM, "Will Stevens"  wrote:
>
> Hello Everyone,
> It has been a pleasure working with you as the ACS VP over the past year.
> I would like to say Thank You to everyone who has supported me in this role
> and have supported the project as a whole.
>
> It is my pleasure to announce that Wido den Hollander has been voted in to
> replace me as the Apache Cloudstack VP in our annual VP rotation.  Wido has
> a long history with the project and we are happy welcome him into this new
> role.
>
> Be sure to join us at CCC in Miami [1] so we can initiate him correctly
> over many beers.  :)
>
> Cheers,
>
> *Will Stevens*
>
> ​[1] http://us.cloudstackcollab.org/​
>
>
>
>
>
> DISCLAIMER
> ==
> This e-mail may contain privileged and confidential information which is
> the property of Accelerite, a Persistent Systems business. It is intended
> only for the use of the individual or entity to which it is addressed. If
> you are not the intended recipient, you are not authorized to read, retain,
> copy, print, distribute or use this message. If you have received this
> communication in error, please notify the sender and delete all copies of
> this message. Accelerite, a Persistent Systems business does not accept any
> liability for virus infected mails.
>

[GitHub] cloudstack issue #1873: CLOUDSTACK-9709: Updated the vm ip fetch task to use...

[jayapalu]

Github user jayapalu commented on the issue:

https://github.com/apache/cloudstack/pull/1873
  
@ustcweizhou  I will add disable and CLOUDSTACK-9413 in new feature.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1889: CLOUDSTACK-9718: Revamp the dropdown showing ...

[rashmidixit]

Github user rashmidixit closed the pull request at:

https://github.com/apache/cloudstack/pull/1889


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Welcoming Wido as the new ACS VP

[Raja Pullela]

Thank you Will for all the great work!  

cheers!
Raja Pullela
Engineering Team,
Accelerite, 2055 Laurelwood Road,
Santa Clara, CA, 95054

On 3/16/17, 10:30 PM, "Will Stevens"  wrote:

Hello Everyone,
It has been a pleasure working with you as the ACS VP over the past year.
I would like to say Thank You to everyone who has supported me in this role
and have supported the project as a whole.

It is my pleasure to announce that Wido den Hollander has been voted in to
replace me as the Apache Cloudstack VP in our annual VP rotation.  Wido has
a long history with the project and we are happy welcome him into this new
role.

Be sure to join us at CCC in Miami [1] so we can initiate him correctly
over many beers.  :)

Cheers,

*Will Stevens*

​[1] http://us.cloudstackcollab.org/​





DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.

Re: Welcoming Wido as the new ACS VP

[Raja Pullela]

congratulations Wido!  All the best with your new responsibilities!

cheers! 
Raja Pullela
Engineering, Accelerite, www.accelerite.com 
2055 Laurelwood Road,
Santa Clara, CA, 95054

On 3/16/17, 10:30 PM, "Will Stevens"  wrote:

Hello Everyone,
It has been a pleasure working with you as the ACS VP over the past year.
I would like to say Thank You to everyone who has supported me in this role
and have supported the project as a whole.

It is my pleasure to announce that Wido den Hollander has been voted in to
replace me as the Apache Cloudstack VP in our annual VP rotation.  Wido has
a long history with the project and we are happy welcome him into this new
role.

Be sure to join us at CCC in Miami [1] so we can initiate him correctly
over many beers.  :)

Cheers,

*Will Stevens*

​[1] http://us.cloudstackcollab.org/​





DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.

Re: Welcoming Wido as the new ACS VP

[Özhan Rüzgar Karaman]

Great News & Congratulations Wido :)

Thanks Will for your all effort & energy :)

On Thu, Mar 16, 2017 at 9:57 PM, Wei ZHOU  wrote:

> Congratulations Wido !
>
> Thanks you for your work as ACS VP, Will!
>
> -Wei
>
>
> 2017-03-16 18:00 GMT+01:00 Will Stevens :
>
> > Hello Everyone,
> > It has been a pleasure working with you as the ACS VP over the past year.
> > I would like to say Thank You to everyone who has supported me in this
> role
> > and have supported the project as a whole.
> >
> > It is my pleasure to announce that Wido den Hollander has been voted in
> to
> > replace me as the Apache Cloudstack VP in our annual VP rotation.  Wido
> has
> > a long history with the project and we are happy welcome him into this
> new
> > role.
> >
> > Be sure to join us at CCC in Miami [1] so we can initiate him correctly
> > over many beers.  :)
> >
> > Cheers,
> >
> > *Will Stevens*
> >
> > ​[1] http://us.cloudstackcollab.org/​
> >
>

[GitHub] cloudstack issue #1889: CLOUDSTACK-9718: Revamp the dropdown showing lists o...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1889
  
LGTM, please merge it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1889: CLOUDSTACK-9718: Revamp the dropdown showing lists o...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1889
  
@rashmidixit finally  I decide to say LGTM to this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Welcoming Wido as the new ACS VP

[Wei ZHOU]

Congratulations Wido !

Thanks you for your work as ACS VP, Will!

-Wei


2017-03-16 18:00 GMT+01:00 Will Stevens :

> Hello Everyone,
> It has been a pleasure working with you as the ACS VP over the past year.
> I would like to say Thank You to everyone who has supported me in this role
> and have supported the project as a whole.
>
> It is my pleasure to announce that Wido den Hollander has been voted in to
> replace me as the Apache Cloudstack VP in our annual VP rotation.  Wido has
> a long history with the project and we are happy welcome him into this new
> role.
>
> Be sure to join us at CCC in Miami [1] so we can initiate him correctly
> over many beers.  :)
>
> Cheers,
>
> *Will Stevens*
>
> ​[1] http://us.cloudstackcollab.org/​
>

Re: Welcoming Wido as the new ACS VP

[Tutkowski, Mike]

Thanks for taking on this role over the past year, Will! You did a great job. 
:-)

> On Mar 16, 2017, at 11:00 AM, Will Stevens  wrote:
> 
> Hello Everyone,
> It has been a pleasure working with you as the ACS VP over the past year.
> I would like to say Thank You to everyone who has supported me in this role
> and have supported the project as a whole.
> 
> It is my pleasure to announce that Wido den Hollander has been voted in to
> replace me as the Apache Cloudstack VP in our annual VP rotation.  Wido has
> a long history with the project and we are happy welcome him into this new
> role.
> 
> Be sure to join us at CCC in Miami [1] so we can initiate him correctly
> over many beers.  :)
> 
> Cheers,
> 
> *Will Stevens*
> 
> ​[1] http://us.cloudstackcollab.org/​

Re: Welcoming Wido as the new ACS VP

[Gabriel Beims Bräscher]

Congratulations Wido! :)

Thank you very much for all the hard work Will!

2017-03-16 14:20 GMT-03:00 Erik Weber :

> Thanks for all you hard work and dedication, Will!
>
> Congratulations Wido! :-)
>
> --
> Erik
> tor. 16. mar. 2017 kl. 18.00 skrev Will Stevens :
>
> > Hello Everyone,
> > It has been a pleasure working with you as the ACS VP over the past year.
> > I would like to say Thank You to everyone who has supported me in this
> role
> > and have supported the project as a whole.
> >
> > It is my pleasure to announce that Wido den Hollander has been voted in
> to
> > replace me as the Apache Cloudstack VP in our annual VP rotation.  Wido
> has
> > a long history with the project and we are happy welcome him into this
> new
> > role.
> >
> > Be sure to join us at CCC in Miami [1] so we can initiate him correctly
> > over many beers.  :)
> >
> > Cheers,
> >
> > *Will Stevens*
> >
> > ​[1] http://us.cloudstackcollab.org/​
> >
>

Re: Welcoming Wido as the new ACS VP

[Erik Weber]

Thanks for all you hard work and dedication, Will!

Congratulations Wido! :-)

-- 
Erik
tor. 16. mar. 2017 kl. 18.00 skrev Will Stevens :

> Hello Everyone,
> It has been a pleasure working with you as the ACS VP over the past year.
> I would like to say Thank You to everyone who has supported me in this role
> and have supported the project as a whole.
>
> It is my pleasure to announce that Wido den Hollander has been voted in to
> replace me as the Apache Cloudstack VP in our annual VP rotation.  Wido has
> a long history with the project and we are happy welcome him into this new
> role.
>
> Be sure to join us at CCC in Miami [1] so we can initiate him correctly
> over many beers.  :)
>
> Cheers,
>
> *Will Stevens*
>
> ​[1] http://us.cloudstackcollab.org/​
>

Welcoming Wido as the new ACS VP

[Will Stevens]

Hello Everyone,
It has been a pleasure working with you as the ACS VP over the past year.
I would like to say Thank You to everyone who has supported me in this role
and have supported the project as a whole.

It is my pleasure to announce that Wido den Hollander has been voted in to
replace me as the Apache Cloudstack VP in our annual VP rotation.  Wido has
a long history with the project and we are happy welcome him into this new
role.

Be sure to join us at CCC in Miami [1] so we can initiate him correctly
over many beers.  :)

Cheers,

*Will Stevens*

​[1] http://us.cloudstackcollab.org/​

[GitHub] cloudstack pull request #2008: Fix datetime format of snapshots events

[olivierlemasle]

GitHub user olivierlemasle reopened a pull request:

https://github.com/apache/cloudstack/pull/2008

Fix datetime format of snapshots events

Include the timezone in datetime format of snapshot events, to be 
consistent with every other events.
"eventDateTime" was added by @chipchilders in commit 14ee684ce3 and was 
updated the same day to add the timezone (commit bf967eb622f) except for 
Snapshots.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Amysta/cloudstack eventDateTimeTz

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/2008.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2008


commit b37ca77636feb22327d1b819657c6fd3913696fe
Author: Olivier Lemasle 
Date:   2017-03-15T15:29:44Z

Fix datetime format of snapshots events

Include the timezone in datetime format of snapshot events, to be consistent
with every other events.
"eventDateTime" was added by @chipchilders in commit 14ee684ce3 and was
updated the same day to add the timezone (commit bf967eb622f) except for
Snapshots.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #2008: Fix datetime format of snapshots events

[olivierlemasle]

Github user olivierlemasle closed the pull request at:

https://github.com/apache/cloudstack/pull/2008


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
I am considering changing my implementation to be the same as the old 
implementation (which removed the IP from the dbag in the initial loop of the 
merge), but if `source_nat` is present and it is `true` and the 
`len(dbag[ip['device']]) > 0` (with all the checking required), then prepend 
else append.   This should ensure that the source nat ip is the primary ip on 
the nic which the StrongSwan feature depends on.

If I do this and there is a bug elsewhere that will duplicate the IPs in 
the databag, then this will clean that up (as I assume it was doing before).  

Not sure this will fix @borisstoyanov's current problem, but I think it is 
probably a safer implementation to keep the source nat IP as the first IP.

I will update this PR with that change later today...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1879
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-592


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1859
  
@nitin-maharana it becomes easier to triage changes when changes are 
confined to a limited number of commits (ideally one per PR), please squash the 
commits based on the author (if not to a single commit) if you don't agree. 
Ideally, you can also group/squash commits based on the 
component/framework/architecture.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1879
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1879
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1867: CLOUDSTACK-9706: Added snapshots cleanup in start an...

[anshul1886]

Github user anshul1886 commented on the issue:

https://github.com/apache/cloudstack/pull/1867
  
@koushik-das Made the changes as per review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1889: CLOUDSTACK-9718: Revamp the dropdown showing lists o...

[rashmidixit]

Github user rashmidixit commented on the issue:

https://github.com/apache/cloudstack/pull/1889
  
@ustcweizhou thanks. I guess there was a misunderstanding.

I understand what you are saying. I think i will just remove that dialog. 
The problem is that we are lazy loading the list of hosts. If there are many, 
as the user scrolls down, the page loads. 

Can you tell me how many hosts you have in the list and explain a little 
about the problem you face? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1889: CLOUDSTACK-9718: Revamp the dropdown showing lists o...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1889
  
@rashmidixit thanks for the update.
Compared with old patch, I notice you changed the return if args.page == 1.
However, it does not solve my issue. We have several hosts (more than 1 
page). Each time when I get the last page (full list),  I get the alert dialog, 
that is what I want to avoid.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1889: CLOUDSTACK-9718: Revamp the dropdown showing lists o...

[rashmidixit]

Github user rashmidixit commented on the issue:

https://github.com/apache/cloudstack/pull/1889
  
@ustcweizhou I have made appropriate changes. Can you please check once the 
validations pass?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...

[anshul1886]

Github user anshul1886 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1867#discussion_r106388631
  
--- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
@@ -1078,6 +1082,16 @@ public void cleanupStorage(boolean recurring) {
 }
 }
 
+//destroy snapshots in destroying state in 
snapshot_store_ref
+List  ssSnapshots = 
_snapshotStoreDao.listByState(ObjectInDataStoreStateMachine.State.Destroying);
+for(SnapshotDataStoreVO ssSnapshotVO : ssSnapshots){
+try {
+
_snapshotService.deleteSnapshot(snapshotFactory.getSnapshot(ssSnapshotVO.getSnapshotId(),
 DataStoreRole.Image));
--- End diff --

@koushik-das If there is any failure in deleteSnapshot() then cleanup will 
be retried. DB entry for such snapshots will only be removed on successful 
deletion. Destroying check  introduced in SnapshotObject class is to make sure 
that DB entry doesn't gets deleted.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...

[anshul1886]

Github user anshul1886 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1867#discussion_r106387626
  
--- Diff: server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java ---
@@ -1181,6 +1181,17 @@ public boolean configure(String name, Map params) throws Configu
 
 @Override
 public boolean start() {
+//destroy snapshots in destroying state
+List dsnapshots = 
_snapshotDao.listAllByStatus(Snapshot.State.Destroying);
--- End diff --

@koushik-das Will make the change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...

[anshul1886]

Github user anshul1886 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1867#discussion_r106387348
  
--- Diff: 
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/SnapshotObject.java
 ---
@@ -191,7 +191,8 @@ public void 
processEvent(ObjectInDataStoreStateMachine.Event event) {
 s_logger.debug("Failed to update state:" + e.toString());
 throw new CloudRuntimeException("Failed to update state: " + 
e.toString());
 } finally {
-if (event == 
ObjectInDataStoreStateMachine.Event.OperationFailed) {
+DataObjectInStore obj = objectInStoreMgr.findObject(this, 
this.getDataStore());
+if (event == 
ObjectInDataStoreStateMachine.Event.OperationFailed && 
!obj.getState().equals(ObjectInDataStoreStateMachine.State.Destroying)) {
--- End diff --

@koushik-das obj cannot be null as that method is kind of called on that 
object itself. That method is fetching it from DB for some more details. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...

[anshul1886]

Github user anshul1886 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1867#discussion_r106386503
  
--- Diff: 
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
 ---
@@ -194,18 +194,22 @@ protected boolean deleteSnapshotChain(SnapshotInfo 
snapshot) {
 }
 }
 if (!deleted) {
-boolean r = snapshotSvr.deleteSnapshot(snapshot);
-if (r) {
-// delete snapshot in cache if there is
-List cacheSnaps = 
snapshotDataFactory.listSnapshotOnCache(snapshot.getId());
-for (SnapshotInfo cacheSnap : cacheSnaps) {
-s_logger.debug("Delete snapshot " + 
snapshot.getId() + " from image cache store: " + 
cacheSnap.getDataStore().getName());
-cacheSnap.delete();
+try {
+boolean r = snapshotSvr.deleteSnapshot(snapshot);
+if (r) {
+// delete snapshot in cache if there is
+List cacheSnaps = 
snapshotDataFactory.listSnapshotOnCache(snapshot.getId());
+for (SnapshotInfo cacheSnap : cacheSnaps) {
+s_logger.debug("Delete snapshot " + 
snapshot.getId() + " from image cache store: " + 
cacheSnap.getDataStore().getName());
+cacheSnap.delete();
+}
 }
-}
-if (!resultIsSet) {
-result = r;
-resultIsSet = true;
+if (!resultIsSet) {
+result = r;
+resultIsSet = true;
+}
+} catch (Exception e){
--- End diff --

@koushik-das Its a catch all as we will retry to delete snapshot again in 
next attempt if it fails to delete so just logging in and carry on. Also it is 
introduced to make sure that all snapshots gets chance to delete.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...

[anshul1886]

Github user anshul1886 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1867#discussion_r106385035
  
--- Diff: 
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/SnapshotObject.java
 ---
@@ -191,7 +191,8 @@ public void 
processEvent(ObjectInDataStoreStateMachine.Event event) {
 s_logger.debug("Failed to update state:" + e.toString());
 throw new CloudRuntimeException("Failed to update state: " + 
e.toString());
 } finally {
-if (event == 
ObjectInDataStoreStateMachine.Event.OperationFailed) {
+DataObjectInStore obj = objectInStoreMgr.findObject(this, 
this.getDataStore());
+if (event == 
ObjectInDataStoreStateMachine.Event.OperationFailed && 
!obj.getState().equals(ObjectInDataStoreStateMachine.State.Destroying)) {
--- End diff --

@koushik-das If there is failure in destroying snapshot then we should not 
delete db entry so that it can be used to detect which snapshots failed to 
delete successfully.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...

[anshul1886]

Github user anshul1886 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1867#discussion_r106384378
  
--- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
@@ -1078,6 +1082,16 @@ public void cleanupStorage(boolean recurring) {
 }
 }
 
+//destroy snapshots in destroying state in 
snapshot_store_ref
+List  ssSnapshots = 
_snapshotStoreDao.listByState(ObjectInDataStoreStateMachine.State.Destroying);
+for(SnapshotDataStoreVO ssSnapshotVO : ssSnapshots){
+try {
+
_snapshotService.deleteSnapshot(snapshotFactory.getSnapshot(ssSnapshotVO.getSnapshotId(),
 DataStoreRole.Image));
--- End diff --

@koushik-das If there is any failure then the db entry will remain 
Destroying and will only be updated if there is successful deletion. Condition 
which is checking Destroying state of object  in SnapshotObject class is meant 
for this purpose.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1853: CLOUDSTACK-9696: Fixed Virtual Router deploym...

[anshul1886]

Github user anshul1886 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1853#discussion_r106381321
  
--- Diff: server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java ---
@@ -584,105 +583,64 @@ private void 
checkForNonDedicatedResources(VirtualMachineProfile vmProfile, Data
 isExplicit = true;
 }
 
-List allPodsInDc = _podDao.listAllPods(dc.getId());
-List allDedicatedPods = _dedicatedDao.listAllPods();
-allPodsInDc.retainAll(allDedicatedPods);
-
-List allClustersInDc = 
_clusterDao.listAllCusters(dc.getId());
-List allDedicatedClusters = _dedicatedDao.listAllClusters();
-allClustersInDc.retainAll(allDedicatedClusters);
-
-List allHostsInDc = _hostDao.listAllHosts(dc.getId());
-List allDedicatedHosts = _dedicatedDao.listAllHosts();
-allHostsInDc.retainAll(allDedicatedHosts);
-
-//Only when the type is instance VM and not explicitly dedicated.
-if (vm.getType() == VirtualMachine.Type.User && !isExplicit) {
-//add explicitly dedicated resources in avoidList
-
-avoids.addPodList(allPodsInDc);
-avoids.addClusterList(allClustersInDc);
-avoids.addHostList(allHostsInDc);
-}
-
-//Handle the Virtual Router Case
-//No need to check the isExplicit. As both the cases are handled.
-if (vm.getType() == VirtualMachine.Type.DomainRouter) {
-long vmAccountId = vm.getAccountId();
-long vmDomainId = vm.getDomainId();
-
-//Lists all explicitly dedicated resources from vm account ID 
or domain ID.
-List allPodsFromDedicatedID = new ArrayList();
-List allClustersFromDedicatedID = new ArrayList();
-List allHostsFromDedicatedID = new ArrayList();
-
-//Whether the dedicated resources belong to Domain or not. If 
not, it may belongs to Account or no dedication.
-List domainGroupMappings = 
_affinityGroupDomainMapDao.listByDomain(vmDomainId);
-
-//For temporary storage and indexing.
-List tempStorage;
-
-if (domainGroupMappings == null || 
domainGroupMappings.isEmpty()) {
-//The dedicated resource belongs to VM Account ID.
-
-tempStorage = _dedicatedDao.searchDedicatedPods(null, 
vmDomainId, vmAccountId, null).first();
-
-for(DedicatedResourceVO vo : tempStorage) {
-allPodsFromDedicatedID.add(vo.getPodId());
-}
-
-tempStorage.clear();
-tempStorage = _dedicatedDao.searchDedicatedClusters(null, 
vmDomainId, vmAccountId, null).first();
+if ((vm.getType() == VirtualMachine.Type.User && !isExplicit) || 
vm.getType() == VirtualMachine.Type.DomainRouter) {
+List allPodsInDc = _podDao.listAllPods(dc.getId());
+List allDedicatedPods = _dedicatedDao.listAllPods();
+allPodsInDc.retainAll(allDedicatedPods);
 
-for(DedicatedResourceVO vo : tempStorage) {
-allClustersFromDedicatedID.add(vo.getClusterId());
-}
+List allClustersInDc = 
_clusterDao.listAllCusters(dc.getId());
+List allDedicatedClusters = 
_dedicatedDao.listAllClusters();
+allClustersInDc.retainAll(allDedicatedClusters);
 
-tempStorage.clear();
-tempStorage = _dedicatedDao.searchDedicatedHosts(null, 
vmDomainId, vmAccountId, null).first();
+List allHostsInDc = _hostDao.listAllHosts(dc.getId());
+List allDedicatedHosts = _dedicatedDao.listAllHosts();
+allHostsInDc.retainAll(allDedicatedHosts);
 
-for(DedicatedResourceVO vo : tempStorage) {
-allHostsFromDedicatedID.add(vo.getHostId());
-}
+//Only when the type is instance VM and not explicitly 
dedicated.
+if (vm.getType() == VirtualMachine.Type.User && !isExplicit) {
+//add explicitly dedicated resources in avoidList
 
-//Remove the dedicated ones from main list
-allPodsInDc.removeAll(allPodsFromDedicatedID);
-allClustersInDc.removeAll(allClustersFromDedicatedID);
-allHostsInDc.removeAll(allHostsFromDedicatedID);
+avoids.addPodList(allPodsInDc);
+avoids.addClusterList(allClustersInDc);
+avoids.addHostList(allHostsInDc);
 }
-else {
-//The dedicated resource belongs to VM 

[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
@borisstoyanov 
I suspect this is caused by the name of your public interface (p55p1). 
can you please try the following change
```
diff --git 
a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 
b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingReso
index d925297..706f7d9 100755
--- 
a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
+++ 
b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
@@ -1481,7 +1481,7 @@ public class LibvirtComputingResource extends 
ServerResourceBase implements Serv

 private String getBroadcastUriFromBridge(final String brName) {
 final String pif = matchPifFileInDirectory(brName);
-final Pattern pattern = 
Pattern.compile("(\\D+)(\\d+)(\\D*)(\\d*)");
+final Pattern pattern = 
Pattern.compile("(\\D+)(\\d+)(\\D*)(\\d*)(\\D*)(\\d*)");
 final Matcher matcher = pattern.matcher(pif);
 s_logger.debug("getting broadcast uri for pif " + pif + " and 
bridge " + brName);
 if(matcher.find()) {
@@ -1489,7 +1489,9 @@ public class LibvirtComputingResource extends 
ServerResourceBase implements Serv
 return 
BroadcastDomainType.Vxlan.toUri(matcher.group(2)).toString();
 }
 else{
-if (!matcher.group(4).isEmpty()) {
+if (!matcher.group(6).isEmpty()) {
+return 
BroadcastDomainType.Vlan.toUri(matcher.group(6)).toString();
+} else if (!matcher.group(4).isEmpty()) {
 return 
BroadcastDomainType.Vlan.toUri(matcher.group(4)).toString();
 } else {
 //untagged or not matching (eth|bond|team)#.#
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1853: CLOUDSTACK-9696: Fixed Virtual Router deploym...

[anshul1886]

Github user anshul1886 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1853#discussion_r106380082
  
--- Diff: server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java ---
@@ -584,105 +583,64 @@ private void 
checkForNonDedicatedResources(VirtualMachineProfile vmProfile, Data
 isExplicit = true;
 }
 
-List allPodsInDc = _podDao.listAllPods(dc.getId());
-List allDedicatedPods = _dedicatedDao.listAllPods();
-allPodsInDc.retainAll(allDedicatedPods);
-
-List allClustersInDc = 
_clusterDao.listAllCusters(dc.getId());
-List allDedicatedClusters = _dedicatedDao.listAllClusters();
-allClustersInDc.retainAll(allDedicatedClusters);
-
-List allHostsInDc = _hostDao.listAllHosts(dc.getId());
-List allDedicatedHosts = _dedicatedDao.listAllHosts();
-allHostsInDc.retainAll(allDedicatedHosts);
-
-//Only when the type is instance VM and not explicitly dedicated.
-if (vm.getType() == VirtualMachine.Type.User && !isExplicit) {
-//add explicitly dedicated resources in avoidList
-
-avoids.addPodList(allPodsInDc);
-avoids.addClusterList(allClustersInDc);
-avoids.addHostList(allHostsInDc);
-}
-
-//Handle the Virtual Router Case
-//No need to check the isExplicit. As both the cases are handled.
-if (vm.getType() == VirtualMachine.Type.DomainRouter) {
-long vmAccountId = vm.getAccountId();
-long vmDomainId = vm.getDomainId();
-
-//Lists all explicitly dedicated resources from vm account ID 
or domain ID.
-List allPodsFromDedicatedID = new ArrayList();
-List allClustersFromDedicatedID = new ArrayList();
-List allHostsFromDedicatedID = new ArrayList();
-
-//Whether the dedicated resources belong to Domain or not. If 
not, it may belongs to Account or no dedication.
-List domainGroupMappings = 
_affinityGroupDomainMapDao.listByDomain(vmDomainId);
-
-//For temporary storage and indexing.
-List tempStorage;
-
-if (domainGroupMappings == null || 
domainGroupMappings.isEmpty()) {
-//The dedicated resource belongs to VM Account ID.
-
-tempStorage = _dedicatedDao.searchDedicatedPods(null, 
vmDomainId, vmAccountId, null).first();
-
-for(DedicatedResourceVO vo : tempStorage) {
-allPodsFromDedicatedID.add(vo.getPodId());
-}
-
-tempStorage.clear();
-tempStorage = _dedicatedDao.searchDedicatedClusters(null, 
vmDomainId, vmAccountId, null).first();
+if ((vm.getType() == VirtualMachine.Type.User && !isExplicit) || 
vm.getType() == VirtualMachine.Type.DomainRouter) {
--- End diff --

@koushik-das Here additional isExplicit check is needed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1853: CLOUDSTACK-9696: Fixed Virtual Router deploym...

[anshul1886]

Github user anshul1886 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1853#discussion_r106378310
  
--- Diff: server/src/com/cloud/dc/dao/DedicatedResourceDaoImpl.java ---
@@ -312,6 +317,65 @@ public DedicatedResourceVO findByHostId(Long hostId) {
 }
 
 @Override
+public List listAvailableResources(Long 
accountId, Long... domains) {
--- End diff --

@koushik-das Could not find a way to write the conditional statement so 
went with this way. Here account_id in involved in two places in condition.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1269: CLOUDSTACK-8867: Added retry logic to reconnect to h...

[anshul1886]

Github user anshul1886 commented on the issue:

https://github.com/apache/cloudstack/pull/1269
  
@GabrielBrascher The other method is there for legacy purposes and is no 
longer get used in Cloudstack. This was getting used in 2.x versions for UI. 
Some third party tool might be using it so kept it for that purpose. Mixing 
things will make it more complicated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

[borisstoyanov]

Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
Thanks @ustcweizhou 
here's the StartCommand log
```
2017-03-16 08:48:46,068 DEBUG [cloud.agent.Agent] 
(agentRequest-Handler-3:null) (logid:be1f1987) Request:Seq 
1-2088825802169778189:  { Cmd , MgmtId: 6629449860900, via: 1, Ver: v1, Flags: 
100011, 
[{"com.cloud.agent.api.StartCommand":{"vm":{"id":5,"name":"r-5-VM","type":"DomainRouter","cpus":1,"minSpeed":250,"maxSpeed":500,"minRam":268435456,"maxRam":268435456,"arch":"x86_64","os":"Debian
 GNU/Linux 5.0 (64-bit)","platformEmulator":"Debian GNU/Linux 5","bootArgs":" 
template=domP name=r-5-VM eth2ip=10.1.35.83 eth2mask=255.255.224.0 
gateway=10.1.63.254 eth0ip=10.1.1.1 eth0mask=255.255.255.0 
domain=cs2cloud.internal cidrsize=24 dhcprange=10.1.1.1 eth1ip=169.254.2.157 
eth1mask=255.255.0.0 type=router disable_rp_filter=true dns1=8.8.8.8 
dns2=8.8.4.4 
baremetalnotificationsecuritykey=QtUSkBDvXbuIN02ekUDrlpkmPzc5XXTVAOV1_L3Nvozwp46Xyq7PnGvYYiPWctsrMj2cgIIxFIUzXOXLntsomA
 
baremetalnotificationapikey=3cvNCQ5aBbRVT2a1vjuO0WKF3cELdiS86t_J_5GJnpPTobkyHZPjmxIKuDNHZHRpzfWooLi6pms0QPiEhpiq5A
 host=1
 0.2.2.44 
port=8080","enableHA":true,"limitCpuUse":false,"enableDynamicallyScaleVm":false,"vncPassword":"aFTlD_W3vJCMrO9fjc_GFA","params":{"cpuOvercommitRatio":"2.0","memoryOvercommitRatio":"1.0"},"uuid":"469106c8-107d-46b9-9bd0-237221c97ffe","disks":[{"data":{"org.apache.cloudstack.storage.to.VolumeObjectTO":{"uuid":"2844d31e-edd9-40a1-8e2d-0394df1b2d1d","volumeType":"ROOT","dataStore":{"org.apache.cloudstack.storage.to.PrimaryDataStoreTO":{"uuid":"a86067db-e2df-3c95-819c-254d6d60f4bd","id":2,"poolType":"NetworkFilesystem","host":"10.2.0.16","path":"/acs/primary/ref-trl-106-k-cs410-bstoyanov/ref-trl-106-k-cs410-bstoyanov-kvm-pri2","port":2049,"url":"NetworkFilesystem://10.2.0.16/acs/primary/ref-trl-106-k-cs410-bstoyanov/ref-trl-106-k-cs410-bstoyanov-kvm-pri2/?ROLE=Primary=a86067db-e2df-3c95-819c-254d6d60f4bd","isManaged":false}},"name":"ROOT-5","size":348984320,"path":"2844d31e-edd9-40a1-8e2d-0394df1b2d1d","volumeId":5,"vmName":"r-5-VM","accountId":2,"format":"QCOW2","prov
 
isioningType":"THIN","id":5,"deviceId":0,"bytesReadRate":0,"bytesWriteRate":0,"iopsReadRate":0,"iopsWriteRate":0,"hypervisorType":"KVM"}},"diskSeq":0,"path":"2844d31e-edd9-40a1-8e2d-0394df1b2d1d","type":"ROOT","_details":{"storageHost":"10.2.0.16","managed":"false","storagePort":"2049","volumeSize":"348984320"}}],"nics":[{"deviceId":2,"networkRateMbps":200,"defaultNic":true,"pxeDisable":true,"nicUuid":"8bc36a5d-e51a-4f93-b764-89d452a89617","uuid":"268a2858-a1ac-4aec-aa3f-365c4ea97d18","ip":"10.1.35.83","netmask":"255.255.224.0","gateway":"10.1.63.254","mac":"06:17:c6:00:00:03","dns1":"8.8.8.8","dns2":"8.8.4.4","broadcastType":"Vlan","type":"Public","broadcastUri":"vlan://7","isolationUri":"vlan://7","isSecurityGroupEnabled":false,"name":"cloudbr1"},{"deviceId":0,"networkRateMbps":200,"defaultNic":false,"pxeDisable":true,"nicUuid":"cf5bcb72-96e2-47a2-a5b2-9187d8922ae5","uuid":"9046a22a-ac92-45c9-9757-107ca10e38d4","ip":"10.1.1.1","netmask":"255.255.255.0","mac":"02:00:46:fd:00:03","d
 
ns1":"8.8.8.8","dns2":"8.8.4.4","broadcastType":"Vlan","type":"Guest","broadcastUri":"vlan://884","isolationUri":"vlan://884","isSecurityGroupEnabled":false,"name":"cloudbr1"},{"deviceId":1,"networkRateMbps":-1,"defaultNic":false,"pxeDisable":true,"nicUuid":"8cc9d552-6238-4add-9497-9b3d61ca938a","uuid":"9a24aaa5-e041-460c-9954-660fb4a41404","ip":"169.254.2.157","netmask":"255.255.0.0","gateway":"169.254.0.1","mac":"0e:00:a9:fe:02:9d","broadcastType":"LinkLocal","type":"Control","isSecurityGroupEnabled":false}]},"hostIp":"10.2.5.1","executeInSequence":false,"wait":0}},{"com.cloud.agent.api.check.CheckSshCommand":{"ip":"169.254.2.157","port":3922,"interval":6,"retries":100,"name":"r-5-VM","wait":0}},{"com.cloud.agent.api.GetDomRVersionCmd":{"accessDetails":{"router.ip":"169.254.2.157","router.name":"r-5-VM"},"wait":0}},{},{"com.cloud.agent.api.routing.AggregationControlCommand":{"action":"Start","accessDetails":{"router.guest.ip":"10.1.1.1","router.ip":"169.254.2.157","router.name":"r
 

[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
@borisstoyanov I think this is caused by KVM plugin.
can you please perform the following on KVM host ?
(1) change INFO to DEBUG in /etc/cloudstack/agent/log4j-cloud.xml, and 
restart cloudstack-agent
(2) restart the VR (on UI), and post the StartCommand in 
/var/log/cloudstack/agent/agent.log
(3) post the xml definition of VR (virsh dumpxml r--VM)
(4) post bridge information (brctl show)
(5) post /etc/cloudstack/agent/agent.properties





---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---