[GitHub] [cloudstack-primate] blueorangutan commented on pull request #353: UI changes for Dynamic roles improvements

2020-06-30 Thread GitBox


blueorangutan commented on pull request #353:
URL: 
https://github.com/apache/cloudstack-primate/pull/353#issuecomment-652209221


   @borisstoyanov a Jenkins job has been kicked to build primate packages. I'll 
keep you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] borisstoyanov commented on pull request #353: UI changes for Dynamic roles improvements

2020-06-30 Thread GitBox


borisstoyanov commented on pull request #353:
URL: 
https://github.com/apache/cloudstack-primate/pull/353#issuecomment-652208833


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on issue #455: Another Usability Issues List

2020-06-30 Thread GitBox


rhtyd commented on issue #455:
URL: 
https://github.com/apache/cloudstack-primate/issues/455#issuecomment-652205986


   With @Pearl1594 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #474: Hide order column for user account

2020-06-30 Thread GitBox


blueorangutan commented on pull request #474:
URL: 
https://github.com/apache/cloudstack-primate/pull/474#issuecomment-652204740


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian 
:heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/474 (JID-2169)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[DISCUSS] Management server default port conflict

2020-06-30 Thread Abhishek Kumar
Hi all,

I would like to know everyone's opinion regarding an issue seen with CloudStack 
on CentOS8 (https://github.com/apache/cloudstack/pull/4068). CentOS8 comes with 
cockpit (https://cockpit-project.org/) installed which uses port 9090, although 
it is not active by default. CloudStack management server also needs port 9090. 
And when CloudStack management server is started with systemd it triggers the 
start of cockpit first and management server fails to start,


2020-06-25 07:20:51,707 ERROR [c.c.c.ClusterManagerImpl] (main:null) (logid:) 
Detected that another management node with the same IP 10.10.2.167 is already 
running, please check your cluster configuration
2020-06-25 07:20:51,708 ERROR [o.a.c.s.l.CloudStackExtendedLifeCycle] 
(main:null) (logid:) Failed to configure ClusterManagerImpl
javax.naming.ConfigurationException: Detected that another management node with 
the same IP 10.10.2.167 is already running, please check your cluster 
configuration
at 
com.cloud.cluster.ClusterManagerImpl.checkConflicts(ClusterManagerImpl.java:1192)
at 
com.cloud.cluster.ClusterManagerImpl.configure(ClusterManagerImpl.java:1065)
at 
org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLifeCycle$3.with(CloudStackExtendedLifeCycle.java:114)
at 
org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLifeCycle.with(CloudStackExtendedLifeCycle.java:153)
at 
org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLifeCycle.configure(CloudStackExtendedLifeCycle.java:110)
at 
org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLifeCycle.start(CloudStackExtendedLifeCycle.java:55)
at 
org.springframework.context.support.DefaultLifecycleProcessor.doStart(DefaultLifecycleProcessor.java:182)
at 
org.springframework.context.support.DefaultLifecycleProcessor.access$200(DefaultLifecycleProcessor.java:53)
at 
org.springframework.context.support.DefaultLifecycleProcessor$LifecycleGroup.start(DefaultLifecycleProcessor.java:360)
at 
org.springframework.context.support.DefaultLifecycleProcessor.startBeans(DefaultLifecycleProcessor.java:158)
at 
org.springframework.context.support.DefaultLifecycleProcessor.onRefresh(DefaultLifecycleProcessor.java:122)
at 
org.springframework.context.support.AbstractApplicationContext.finishRefresh(AbstractApplicationContext.java:894)
at 
org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:553)
at 
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.loadContext(DefaultModuleDefinitionSet.java:144)
at 
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet$2.with(DefaultModuleDefinitionSet.java:121)
at 
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:244)
at 
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:249)
at 
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:249)
at 
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:232)
at 
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.loadContexts(DefaultModuleDefinitionSet.java:116)
at 
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.load(DefaultModuleDefinitionSet.java:78)
at 
org.apache.cloudstack.spring.module.factory.ModuleBasedContextFactory.loadModules(ModuleBasedContextFactory.java:37)
at 
org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.init(CloudStackSpringContext.java:70)
at 
org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.(CloudStackSpringContext.java:57)
at 
org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.(CloudStackSpringContext.java:61)
at 
org.apache.cloudstack.spring.module.web.CloudStackContextLoaderListener.contextInitialized(CloudStackContextLoaderListener.java:51)
at 
org.eclipse.jetty.server.handler.ContextHandler.callContextInitialized(ContextHandler.java:930)
at 
org.eclipse.jetty.servlet.ServletContextHandler.callContextInitialized(ServletContextHandler.java:553)
at 
org.eclipse.jetty.server.handler.ContextHandler.startContext(ContextHandler.java:889)
at 
org.eclipse.jetty.servlet.ServletContextHandler.startContext(ServletContextHandler.java:356)
at 
org.eclipse.jetty.webapp.WebAppContext.startWebapp(WebAppContext.java:1445)
at 
org.eclipse.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1409)
at 
org.eclipse.jetty.server.handler.ContextHandler.doStart(ContextHandler.java:822)
at 
org.eclipse.jetty.servlet.ServletContextHandler.doStart(ServletContextHandler.java:275)
   

[GitHub] [cloudstack-primate] rhtyd commented on issue #476: [BUG] Template Status data not relevant to non admin users

2020-06-30 Thread GitBox


rhtyd commented on issue #476:
URL: 
https://github.com/apache/cloudstack-primate/issues/476#issuecomment-652204182


   With @Pearl1594 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #474: Hide order column for user account

2020-06-30 Thread GitBox


blueorangutan commented on pull request #474:
URL: 
https://github.com/apache/cloudstack-primate/pull/474#issuecomment-652202323


   @Pearl1594 a Jenkins job has been kicked to build primate packages. I'll 
keep you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #474: Hide order column for user account

2020-06-30 Thread GitBox


Pearl1594 commented on pull request #474:
URL: 
https://github.com/apache/cloudstack-primate/pull/474#issuecomment-652201953


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[VOTE] Release Apache CloudStack CloudMonkey 6.1.0

2020-06-30 Thread Rohit Yadav
Hi All,

I've created a 6.1.0 release of CloudMonkey, with the following artifacts
up for a vote:

Git Branch:
https://github.com/apache/cloudstack-cloudmonkey/commits/abc31929e74a9f5b07507db203e75393fffc9f3e
Commit: abc31929e74a9f5b07507db203e75393fffc9f3e

Commits since last release 6.0.0:
https://github.com/apache/cloudstack-cloudmonkey/compare/6.0.0...abc31929e74a9f5b07507db203e75393fffc9f3e

Source release (checksums and signatures are available at the same
location):
https://dist.apache.org/repos/dist/dev/cloudstack/cloudmonkey-6.1.0

To facilitate voting and testing, the builds are uploaded in this
pre-release:
https://github.com/apache/cloudstack-cloudmonkey/releases/tag/6.1.0

List of changes:
https://github.com/apache/cloudstack-cloudmonkey/blob/master/CHANGES.md

PGP release keys (signed using 5ED1E1122DC5E8A4A45112C2484248210EE3D884):
https://dist.apache.org/repos/dist/release/cloudstack/KEYS

For sanity in tallying the vote, can PMC members please be sure to indicate
"(binding)" with their vote?
[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove (and reason why)

Vote will be open for till the end of the next week (10 July 2020),
otherwise, extend until we reach lazy consensus. Thanks.

Regards.


[GitHub] [cloudstack-primate] rhtyd closed issue #468: VM deployment form group template/iso

2020-06-30 Thread GitBox


rhtyd closed issue #468:
URL: https://github.com/apache/cloudstack-primate/issues/468


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on issue #468: VM deployment form group template/iso

2020-06-30 Thread GitBox


rhtyd commented on issue #468:
URL: 
https://github.com/apache/cloudstack-primate/issues/468#issuecomment-652154998


   Has PR



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on issue #475: [BUG] Many screens show Account and Domain to non-root admins when they should not.

2020-06-30 Thread GitBox


rhtyd commented on issue #475:
URL: 
https://github.com/apache/cloudstack-primate/issues/475#issuecomment-652154481


   With @PaulAngus - to review presented arguments and close the ticket; or 
start thread on dev/users ML to gather consensus on mitigation options such as:
   - Hide account/domain information in Primate for the sections - template, 
iso, kubernetes iso and project
   - Give some config parameter (Primate fix, provide via config.json) and/or 
global setting (CloudStack/server fix, fix API response) to show or hide this?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on issue #476: [BUG] Template Status data not relevant to non admin users

2020-06-30 Thread GitBox


rhtyd commented on issue #476:
URL: 
https://github.com/apache/cloudstack-primate/issues/476#issuecomment-652152753


   Make sense, @davidjumani please check legacy UI for "Domain Admin" and 
"User" accounts, and remove status column from the listviews of both template 
and ISOs and the zonetemplate/zoneiso tab components. I did a quick check as a 
normal User role/account and I see no status information being returned, so 
it's safe to remove this column at least for the "User" roletype.
   
   With @davidjumani 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on issue #477: [BUG] Prompt regarding Data Volumes shown when destroying a VM is misleading

2020-06-30 Thread GitBox


rhtyd commented on issue #477:
URL: 
https://github.com/apache/cloudstack-primate/issues/477#issuecomment-652152008







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd edited a comment on issue #475: [BUG] Many screens show Account and Domain to non-root admins when they should not.

2020-06-30 Thread GitBox


rhtyd edited a comment on issue #475:
URL: 
https://github.com/apache/cloudstack-primate/issues/475#issuecomment-652147779


   @PaulAngus we also show the information in most screens (detail views if not 
list/table view) in legacy UI, ultimately the API response contains account and 
domain information for resources that a user is allowed to call/see.
   
   Example screenshots from legacy UI, templates have the account/domain 
information for an account of role type User:
   ![Screenshot from 2020-07-01 
07-48-12](https://user-images.githubusercontent.com/95203/86195936-a7d8f900-bb6f-11ea-88c3-90d2401d4261.png)
   
   Example screenshots from legacy UI, projects have the account/domain 
information for an account of role type User who was invited to be part of the 
project:
   ![Screenshot from 2020-07-01 
07-50-18](https://user-images.githubusercontent.com/95203/86195938-a90a2600-bb6f-11ea-9b64-0724a8d44fd6.png)
   
   Domain admin would be able to see resources in the domain created/owned by 
other accounts, so I reviewed the list of resources mentioned in this ticket 
for the "User" role accounts;
   
   Most items in the following list will have the "User" account's own 
resources and do not usually possess a leakage of account and domain 
information to other "User" accounts:
   Kubernetes
   Instance Groups
   SSH Key Pairs
   Affinity Groups
   Volumes
   Snapshots
   VM Snapshots
   Backups
   Guest Networks (I checked shared networks say created by an Admin account 
will only leak domain but not account name)
   VPC
   Security Groups
   Public IP addresses
   VPN Customer Gateway
   
   Only the following resources are generally shared with other 
accounts/projects which may show the account/domain information:
   Templates
   ISOs
   Projects
   
   In summary, this is not a UI blocker:
   - the API response is returning the information and so does the legacy UI 
show the same information in detail view (if not list view)
   - some enterprise users may argue on backward compatibility and want the 
behaviour continued and may they want their accounts  to know which 
account/domain was responsible for creating and sharing a community/shared 
template/iso and project
   - while public clouds may not have this issue if they don't allow 
creating/sharing of public templates/isos
   
   I'll lower the severity to Major, if you disagree start a discussion thread 
on dev@ @PaulAngus 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd edited a comment on issue #475: [BUG] Many screens show Account and Domain to non-root admins when they should not.

2020-06-30 Thread GitBox


rhtyd edited a comment on issue #475:
URL: 
https://github.com/apache/cloudstack-primate/issues/475#issuecomment-652147779


   @PaulAngus we also show the information in most screens (detail views if not 
list/table view) in legacy UI, ultimately the API response contains account and 
domain information for resources that a user is allowed to call/see.
   
   Example screenshots from legacy UI, templates have the account/domain 
information for an account of role type User:
   ![Screenshot from 2020-07-01 
07-48-12](https://user-images.githubusercontent.com/95203/86195936-a7d8f900-bb6f-11ea-88c3-90d2401d4261.png)
   
   Example screenshots from legacy UI, projects have the account/domain 
information for an account of role type User who was invited to be part of the 
project:
   ![Screenshot from 2020-07-01 
07-50-18](https://user-images.githubusercontent.com/95203/86195938-a90a2600-bb6f-11ea-9b64-0724a8d44fd6.png)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on issue #475: [BUG] Many screens show Account and Domain to non-root admins when they should not.

2020-06-30 Thread GitBox


rhtyd commented on issue #475:
URL: 
https://github.com/apache/cloudstack-primate/issues/475#issuecomment-652147779


   @PaulAngus we also show the information in most screens (detail views if not 
list/table view) in legacy UI, ultimately the API response contains account and 
domain information for resources that a user is allowed to call/see.
   
   Example screenshots from legacy UI, templates have the account/domain 
information:
   ![Screenshot from 2020-07-01 
07-50-18](https://user-images.githubusercontent.com/95203/86195938-a90a2600-bb6f-11ea-9b64-0724a8d44fd6.png)
   
   ![Screenshot from 2020-07-01 
07-48-12](https://user-images.githubusercontent.com/95203/86195936-a7d8f900-bb6f-11ea-88c3-90d2401d4261.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] ACSGitBot commented on pull request #140: [WIP] Update xenserver.rst

2020-06-30 Thread GitBox


ACSGitBot commented on pull request #140:
URL: 
https://github.com/apache/cloudstack-documentation/pull/140#issuecomment-651853694


   Build finished.  You can review it at:   
https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr140
   
   Build Log Output:
   
   
   No log errors found to report.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] ACSGitBot commented on pull request #140: [WIP] Update xenserver.rst

2020-06-30 Thread GitBox


ACSGitBot commented on pull request #140:
URL: 
https://github.com/apache/cloudstack-documentation/pull/140#issuecomment-651852442


   Your request had been received, i'll go and build the documentation and 
check the output log for errors.
   
   This shouldn't take long.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] ACSGitBot removed a comment on pull request #140: [WIP] Update xenserver.rst

2020-06-30 Thread GitBox


ACSGitBot removed a comment on pull request #140:
URL: 
https://github.com/apache/cloudstack-documentation/pull/140#issuecomment-651672594







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] andrijapanicsb removed a comment on pull request #140: [WIP] Update xenserver.rst

2020-06-30 Thread GitBox


andrijapanicsb removed a comment on pull request #140:
URL: 
https://github.com/apache/cloudstack-documentation/pull/140#issuecomment-651672542


   requesting docbuild



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] PaulAngus opened a new issue #473: Templates screen should not show 'order' column to non-root admins

2020-06-30 Thread GitBox


PaulAngus opened a new issue #473:
URL: https://github.com/apache/cloudstack-primate/issues/473


   **Describe the bug**
   A clear and concise description of what the bug is.
   
   Someone of type 'user' should not be able to see the Order column - it's not 
a user-supported function.
   
   
   **To Reproduce**
   Steps to reproduce the behavior:
   
   1. Log in as a normal user
   2. Go to 'Images -> templates'
   
   Order column is visible - this should only be visible to root admins
   
   **Expected behavior**
   
   The Order column should not be visible to normal users.
   
   **Screenshots**
   
![image](https://user-images.githubusercontent.com/4810220/86139071-348ba480-bae7-11ea-9f52-72de04b243d9.png)
   
   **Desktop (please complete the following information):**
- OS: [e.g. Windows, Mac, iOS, Android with device/screen details if 
applicable]
- Browser [e.g. chrome, safari]
- Version [e.g. 22]
   
   **Additional context**
   Add any other context about the problem here.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #353: UI changes for Dynamic roles improvements

2020-06-30 Thread GitBox


blueorangutan commented on pull request #353:
URL: 
https://github.com/apache/cloudstack-primate/pull/353#issuecomment-651722056


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian 
:heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/353 (JID-2167)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #353: UI changes for Dynamic roles improvements

2020-06-30 Thread GitBox


blueorangutan commented on pull request #353:
URL: 
https://github.com/apache/cloudstack-primate/pull/353#issuecomment-651718905


   @borisstoyanov a Jenkins job has been kicked to build primate packages. I'll 
keep you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] borisstoyanov commented on pull request #353: UI changes for Dynamic roles improvements

2020-06-30 Thread GitBox


borisstoyanov commented on pull request #353:
URL: 
https://github.com/apache/cloudstack-primate/pull/353#issuecomment-651718631


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani opened a new pull request #472: Fixing permission issues

2020-06-30 Thread GitBox


davidjumani opened a new pull request #472:
URL: https://github.com/apache/cloudstack-primate/pull/472


   Fixes #463 
   
   Compute:
   
   - [ ] SSH keys: create SSH key without specifying public key creates private 
key, could we make it easier for user to copy or download it? Or, simply cause 
a file to be downloaded after the form finishes.
   
   Network:
   
   - [ ] VPN users: add user causes failure (could be backend issue, or this 
needs to be allowed only after VPN is enabled on some network?)
   - [x] After adding VPC tier it does not refresh the network/tiers list
   
   Templates:
   
   - [x] Edit Template and edit Template permission action show to user 
(restrict to owner or domain/admin?)
   - [x] Copy and Delete Template show irrespective of user/account/acl checks
   - [x] Setting tab show for edit/add settings to templates to non-owner/user 
(read-only is fine)
   - [x] Download template buttons show without doing checks (only Domain Admin 
and regular users can modify only their own Public templates)
   - [x] Users are unable to edit their template - Don't show isrouting 
parameter is create/edit template for users
   
   ISOs:
   
   - [x] Edit ISO and edit ISO permission action show to user (restrict to 
owner or domain/admin?)
   - [x] Copy and Delete ISO show irrespective of user/account/acl checks
   - [x] Download ISO button show without doing checks (only Domain Admin and 
regular users can modify only their own Public templates)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #459: Display tab showing the current resource count for domain

2020-06-30 Thread GitBox


rhtyd commented on pull request #459:
URL: 
https://github.com/apache/cloudstack-primate/pull/459#issuecomment-651688491


   @ravening we can skip those or show a progress bar with no progress (0%) as 
the limit is unlimited?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on issue #455: Another Usability Issues List

2020-06-30 Thread GitBox


rhtyd commented on issue #455:
URL: 
https://github.com/apache/cloudstack-primate/issues/455#issuecomment-651687570


   With @davidjumani 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on issue #466: Usability: Explain what states mean

2020-06-30 Thread GitBox


rhtyd commented on issue #466:
URL: 
https://github.com/apache/cloudstack-primate/issues/466#issuecomment-651686320


   With @davidjumani 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on issue #471: Logged in from event to use x-forward ip

2020-06-30 Thread GitBox


rhtyd commented on issue #471:
URL: 
https://github.com/apache/cloudstack-primate/issues/471#issuecomment-651685772


   @gaaray2k this is not a UI issue, please log against apache/cloudstack repo; 
I think X-Forwarded-Host is already supported



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd closed issue #471: Logged in from event to use x-forward ip

2020-06-30 Thread GitBox


rhtyd closed issue #471:
URL: https://github.com/apache/cloudstack-primate/issues/471


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] ACSGitBot commented on pull request #140: [WIP] Update xenserver.rst

2020-06-30 Thread GitBox


ACSGitBot commented on pull request #140:
URL: 
https://github.com/apache/cloudstack-documentation/pull/140#issuecomment-651673748


   Build finished.  You can review it at:   
https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr140
   
   Build Log Output:
   
   
   No log errors found to report.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] ACSGitBot commented on pull request #140: [WIP] Update xenserver.rst

2020-06-30 Thread GitBox


ACSGitBot commented on pull request #140:
URL: 
https://github.com/apache/cloudstack-documentation/pull/140#issuecomment-651672594


   Your request had been received, i'll go and build the documentation and 
check the output log for errors.
   
   This shouldn't take long.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] andrijapanicsb commented on pull request #140: [WIP] Update xenserver.rst

2020-06-30 Thread GitBox


andrijapanicsb commented on pull request #140:
URL: 
https://github.com/apache/cloudstack-documentation/pull/140#issuecomment-651672542


   requesting docbuild



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani commented on pull request #458: Adding quick-view options to list view

2020-06-30 Thread GitBox


davidjumani commented on pull request #458:
URL: 
https://github.com/apache/cloudstack-primate/pull/458#issuecomment-651631833


   @rhtyd @shwstppr good to go!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #469: Diabling actions for readonly admin

2020-06-30 Thread GitBox


blueorangutan commented on pull request #469:
URL: 
https://github.com/apache/cloudstack-primate/pull/469#issuecomment-651617760


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian 
:heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/469 (JID-2166)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #469: Diabling actions for readonly admin

2020-06-30 Thread GitBox


blueorangutan commented on pull request #469:
URL: 
https://github.com/apache/cloudstack-primate/pull/469#issuecomment-651613065


   @davidjumani a Jenkins job has been kicked to build primate packages. I'll 
keep you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani commented on pull request #469: Diabling actions for readonly admin

2020-06-30 Thread GitBox


davidjumani commented on pull request #469:
URL: 
https://github.com/apache/cloudstack-primate/pull/469#issuecomment-651612284


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani commented on pull request #469: Diabling actions for readonly admin

2020-06-30 Thread GitBox


davidjumani commented on pull request #469:
URL: 
https://github.com/apache/cloudstack-primate/pull/469#issuecomment-651609819


   @rhtyd Would that apply only to user vms or systemvms too ?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani removed a comment on issue #467: Read-only admin issues

2020-06-30 Thread GitBox


davidjumani removed a comment on issue #467:
URL: 
https://github.com/apache/cloudstack-primate/issues/467#issuecomment-651609518


   Would that apply only to user vms or systemvms too ?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] davidjumani commented on issue #467: Read-only admin issues

2020-06-30 Thread GitBox


davidjumani commented on issue #467:
URL: 
https://github.com/apache/cloudstack-primate/issues/467#issuecomment-651609518


   Would that apply only to user vms or systemvms too ?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org