[GitHub] [cloudstack-primate] slavkap commented on issue #836: [BASIC NETWORK TESTING] - Now start VM Zone Selection Bug

2020-12-06 Thread GitBox


slavkap commented on issue #836:
URL: 
https://github.com/apache/cloudstack-primate/issues/836#issuecomment-739716617


   @rhtyd I've tested with the fix and it's work correct



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #891: Primary Storage: Fix empty server details for SharedMountPoint protocol

2020-12-06 Thread GitBox


blueorangutan commented on pull request #891:
URL: 
https://github.com/apache/cloudstack-primate/pull/891#issuecomment-739667992


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian 
:heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/891 (JID-3727)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #891: Fix empty server details for SharedMountPoint protocol

2020-12-06 Thread GitBox


blueorangutan commented on pull request #891:
URL: 
https://github.com/apache/cloudstack-primate/pull/891#issuecomment-739665063


   @Pearl1594 a Jenkins job has been kicked to build primate packages. I'll 
keep you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #891: Fix empty server details for SharedMountPoint protocol

2020-12-06 Thread GitBox


Pearl1594 commented on pull request #891:
URL: 
https://github.com/apache/cloudstack-primate/pull/891#issuecomment-739664778


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] Pearl1594 opened a new pull request #891: Fix empty server details for SharedMountPoint protocol

2020-12-06 Thread GitBox


Pearl1594 opened a new pull request #891:
URL: https://github.com/apache/cloudstack-primate/pull/891


   Selecting SharedMountPoint protocol while adding a Primary Store throws an 
error claiming the server detail is null:
   
![image](https://user-images.githubusercontent.com/10495417/101311348-3405ef80-3877-11eb-94d9-67f7097b8c35.png)
   
   This PR fixes this by passing the server detail as localhost



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #890: Fixes - OS type combo box not respond

2020-12-06 Thread GitBox


blueorangutan commented on pull request #890:
URL: 
https://github.com/apache/cloudstack-primate/pull/890#issuecomment-739638336


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian 
:heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/890 (JID-3726)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] blueorangutan commented on pull request #890: Fixes - OS type combo box not respond

2020-12-06 Thread GitBox


blueorangutan commented on pull request #890:
URL: 
https://github.com/apache/cloudstack-primate/pull/890#issuecomment-739635816


   @utchoang a Jenkins job has been kicked to build primate packages. I'll keep 
you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] utchoang commented on pull request #890: Fixes - OS type combo box not respond

2020-12-06 Thread GitBox


utchoang commented on pull request #890:
URL: 
https://github.com/apache/cloudstack-primate/pull/890#issuecomment-739635681


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] utchoang opened a new pull request #890: Fixes - OS type combo box not respond

2020-12-06 Thread GitBox


utchoang opened a new pull request #890:
URL: https://github.com/apache/cloudstack-primate/pull/890


   Fixes #889 
   @rhtyd @davidjumani cc @svenvogel Please review it. Thanks.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] PaulAngus edited a comment on issue #835: [FEATURE] server: update template to another template type

2020-12-06 Thread GitBox


PaulAngus edited a comment on issue #835:
URL: 
https://github.com/apache/cloudstack-primate/issues/835#issuecomment-739556047


   Thanks for clarifying @ravening, but that make might make it worse as:
   
   - The description does not suggest that the system VM template that was 
active is updated to inactive. - leaving the DB in an inconsistent state.
   - The testing description only says that only user -> system was tested.  
   - And I can't _see_ anything that looks like the backend operations like 
downloading system VM templates to all secondary storage pools. 
   - User VM templates are only supposed to be in one pool, so what happens 
there? Cloudstack isn't going to be expecting user templates in all sec storage 
pools - hows deletion and GC going to work?
   - Builtin templates should be in all secondary storage pools as well. do 
they get downloaded?
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] PaulAngus commented on issue #835: [FEATURE] server: update template to another template type

2020-12-06 Thread GitBox


PaulAngus commented on issue #835:
URL: 
https://github.com/apache/cloudstack-primate/issues/835#issuecomment-739556047


   Thanks for clarifying @ravening, but that make might make it worse as:
   
   - The description does not suggest that the system VM template that was 
active is updated to inactive. - leaving the DB in an inconsistent state.
   - The testing description only says that only user -> system was tested.  
   - And I can't _see_ anything that looks like the backend operations like 
downloading system VM templates to all secondary storage pools. 
   - User VM templates are only supposed to be in one pool, so what happens 
there Cloudstack isn't going to be expecting user templates in all sec storage 
pools - hows deletion and GC going to work?
   - Builtin templates should be in all secondary storage pools as well. do 
they get downloaded?
   - Builtin templates also should be in all storage pools.
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] ravening commented on issue #835: [FEATURE] server: update template to another template type

2020-12-06 Thread GitBox


ravening commented on issue #835:
URL: 
https://github.com/apache/cloudstack-primate/issues/835#issuecomment-739547525


   @PaulAngus  if I'm not mistaken, even in backend, you can change template 
type from any to any



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] PaulAngus commented on issue #835: [FEATURE] server: update template to another template type

2020-12-06 Thread GitBox


PaulAngus commented on issue #835:
URL: 
https://github.com/apache/cloudstack-primate/issues/835#issuecomment-739542026


   The proposed UI change does not match the functionality described in the 
Backend PR which only allows changes between user and system. the UI screenshot 
shows changes to/from all types.
   
   
![image](https://user-images.githubusercontent.com/4810220/101288528-0aa18100-37ef-11eb-8dd5-dc853702aae9.png)
   
   The UI change needs reverting -admins can use the API.
   
   The [(https://github.com/apache/cloudstack/pull/3945)]  logic also looks to 
be flawed, as the description does not suggest that the system VM template that 
was active is updated to inactive.  - leaving the DB in an inconsistent state. 
   
   it **_really_** needs fixing or reverting.
   
   @rhtyd @DaanHoogland @weizhouapache @ravening 
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org