GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/680
Interface changes related to CLOUDSTACK-8580
See issue CLOUDSTACK-8580 and individual commits.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/679#issuecomment-130612388
@wido @remibergsma @koushik-das Folowed up on lastest comments by Remi and
Koushik.
---
If your project is set up for it, you can reply to this email and have
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/680#issuecomment-130659980
@remibergsma Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/709#issuecomment-132140803
@karuturi You should send a public key which has it's special characters (
SPACE / - % ) replaced with uri compatible escape characters. - encoding
http
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/705#issuecomment-131808466
@DaanHoogland I did the following;
- Refactored NicProfile.java (in 1 go)
- Changed names in every file llinked to NicProfile to make sure
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/705
Refactored NicProfile.java for readability.
Only changed names and reorganized them! No functional implementation
change.
See issue CLOUDSTACK-8736 for ongoing effort to clean up
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/705#issuecomment-132115146
Hi @karuturi
The pull analysis failure is unrelated. -- Checkstyle errors in code I
didn't touch
The errors in the master build are being
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/709#issuecomment-132106862
@karuturi Cloudmonkey passes an single encoded public key, as it's supposed
to!
---
If your project is set up for it, you can reply to this email and have your
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/707#issuecomment-132187698
@karuturi I see, fixed them in a new commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/720#issuecomment-132630872
This closes #384. Squashed to commits into 1 as requested per comment.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/720
CLOUDSTACK-8308: Adding automation testcases for Delta Snapshot.
CLOUDSTACK-8308: Updating automation testcases for Delta Snapshot testpath.
Reference to #384
You can merge
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/716#issuecomment-132646596
@remibergsma You are correct. Those are all not related to the
AddressFormat enum. Of course all should be renamed, but doing so in 1 time
will also
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/384#issuecomment-132631777
See #720 - Resolved comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/720#issuecomment-132631927
@remibergsma @bhaisaab Any more comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/721#issuecomment-132813609
LGTM We've tested the git-pr script with #705 #709 #708.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/726#issuecomment-133399200
@remibergsma @karuturi Please review!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/726#issuecomment-133398943
Tested it in a new environment. The nics are correctly put in the db again.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/726#issuecomment-133408184
@karuturi I came to that conclusion in the previous pr. I will stack all
refactoring work in a branch. And send a PR when done.
---
If your project is set up
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/726
Fix for the NicVO.java regression.
Renamed set*() methods to correct naming.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/borisroman
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/726#issuecomment-133395038
The updateBuilder will check if the DAO has changed based on the set*()
methods. When it can't resolve one, it won't update. After learning this I
changed
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/716
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/716#issuecomment-133758939
Will do.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/707
Refactored Nic.java for readability.
Only changed names and reorganized them! No functional implementation
change.
See issue CLOUDSTACK-8736 for ongoing effort to clean up network
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/707#issuecomment-131871473
@DaanHoogland You are right. I squashed to commits together so there will
not be a non-working commit left.
---
If your project is set up for it, you can reply
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/716
Changed AddressFormat elements to reflect changes in IPv4 and IPv6 refactor.
See issue CLOUDSTACK-8736 for ongoing effort to clean up network code.
You can merge this pull request into a Git
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/615#issuecomment-131960910
Looked into it. See PR #709
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/709#issuecomment-131968267
It was double encoded because encodeURIComponent() and jQuery.param()
encoded it. The latter does this automatically because the request is of type
post
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/709
Removed double encoding of Public Key from JS.
See Cloudstack issue CLOUDSTACK-8742 CLOUDSTACK-8649 for information.
You can merge this pull request into a Git repository by running
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/731#issuecomment-134071270
LGTM - Deployed on Centos7 started 2 systemvms, 1 router and 1 guest vm
without libvirt errors.
---
If your project is set up for it, you can reply
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/651
CLOUDSTACK-8703: Fixed issue when listing directory on S3.
It would only return objectSummaries when the anwser from the S3 System was
truncated.
You can merge this pull request into a Git
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/651#discussion_r36103980
--- Diff: utils/src/com/cloud/utils/S3Utils.java ---
@@ -352,10 +352,15 @@ public static File getFile(final ClientOptions
clientOptions, final String
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/651#discussion_r36103914
--- Diff: utils/src/com/cloud/utils/S3Utils.java ---
@@ -352,10 +352,15 @@ public static File getFile(final ClientOptions
clientOptions, final String
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/679
Added Virtualmachine count and ID's to listSecurityGroups response
See issue CLOUDSTACK-8133 for more information.
You can merge this pull request into a Git repository by running
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/commit/f4449b62d93e56d9f62fac06922b12381a51b8e4#commitcomment-12645845
The re-positioning of the imports is an automated feature of Eclipse.
---
If your project is set up for it, you can reply
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/664#issuecomment-128682659
@karuturi @DaanHoogland @remibergsma As discussed on Slack August 3rd.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/664#issuecomment-128689329
We've used the following scripts to remove the trailing white spaces and
leading tabs:
Tabs to 4 white spaces:
find . -iname '*.js' -type f
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/680#issuecomment-131036175
@wido @DaanHoogland Removed last comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/680#issuecomment-130232580
@wilderrodrigues @DaanHoogland @remibergsma Here are the interface changes
related to #593.
---
If your project is set up for it, you can reply to this email
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/679#issuecomment-130231279
@wilderrodrigues @DaanHoogland @remibergsma Here are the interface changes
related to https://github.com/apache/cloudstack/pull/593.
---
If your project is set
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/679#issuecomment-130313964
@koushik-das Added tests. Please have a look!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/614
CLOUDSTACK-8649: Fixed unnecessary double url decoding in
registerSSHKeyPair.
The method cmd.getPublicKey() already returns a decoded string. So when we
try to decode it again the plus
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/614
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/612#issuecomment-123661436
The https://builds.apache.org/job/cloudstack-pull-requests fail after
adding the Default Charset test. I think the localization of the Jenkins server
needs
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/615
CLOUDSTACK-8649: Fixed unnecessary double url decoding in
registerSSHKeyPair.
The method cmd.getPublicKey() already returns a decoded string. So when we
try to decode it again the plus
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/598
CLOUDSTACK-8642: SSO Method not allowed bug fix.
Due to CLOUDSTACK-8505 and commit 1c81b241e7914b24b06c3b7b3ee98bc0d3b4f68b
only POST methods are allowed. This needs to be explicitly stated
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/597
Cloudstack 8642: Fix to use POST method instead of GET method.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/borisroman/cloudstack
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/597
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/593
CLOUDSTACK-8580
Users are now able to view, expunge and recover their vm's themselves. Two
configuration options are added to allow this behaviour on a global or per
account scale
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/589
CLOUDSTACK-8580
CLOUDSTACK-8580 Users are now able to view, expunge and recover their vm's
themselves. Two configuration options are added to allow this behaviour on a
global or per account
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/593#issuecomment-121600559
Added description to title.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/589
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/958#issuecomment-149918708
LGTM :+1:
```
$ mvn clean install -T2C -Pdeveloper,systemvm
```
```
[INFO
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/959#issuecomment-149901843
@wilderrodrigues Done.
Test results:
```
=== TestName: test_03_ssvm_internals | Status : SUCCESS ===
ok
=== TestName
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/954#issuecomment-150657287
@snuf @remibergsma I like this idea. I actually think we should have this
kind behavior everywhere...
Here's another example of non-deterministic
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/970#issuecomment-150662299
Based on code review, LGTM :+1:
I haven't spun up a cluster to run integration tests...
---
If your project is set up for it, you can reply
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/954#issuecomment-150661801
@jburwell I think it should be 2 commits... They fix 2 different things.
The first fixes the Guru issue, while the second one makes it possible to
create
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/890
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/932#issuecomment-150553777
@DaanHoogland Could you please have a look again?
```
WARN [c.c.a.m.AgentManagerImpl] (StatsCollector-1:ctx-94b6fe0e) Exception
while sending
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/963#issuecomment-150547987
@remibergsma All green now! LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/936#issuecomment-150578738
@remibergsma Did the same :) KVM Basic setup though. Integeration test:
smoke/test_vm_life_cycle.py returned all success!
LGTM :+1:
---
If your
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/965#issuecomment-150646084
Compilation and testing went successfull. As it only involved a change of a
unit test, I hadn't ran integration tests.
```
Running
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/973#issuecomment-150647352
@DaanHoogland IMHO I think the unit test is a bit inconclusive. It would
pass if 8 out of 10 of the possible prefixes were removed
And maybe remove
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/962#issuecomment-150325540
@snuf The
org.apache.cloudstack.utils.hypervisor.HypervisorUtilsTest.checkVolumeFileForActivityTest(HypervisorUtilsTest.java:70)
test is IMHO a known issue
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/967#issuecomment-150324755
@wilderrodrigues i'm on it when it's ready!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/932#issuecomment-150010981
@DaanHoogland I tested this PR again today.
When using the listSystemVms API call:
```
INFO [c.c.a.ApiServer] (1975058800@qtp-1945752215-4
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/964#issuecomment-150979025
@remibergsma @snuf I've run the following tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=false
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/860#issuecomment-151089307
@remibergsma @karuturi I tested this PR with the changes in #979. Results:
```
nosetests --with-marvin
--marvin-config=/data/shared/marvin/mct-zone1
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/979
CLOUDSTACK-8989 test_ps_limits.py tests can also be run on a "basic" setup.
The tests in the test_ps_limits.py file can all be run on a "basic" setup.
This PR adds that
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/860#issuecomment-151096159
@karuturi Jenkins failed;
[ERROR] Error in Cobertura Report generation: Unable to execute Cobertura.
Could maybe force push again?
---
If your
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/950#issuecomment-151055701
Can't we include it as dependency? Or are there licencing issues?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/932#issuecomment-151299203
Well...
We could have expected it...
https://sites.google.com/site/gson/gson-roadmap
After version 2.0 Primtive Types weren't allowed
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/986#issuecomment-151490397
Ping @remibergsma, when Jenkins is happy to may merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/979
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/979
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user borisroman reopened a pull request:
https://github.com/apache/cloudstack/pull/979
[4.6] CLOUDSTACK-8989 test_ps_limits.py tests can also be run on a "basic"
setup.
The tests in the test_ps_limits.py file can all be run on a "basic"
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/986#issuecomment-151490241
@wido LGTM :+1:
```
Running com.cloud.hypervisor.kvm.storage.LibvirtStoragePoolTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time
GitHub user borisroman reopened a pull request:
https://github.com/apache/cloudstack/pull/979
[4.6] CLOUDSTACK-8989 test_ps_limits.py tests can also be run on a "basic"
setup.
The tests in the test_ps_limits.py file can all be run on a "basic"
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1005#issuecomment-152213938
@wido You'd onky changed a methode name and added a getter. But no Unit
test were added right? Forgot "git add ." before commiting?
---
If your proj
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1002#issuecomment-152264912
@remibergsma @wilderrodrigues Also ran the test against PR #981 => LGTM
:+1:
```
=== TestName: test_router_dhcphosts | Status : SUCCESS ===
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/832#issuecomment-152337266
@remibergsma @wilderrodrigues @DaanHoogland Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-150802394
@rodrigo93 You changed the PR title, nog thr commit title. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/979#issuecomment-151556191
@remibergsma Jenkins happy :)
https://builds.apache.org/job/cloudstack-pull-analysis/1008/
---
If your project is set up for it, you can reply
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/978#issuecomment-151636411
@remibergsma LGMT :+1:
:
if self.dev
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/961#issuecomment-151636873
@ustcweizhou I'm not experiencing any problems...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/989#discussion_r43184165
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
@@ -602,9 +610,8 @@ def compare(self, bag):
if self.dev
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/983#issuecomment-151893972
@terbolous It doesn't effect log-rotating at all. This just let's the
password_server_ip.py logs to be written to /var/log/cloud.log instead of
/dev/nul
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/983#issuecomment-151894028
@karuturi I'll check again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/989#issuecomment-151953800
@wilderrodrigues Ok! Code LGTM :+1: @remibergsma
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/989#issuecomment-151944891
@remibergsma The comments I placed are fixed in
50827f7e4ba90e2cbf163a9946c84d1835630ead. Though this introduces my new
comment; can the commits be squashed
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/983#issuecomment-151950464
@remibergsma I think it might be the problem, which also caused my vr to
not restart... Looking into it
---
If your project is set up for it, you can reply
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/998#issuecomment-151957189
@wilderrodrigues @remibergsma LGTM :+1:
Tested VM password manually => working!
```
nosetests --with-marvin
--marvin-config=/data/sha
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/983
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/983#issuecomment-152114882
@remibergsma Thanks for the effort. This was what also caused my vr to not
reboot... Knowing that I closed the PR yesterday. Will look into it and test
more
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/980
CLOUDSTACK-8992 Allow 32 disks to be attached to a KVM VM.
Tested manually.
Added 32 disks to a VM, booted the VM, formatted all disks and mounted them
all. Also created volume
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/950#issuecomment-150670213
@miguelaferreira Could you force push your commit again? So we're all
green? :)
---
If your project is set up for it, you can reply to this email and have your
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-150672917
@rodrigo93 Thanks for squashing! Could you also rename the commit title to
something more sensible?
---
If your project is set up for it, you can reply
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/961#issuecomment-150667050
Verified with curl -v => LGTM :+1:
Before:
```
[root@cs1 cloudstack]# curl -v 192.168.22.61:8080/client/
* About to conn
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/972#issuecomment-150668944
Ok, here they are:
```
=== TestName: test_isolate_network_FW_PF_default_routes | Status : SUCCESS
===
ok
=== TestName
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/954#issuecomment-150672117
@ustcweizhou You may do so! Then also separate the ticket.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
1 - 100 of 305 matches
Mail list logo
