GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack-docs-rn/pull/16
removed 'CloudStack on Windows' from 4.4.0 RN
http://markmail.org/message/n7rkzugnjtnmpb2a
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack-docs/pull/6
updated instructions to install jdk1.7
for apt-get and yum corrected the java install commands to install jdk1.7
You can merge this pull request into a Git repository by running:
$ git
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack-docs-admin/pull/15
CLOUDSTACK-6634
updated the ldap section in admin guide
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/karuturi/cloudstack-docs
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack-docs-admin/pull/15#issuecomment-52734745
closing it as it is merged to upstream
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user karuturi closed the pull request at:
https://github.com/apache/cloudstack-docs-admin/pull/15
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack-docs-admin/pull/17
moved ldap.firstname.attribute to the correct section.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/karuturi/cloudstack-docs
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/15#issuecomment-54590261
If JAVA_HOME is not set, setJavaHome()(cloud-usage.rc:49) method is trying
to find it from default java available using something like
`JAVA_HOME=$(dirname
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/15#issuecomment-54608409
ok. understood. Thanks.
I am committing this to master. Do you want this in any other branch?
---
If your project is set up for it, you can reply
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/17#issuecomment-54777280
4.4:packaging/debian/init/cloud-usage already has the new logic to set
$JAVA_HOME (e77da80e01b0774951e5c2ab1b23539af002b8b4)
Given that it is already in 4.3
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack-docs-admin/pull/20
CLOUDSTACK-6634: added more details for ldap ssl
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/karuturi/cloudstack-docs-admin
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack-docs-install/pull/9
doc for enabling CSP support on xenserver 6.1
https://issues.apache.org/jira/browse/CLOUDSTACK-6574
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack-docs-install/pull/15
corrected the java version to 1.7
changed java package and JAVA_HOME to 1.7
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/27#issuecomment-61086586
shouldnt this go in 4.5 as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack/pull/34
CLOUDSTACK-7242: Adding a securing config using configDepo doesnt work
In ConfigurationVo, changed the setter to do the encryption if required
like the getter. Called the setter
Github user karuturi closed the pull request at:
https://github.com/apache/cloudstack/pull/34
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack/pull/35
Fixed CLOUDSTACK-7242: Adding a securing config using configDepo doesnt ...
In ConfigurationVo, changed the setter to do the encryption if required
(like the getter). Called the setter
Github user karuturi closed the pull request at:
https://github.com/apache/cloudstack/pull/35
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack/pull/36
Merge 4.5 to master
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/karuturi/cloudstack merge-4.5-to-master
Alternatively you can review
Github user karuturi closed the pull request at:
https://github.com/apache/cloudstack/pull/36
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack/pull/37
Fixed coverity issue
CID 11461 (#1 of 1): DLS: Dead local store (FB.DLS_DEAD_LOCAL_STORE)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user karuturi closed the pull request at:
https://github.com/apache/cloudstack/pull/37
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack/pull/38
Merge 4.5 to master
I saw conflicts in the following two commits and resolved in favour of
master commit
4.5: d82e556dcd980bac50f27eaca284983808e04b1c
master
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack/pull/42
Merge 4.5 to master
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/karuturi/cloudstack merge-45-to-master
Alternatively you can review
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/39#issuecomment-63428603
From the method definition (isVmAlive), looks like what it is doing is
right.
ideally, we should change the return type from Boolean to boolean in the
interface
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/40#discussion_r20487864
--- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
---
@@ -3723,6 +3723,10 @@ public NetworkOffering
createNetworkOffering
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/41#discussion_r20488370
--- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
---
@@ -725,6 +725,21 @@ private String validateConfigurationValue(String name
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/41#discussion_r20488404
--- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
---
@@ -725,6 +725,21 @@ private String validateConfigurationValue(String name
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/41#issuecomment-63430386
Can you add unittests for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/39#issuecomment-63430873
In the second return statement, should it return false since the agent is
alive and returned some status?
I didnt understand the argument for not adding
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/41#discussion_r20492616
--- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
---
@@ -725,6 +725,21 @@ private String validateConfigurationValue(String name
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/41#discussion_r20492860
--- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
---
@@ -725,6 +725,21 @@ private String validateConfigurationValue(String name
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/39#issuecomment-63441065
I dont see a case when it could return false then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user karuturi closed the pull request at:
https://github.com/apache/cloudstack/pull/42
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack/pull/45
Merge 4.5 to master
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/karuturi/cloudstack merge45-to-master
Alternatively you can review
Github user karuturi closed the pull request at:
https://github.com/apache/cloudstack/pull/45
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/47#issuecomment-66013624
I tested this with a noredist build. The stripped functions work fine ;)
I will apply the patch.
---
If your project is set up for it, you can reply
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack/pull/53
Merge 4.5 to master
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/karuturi/cloudstack merge-45-to-master-2
Alternatively you can review
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/53#issuecomment-66043331
sure Rohit.. waiting for travis to finish.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/53#issuecomment-66103841
sure @runseb. I can help with that.
rebase master on noawsapi branch would required a force push.
This is what I think we can do here is
1. create a new
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/47#issuecomment-66104188
missed adding a link to the pr in commit message
4.3: 7d17e95991035beeb802483a4b3d98df0dc9c8e8
4.4: c8882b39ec6ba84355a70c2f59f01a422e906b31
4.5 and master
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack-docs-install/pull/19#issuecomment-66951888
@terbolous are you doing the merge? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/59#issuecomment-67445120
@K0zka thanks for the pull request.
I have been running jetty9 on my local without any issue. I dont think the
test failures has anything to do with this change
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/69#issuecomment-72786877
Should we also raise another defect to fix this properly as outlined by you
here? http://markmail.org/message/cr4bfzvl6eyfisb5
---
If your project is set up
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/66#issuecomment-70210894
Thanks for the patch. Agree to the slash change. I am pushing this to
master(4.6). Let me know if you want it on any other branch.
---
If your project is set up
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/66#discussion_r22932788
--- Diff: server/src/com/cloud/server/ConfigurationServerImpl.java ---
@@ -894,6 +894,13 @@ protected void
injectSshKeysIntoSystemVmIsoPatch(String
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/66#issuecomment-69908275
In case of windows, python scripts are executed and I think it runs fine
from cygwin. Is this change targeted to make it work from cmd?
---
If your project is set
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/66#discussion_r22932649
--- Diff: server/src/com/cloud/server/ConfigurationServerImpl.java ---
@@ -894,6 +894,13 @@ protected void
injectSshKeysIntoSystemVmIsoPatch(String
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/104#issuecomment-77996504
@resmo May I know how you discovered this?
AFAIK, scp and sftp are working fine from ssvm and we do not need sftp
server on ssvm
Can we remove
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/100#issuecomment-77817353
I dont think this fixes the issue. we are specifying a version number.
maven will not check for snapshots.
---
If your project is set up for it, you can reply
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/100#issuecomment-78038271
understood. This will definitely save build time. (will do the merge in
sometime)
But, the build will fail irrespective of whether snapshot is enabled right
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/104#issuecomment-78021815
@resmo Thanks for the explanation.
+1 for the sftp-server if it makes it faster :)
---
If your project is set up for it, you can reply to this email and have
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/108#issuecomment-78201760
looks good. merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/108#issuecomment-78202455
just an unrelated note. It would help for easy reading if the commit
message text width is set to 72. especially headline.
http://tbaggery.com/2008/04/19/a-note
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack-docs-install/pull/20#issuecomment-87557065
Hi @PaulAngus,
Thanks for the pull request
Author information in some of the commits is empty. I changed it to Paul
Angus paul.an
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/25#issuecomment-77317485
I added two commits on top of this
checkstyle issues fix: c5c1b1d4628c5fc7a402586325c7bf937f42766e
PMD issues fix: debcbcc1454789936407583fe0aba8e158b16cad
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/10#issuecomment-77123920
I dont think the main methods are required. Looks like they are there only
for testing. may be we should just delete the main methods.
---
If your project is set up
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/108#issuecomment-88835845
Hi @ghxandsky
After this change, if I install the rpm, its installing java 1.6. I am
trying on centos6.3 machine. if I give the version as java-1.7.0-openjdk
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/108#issuecomment-89206971
@ghxandsky
I fixed it on master yesterday. Please verify.
@bhaisaab
This is not pushed to 4.5
-Original Message-
From: Rohit
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/188#issuecomment-95822665
@agneya2001 some functionality like?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/199#discussion_r29309160
--- Diff:
engine/storage/image/src/org/apache/cloudstack/storage/image/store/TemplateObject.java
---
@@ -28,7 +28,6 @@
import
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack/pull/206
[MERGE] Browser based template or volume upload (resolved conflicts with
master)
Proposal discussion: http://markmail.org/message/ne6ucmnfqhkddnhu
FS and testplan:
https
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/199#issuecomment-97306176
closing this. created a new one #206
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user karuturi closed the pull request at:
https://github.com/apache/cloudstack/pull/199
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/206#issuecomment-97313324
since travis and jenkins are happy, I am merging this pull request.
@bhaisaab the js messaging/i18n changes will be handled through separate
pull requests
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack/pull/215
Fixed a few findbugs issues after the merge 0b83559
HttpUploadServerHandler.java:142, DM_BOXED_PRIMITIVE_FOR_PARSING
NfsSecondaryStorageResource.java:2630, DM_BOXED_PRIMITIVE_FOR_PARSING
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/215#issuecomment-97754239
Thanks Daan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/192#discussion_r29119746
--- Diff: packaging/centos63/cloud.spec ---
@@ -113,7 +113,7 @@ The Apache CloudStack files shared between agent and
management server
%package
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/199#discussion_r29224805
--- Diff:
services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/HttpUploadServerHandler.java
---
@@ -0,0 +1,295
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/199#discussion_r29224874
--- Diff:
engine/storage/image/src/org/apache/cloudstack/storage/image/store/TemplateObject.java
---
@@ -28,7 +28,6 @@
import
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/199#discussion_r29224917
--- Diff: systemvm/patches/debian/config/etc/init.d/cloud-early-config ---
@@ -1156,6 +1156,36 @@ setup_secstorage() {
fi
setup_apache2
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/218#issuecomment-98149776
@bhaisaab Thanks for the review. please dont merge this yet. Travis is
still failing and would like to fix it. It would be good to have abhi's
opinion
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/217#issuecomment-98048948
some of the travis jobs timedout. changes look good to me. merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/commit/fb0bfd5d4f446656cdb136f2a05e5b27f680578a#commitcomment-10998570
we shouldn't disable unittests in all the jobs.
I was thinking something like
https://github.com/karuturi/cloudstack
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/217#issuecomment-98052415
merged. forgot to add closes tag
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack/pull/218
travis: run junit tests only in one job
added DONOTRUNUNITTESTS variable for each of the jobs. The value is
false only in the first job
You can merge this pull request into a Git
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack/pull/220
maven plugin cleanup
1. removed redundant maven-site-plugin
2. added maven-resources-plugin version 2.7 which has the fix for
http://jira.codehaus.org/browse/MRESOURCES-140
You can
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/commit/fb0bfd5d4f446656cdb136f2a05e5b27f680578a#commitcomment-10998875
All the jobs except the first failed. looks like there are some unitest
failures. will debug and then put a PR. Also
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack/pull/219
Fixed two coverity reported issues
Dereference after null check
Dm: Dubious method used
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/219#issuecomment-98095126
In the current usage of it, they are utf8. Also, it uses UTF-8 for the key.
I will go ahead and merge. Thanks for the review Daan.
---
If your project
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/218#issuecomment-98097425
@abhinandanprateek
job 1: timedout. since its running unittests, should we decrease the tests
there? may be run only unit tests
job 9: timedout
job
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/commit/79a46fe0b4982e812d6a6ed0f08d1fe92b0b5e8d#commitcomment-10908911
In api/src/org/apache/cloudstack/api/command/user/iso/UpdateIsoCmd.java:
In api/src/org/apache/cloudstack/api/command
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack/pull/199
[MERGE] Browser based template or volume upload
We worked on below proposal for Browser based template or volume upload.
development effort from @bvbharat, Koushik Das and @karuturi
UI
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/220#issuecomment-98099270
travis failures are not related to this change. Pushing this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/218#issuecomment-98124888
these tests are explicitly disabled in the pom.xml using skipTests=true
refactored a but and not using skipTests now.
---
If your project is set up for it, you
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/218#issuecomment-98114499
job 1: timed out in the deploy datacenter phase. debugging
job10: timed out. removed one more test file
---
If your project is set up for it, you can reply
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/218#issuecomment-98117972
There are two unittests failing with the below error
```java
Running
org.apache.cloudstack.storage.resource.NfsSecondaryStorageResourceTest
Tests run: 1
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/233#issuecomment-101902069
@wilderrodrigues build-master-jdk18 is failing in jenkins.
http://jenkins.buildacloud.org/job/build-master-jdk18/38/
It fails on the below test
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/172#issuecomment-93635210
do we need this in 4.4? its a build time performance improvement.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack/pull/176
removed unused static main in ConsoleProxyPasswordBasedEncryptor
This closes #11
This closes #10
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack/pull/177
modified travis.yml added sudo: required
travis by default uses container based infra which doesnt not allow sudo.
http://docs.travis-ci.com/user/workers/container-based-infrastructure
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/177#issuecomment-93970920
Thanks @imduffy15. merged it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/168#issuecomment-93207386
@kwanggithub Thanks a lot for taking care of these issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/168#issuecomment-93206517
I can see more than 200 issues fixed after this patch on master. I will
merge it in sometime
---
If your project is set up for it, you can reply to this email
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/108#issuecomment-89913657
@ghxandsky, do you know why java = 1.7.0 is working with centos7 and not
with centos63? The surprising thing was, on 6.3 without failing due to missing
dependency
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack-docs-install/pull/21#issuecomment-91110630
Can you correct the author information in the commits?
It also shows some merge conflicts. Can you rebase and update?
---
If your project is set up
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack/pull/269
Fixed blocker issues reported by sonarqube in js files
All of them are trailing comma in array or object
more details @
https://analysis.apache.org/component_issues?id
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/321#issuecomment-108335819
np. Thanks for testing it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/334#issuecomment-108717787
Do we really need projectId here? The api doc says A template created
from this command is automatically designated as a private template visible to
the account
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/335#issuecomment-108718604
Can you add some unit/marvin tests?
Also, fix the commit msg header to 72 :)
http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/334#discussion_r31692655
--- Diff:
api/src/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java
---
@@ -215,33 +221,39 @@ public long getEntityOwnerId
1 - 100 of 1399 matches
Mail list logo
