[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1955 @karuturi 3 x LGTM, testing successful. Ready for Merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1955 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1941: CLOUDSTACK-8663: Fixed various issues to allow VM sn...
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1941 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1907: Fix public IPs not being removed from the VR when de...
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1907 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1948: [CLOUDSTACK-9793] Faster IP in subnet check
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1948 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1948: [CLOUDSTACK-9793] Faster IP in subnet check
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1948 LGTM from borisstoyanov in a commit comment (acspr) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #351: This branch implements the CSV and native HA support ...
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/351 tag:needslove --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/669 tag:needslove --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1885: CLOUDSTACK-9724: Fixed missing additional public ip ...
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1885 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1946: CLOUDSTACK-9788: Fix exception listNetworks with pag...
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1946 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1956: CLOUDSTACK-9796 - Fix NPE in VirtualMachineManagerIm...
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1956 LGTM by Rafael in commit review above (for acspr). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1915: CLOUDSTACK-9746 system-vm: logrotate config causes c...
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1915 We pulled this in and tested it alongside https://github.com/apache/cloudstack/pull/1954  We did remove the delay compress in our testing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1955 @remibergsma @ustcweizhou This might be of interest to you guys as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1954: CLOUDSTACK-9795: moved logrotate from cron.daily to ...
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1954 Tested in our QA environment. We cycled 2800 VMs through a VPC VR pair successfully over the weekend. The logs are rotating correctly as per the following screenshot:  LGTM based on testing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #977: [4.10] CLOUDSTACK-8746: VM Snapshotting implementatio...
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/977 @karuturi please see testing above. This PR now has working tests and is ready for merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #977: [4.10] CLOUDSTACK-8746: VM Snapshotting implementatio...
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/977 Great job all. I think this one is ready. @ustcweizhou @nathanejohnson --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #977: [4.10] CLOUDSTACK-8746: VM Snapshotting implementatio...
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/977 @ustcweizhou @nathanejohnson https://github.com/myENA/cloudstack/commit/7a2a1c1c432dd2e39065627eed38bd3fb429cf70 Nathan is going to test this for us. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #977: [4.10] CLOUDSTACK-8746: VM Snapshotting implementatio...
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/977 @ustcweizhou I'm working on fixing the tests. In regards to item 3, Is there actually an API call for this, rather that it just being on a timer thread? Maybe I'm blind, but I'm not seeing one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #977: [4.10] CLOUDSTACK-8746: VM Snapshotting implementatio...
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/977 @ustcweizhou @rhtyd So the vmsnapshot test seems might need some work. Here's the exception it threw: 2017-01-10 17:27:01,025 - CRITICAL - EXCEPTION: test_01_create_vm_snapshots: ['Traceback (most recent call last):\n', ' File "/usr/lib64/python2.7/unittest/case.py", line 369, in run\ntestMethod()\n', ' File "/marvin/tests/smoke/test_vm_snapshots.py", line 158, in test_01_create_vm_snapshots\n"Dsiplay Text"\n', ' File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 4702, in create\n return VmSnapshot(apiclient.createVMSnapshot(cmd).__dict__)\n', ' File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 1281, in createVMSnapshot\nresponse = self.connection.marvinRequest(command, response_type=response, method=method)\n', ' File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest\nraise e\n', 'CloudstackAPIException: Execute cmd: createvmsnapshot failed, due to: errorCode: 431, errorText:KVM VM does not allow to take a disk-only snapshot when VM is in running state\n'] The nuance here is that you need to specify snapshotmemory=true in order to take a KVM snapshot with the VM running. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #977: [4.10] CLOUDSTACK-8746: VM Snapshotting implementatio...
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/977 Based on functional testing LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #977: [4.10] CLOUDSTACK-8746: VM Snapshotting implementatio...
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/977 VM Snapshot revert was successful. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #977: [4.10] CLOUDSTACK-8746: VM Snapshotting implementatio...
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/977 VM snapshot revert live:   --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #977: [4.10] CLOUDSTACK-8746: VM Snapshotting implementatio...
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/977 VMsnapshot was successful with running VM as seen above. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #977: [4.10] CLOUDSTACK-8746: VM Snapshotting implementatio...
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/977    --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #977: [4.10] CLOUDSTACK-8746: VM Snapshotting implementatio...
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/977   --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #977: [4.10] CLOUDSTACK-8746: VM Snapshotting implementatio...
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/977  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1858: README: Happy Christmas, happy holidays!
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1858 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #977: [4.9] CLOUDSTACK-8746: VM Snapshotting implementation...
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/977 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #977: [4.9] CLOUDSTACK-8746: VM Snapshotting implementation...
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/977 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #977: [4.9] CLOUDSTACK-8746: VM Snapshotting implementation...
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/977 @ustcweizhou If you rebase it, I'll get it tested. The last time I tested this PR, it was looking really good. The only thing it needed was some restriction so that it returned an error if the primary storage wasn't NFS. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1606 I've added issue Jira CLOUDSTACK-9661 to track this. https://issues.apache.org/jira/browse/CLOUDSTACK-9661 @leprechau @rhtyd --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1741: Updated StrongSwan VPN Implementation
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1741 @jayapalu Can you expand on your findings regarding public ip order? Did you pull in the latest PR with the fixes from @swill? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1644: Honors the snapshot.backup.rightafter configuration ...
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1644 @jburwell We found an issue on Friday related to a use case related to snapshot to template. We're working on it. More soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1645: On snapshot backup, this converts the rbd raw format...
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1645 @karuturi - So, note that this feature addition only affects KVM when using RBD as the back-end storage. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #872: Strongswan vpn feature
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/872 Yeah, I think this one is dead unless it gets reworked into a new PR. We might be able to help a bit on this one as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1645: On snapshot backup, this converts the rbd raw format...
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1645 I took a look at the code last night and it seems that we're no longer specifying the source format when calling qemu-img convert. We're relying on qemu-img's auto detection of source format and just specifying the output format. See here: https://github.com/apache/cloudstack/blob/de173bd8921ef926ace405796b4037902ce1979e/plugins/hypervisors/kvm/src/org/apache/cloudstack/utils/qemu/QemuImg.java#L226 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1644: Honors the snapshot.backup.rightafter configuration ...
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1644 Pure RBD based revert is not supported today (plus it's really slow). The way we do it is we snap to volume (clone), shut the vm down, then detach the old disk and reattach the new disk to the vm. We submitted a patch a few months back to allow for a root volume to be detached and reattached by specifying the number of the volume as 0 - https://github.com/apache/cloudstack/pull/1500. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1635: CLOUDSTACK-9451
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1635 I'll let him comment on this, but If I recall, it had more to do with implementation of force stopping with KVM rather than the lack of the parameter being passing into the VM Manager. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1635: CLOUDSTACK-9451
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1635 @ProjectMoon Jeff, could you help review this, as I believe you were the first to point it out on the list. From talking to Nathan, it sounds like we're not sure KVM is actually affected by this bug. He was in the process of doing some digging. Regardless of that, it probably affects other hypervisors. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1645: On snapshot backup, this converts the rbd raw format...
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1645 Yeah, there seems to be some black magic going on here. We'll dig into this a bit more. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1645: On snapshot backup, this converts the rbd raw format...
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1645 For reference, here are the DB entries:   --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1606 John, I'll defer to Aaron on this, as he submitted the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1645: On snapshot backup, this converts the rbd raw format...
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1645 CLOUDSTACK-9461 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1645: On snapshot backup, this converts the rbd raw format...
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1645 @wido This is also nice for users of Ceph. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1644: Honors the snapshot.backup.rightafter configuration ...
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1644 @wido Nice feature for Ceph users. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1644: Honors the snapshot.backup.rightafter configuration ...
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1644 LGTM, tested in our lab. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1645: On snapshot backup, this converts the rbd raw format...
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1645 LGTM, tested in our lab. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1635: CLOUDSTACK-9451
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1635 References: https://github.com/apache/cloudstack/pull/1632 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1608: Cleanup RBD contexts after exceptions to prevent pot...
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1608 We have QA'd the patch and confirm that it prevents the agent from crashing when an unexpected exception occurs from upstream RBD libs. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1606 Tested in a 4.8 lab. Verified as per screen shots that all RFC 1918 and RFC 6598 ranges work. Attempting to use a public cidr produces an error as expected. Interface is correctly configured on the VR and the routing table is correct and matches the interface the private gateway was configured on (eth3). LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1606  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1606  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1606  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1606  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1606  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1606  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1606  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1606  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1513#issuecomment-219874035 @swill Sure you haven't got some artifacts left behind from some other testing? This is only a libvirt hook, so I can't imagine how the tests failing above could be related to this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1482#issuecomment-219555051 LGTM above from @DaanHoogland as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1482#issuecomment-219554704 I've done some basic testing of this patch adding and deleting ACLs and rules within ACLs within VPCs. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Make the generated json files unique to p...
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1470#issuecomment-219137807 LGTM based on the manual testing above. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Make the generated json files unique to p...
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1470#issuecomment-219137482 Kill the Master VR:    --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Make the generated json files unique to p...
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1470#issuecomment-219137332 Add a private gw:  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Make the generated json files unique to p...
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1470#issuecomment-219137269 Add a new ACL, add a rule to it and apply it to a Tier:   --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Make the generated json files unique to p...
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1470#issuecomment-219137126 Hot add static route:  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Make the generated json files unique to p...
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1470#issuecomment-219076184 We have the fixes pulled in for testing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CPU socket count reporting correction
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1520#issuecomment-219033610 @swill This one is green now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-6928: fix issue disk I/O throt...
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1410#issuecomment-219033178 We're working on getting this tested as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9348: Make NioConnectio loop l...
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1543#issuecomment-218947359 @rhtyd This patch seems to have fixed the cpu issue. I've got this running on a hardware lab right now. We'll also install this on a larger lab tomorrow and stress test the agent a bit. Thought you'd like to know before I hit the sack for the night! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-218943044 @rhtyd Sounds good. Thanks for taking a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1482#issuecomment-218838012 ok, I'm just blind and didn't see the additional commit to remove the forceencaps. :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1482#issuecomment-218835105 @remibergsma I'm porting this patch set into our 4.8 QA branch currently. I noticed 709be45 is in here as well (force encap). Can you pull that out of this set, as we've already merged it in https://github.com/apache/cloudstack/pull/1402 from your other PR. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1482#issuecomment-218802890 @swill We'll pull this in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-218776521 @rhtyd With the agent in trace mode, I see this scrolling through very rapidly: 2016-05-12 09:36:01,707 TRACE [utils.nio.NioConnection] (pool-1-thread-1:null) (logid:) Keys Processing: 0 2016-05-12 09:36:01,707 TRACE [utils.nio.NioConnection] (pool-1-thread-1:null) (logid:) Keys Done Processing. 2016-05-12 09:36:01,707 TRACE [utils.nio.NioConnection] (pool-1-thread-1:null) (logid:) Keys Processing: 0 2016-05-12 09:36:01,707 TRACE [utils.nio.NioConnection] (pool-1-thread-1:null) (logid:) Keys Done Processing. 2016-05-12 09:36:01,707 TRACE [utils.nio.NioConnection] (pool-1-thread-1:null) (logid:) Keys Processing: 0 2016-05-12 09:36:01,707 TRACE [utils.nio.NioConnection] (pool-1-thread-1:null) (logid:) Keys Done Processing. 2016-05-12 09:36:01,707 TRACE [utils.nio.NioConnection] (pool-1-thread-1:null) (logid:) Keys Processing: 0 2016-05-12 09:36:01,707 TRACE [utils.nio.NioConnection] (pool-1-thread-1:null) (logid:) Keys Done Processing. 2016-05-12 09:36:01,707 TRACE [utils.nio.NioConnection] (pool-1-thread-1:null) (logid:) Keys Processing: 0 2016-05-12 09:36:01,707 TRACE [utils.nio.NioConnection] (pool-1-thread-1:null) (logid:) Keys Done Processing. 2016-05-12 09:36:01,707 TRACE [utils.nio.NioConnection] (pool-1-thread-1:null) (logid:) Keys Processing: 0 2016-05-12 09:36:01,707 TRACE [utils.nio.NioConnection] (pool-1-thread-1:null) (logid:) Keys Done Processing. 2016-05-12 09:36:01,707 TRACE [utils.nio.NioConnection] (pool-1-thread-1:null) (logid:) Keys Processing: 0 2016-05-12 09:36:01,707 TRACE [utils.nio.NioConnection] (pool-1-thread-1:null) (logid:) Keys Done Processing. 2016-05-12 09:36:01,707 TRACE [utils.nio.NioConnection] (pool-1-thread-1:null) (logid:) Keys Processing: 0 2016-05-12 09:36:01,707 TRACE [utils.nio.NioConnection] (pool-1-thread-1:null) (logid:) Keys Done Processing. 2016-05-12 09:36:01,707 TRACE [utils.nio.NioConnection] (pool-1-thread-1:null) (logid:) Keys Processing: 0 2016-05-12 09:36:01,707 TRACE [utils.nio.NioConnection] (pool-1-thread-1:null) (logid:) Keys Done Processing. 2016-05-12 09:36:01,707 TRACE [utils.nio.NioConnection] (pool-1-thread-1:null) (logid:) Keys Processing: 0 2016-05-12 09:36:01,707 TRACE [utils.nio.NioConnection] (pool-1-thread-1:null) (logid:) Keys Done Processing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-218763389 @rhtyd I'll work on pulling some trace logs and a debugger on the agent if the trace logs don't show anything. For reference, These patches were on our QA 4.8 build. I believe I had all of our patches applied (including 1534). Please take a look at https://github.com/myENA/cloudstack/commits/ENA-4.8. The two reverts at the top cover the patches I believe. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1514#issuecomment-218611825 LGTM. Tested in hardware lab and works as designed. tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Handle private gateways more reliably
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1474#issuecomment-218607576 LGTM. Tested in a hardware lab. tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Apply static routes on change to master s...
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1472#issuecomment-218607629 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Apply static routes on change to master s...
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1472#issuecomment-218592243 LGTM. Tested in a hardware lab. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-218473922  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-218473890 @rhtyd We're still seeing some odd behaviour related to the agent with this PR (and PR1534) applied to 2 of our hardware labs. What we're seeing is 100% cpu on the agent (KVM). There's nothing obvious in the debug logs indicating a problem. I've tried it both behind haproxy and directly to the management server and we see the same symptoms. Let me know what we can provide to help in terms of debugging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Make the generated json files unique to p...
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-218446038
Remi,
I'm seeing some issues with this PR, related to the way the VR scripts
utilize the argv file name for other uses. We spent a fair bit of time trying
to run down a problem with static routes not being hot plugged. The odd thing
was, a failover to the backup, or a restart of the network brought up the
static routes fine (after applying your static route failover PR - thanks for
that!).
I think the problem is in the way /opt/cloud/bin/update_config.py calls out
to configure.main, that in turn calls the individual process classes:
def finish_config():
# Converge
returncode = configure.main(sys.argv)
sys.exit(returncode)
sys.argv here, happens in this PRs case to be static_routes.json.[GUID].
In configure.py, def main(argv) relies on the argv to be the actual json
file payload from /etc/cloudstack/, or in the case where you want to configure
every service, you just specify cmd_line.json. In our case, what we see is that
/etc/cloudstack/static_routes.json gets correctly replaced with the valid data,
but the configure method never calls out to CsStaticRoutes here:
if process_file in ["cmd_line.json", "static_routes.json"]:
logging.debug("Configuring static routes")
static_routes = CsStaticRoutes("staticroutes", config)
static_routes.process()
I took a look at this in Cosmic last night and I didn't see any additional
code within the systemvm scripts to handle this differently, so this may also
be an issue in Cosmic.
I would suspect, this pretty much affects the hot-plugging of any new
configuration.
I've learnt a lot about how horrible the VR scripts are in this adventure
and honestly I think the community needs to work on not just cleaning these up,
but making them more bulletproof in general.
I hope this points you in the right direction.
- Si
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Cloudstack 9339: Virtual Routers don't ha...
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1519#issuecomment-217290619 Has anyone tested this with VPC VRs as of yet? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Apply static routes on change to master s...
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1472#issuecomment-217289669 We'll be pulling this one in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9362: Skip VXLANs when rewriti...
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1513#issuecomment-216709951 Tested this in a hardware 4.8 lab: I was able to migrate VXLAN enabled VMs between hosts as expected. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9287 - Fix unique mac address ...
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1413#issuecomment-216517829 Well, the open version of it - PR 1483 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9287 - Fix unique mac address ...
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1413#issuecomment-216517631 I'm about to start testing this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Set default networkDomain to empty instea...
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1485#issuecomment-216516629 @swill This has 2 x LGTM. Simple change and probably doesn't require any additional CI IMO. This is Ready to Merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9336 surround the execution of...
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1463#issuecomment-216508518 @swill 4 x LGTM + CI from Daan. This is Ready to Merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-6928: fix issue disk I/O throt...
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1410#issuecomment-216507445 @ustcweizhou Could you rebase this to resolve the conflicts? I'll pull this in for testing once you've had a chance to do that. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-216375175 I pulled this into a hardware lab on 4.8.1. I setup a number of fake clients and hammered 8250. Prior to the patch the agents end up in a disconnected state after a few minutes. I applied the patch and my little DOS test is unable to affect the connectivity between the management server and the agents. I also tested some provisioning activities and made sure the agent survived taking the management server down and then bringing it back up. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-216296997 @swill I'm a bit behind. I'm building this now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: KVM: Fix plugging ip addresses to the wro...
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1524#issuecomment-215986875 Strangely enough, I just ran into this problem yesterday.I'll pull it in. Thanks Remi! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Add lsb-release dependency to agent and m...
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1412#issuecomment-215874307 @ProjectMoon Can you open a new PR against 4.7 with this? We're really only supporting 4.7.x onward. Trivial packing change. LTGM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Bump ssh retries to prevent false positiv...
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1473#issuecomment-215873345 This is a trivial config change for a smoke test. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Followup fix for #1162: Add support for n...
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1330#issuecomment-215872240 Team, Where are we currently on this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1428#issuecomment-215860378 Interesting. I'll go digging into the code. I'm not that familiar with the console proxy (yet). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1428#issuecomment-215856646 @Slair1 Are you failing a ACS management server in addition to the MySQL instance? If so, make sure your Load Balancer is also moving the traffic to the backup server. Host communication occurs on port 8250. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1428#issuecomment-215840702 @Slair1 @dmabry @remibergsma Could I get some review on this when you get a chance? I'd like to get this PR moving. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
