[GitHub] cloudstack pull request: Apply static routes on change to master s...

2016-05-02 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1472#issuecomment-216227202 tag:needlove --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: Bump ssh retries to prevent false positiv...

2016-05-02 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1473#issuecomment-216227254 LGTM tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: When no zone name is available display a ...

2016-05-02 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1477#issuecomment-216227415 LGTM A manual UI testing is needed tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: CLOUDSTACK-9287 - Fix unique mac address ...

2016-05-02 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1483#issuecomment-216227701 @remibergsma please squash changes to a single commit, and push -f tag:needlove --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...

2016-05-02 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1482#issuecomment-216227551 @remibergsma please rebase against master and squash changes to a single commit tag:needlove --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: Set default networkDomain to empty instea...

2016-05-02 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1485#issuecomment-216227853 @karuturi @imduffy15 comments on the change, thanks tag:needlove --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: agent: Enable IPv6 connectivity for KVM A...

2016-05-02 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1488#issuecomment-216228181 LGTM tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: Reimplement router.redundant.vrrp.interva...

2016-05-02 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1486#issuecomment-216228086 @remibergsma can do a push -f again, Travis failed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack pull request: Installing bzip2 since it is required for...

2016-05-02 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1490#issuecomment-216228399 LGTM tag:easypr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

2016-05-02 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-216228508 This PR is ready for merge, /cc @swill tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-05-02 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-216228334 The PR is ready for merge, any testing/feedback welcome /cc @swill tag:mergeready --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: Add perl-modules as install dependency fo...

2016-05-02 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1495#issuecomment-216228633 tag:easypr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-9350: KVM-HA- Fix CheckOnHost ...

2016-05-02 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1496#issuecomment-216228687 LGTM (code review) tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

2016-05-02 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-216228984 Nice PR, though this would need some regression tests. Can you add marvin smoke tests around list APis (add them to travis yml file) tag:needlove

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

2016-05-02 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-216229542 @DaanHoogland please rebase against latest master; after that I can help test this in my env. Thanks. tag:needlove --- If your project is set up

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-05-02 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-216229281 PR is code complete with testing efforts that @borisstoyanov can share tag:mergeready --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

2016-05-02 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1514#issuecomment-216229708 Good pr, let's ask comments from @remibergsma @DaanHoogland @wido and others? tag:needlove --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: CLOUDSTACK-9366: Capacity of one zone-wid...

2016-05-02 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1516#issuecomment-216229873 @sudhansu7 rebase against master and push -f, squash changes to a single commit, thanks --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: Cloudstack 9339: Virtual Routers don't ha...

2016-05-02 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1519#issuecomment-216229957 @dsclose rebase against master, squash changes to a single commit, thanks tag:needlove --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: L10n update 4.8 20160422

2016-05-02 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1515#issuecomment-216229763 LGTM tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: CPU socket count reporting correction

2016-05-02 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1520#issuecomment-216230034 @NuxRo thanks, please rebase and squash to a single commit LGTM tag:mergeready --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-05-03 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-216603249 @swill I'm fine with all changes, I've ran a final set of tests as well. @jburwell please share any outstanding issue that should be fixed, @borisstoyanov and I

[GitHub] cloudstack pull request: CLOUDSTACK-9334: Support jenv and pyenv t...

2016-05-03 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1460#issuecomment-216603725 I'll play with pyenv, jenv tomorrow and keep you posted --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-05-08 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r62441858 --- Diff: server/src/com/cloud/server/StatsCollector.java --- @@ -412,6 +428,36 @@ protected void runInContext

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-05-08 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r62441896 --- Diff: server/src/com/cloud/server/StatsCollector.java --- @@ -412,6 +428,36 @@ protected void runInContext

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-05-08 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r62442087 --- Diff: utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java --- @@ -0,0 +1,111 @@ +// +// Licensed to the Apache Software

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-05-08 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r62442464 --- Diff: utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java --- @@ -0,0 +1,111 @@ +// +// Licensed to the Apache Software

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-05-08 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r62444371 --- Diff: utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java --- @@ -0,0 +1,111 @@ +// +// Licensed to the Apache Software

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-05-08 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r6206 --- Diff: utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java --- @@ -0,0 +1,111 @@ +// +// Licensed to the Apache Software

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-05-10 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r62656777 --- Diff: utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java --- @@ -0,0 +1,109 @@ +// +// Licensed to the Apache Software

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

2016-04-28 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-215350128 @swill there are in total 25 malicious clients that can block for 60s for all 5 (max.) server worker threads; so worst case we should have waited for at least 25*60

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-28 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-215352448 @DaanHoogland @wido @mlsorensen @jburwell @agneya2001 @koushik-das @terbolous @resmo @K0zka review and LGTM please? @swill I think we've resolved all

[GitHub] cloudstack pull request: kvm: Aqcuire lock when running security g...

2016-04-28 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1408#issuecomment-215353110 @wido +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: kvm: Aqcuire lock when running security g...

2016-04-28 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1408#issuecomment-215353392 reviewed updated PR, LGTM cc @swill --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization

2016-04-28 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1466#issuecomment-215548664 @nvazquez that's by design -- all upgrade paths (migration code and the schema files) are run first and after that only the cleanup scripts are ran --- If your

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-05-08 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-217774436 @swill thanks, let's merge this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-05-08 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-217775304 @jburwell I've fixed the outstanding issues, please re-review and suggest any other improvement or LGTM. Thanks. --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: CLOUDSTACK-9238: Change template_host_ref...

2016-05-25 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1562#issuecomment-221538713 LGTM, simple fix. Tested on local database. tag:easypr --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request #1614: [blocker] CLOUDSTACK-9437: Fix outbound traff...

2016-07-25 Thread rhtyd
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1614 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack issue #1614: [blocker] CLOUDSTACK-9437: Fix outbound traffic afte...

2016-07-25 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1614 Alright Will, closing now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1612: packaging: Marvin and integration-tests packages

2016-07-27 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1612 @swill @wido @PaulAngus @jburwell review and lgtm please, thanks :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1610: packaging: Add db.X.driver=jdbc:mysql to db.properti...

2016-07-12 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1610 @wido lgtm, though we would also want the same change in the centos6's spec file. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack pull request #1614: CLOUDSTACK-9437: Fix egress chain and cleanup...

2016-07-21 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1614 CLOUDSTACK-9437: Fix egress chain and cleanup for allow all traffic - Fixes use of rules.v4/rules instead of router_rules.v4 file, this makes sure that FW_EGRESS_RULE chain gets created

[GitHub] cloudstack issue #1519: Cloudstack 9339: Virtual Routers do not handle Multi...

2016-07-25 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1519 We should get this tested and merged for 4.9 /cc @swill @abhinandanprateek @murali-reddy @JayapalUradi can you help review this and advise any further changes, thanks. --- If your project

[GitHub] cloudstack issue #1610: packaging: Add db.X.driver=jdbc:mysql to db.properti...

2016-08-01 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1610 @milamberspace I tested upgrade scenario using debian packages, so at least this works for debian mgmt server hosts. I think you hit the issue with CentOS based mgmt server host? --- If your

[GitHub] cloudstack issue #1612: packaging: Marvin and integration-tests packages

2016-08-01 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1612 @wido thanks, the Juniper fix is not a separate PR as without that fix packaging/build failure were happening (some times, and every time on a centos7 machine). --- If your project is set up

[GitHub] cloudstack issue #1599: Marvin: Fix codegenerator to work with API discovery

2016-08-03 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1599 Pinging for review - @wido @koushik-das @karuturi @abhinandanprateek @jburwell This enables `cloudstackAPI` api cmd/resp classes generation against a live running mgmt server. --- If your

[GitHub] cloudstack issue #1511: 4.9/master bountycastle changes

2016-08-03 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1511 Let's have another attempt at this? /cc @karuturi @jburwell @DaanHoogland @wido @swill @koushik-das @abhinandanprateek and others --- If your project is set up for it, you can reply

[GitHub] cloudstack issue #1619: Add the Transifex config for next version of CS (4.1...

2016-08-03 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1619 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1611: marvin: deploy clusters in separate threads

2016-08-03 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1611 Pinging for review - @wido @karuturi @koushik-das @abhinandanprateek @murali-reddy @jburwell This is marvin specific change, Travis validation is enough to show that deployDatacenter

[GitHub] cloudstack issue #1612: packaging: Marvin and integration-tests packages

2016-08-03 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1612 Pinging for review -- @karuturi @koushik-das @abhinandanprateek @jburwell If we can get this merged soon, all new PRs etc can be tested easily with CI systems as we'll get the marvin

[GitHub] cloudstack pull request #1611: marvin: deploy clusters in separate threads

2016-08-03 Thread rhtyd
GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/1611 marvin: deploy clusters in separate threads This speeds up cluster deployment by Marvin, each cluster deployment can be executed in separate threads. This for example, allows for setting up

[GitHub] cloudstack pull request #1611: marvin: deploy clusters in separate threads

2016-08-03 Thread rhtyd
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1611 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack issue #1622: Adding missing bits field to TemplateResponse

2016-08-03 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1622 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1612: CLOUDSTACK-9446: Marvin and integration-tests packag...

2016-08-10 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1612 Just to note here for future reference: this PR was backported to 4.5 and 4.6 branches as well. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request #1599: Marvin: Fix codegenerator to work with API di...

2016-08-11 Thread rhtyd
GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/1599 Marvin: Fix codegenerator to work with API discovery This fixes Marvin cloudstackAPI generator to work with a live running mgmt server's api discovery. You can merge this pull request

[GitHub] cloudstack pull request #1599: Marvin: Fix codegenerator to work with API di...

2016-08-11 Thread rhtyd
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1599 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack issue #1541: Systemd packaging for Ubuntu 16.04

2016-08-10 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1541 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1625: [blocker] cloudstack: fix upgrade paths to 4.10.0

2016-08-04 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1625 @karuturi our Trillian job has hit an internal bug so the job died, nevertheless a single run could take hours against real hypervisors (we've xen, kvm and vmware). I'll keep you posted when

[GitHub] cloudstack issue #1625: [blocker] cloudstack: fix upgrade paths to 4.10.0

2016-08-04 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1625 @karuturi all green now, can we merge this? /cc @jburwell --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request #1620: oobm: simply change password transactional lo...

2016-08-04 Thread rhtyd
GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/1620 oobm: simply change password transactional logic - Simplifies change password transactional logic without using pessmistic locks - Adds a re-enter password field in the UI to valid ipmi

[GitHub] cloudstack issue #1612: packaging: Marvin and integration-tests packages

2016-08-04 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1612 @karuturi can we also test/merge this. This is a packaging change that only introduces 'cloudstack-marvin' and 'cloudstack-integration-tests' packages. The above package build verifies

[GitHub] cloudstack pull request #1620: oobm: simply change password transactional lo...

2016-08-04 Thread rhtyd
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1620 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack issue #1625: [blocker] cloudstack: fix upgrade paths to 4.10.0

2016-08-04 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1625 Thanks @karuturi --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1492: [CLOUDSTACK-9003] Resource Naming Policies

2016-08-04 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1492 @ProjectMoon can you close/open the PR to re-kick Travis --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack issue #1607: SSVM downloader now handles redirects properly.

2016-08-04 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1607 @ProjectMoon can you close/open the PR to re-kick Travis --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack issue #1625: [blocker] cloudstack: fix upgrade paths to 4.10.0

2016-08-04 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1625 I'm able to consistently reproduce the unit test failure on a machine with similar memory as Travis (~8GB RAM): searchForExistingLoadBalancer

[GitHub] cloudstack issue #1625: [blocker] cloudstack: fix upgrade paths to 4.10.0

2016-08-04 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1625 @karuturi that's a bot account that will do packaging and testing for us soon, I was testing it :) --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack issue #1625: [blocker] cloudstack: fix upgrade paths to 4.10.0

2016-08-04 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1625 The unit test again failed with Travis: Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 3.821 sec <<< FAILURE! - in org.apache.cloudstack.network.lb.ApplicationLoadBal

[GitHub] cloudstack pull request #1625: [blocker] cloudstack: fix upgrade paths to 4....

2016-08-04 Thread rhtyd
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1625 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack issue #1625: [blocker] cloudstack: fix upgrade paths to 4.10.0

2016-08-04 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1625 @karuturi on the machine which was building the rpm packages --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request #1625: [blocker] cloudstack: fix upgrade paths to 4....

2016-08-04 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1625 [blocker] cloudstack: fix upgrade paths to 4.10.0 This adds an upgrade to master since the recent 4.9 cut, adds an upgrade path to the new code version 4.10. Without this PR all PRs to master

[GitHub] cloudstack issue #1625: [blocker] cloudstack: fix upgrade paths to 4.10.0

2016-08-04 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1625 @karuturi thanks, I'll have a look why it failed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1625: [blocker] cloudstack: fix upgrade paths to 4.10.0

2016-08-04 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1625 Looks like this unit test is known to consume a lot of memory: Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.918 sec

[GitHub] cloudstack issue #1625: [blocker] cloudstack: fix upgrade paths to 4.10.0

2016-08-04 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1625 Looks like this unit test failed: Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 4.773 sec <<< FAILURE! - in org.apache.cloudstack.network.lb.ApplicationLoadBal

[GitHub] cloudstack pull request #1625: [blocker] cloudstack: fix upgrade paths to 4....

2016-08-04 Thread rhtyd
GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/1625 [blocker] cloudstack: fix upgrade paths to 4.10.0 This adds an upgrade to master since the recent 4.9 cut, adds an upgrade path to the new code version 4.10. Without this PR all PRs to master

[GitHub] cloudstack pull request #1531: systemvmtemplate: fix build and upgrade to de...

2016-08-04 Thread rhtyd
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1531 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request #1626: [blocker] Fix systemvm template build

2016-08-04 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1626 [blocker] Fix systemvm template build Previous PR: https://github.com/apache/cloudstack/pull/1531 Fixes failing systemvmtemplate build. You can merge this pull request into a Git

[GitHub] cloudstack issue #1626: [blocker] Fix systemvm template build

2016-08-04 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1626 Ping for review and merge -- @karuturi @jburwell @agneya2001 @swill @wido @DaanHoogland and others --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request #1626: [blocker] Fix systemvm template build

2016-08-04 Thread rhtyd
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1626 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request #1626: [blocker] Fix systemvm template build

2016-08-04 Thread rhtyd
GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/1626 [blocker] Fix systemvm template build Previous PR: https://github.com/apache/cloudstack/pull/1531 Fixes failing systemvmtemplate build. You can merge this pull request into a Git

[GitHub] cloudstack pull request #1638: CLOUDSTACK-9456: Use Spring 4 and Java 8

2016-08-12 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1638 CLOUDSTACK-9456: Use Spring 4 and Java 8 This changes makes CloudStack use spring 4 and Java 8: - Bumps jdk version to 1.8 - Use jdk8 for Travis CI - Bump spring

[GitHub] cloudstack issue #1638: CLOUDSTACK-9456: Use Spring 4 and Java 8

2016-08-12 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1638 @blueorangutan I see, slaves need Java8 installed. Fixing that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1546: [WIP][4.10+/long-term] Moving towards Java8 and Spri...

2016-08-12 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1546 I'll split this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack pull request #1638: CLOUDSTACK-9456: Use Spring 4 and Java 8

2016-08-12 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1638#discussion_r74580238 --- Diff: pom.xml --- @@ -92,22 +85,22 @@ 1.5.1 1.2.8 2.0.4 -2.5 +3.1.0 1.2 1.2.1

[GitHub] cloudstack pull request #1638: CLOUDSTACK-9456: Use Spring 4 and Java 8

2016-08-12 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1638#discussion_r74574871 --- Diff: pom.xml --- @@ -92,22 +85,22 @@ 1.5.1 1.2.8 2.0.4 -2.5 +3.1.0 1.2 1.2.1

[GitHub] cloudstack pull request #1638: CLOUDSTACK-9456: Use Spring 4 and Java 8

2016-08-12 Thread rhtyd
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1638 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request #1638: CLOUDSTACK-9456: Use Spring 4 and Java 8

2016-08-12 Thread rhtyd
GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/1638 CLOUDSTACK-9456: Use Spring 4 and Java 8 This changes makes CloudStack use spring 4 and Java 8: - Bumps jdk version to 1.8 - Use jdk8 for Travis CI - Bump spring

[GitHub] cloudstack issue #1633: [blocker] CLOUDSTACK-9452: use optparse instead of a...

2016-08-10 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1633 @wido I'm sorry we will need to support CentOS6 kvm hosts, just because you don't use it does not mean we should not support for people. It is a valid `blocker` as the KVM CentOS6 hosts have

[GitHub] cloudstack issue #1633: [blocker] CLOUDSTACK-9452: use optparse instead of a...

2016-08-10 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1633 CentOS6 default/epel repos don't have python 2.7 :) There are large installations running old code, old hardware, old kernels/OSs; they will get upgraded over time, but they need to be supported

[GitHub] cloudstack issue #1633: [blocker] CLOUDSTACK-9452: use optparse instead of a...

2016-08-10 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1633 @wido @sverrirab will adding python-argparse as a dependency be an acceptable solution to the problem? this package is available on el6, but python 2.7 is not available (without using one

[GitHub] cloudstack pull request #1633: [blocker] CLOUDSTACK-9452: use optparse inste...

2016-08-10 Thread rhtyd
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1633 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack issue #1633: [blocker] CLOUDSTACK-9452: use optparse instead of a...

2016-08-10 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1633 @karuturi @jburwell @wido @sverrirab please review, it's a blocker for kvm centos6 hosts without argparse/python2.7 installed. I could run an existing test: (gave same results before

[GitHub] cloudstack issue #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Make NFS ...

2016-08-10 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1615 @blueorangutan package @jburwell @nvazquez since a new code commit was made, we need to call package before we could kick in tests. --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request #1634: [blocker] CLOUDSTACK-9452: add python-argpars...

2016-08-10 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1634 [blocker] CLOUDSTACK-9452: add python-argparse dependency on el6,7 rpms The patchviasocket script was rewritten in Python from PR #1533 and made assumptions that Python 2.7 would be available

[GitHub] cloudstack issue #1632: Honor the forced parameter for stopVirtualMachine ap...

2016-08-11 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1632 @karuturi @jburwell test keyword has been disabled due to infrastructural issues, I'll try to get this fixed today. Also, we need to run package first, to evaluate build/test/package checks

[GitHub] cloudstack issue #1632: Honor the forced parameter for stopVirtualMachine ap...

2016-08-11 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1632 @nathanejohnson LGTM, but this bug affects 4.9 as well; please close this PR and reopen against 4.9. Your PR when accepted will be merged on 4.9 and fwd-merged on master. Thanks. --- If your

[GitHub] cloudstack issue #1632: Honor the forced parameter for stopVirtualMachine ap...

2016-08-11 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1632 @ProjectMoon With our current branch support policy, we should merge bugfixes/changes on master and the last release branch (i.e. 4.9 and also since 4.9 is current/to-be lts branch). I'm fine

[GitHub] cloudstack issue #1541: Systemd packaging for Ubuntu 16.04

2016-08-10 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1541 @wido sure I'll spend sometime testing them as well. Since this is packaging only changes, should we get this on 4.9 for the lts /cc @jburwell @karuturi ? --- If your project is set up

[GitHub] cloudstack issue #1541: Systemd packaging for Ubuntu 16.04

2016-08-10 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1541 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

<    1   2   3   4   5   6   7   8   9   10   >