[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance

2017-02-16 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1944 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #847: Bug-ID: CLOUDSTACK-8880: calculate free memory on hos...

2017-02-16 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/847 Thanks @kishankavala @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request #1944: CLOUDSTACK-9783: Improve metrics view perform...

2017-02-16 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1944 CLOUDSTACK-9783: Improve metrics view performance This improves the metrics view feature by improving the rendering performance of metrics view tables, by re-implementing the logic

[GitHub] cloudstack issue #1826: CLOUDSTACK-9675: Cloudstack Metrics Miscellaneous bu...

2017-02-16 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1826 Thanks @rashmidixit both the PRs may be closed given the new performance improvement PR #1944 which also includes some case fixes from this PR. --- If your project is set up for it, you can

[GitHub] cloudstack issue #1826: CLOUDSTACK-9675: Cloudstack Metrics Miscellaneous bu...

2017-02-16 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1826 @rashmidixit I've taken your feedback and improved the feature here https://github.com/apache/cloudstack/pull/1944 -- this reimplements the frontend logic at the backend, improving the overall

[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance

2017-02-16 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1944 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance

2017-02-16 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1944 Thanks for testing/reviewing @borisstoyanov --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #847: Bug-ID: CLOUDSTACK-8880: calculate free memory on hos...

2017-02-16 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/847 LGTM, @kishankavala please squash your changes and amend git summary with jira id. /cc @karuturi --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack issue #1916: [4.9] CLOUDSTACK-9462: Build packages on Ubuntu 12.0...

2017-02-17 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1916 @ustcweizhou makes sense, in that case please close this PR and open a new PR for 4.10/master that adds support for cloudstack mgmt server on ubuntu 16.04, dropping support for 12.04 etc

[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

2017-02-17 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1951 @borisstoyanov an explicit integration test is not necessary if Travis passes, since all changes are around db upgrade/version. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....

2017-02-17 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1950 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

2017-02-17 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1951 CLOUDSTACK-9792: Add upgrade path for 4.9.3.0 This adds an upgrade path from 4.9.2.0 to 4.9.3.0, this also includes changes from PR https://github.com/apache/cloudstack/pull/1928 that adds

[GitHub] cloudstack pull request #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

2017-02-17 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1951#discussion_r101735670 --- Diff: setup/db/db/schema-4920to4930.sql --- @@ -0,0 +1,22 @@ +-- Licensed to the Apache Software Foundation (ASF) under one +-- or more

[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance

2017-02-17 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1944 Thanks @borisstoyanov test results LGTM. /cc @karuturi --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack issue #1888: CLOUDSTACK-9710: Switch to JRE1.8

2017-01-18 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1888 @syed yes, if the systemvmtemplates were built from master after this PR was merged. There is no secret sauce in the systemvmtemplate that I've uploaded on packages.shapeblue.com S3 bucket

[GitHub] cloudstack issue #1888: CLOUDSTACK-9710: Switch to JRE1.8

2017-01-18 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1888 @swill build el7 (centos7) packages on centos7, and el6 (centos6) packages on centos6. You may use my docker images, this is what Trillian/blueorangutan uses for building (PR) packages: https

[GitHub] cloudstack issue #1650: fix macchinina template specificied for vmware in Ma...

2016-08-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1650 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1651: Marvin Tests: fix expected return string for success...

2016-08-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1651 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack pull request #1648: test/integration: fix tearDown order in list_...

2016-08-22 Thread rhtyd
GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/1648 test/integration: fix tearDown order in list_acl_ tests This fixes tearDown issues because of which few Travis tests have failed such as: https://travis-ci.org/apache/cloudstack

[GitHub] cloudstack pull request #1648: test/integration: fix tearDown order in list_...

2016-08-22 Thread rhtyd
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1648 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack issue #1652: Marvin Tests: Fix VPC network offering selection .

2016-08-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1652 LGTM, the Travis test failures are not related to this PR but with tearDown issues fixed here: https://github.com/apache/cloudstack/pull/1648 --- If your project is set up for it, you can reply

[GitHub] cloudstack issue #1646: [4.9/LTS] Add upgrade path from 4.9.0 to 4.9.1

2016-08-19 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1646 @jburwell @karuturi fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1646: [4.9/LTS] Add upgrade path from 4.9.0 to 4.9.1, chan...

2016-08-19 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1646 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request #1647: CLOUDSTACK-9462: Systemd support for Ubuntu 1...

2016-08-19 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1647 CLOUDSTACK-9462: Systemd support for Ubuntu 16.04 Created this based on @wido 's origin PR #1541 . Requesting for review and testing -- @jburwell @karuturi @wido @vincentbernat

[GitHub] cloudstack issue #1599: Marvin: Fix codegenerator to work with API discovery

2016-08-19 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1599 @jburwell fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1541: Systemd packaging for Ubuntu 16.04

2016-08-19 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1541 @wido if this helps you I can port your PR to 4.9 and push on asf remote so we can work on it together? Cherry-picking to 4.9 would against cause conflicts, and nice we've a fwd-merging based

[GitHub] cloudstack issue #1541: Systemd packaging for Ubuntu 16.04

2016-08-19 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1541 @wido I've used your PR to create this new branch on asf remote (so we both and anyone else can collaborate) and this PR: #1647 -- let's close this PR and continue on the new one against 4.9

[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...

2016-08-19 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1647 @wido given it's a pure packaging fix, and as per RMs we've enough LGTMs but we lack a test LGTM -- I can help merge this after some tests wrt usage and kvm agent (on ubuntu 16.04) over

[GitHub] cloudstack pull request #1648: test/integration: fix tearDown order in list_...

2016-08-19 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1648 test/integration: fix tearDown order in list_acl_ tests This fixes tearDown issues because of which few Travis tests have failed such as: https://travis-ci.org/apache/cloudstack/jobs

[GitHub] cloudstack pull request #1649: CLOUDSTACK-9463: Fix dynamic-roles migrate sc...

2016-08-19 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1649 CLOUDSTACK-9463: Fix dynamic-roles migrate script for old format The old commands.properties format included the full class name such as: createAccount

[GitHub] cloudstack issue #1649: CLOUDSTACK-9463: Fix dynamic-roles migrate script fo...

2016-08-19 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1649 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

2016-08-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1653 @NuxRo okay, can you grant me push access on your fork: https://github.com/NuxRo/cloudstack/tree/patch-4 and I can help fix it for you? --- If your project is set up for it, you can reply

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

2016-08-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1653 @NuxRo thanks, fixed the branch, you may remove my access now :) @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

2016-08-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1653 @blueorangutan test matrix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request #1620: oobm: simply change password transactional lo...

2016-08-03 Thread rhtyd
GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/1620 oobm: simply change password transactional logic - Simplifies change password transactional logic without using pessmistic locks - Adds a re-enter password field in the UI to valid ipmi

[GitHub] cloudstack pull request #1620: oobm: simply change password transactional lo...

2016-08-03 Thread rhtyd
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1620 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack issue #1531: systemvmtemplate: fix build and upgrade to debian 7....

2016-08-03 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1531 @karuturi @jburwell this PR has enough review, can we merge this? The changes are necessary without them the systemvm template appliance building fails, tested and built these templates

[GitHub] cloudstack pull request #1531: systemvmtemplate: fix build and upgrade to de...

2016-08-03 Thread rhtyd
GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/1531 systemvmtemplate: fix build and upgrade to debian 7.11 iso - Bumps base debian iso to version 7.11 - Upgrade ruby version to 2.3.0 (latest/stable) - Fix Gemfile - Update README

[GitHub] cloudstack pull request #1531: systemvmtemplate: fix build and upgrade to de...

2016-08-03 Thread rhtyd
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1531 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack issue #1641: CLOUDSTACK-9459: the try's catch block was shortenin...

2016-08-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1641 Based on tests and review, merging this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1620: oobm: simply change password transactional logic

2016-08-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1620 Merging based on review and test results above, thanks @blueorangutan. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1634: [blocker] CLOUDSTACK-9452: add python-argparse depen...

2016-08-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1634 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

2016-08-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1653 Thanks @NuxRo can you rebase against latest 4.9, looks like some more commits came in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack issue #1641: CLOUDSTACK-9459: the try's catch block was shortenin...

2016-08-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1641 Ran tests, failure before the fix: 2016-08-22 14:11:09,496 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) UPDATE `cloud`.`ntwk_offering_service_map` SET Provider='VpcVirtualRouter

[GitHub] cloudstack issue #1649: CLOUDSTACK-9463: Fix dynamic-roles migrate script fo...

2016-08-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1649 This change is limited to the migration script and does not impact CloudStack. Manual tests confirmed the fix works with both new and old commands.properties. --- If your project is set up

[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...

2016-08-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1647 @wido with this change will we have to host two versions of deb repository -- one built on ubuntu without systemd (such as 14.04) and one built on ubuntu with systemd (16.04+)? --- If your

[GitHub] cloudstack issue #1620: oobm: simply change password transactional logic

2016-08-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1620 Trillian test results wrt oobm: Tests out-of-band management background powerstate sync ... === TestName: test_oobm_background_powerstate_sync | Status : SUCCESS === ok Tests out

[GitHub] cloudstack issue #1649: CLOUDSTACK-9463: Fix dynamic-roles migrate script fo...

2016-08-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1649 Test run: python scripts/util/migrate-dynamicroles.py -d -f commands.properties Apache CloudStack Role Permission Migration Tool (c) Apache CloudStack Authors and the ASF, under

[GitHub] cloudstack issue #1648: test/integration: fix tearDown order in list_acl_ te...

2016-08-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1648 The specific tests run with simulator only, so travis test results should be acceptable. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

2016-08-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1653 LGTM, we need to also test for users who connect to VPN on that network (will DNS work for them as well?). --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1630: Add projectid to project details page

2016-08-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1630 Manually tested, LGTM. We can merge this, the failing Travis tests are not related to the change (which is purely UI). --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack issue #1621: [CLOUDSTACK-9444] Fix a little issue from PR1610 if ...

2016-08-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1621 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1648: test/integration: fix tearDown order in list_acl_ te...

2016-08-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1648 @jburwell thanks fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

2016-08-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1653 @NuxRo if you can change the base-branch of the PR to 4.9, I can initiate some tests on VR/trillian. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack issue #1643: CLOUDSTACK-9460: For long running transactions, if t...

2016-08-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1643 @abhinandanprateek can you reopen/edit the PR for 4.9? thanks. LGTM. /cc @jburwell @karuturi --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

2016-08-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1653 @NuxRo there are still several commits which have come from master; can you export the commit (git format-patch -1) and reset --hard origin/4.9 and re-apply the commit (git am ) and then git push

[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance

2017-02-27 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1944 @borisstoyanov can you see the failure in Travis with test_list_infrastructure_metrics test case? Thanks @rashmidixit you're right I added this as a plugin to keep it separate from the core

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-27 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1768 @marcaurele can we have a unit test to confirm that this does not break upgrade for older systems, also by changing the order for all older versions, the way someone would upgrade from say 4.3

[GitHub] cloudstack pull request #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubu...

2017-02-27 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1950#discussion_r103382438 --- Diff: debian/control --- @@ -16,14 +16,15 @@ Description: A common package which contains files which are shared by several C Package

[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance

2017-02-27 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1944 @rashmidixit the current UI does not support support pluggability of components within UI like the backend does. We can have a separate tab but not the implementation that the current metrics

[GitHub] cloudstack pull request #1944: CLOUDSTACK-9783: Improve metrics view perform...

2017-02-27 Thread rhtyd
GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/1944 CLOUDSTACK-9783: Improve metrics view performance This improves the metrics view feature by improving the rendering performance of metrics view tables, by re-implementing the logic

[GitHub] cloudstack pull request #1944: CLOUDSTACK-9783: Improve metrics view perform...

2017-02-27 Thread rhtyd
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1944 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance

2017-02-27 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1944 Thanks @rashmidixit @karuturi this is ready for merge, as soon as Travis passes. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack issue #1975: Fix build failure on master

2017-02-27 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1975 LGTM, found the build failure locally today. Introduced in `a2428508`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

2017-02-26 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1951 @syed yes there is no problem I see, with `INSERT IGNORE` we can have this db change in both paths resulting in same final state. --- If your project is set up for it, you can reply

[GitHub] cloudstack issue #1958: CLOUDSTACK-5806: add presetup to storage types that ...

2017-02-27 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1958 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1241: CLOUDSTACK-9162: Unable to add VPN user via API with...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1241 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1302: CLOUDSTACK-9104: VM naming convention in case vmware...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1302 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1257 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request #1302: CLOUDSTACK-9104: VM naming convention in case...

2017-02-28 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1302#discussion_r103404351 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -2226,17 +2227,33 @@ int getReservedCpuMHZ

[GitHub] cloudstack pull request #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KV...

2017-02-28 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1960#discussion_r103397573 --- Diff: api/src/org/apache/cloudstack/api/command/admin/ha/DisableHAForClusterCmd.java --- @@ -0,0 +1,114 @@ +// Licensed to the Apache Software

[GitHub] cloudstack pull request #1302: CLOUDSTACK-9104: VM naming convention in case...

2017-02-28 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1302#discussion_r103405341 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -2226,17 +2227,33 @@ int getReservedCpuMHZ

[GitHub] cloudstack pull request #1302: CLOUDSTACK-9104: VM naming convention in case...

2017-02-28 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1302#discussion_r103405279 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -2226,17 +2227,33 @@ int getReservedCpuMHZ

[GitHub] cloudstack issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA pr...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1960 Thanks @DaanHoogland wherever applicable I'll address the comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-27 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1768 @marcaurele I appreciate the cleanup, it should have been like this from the beginning but since we've the workflow to execute all the upgrades first and then the cleanup. In `https://github.com

[GitHub] cloudstack issue #1241: CLOUDSTACK-9162: Unable to add VPN user via API with...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1241 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1302: CLOUDSTACK-9104: VM naming convention in case vmware...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1302 I've left some outstanding comments, I'm -1 on the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1257 @blueorangutan test centos7 vmware-55u3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack-docs issue #19: Updating The Nuage VSP Plugin Documentation for A...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack-docs/pull/19 LGTM thanks. /cc @karuturi we can merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request #1768: CLOUDSTACK 9601: Upgrade: change logic for up...

2017-02-27 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1768#discussion_r103388263 --- Diff: engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java --- @@ -424,27 +421,9 @@ protected void upgrade(CloudStackVersion dbVersion

[GitHub] cloudstack issue #1974: CLOUDSTACK-9795: moved logrotate from cron.daily to ...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1974 LGTM, looks like we'll have to backport by cherry-picking this given the PR for master has been merged. Thanks @dmabry --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack issue #1954: CLOUDSTACK-9795: moved logrotate from cron.daily to ...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1954 Thanks @dmabry looks like this has been already merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KV...

2017-02-28 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1960#discussion_r103397882 --- Diff: api/src/org/apache/cloudstack/api/command/admin/host/PrepareForMaintenanceCmd.java --- @@ -108,4 +108,8 @@ public void execute

[GitHub] cloudstack pull request #1302: CLOUDSTACK-9104: VM naming convention in case...

2017-02-28 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1302#discussion_r103404645 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -2226,17 +2227,33 @@ int getReservedCpuMHZ

[GitHub] cloudstack issue #1779: CLOUDSTACK-9610: Disabled Host Keeps Being up status...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1779 I think we'll need to discuss, I'm not sure if we should hide hosts that are disabled and cluster is un-managed. /cc @DaanHoogland @abhinandanprateek comment? --- If your project is set up

[GitHub] cloudstack issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA pr...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1960 @koushik-das I've shared a list of advantages of this work over existing framework on dev@ that explain why existing VM-HA framework cannot be used for host-ha implementation. If you've more

[GitHub] cloudstack issue #1945: CLOUDSTACK-9787: Fix wrong return value in NetUtils....

2017-02-26 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1945 LGTM. @karuturi let's merge this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance

2017-02-26 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1944 Thanks @rashmidixit awaiting your review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1946: CLOUDSTACK-9788: Fix exception listNetworks with pag...

2017-02-26 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1946 LGTM. @karuturi let's merge this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....

2017-02-26 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1950 @ustcweizhou can you check the permissions issue I hit in my test, as share in my comment above? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack issue #1903: [4.9] CLOUDSTACK-9356: FIX Cannot add users in VPC V...

2017-02-26 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1903 LGTM. @karuturi let's merge this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1829: CLOUDSTACK-9363: Fix HVM VM restart bug in XenServer

2017-02-26 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1829 Okay @syed either PR need to be merged to solve the issue of restart bug. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1941: CLOUDSTACK-8663: Fixed various issues to allow VM sn...

2017-02-26 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1941 LGTM. @karuturi let's merge this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1896: [CLOUDSTACK-9732] Update L10N resource files with 4....

2017-02-26 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1896 LGTM. @karuturi let's merge this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....

2017-02-27 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1950 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1949: Automated Cloudstack bugs 9277 9276 9275 9274 9273 9...

2017-02-27 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1949 @shwetaag I see some new failures in Travis around component tests, can you close and reopen this PR to rekick Travis tests? If Travis fails again, please see the failed tests and fix them

[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

2017-02-27 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1961 @serg38 okay, we can add this to test_data /cc @PaulAngus --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KV...

2017-02-27 Thread rhtyd
GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/1960 [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA provider Host-HA offers investigation, fencing and recovery mechanisms for host that for any reason are malfunctioning. It uses Activity

[GitHub] cloudstack pull request #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KV...

2017-02-27 Thread rhtyd
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1960 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack issue #1948: [CLOUDSTACK-9793] Faster IP in subnet check

2017-02-27 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1948 LGTM, @karuturi can this be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

<    4   5   6   7   8   9   10   11   12   13   >