[GitHub] cloudstack pull request #2046: CLOUDSTACK-7958: Add configuration for limit ...
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/2046#discussion_r111591078
--- Diff: server/src/com/cloud/api/ApiServlet.java ---
@@ -290,6 +292,17 @@ void processRequestInContext(final HttpServletRequest
req, final HttpServletResp
CallContext.register(accountMgr.getSystemUser(),
accountMgr.getSystemAccount());
}
+if (CallContext.current().getCallingAccount().getType() ==
Account.ACCOUNT_TYPE_ADMIN) {
+s_logger.debug("CIDRs from which Admin accounts are
allowed to perform API calls " + adminCidrs);
--- End diff --
I was thinking trace here and debug or info on the first load of the cidr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #2044: CLOUDSTACK-9877 Cleanup unlinked templates
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/2044 ah ok, I was not aware of that @serg38 . I'll look it up, except from not enabling the feature, how would you handle this? a. To not allow restore b. To recognise that the disk is fully cloned and bypass the null-template (if almighty vmware allows) c. To allow for choosing a successor-template d. ... Also, Is this a blocker for you? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2044: CLOUDSTACK-9877 Cleanup unlinked templates
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/2044
@serg38
ad 1. yes they can, if you look in the ticket there is a part of
description that describes this possibility. But that said I don't see how
restore is going to be hindered if the vm was created using a full clone. The
image is not deleted.
ad 2. No it is only marking templates for gc and not touching any cleanup
process, it relies on the regular process to do the actual cleanup. The benefit
is that short lived templates that will be replaced by cron jobs for instance
will be cleaned without having to wait until the VMs cloned from it are all
gone (on a per primary store basis btw)
ad 3. Yes so far it is I have not studied other hypervisors on this area.
The code is now in the vmware plugin but not tightly coupled to the vmware API
so generalizing it shoud be rather trivial.
ad 4. the host scan task was an empty placeholder with only todo. The
vcente clusters are not scanned for new hosts atm. If you look at the old code
you can find that the task consists of only a comment:
```
private Runnable getHostScanTask() {
return new Runnable() {
@Override
public void run() {
// TODO scan vSphere for newly added hosts.
// we are going to both support adding host from CloudStack
UI and
// adding host via vSphere server
//
// will implement host scanning later
}
};
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #2046: CLOUDSTACK-7958: Add configuration for limit ...
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/2046#discussion_r111568764
--- Diff: api/src/org/apache/cloudstack/config/ApiServiceConfiguration.java
---
@@ -28,6 +28,8 @@
"API end point. Can be used by CS components/services deployed
remotely, for sending CS API requests", true);
public static final ConfigKey DefaultUIPageSize = new
ConfigKey("Advanced", Long.class, "default.ui.page.size", "20",
"The default pagesize to be used by UI and other clients when
making list* API calls", true, ConfigKey.Scope.Global);
+public static final ConfigKey ManagementAdminCidr = new
ConfigKey("Advanced", String.class, "management.admin.cidr",
+"0.0.0.0/0,::/0", "Comma separated list of IPv4/IPv6 CIDRs
from which Admin accounts can perform API calls", true, ConfigKey.Scope.Global);
--- End diff --
argument for this default: backwards compatible
argument against: inherent security risk
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #2046: CLOUDSTACK-7958: Add configuration for limit ...
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/2046#discussion_r11156
--- Diff: server/src/com/cloud/api/ApiServlet.java ---
@@ -290,6 +292,17 @@ void processRequestInContext(final HttpServletRequest
req, final HttpServletResp
CallContext.register(accountMgr.getSystemUser(),
accountMgr.getSystemAccount());
}
+if (CallContext.current().getCallingAccount().getType() ==
Account.ACCOUNT_TYPE_ADMIN) {
+s_logger.debug("CIDRs from which Admin accounts are
allowed to perform API calls " + adminCidrs);
+if
(!NetUtils.isIpInCidrList(InetAddress.getByName(remoteAddress),
adminCidrs.split(","))) {
+auditTrailSb.append(" " +
HttpServletResponse.SC_UNAUTHORIZED + " " + "IP-Address of remote not in
configured Admin CIDR list");
+final String serializedResponse =
+
apiServer.getSerializedApiError(HttpServletResponse.SC_UNAUTHORIZED,
"IP-Address of remote not in configured Admin CIDR list",
+params, responseType);
+HttpUtils.writeHttpResponse(resp, serializedResponse,
HttpServletResponse.SC_UNAUTHORIZED, responseType,
apiServer.getJSONContentType());
--- End diff --
this you do want to log on every attempt (WARN or INFO???)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #2046: CLOUDSTACK-7958: Add configuration for limit ...
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/2046#discussion_r111568831
--- Diff: server/src/com/cloud/api/ApiServlet.java ---
@@ -290,6 +292,17 @@ void processRequestInContext(final HttpServletRequest
req, final HttpServletResp
CallContext.register(accountMgr.getSystemUser(),
accountMgr.getSystemAccount());
}
+if (CallContext.current().getCallingAccount().getType() ==
Account.ACCOUNT_TYPE_ADMIN) {
+s_logger.debug("CIDRs from which Admin accounts are
allowed to perform API calls " + adminCidrs);
--- End diff --
you don't want to log this on every call.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #2046: CLOUDSTACK-7958: Add configuration for limit ...
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/2046#discussion_r111568225
--- Diff: core/src/com/cloud/network/HAProxyConfigurator.java ---
@@ -538,7 +536,7 @@ private String getLbSubRuleForStickiness(final
LoadBalancerTO lbTO) {
if (stickinessSubRule != null && !destsAvailable) {
s_logger.warn("Haproxy stickiness policy for lb rule: " +
lbTO.getSrcIp() + ":" + lbTO.getSrcPort() + ": Not Applied, cause: backends
are unavailable");
}
-if (publicPort.equals(NetUtils.HTTP_PORT) && !keepAliveEnabled ||
httpbasedStickiness) {
+if (publicPort == NetUtils.HTTP_PORT && !keepAliveEnabled ||
httpbasedStickiness) {
--- End diff --
why this? equals() seems more what is intended then ==
is making it an int really the best? as opposed to Integer (or String for
that matter)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #2030: WIP: CLOUDSTACK-9864 cleanup stale worker VMs after ...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/2030 show me the money (tm) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #2030: WIP: CLOUDSTACK-9864 cleanup stale worker VMs...
GitHub user DaanHoogland reopened a pull request: https://github.com/apache/cloudstack/pull/2030 WIP: CLOUDSTACK-9864 cleanup stale worker VMs after job expiry time You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudstack snapshot-housekeeping Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/2030.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2030 commit 40869570fc510fac0d2357f272e96cd4a4518176 Author: Daan Hoogland <daan.hoogl...@shapeblue.com> Date: 2017-03-30T14:35:37Z CE-113 trace logging and rethrow instead of nesting CloudRuntimeException commit 66d7d846352d52cc539b1dafb5e4d0f1620829a5 Author: Daan Hoogland <daan.hoogl...@shapeblue.com> Date: 2017-04-05T12:19:14Z CE-113 configure workervm gc based on job expiry commit 996f5834e6a0a9e4dc57d436ceeb5b89e6dc9974 Author: Daan Hoogland <daan.hoogl...@shapeblue.com> Date: 2017-04-05T15:35:41Z CE-113 extra trace log of worker VMs commit 9a8ea7c0d1c9775ad7e4200db2b3eca93e121909 Author: Daan Hoogland <daan.hoogl...@shapeblue.com> Date: 2017-04-06T09:33:53Z CE-113 removed TODOs commit e2c0f09609b48f4539f13edcc742ca7e06f0cca2 Author: Daan Hoogland <daan.hoogl...@shapeblue.com> Date: 2017-04-07T12:54:19Z CE-113 use of duration (instead of the old clock-tick-based code --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #2030: WIP: CLOUDSTACK-9864 cleanup stale worker VMs...
Github user DaanHoogland closed the pull request at: https://github.com/apache/cloudstack/pull/2030 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2030: WIP: CLOUDSTACK-9864 cleanup stale worker VMs after ...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/2030 renaming and close-opening for retests. "it works on my laptop (tm)" --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #2044: CLOUDSTACK-9877 Cleanup unlinked templates
GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/2044 CLOUDSTACK-9877 Cleanup unlinked templates This implements CLOUDSTACK-9877 by marking templates for gc when 1. the template they where created with is deleted from cloudstack 2. all vms that still use it were created as full clones You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudstack cleanup-unlinked-templates Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/2044.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2044 commit 7a051b31587e43f94b49bf6f26478b33fc8c4c42 Author: Daan Hoogland <daan.hoogl...@shapeblue.com> Date: 2017-03-23T15:45:43Z CE-110 move config to public fields commit cf495adfd3fea9fc4806bb1453bbe05d2200f155 Author: Daan Hoogland <daan.hoogl...@shapeblue.com> Date: 2017-04-14T07:33:35Z CE-110 remove duplicate-unused functionality commit 5cd18ebfb61839816f827eef8b0604c052edf96d Author: Daan Hoogland <daan.hoogl...@shapeblue.com> Date: 2017-04-14T07:41:46Z CE-110 task for marking cleaning fully cloned templates implemented by marking them for GC --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2032: CLOUDSTACK-9783: corrected the version number in met...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/2032 LGTM, checked the source $ grep -r 4.9.3.0 no hits --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #2030: WIP: CLOUDSTACK-9864 cleanup stale worker VMs...
GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/2030 WIP: CLOUDSTACK-9864 cleanup stale worker VMs after job expiry time You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudstack snapshot-housekeeping Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/2030.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2030 commit 40869570fc510fac0d2357f272e96cd4a4518176 Author: Daan Hoogland <daan.hoogl...@shapeblue.com> Date: 2017-03-30T14:35:37Z CE-113 trace logging and rethrow instead of nesting CloudRuntimeException commit 66d7d846352d52cc539b1dafb5e4d0f1620829a5 Author: Daan Hoogland <daan.hoogl...@shapeblue.com> Date: 2017-04-05T12:19:14Z CE-113 configure workervm gc based on job expiry commit 996f5834e6a0a9e4dc57d436ceeb5b89e6dc9974 Author: Daan Hoogland <daan.hoogl...@shapeblue.com> Date: 2017-04-05T15:35:41Z CE-113 extra trace log of worker VMs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1997: CLOUDSTACK-9208: Assertion Error in VM_POWER_STATE h...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1997 so that is two situations 1. it is known to be powered off (no sendStop() should be performed at all) 2. it is unknown because their is no report. Wouldn't one first check the host to send the stop command to before sending it? That said, I am +0 on this code, the check is not harming in any way. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2024: CLOUDSTACK-9857: With this change if agent dies the ...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/2024 trivial enough: LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1997: CLOUDSTACK-9208: Assertion Error in VM_POWER_STATE h...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1997 @jayapalu your check is ok, what is not ok is that it is needed. Somehow a stop can be send to a VM for which no host is known? I am worried about the reason of your fix and that we might obscure it. Why is a stop command attempted on a vm for which no host is known? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2023: BUG-ID: CLOUDSTACK-9808 Added system Vm upgrade path...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/2023 @karuturi I think it is easiest to just reapply and not search for the cause of an 8 month old PR resulting in conflicts. (if the original code has the right URLS in it) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #2022: CLOUDSTACK-9591: Fix systemvmtemplate to not ...
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/2022#discussion_r108918688
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java ---
@@ -1477,6 +1493,40 @@ public static String
resolveHostNameInUrl(DatacenterMO dcMo, String url) {
return url;
}
+public static String removeOVFNetwork(final String ovfString) {
+if (ovfString == null || ovfString.isEmpty()) {
+return ovfString;
+}
+try {
+final DocumentBuilderFactory factory =
DocumentBuilderFactory.newInstance();
+final Document doc = factory.newDocumentBuilder().parse(new
ByteArrayInputStream(ovfString.getBytes()));
+final DocumentTraversal traversal = (DocumentTraversal) doc;
+final NodeIterator iterator =
traversal.createNodeIterator(doc.getDocumentElement(), NodeFilter.SHOW_ELEMENT,
null, true);
+for (Node n = iterator.nextNode(); n != null; n =
iterator.nextNode()) {
+final Element e = (Element) n;
+if ("NetworkSection".equals(e.getTagName())) {
+if (e.getParentNode() != null) {
+e.getParentNode().removeChild(e);
+}
+} else if ("rasd:Connection".equals(e.getTagName())) {
+if (e.getParentNode() != null &&
e.getParentNode().getParentNode() != null) {
+
e.getParentNode().getParentNode().removeChild(e.getParentNode());
+}
+}
+}
+final DOMSource domSource = new DOMSource(doc);
+final StringWriter writer = new StringWriter();
+final StreamResult result = new StreamResult(writer);
+final TransformerFactory tf = TransformerFactory.newInstance();
+final Transformer transformer = tf.newTransformer();
+transformer.transform(domSource, result);
+return writer.toString();
+} catch (SAXException | IOException | ParserConfigurationException
| TransformerException e) {
+s_logger.warn("Unexpected exception caught while removing
network elements from OVF:", e);
--- End diff --
thanks for this.
I'd log a warn without, and a debug with the stacktrace.That way an admin
had better control on what is seen in the logs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #2023: BUG-ID: CLOUDSTACK-9808 Added system Vm upgrade path...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/2023 LGTM @kishankavala did you check what went wrong with the kvm template. @karuturi reported that and it was probably some auto-conflict-resolution. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1980: CLOUDSTACK-9805: Display VR list in network details
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1980 LGTM (based on code only) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2011: CLOUDSTACK-9811: fix duplicated nics on VR caused by...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/2011 thanks @ustcweizhou @karuturi can we merge this? and merge forward? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1582: CLOUDSTACK-9408 for the move away from download.clou...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1582 @karuturi I hade a brief peek, #1982 does not have templates for lxc or ovm3, so that at least is one problem. I think it needs to be reverted and recreated, probably on top of this one. Or else this one would again need to be rebased. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2011: CLOUDSTACK-9811: fix duplicated nics on VR caused by...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/2011 @ustcweizhou this enables looking for a nic by a name like a1b2c3 (\D+\d+\D*\d*\D*\d*) it will also allow all shorter as long as they start with which makes sense. But to satisfy @karuturi's question in 2003, could you *briefly* describe how this prevents extra nics from being created? otherwise LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1582: CLOUDSTACK-9408 for the move away from download.clou...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1582 @karuturi the intent of this PR was never to change any of the templates, only the locations. I see some changes in there that I think are the result of the many rebasing this PR has undergone. I think you need to check against the change that updated the templates. Maybe reapplying that code can work. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/2003 code LGTM but @ustcweizhou 's patch still makes sense to me. Maybe you can add that separately? travis still fails! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1582: CLOUDSTACK-9408 for the move away from downlo...
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1582#discussion_r106675353 --- Diff: api/src/org/apache/cloudstack/api/response/AutoScaleVmProfileResponse.java --- @@ -75,6 +75,7 @@ @Parameter(name = ApiConstants.CS_URL, type = CommandType.STRING, description = "the API URL including port of the CloudStack Management Server example: http://server.cloud.com:8080/client/api?;) +// leaving cloud.com reference above as it serves only as an example --- End diff -- ok, in that perspect you have a point absolutely. The sentence would need to be rephrased, then. It now spells "example: http://...;! Ive been going through the, code reviewing every occurrence of cloud.com, back in june!!! just before leaving the project to do some paid work ;) (hope my boss is alright with this remark) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1582: CLOUDSTACK-9408 for the move away from download.clou...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1582 @karuturi I rebased on latest master, is anything else expected? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1582: CLOUDSTACK-9408 for the move away from downlo...
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1582#discussion_r106667548 --- Diff: api/src/org/apache/cloudstack/api/response/AutoScaleVmProfileResponse.java --- @@ -75,6 +75,7 @@ @Parameter(name = ApiConstants.CS_URL, type = CommandType.STRING, description = "the API URL including port of the CloudStack Management Server example: http://server.cloud.com:8080/client/api?;) +// leaving cloud.com reference above as it serves only as an example --- End diff -- I don't see you point Rafael. it would no longer be an example bu a semi formal definition. Also I think it is out of scope to be frank --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1582: CLOUDSTACK-9408 for the move away from download.clou...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1582 sorry @karuturi should I update? This is really not on my radar that much anymore. I will look at it this afternoon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1988: WIP: CLOUDSTACK-9815 intergration of ApplicationClus...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1988 @ustcweizhou @sebgoa @rhtyd can you review this as a first version of an integrated plugin for application clusters. It is still very k8s specific and I want to defer making it more generic until we found real use cases for that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1988: WIP: CLOUDSTACK-9815 intergration of ApplicationClus...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1988 @blueorangutan test centos7 kvm-centos7 component/application_clusters/test_application_cluster_life_cycle.py,component/application_clusters/test_application_cluster_provisioning.py,component/application_clusters/test_provisioning_and_deployment.py --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1582: CLOUDSTACK-9408 for the move away from download.clou...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1582 @karuturi @wido @rhtyd @swill @pdion891 @rafaelweingartner I see the system VMs pointed to are still those in the 4.6 directory on the download servers. Is that really intended? I thought we now have 4.9 (because of strongswan). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1582: CLOUDSTACK-9408 for the move away from download.clou...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1582 So this PR will be useless as is! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/669 @rafaelweingartner good improvement. @anshul1886 can you merge Rafael's stuff? He addresses the code doublure and the generic exception. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1988: WIP: CLOUDSTACK-9815 intergration of ApplicationClus...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1988 @blueorangutan package centos7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1988: WIP: CLOUDSTACK-9815 intergration of ApplicationClus...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1988 @blueorangutan package centos7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1988: WIP: CLOUDSTACK-9815 intergration of ApplicationClus...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1988 @blueorangutan help --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1582: CLOUDSTACK-9408 for the move away from downlo...
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1582#discussion_r105162233
--- Diff: packaging/centos63/cloud.spec ---
@@ -445,7 +445,7 @@ grep -s -q "db.usage.driver=jdbc:mysql"
"%{_sysconfdir}/%{name}/management/db.pr
grep -s -q "db.simulator.driver=jdbc:mysql"
"%{_sysconfdir}/%{name}/management/db.properties" || sed -i -e
"\$adb.simulator.driver=jdbc:mysql"
"%{_sysconfdir}/%{name}/management/db.properties"
if [ ! -f
%{_datadir}/cloudstack-common/scripts/vm/hypervisor/xenserver/vhd-util ] ; then
-echo Please download vhd-util from
http://download.cloud.com.s3.amazonaws.com/tools/vhd-util and put it in
+echo Please download vhd-util from
http://download.apachecloudstack.net/tools/vhd-util and put it in
--- End diff --
@rhtyd yes, we can. At the time we started with this it wasn't clear yet
what the url would eventually be.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1995: CLOUDSTACK-9828: GetDomRVersionCommand fails to get ...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1995 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1582: CLOUDSTACK-9408 for the move away from download.clou...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1582 ping @rhtyd @swill @chiradeep @NuxRo @pdion891 @wido @karuturi I rebased please send me any pull requests on this if you feel extra is needed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1988: WIP: CLOUDSTACK-9815 intergration of ApplicationClus...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1988 @ustcweizhou of course. It is still work in progress but all changes needed will be added in time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1988: WIP: CLOUDSTACK-9815 intergration of ApplicationClus...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1988 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1988: WIP: CLOUDSTACK-9815 intergration of ApplicationClus...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1988 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1779: CLOUDSTACK-9610: Disabled Host Keeps Being up status...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1779 Looks good to me, @rhtyd are your concerns met? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1988: WIP: CLOUDSTACK-9815 intergration of Applicat...
GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/1988 WIP: CLOUDSTACK-9815 intergration of ApplicationClusterService this external plugin will be integrated as core plugin. It was originally created as plugin on 4.5. bouncycaste needs updating and several integration problems are still blocking a merge. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudstack application-clusters Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1988.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1988 commit ad03449239df0d17ef9dfd9bede96081d9e657e4 Author: Daan Hoogland <daan.hoogl...@shapeblue.com> Date: 2017-03-03T20:56:53Z intergration of ContainerClusterService as ApplicationClusterService this external plugin will be integrated as core plugin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KV...
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1960#discussion_r103890661 --- Diff: api/src/org/apache/cloudstack/api/command/admin/ha/DisableHAForClusterCmd.java --- @@ -0,0 +1,114 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.cloudstack.api.command.admin.ha; + +import com.cloud.event.EventTypes; +import com.cloud.exception.ConcurrentOperationException; +import com.cloud.exception.InsufficientCapacityException; +import com.cloud.exception.NetworkRuleConflictException; +import com.cloud.exception.ResourceAllocationException; +import com.cloud.exception.ResourceUnavailableException; +import com.cloud.org.Cluster; +import org.apache.cloudstack.acl.RoleType; +import org.apache.cloudstack.api.APICommand; +import org.apache.cloudstack.api.ApiArgValidator; +import org.apache.cloudstack.api.ApiConstants; +import org.apache.cloudstack.api.ApiErrorCode; +import org.apache.cloudstack.api.BaseAsyncCmd; +import org.apache.cloudstack.api.BaseCmd; +import org.apache.cloudstack.api.Parameter; +import org.apache.cloudstack.api.ServerApiException; +import org.apache.cloudstack.api.response.ClusterResponse; +import org.apache.cloudstack.api.response.SuccessResponse; +import org.apache.cloudstack.context.CallContext; +import org.apache.cloudstack.ha.HAConfigManager; + +import javax.inject.Inject; + +@APICommand(name = DisableHAForClusterCmd.APINAME, description = "Disables HA cluster-wide", --- End diff -- If we decide to implement some kind of mirroring service for entire zones or clusters for high availability, these would then be disabled / enabled for a zone or cluster. In this case the enabling is done per host in the zone/cluster. That's why i consider the longer name I propose more appropriate. That said the shorter the name the better as long as it is unambiguous. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KV...
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1960#discussion_r103872151
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/host/PrepareForMaintenanceCmd.java
---
@@ -108,4 +108,8 @@ public void execute() {
throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR,
"Failed to prepare host for maintenance");
}
}
+
+public void setHostId(final Long hostId) {
--- End diff --
the field name is id, so i don't understand your reply
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1779: CLOUDSTACK-9610: Disabled Host Keeps Being up status...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1779 @priyankparihar I agree that host should not show as up but indeed why hide it? Unless we show no details for an unmanaged cluster we should be able to find the host in there. It should still show as disabled of course. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA pr...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1960 I went through the code and found no real issues. for any other reviewers I recommend reading the FS first. It is quit a big chunk but very neat. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KV...
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1960#discussion_r103221397
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/ChangeOutOfBandManagementPasswordCmd.java
---
@@ -74,7 +74,7 @@ public void execute() throws
ResourceUnavailableException, InsufficientCapacityE
CallContext.current().setEventDetails("Host Id: " + host.getId() +
" Password: " + getPassword().charAt(0) + "");
CallContext.current().putContextParameter(Host.class,
host.getUuid());
-final OutOfBandManagementResponse response =
outOfBandManagementService.changeOutOfBandManagementPassword(host,
getPassword());
+final OutOfBandManagementResponse response =
outOfBandManagementService.changePassword(host, getPassword());
--- End diff --
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KV...
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1960#discussion_r103221221
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/host/PrepareForMaintenanceCmd.java
---
@@ -108,4 +108,8 @@ public void execute() {
throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR,
"Failed to prepare host for maintenance");
}
}
+
+public void setHostId(final Long hostId) {
--- End diff --
naming: consistency would dictate this be called setId()
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1768 [1768.network.results.txt](https://github.com/apache/cloudstack/files/805988/1768.network.results.txt) [1768.vpc_routers.results.txt](https://github.com/apache/cloudstack/files/805989/1768.vpc_routers.results.txt) just for form @karuturi . I see failures in network but can not relate these to the upgrades --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1768 @rhtyd I don't see how your concern is more true for the new code by @marcaurele then it is true for old code. cleanup is still going to be executed after the scripts, is it? only directly after instead of waiting for unrelated upgrade scripts to complete as well. We never have and never can have full coverage of upgrades as every cloud is a different snowflake. So we'll need to fix problems after intitial release most of the time. That is no worse or better with this code it is just a little more predictable. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KV...
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1960#discussion_r103207344 --- Diff: .travis.yml --- @@ -42,13 +42,18 @@ env: smoke/test_dynamicroles smoke/test_global_settings smoke/test_guest_vlan_range + smoke/test_ha_for_host --- End diff -- :+1: :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KV...
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1960#discussion_r103210828 --- Diff: api/src/org/apache/cloudstack/api/command/admin/ha/DisableHAForClusterCmd.java --- @@ -0,0 +1,114 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.cloudstack.api.command.admin.ha; + +import com.cloud.event.EventTypes; +import com.cloud.exception.ConcurrentOperationException; +import com.cloud.exception.InsufficientCapacityException; +import com.cloud.exception.NetworkRuleConflictException; +import com.cloud.exception.ResourceAllocationException; +import com.cloud.exception.ResourceUnavailableException; +import com.cloud.org.Cluster; +import org.apache.cloudstack.acl.RoleType; +import org.apache.cloudstack.api.APICommand; +import org.apache.cloudstack.api.ApiArgValidator; +import org.apache.cloudstack.api.ApiConstants; +import org.apache.cloudstack.api.ApiErrorCode; +import org.apache.cloudstack.api.BaseAsyncCmd; +import org.apache.cloudstack.api.BaseCmd; +import org.apache.cloudstack.api.Parameter; +import org.apache.cloudstack.api.ServerApiException; +import org.apache.cloudstack.api.response.ClusterResponse; +import org.apache.cloudstack.api.response.SuccessResponse; +import org.apache.cloudstack.context.CallContext; +import org.apache.cloudstack.ha.HAConfigManager; + +import javax.inject.Inject; + +@APICommand(name = DisableHAForClusterCmd.APINAME, description = "Disables HA cluster-wide", --- End diff -- naming: looking at the code below this actually is DisableHAForHostsInClusterCmd. I don't think it is a biggy but might lead to conflicts at some point --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KV...
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1960#discussion_r103212736 --- Diff: api/src/org/apache/cloudstack/api/command/admin/ha/DisableHAForZoneCmd.java --- @@ -0,0 +1,115 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.cloudstack.api.command.admin.ha; + +import com.cloud.dc.DataCenter; +import com.cloud.event.EventTypes; +import com.cloud.exception.ConcurrentOperationException; +import com.cloud.exception.InsufficientCapacityException; +import com.cloud.exception.NetworkRuleConflictException; +import com.cloud.exception.ResourceAllocationException; +import com.cloud.exception.ResourceUnavailableException; +import org.apache.cloudstack.acl.RoleType; +import org.apache.cloudstack.api.APICommand; +import org.apache.cloudstack.api.ApiArgValidator; +import org.apache.cloudstack.api.ApiConstants; +import org.apache.cloudstack.api.ApiErrorCode; +import org.apache.cloudstack.api.BaseAsyncCmd; +import org.apache.cloudstack.api.BaseCmd; +import org.apache.cloudstack.api.Parameter; +import org.apache.cloudstack.api.ServerApiException; +import org.apache.cloudstack.api.response.SuccessResponse; +import org.apache.cloudstack.api.response.ZoneResponse; +import org.apache.cloudstack.context.CallContext; +import org.apache.cloudstack.ha.HAConfigManager; + +import javax.inject.Inject; + +@APICommand(name = DisableHAForZoneCmd.APINAME, description = "Disables HA for a zone", --- End diff -- naming: see disable cluster cmd --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KV...
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1960#discussion_r103212914
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/ha/EnableHAForClusterCmd.java
---
@@ -0,0 +1,114 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.api.command.admin.ha;
+
+import com.cloud.event.EventTypes;
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.exception.NetworkRuleConflictException;
+import com.cloud.exception.ResourceAllocationException;
+import com.cloud.exception.ResourceUnavailableException;
+import com.cloud.org.Cluster;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiArgValidator;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.ClusterResponse;
+import org.apache.cloudstack.api.response.SuccessResponse;
+import org.apache.cloudstack.context.CallContext;
+import org.apache.cloudstack.ha.HAConfigManager;
+
+import javax.inject.Inject;
+
+@APICommand(name = EnableHAForClusterCmd.APINAME, description = "Enables
HA cluster-wide",
+responseObject = SuccessResponse.class,
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false,
+since = "4.11", authorized = {RoleType.Admin})
+public final class EnableHAForClusterCmd extends BaseAsyncCmd {
--- End diff --
naming: see disable cmd
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1768 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1768 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1768 @BlueOrangUtan help --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1768 @BlueOrangUtan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1768 @syed the -cleanup scripts are for removing data that had been migrated, not for temporary tables. also a use case for those may be if things are done partly in the migrate script and partly in the migrate class, though I can't think of a real instance of that use case. as for the ovs-tunnel code, we don't have to loose that, do we? SO even with people using it we can apply this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1944 seen it work in practice: LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1768 @karuturi I think this should go in. Even being a bit of a risk, it will potentially reduce the support hours on upgrades. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1768 btw @marcaurele @rhtyd idempotent will only be possible if we encode it. It is not encoded in older upgrades. Unless we clean those upgrades up we will have some issues. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1768 LGTM but I hope you appreciate the concerns @marcaurele , on the other hand let's fix what breaks and make sure the 4.9 to 4.10 works with this. We can always advice to upgrade to 4.9 before going up. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #859: Bug-ID: CLOUDSTACK-8882: calculate network offering u...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/859 @kishankavala i forgot about this one, guess we won't make 4.7 ;) can you appease cloudmonger? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1741: Updated StrongSwan VPN Implementation
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1741
@swill I know and work needs done. On the other hand, you mentioned you
wanted to see this run in trillian. You still want that? Else I will skip
and just review the code tomorrow.
Biligual auto correct use. Read at your own risico
On 9 Feb 2017 6:29 pm, "Will Stevens" <notificati...@github.com> wrote:
> @DaanHoogland <https://github.com/DaanHoogland> did you make the test run
> in Trillian install a SystemVM built from this PR? If you didn't it won't
> actually be a valid test run...
>
> â
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/cloudstack/pull/1741#issuecomment-278712858>,
> or mute the thread
>
<https://github.com/notifications/unsubscribe-auth/ACXysUVYKVbIJIXDlnrSXhez12lK23GKks5ra00HgaJpZM4KiVbU>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1747: CLOUDSTACK-9574: Redesign storage views
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1747 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1747: CLOUDSTACK-9574: Redesign storage views
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1747 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1741: Updated StrongSwan VPN Implementation
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1741
I started a build yesterday but am not at my computer today. I'll look at
the results later.
Biligual auto correct use. Read at your own risico
On 8 Feb 2017 4:58 pm, "Will Stevens" <notificati...@github.com> wrote:
> @DaanHoogland <https://github.com/DaanHoogland> I don't think this will
> work. I think you have to manually specify a SystemVM template built from
> this PR in order for the tests to work. I don't think a SystemVM from this
> PR is used by default.
>
> â
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/cloudstack/pull/1741#issuecomment-278369282>,
> or mute the thread
>
<https://github.com/notifications/unsubscribe-auth/ACXysTl0u14tUk1K6hyzSfJpgR07rG7gks5raeYPgaJpZM4KiVbU>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #844: [4.10] CLOUDSTACK-7985: assignVM in Advanced zone wit...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/844 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #844: [4.10] CLOUDSTACK-7985: assignVM in Advanced zone wit...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/844 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1741: Updated StrongSwan VPN Implementation
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1741 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1741: Updated StrongSwan VPN Implementation
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1741 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1929: CLOUDSTACK-9770: fix missing ip routes in VR
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1929 @milamberspace could you try with this patch? I think @ustcweizhou solved your problem with the default route --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #977: [4.10] CLOUDSTACK-8746: VM Snapshotting implementatio...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/977 hey @kiwiflyer (not related to the PR at hand) I see that this PR is not reported on acspr.enu.net as ci complete. Is that a bug? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1858: README: Happy Christmas, happy holidays!
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1858 If we have to On Thu, Dec 22, 2016 at 9:02 PM, Milamber <notificati...@github.com> wrote: > LGTM and Happy holidays! > > â > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/cloudstack/pull/1858#issuecomment-268878983>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ACXysT2sqOEoootd9CzKLxaRlkJkNqnvks5rKtc6gaJpZM4LUPlG> > . > -- Daan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1542 @nvazquez unfortunately I no longer am involved in cloud computing. I'd really need a deep dive to give value, sorry. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1582: CLOUDSTACK-9408 for the move away from download.clou...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1582 valid points @chiradeep but I think they both warrant separate PRs, no? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1582: CLOUDSTACK-9408 for the move away from download.clou...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1582 I think we can remove all templates from prior versions, from the code that is. As for the repo, only if we know it is no longer being used. I think we at least need to give a heads up to accelarite as they should be owner of the name cloud.com by now and thus the older references to the templates. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1582: CLOUDSTACK-9408 for the move away from download.clou...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1582 I removed it in the last commit. download,apachecloudstack.net points to cloudstack.apt-get.eu. Did I miss one or Do you mean to remove the domainname? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1582: CLOUDSTACK-9408 for the move away from download.clou...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1582 pinging some people as this might need attention @swill @chiradeep @pdion891 @wido @shapeblue ( @rhtyd @jburwell @abhinandanprateek ;) @accelarite (@rajani @koushik-das ...?) I think we can merge as is or discuss further additions for this PR or as follow up. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1547 @swill Pinging @ustcweizhou again, I know leaseweb has an interest in this. They use advanced zones in several different setups so their ok is a good indication we can merge (together with pcxtreme their ok) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1530: Vmdk findbugs
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1530 @swill @jburwell is this one ok? @bvbharat I don't see anything in the link in your comment so I must assume the failure is in the test itself If we don't merge this I will close the PR. It is simple and not worth much more attention. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1582: CLOUDSTACK-9408 for the move away from downlo...
GitHub user DaanHoogland reopened a pull request: https://github.com/apache/cloudstack/pull/1582 CLOUDSTACK-9408 for the move away from download.cloud.com - commented some occurences of cloud.com as being harmless * examples * identifiers (internal) - changed the URL for vhd-util download - changed comments from 'cloud.com' to 'Apache CloudStack' What remains now is to find all other downloads that occur from the code and reconstruct the tree in a save location (atm at cloudstack.apt-get.eu) We will also want to use a CNAME for download.cloudstack.org which can for now point to cloudstack.apt-get.eu and can later be implemented with a redirect mechanism to a mirror list. this should be save to pull in now but we can add the missing parts in this PR as well. You can merge this pull request into a Git repository by running: $ git pull https://github.com/DaanHoogland/cloudstack CLOUDSTACK-9408 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1582.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1582 commit c443efd7825038c1b42785e13246bbfadd2f08ab Author: Daan Hoogland <d...@onecht.net> Date: 2016-06-07T10:20:36Z CLOUDSTACK-9408 for the move away from download.cloud.com - commented some occurences of cloud.com as being harmless * examples * identifiers (internal) - changed the URL for vhd-util download - changed comments from 'cloud.com' to 'Apache CloudStack' commit c4f13fe286e0b53360d4adf2e7b63cca3b6c9549 Author: Daan Hoogland <d...@onecht.net> Date: 2016-06-07T10:40:38Z CLOUDSTACK-9408 remove antiquated devcloud project as it contains references to cloud.com and is not current commit 9b7049d6c116a82287fed7bb9201e0344e70a13f Author: Daan Hoogland <d...@onecht.net> Date: 2016-06-07T18:10:25Z CLOUDSTACK-9408 change URLs in templates.sql --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1582: CLOUDSTACK-9408 for the move away from downlo...
Github user DaanHoogland closed the pull request at: https://github.com/apache/cloudstack/pull/1582 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1582: CLOUDSTACK-9408 for the move away from downlo...
GitHub user DaanHoogland reopened a pull request: https://github.com/apache/cloudstack/pull/1582 CLOUDSTACK-9408 for the move away from download.cloud.com - commented some occurences of cloud.com as being harmless * examples * identifiers (internal) - changed the URL for vhd-util download - changed comments from 'cloud.com' to 'Apache CloudStack' What remains now is to find all other downloads that occur from the code and reconstruct the tree in a save location (atm at cloudstack.apt-get.eu) We will also want to use a CNAME for download.cloudstack.org which can for now point to cloudstack.apt-get.eu and can later be implemented with a redirect mechanism to a mirror list. this should be save to pull in now but we can add the missing parts in this PR as well. You can merge this pull request into a Git repository by running: $ git pull https://github.com/DaanHoogland/cloudstack CLOUDSTACK-9408 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1582.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1582 commit c443efd7825038c1b42785e13246bbfadd2f08ab Author: Daan Hoogland <d...@onecht.net> Date: 2016-06-07T10:20:36Z CLOUDSTACK-9408 for the move away from download.cloud.com - commented some occurences of cloud.com as being harmless * examples * identifiers (internal) - changed the URL for vhd-util download - changed comments from 'cloud.com' to 'Apache CloudStack' commit c4f13fe286e0b53360d4adf2e7b63cca3b6c9549 Author: Daan Hoogland <d...@onecht.net> Date: 2016-06-07T10:40:38Z CLOUDSTACK-9408 remove antiquated devcloud project as it contains references to cloud.com and is not current commit 9b7049d6c116a82287fed7bb9201e0344e70a13f Author: Daan Hoogland <d...@onecht.net> Date: 2016-06-07T18:10:25Z CLOUDSTACK-9408 change URLs in templates.sql --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1582: CLOUDSTACK-9408 for the move away from downlo...
Github user DaanHoogland closed the pull request at: https://github.com/apache/cloudstack/pull/1582 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1547 Yes @wido ,they look good to me but I am not running a cloud at the moment so hence I asked @ustcweizhou to have a look. He had concerns but I did not see him react since. The test I did were in advanced zone so we do have a rather broad coverage so far. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1582: CLOUDSTACK-9408 for the move away from downlo...
GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/1582 CLOUDSTACK-9408 for the move away from download.cloud.com - commented some occurences of cloud.com as being harmless * examples * identifiers (internal) - changed the URL for vhd-util download - changed comments from 'cloud.com' to 'Apache CloudStack' What remains now is to find all other downloads that occur from the code and reconstruct the tree in a save location (atm at cloudstack.apt-get.eu) We will also want to use a CNAME for download.cloudstack.org which can for now point to cloudstack.apt-get.eu and can later be implemented with a redirect mechanism to a mirror list. this should be save to pull in now but we can add the missing parts in this PR as well. You can merge this pull request into a Git repository by running: $ git pull https://github.com/DaanHoogland/cloudstack CLOUDSTACK-9408 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1582.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1582 commit c443efd7825038c1b42785e13246bbfadd2f08ab Author: Daan Hoogland <d...@onecht.net> Date: 2016-06-07T10:20:36Z CLOUDSTACK-9408 for the move away from download.cloud.com - commented some occurences of cloud.com as being harmless * examples * identifiers (internal) - changed the URL for vhd-util download - changed comments from 'cloud.com' to 'Apache CloudStack' --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1531: systemvmtemplate: fix build and upgrade to debian 7....
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1531 @remibergsma @rhtyd :+1: let's add the packer project and phase out the old template builds. more decoupling and (i suspect) simpler build process. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1547 CI Results: ok one test failed but retest manually succeeded [1547.results.network.txt](https://github.com/apache/cloudstack/files/300726/1547.results.network.txt) [1547.results.vpc_routers.txt](https://github.com/apache/cloudstack/files/300727/1547.results.vpc_routers.txt) @ustcweizhou can you re-review? @The-Loeki one travis run failed during install though the others succeeded. Maybe you can re-open to try your luck. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1547 @wido, I am not in favour of squashing these. They seem to be different fixes with their own history. I will start an integration run. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: systemvm - Python code cleanup
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1575 @romain-dartigues in such cases you can fetch the branch of the submitter in your own workspace and build on top of it, push to your own fork on github and open a PR from that. When that gets merged the older one automatically get marked as merged as well. very convenient way of building on each others work. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Removed unused methods from XenServerConnectionPool
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1557 No I am talking about the problems with TrustAllManager. I am not convinced there is a problem by the not by @rodrigo93 . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Removed unused methods from XenServerConnectionPool
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1557 @rodrigo93 @rafaelweingartner Do you have a scenario that proves these methods to be a problem? returning true or null (or void) does not imply a problem unless the result can be abused. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9379: Support nested virtualization at V...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1542 @nvazquez sounds great, keep us posted --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Vmdk findbugs
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1530#discussion_r64402582
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -27,55 +27,53 @@
import org.apache.log4j.Logger;
+import com.cloud.utils.StringUtils;
+import com.google.common.base.Preconditions;
+
public class VmdkFileDescriptor {
private static final Logger s_logger =
Logger.getLogger(VmdkFileDescriptor.class);
private static final String VMDK_PROPERTY_CREATE_TYPE = "createType";
private static final String VMDK_CREATE_TYPE_VMFSSPARSE = "vmfsSparse";
private static final String VMDK_PROPERTY_ADAPTER_TYPE =
"ddb.adapterType";
-private Properties _properties = new Properties();
+private final Properties _properties = new Properties();
private String _baseFileName;
public VmdkFileDescriptor() {
}
public void parse(byte[] vmdkFileContent) throws IOException {
-BufferedReader in = null;
-try {
-in = new BufferedReader(new InputStreamReader(new
ByteArrayInputStream(vmdkFileContent),"UTF-8"));
+try (BufferedReader in = new BufferedReader(new
InputStreamReader(new ByteArrayInputStream(vmdkFileContent),"UTF-8"));) {
String line;
while ((line = in.readLine()) != null) {
// ignore empty and comment lines
line = line.trim();
-if (line.isEmpty())
-continue;
-if (line.charAt(0) == '#')
+if (line.isEmpty() | line.charAt(0) == '#') {
--- End diff --
will redo the travis thing as well ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
