[GitHub] cloudstack issue #1908: CLOUDSTACK-9317: Fixed disable static nat on leaving...

2017-04-11 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1908 Looks good now. Not sure what's up with Jenkins though. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...

2017-04-11 Thread ProjectMoon
Github user ProjectMoon commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1908#discussion_r110848750 --- Diff: setup/db/db/schema-4920to41000.sql --- @@ -230,5 +230,11 @@ JOIN `cloud`.`vm_snapshots` s ON (s.service_offering_id = o.id AND s.vm_id

[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...

2017-04-11 Thread ProjectMoon
Github user ProjectMoon commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1908#discussion_r110849362 --- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java --- @@ -848,13 +849,38 @@ public int compare(final PublicIpAddress o1, final

[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...

2017-04-11 Thread ProjectMoon
Github user ProjectMoon commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1908#discussion_r110848709 --- Diff: setup/db/db/schema-4920to41000.sql --- @@ -230,5 +230,11 @@ JOIN `cloud`.`vm_snapshots` s ON (s.service_offering_id = o.id AND s.vm_id

[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...

2017-04-06 Thread ProjectMoon
Github user ProjectMoon commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1908#discussion_r110113725 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java --- @@ -625,15 +627,20 @@ protected

[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...

2017-03-20 Thread ProjectMoon
Github user ProjectMoon commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1908#discussion_r106855504 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java --- @@ -1764,9 +1765,12 @@ protected

[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...

2017-03-20 Thread ProjectMoon
Github user ProjectMoon commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1908#discussion_r106856634 --- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java --- @@ -848,13 +849,37 @@ public int compare(final PublicIpAddress o1, final

[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...

2017-03-20 Thread ProjectMoon
Github user ProjectMoon commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1908#discussion_r106855300 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java --- @@ -625,15 +627,20 @@ protected

[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...

2017-03-20 Thread ProjectMoon
Github user ProjectMoon commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1908#discussion_r106857110 --- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java --- @@ -848,13 +849,37 @@ public int compare(final PublicIpAddress o1, final

[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...

2017-03-09 Thread ProjectMoon
Github user ProjectMoon commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1908#discussion_r105130816 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java --- @@ -625,15 +627,20 @@ protected

[GitHub] cloudstack issue #1908: CLOUDSTACK-9317: Fixed disable static nat on leaving...

2017-03-03 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1908 Hi, that's great news. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1908: CLOUDSTACK-9317: Fixed disable static nat on leaving...

2017-03-01 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1908 @jayapalu Quite possible, yes. It could be fixed by adding another condition to the check that was added with #1907. It could also be "fixed" by checkiing if `configured()` ret

[GitHub] cloudstack issue #1908: CLOUDSTACK-9317: Fixed disable static nat on leaving...

2017-02-28 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1908 We have been testing this PR internally for some time now, and we have seen some strange `arping` issues. We have seen that `/etc/cloudstack/ips.json` on the router has IPs on them

[GitHub] cloudstack issue #1908: CLOUDSTACK-9317: Fixed disable static nat on leaving...

2017-02-28 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1908 I'm looking at the `DataBag` code, and it seems that it loads information from the data located at `/etc/cloudstack/` and therefore 1907 should work fine with this, ASSUMING that is smart

[GitHub] cloudstack issue #1908: CLOUDSTACK-9317: Fixed disable static nat on leaving...

2017-02-28 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1908 Question: would #1907 be relevant to this? That change relied on sending all the IPs to the router, but under this change, we will be sending one at a time. --- If your project is set up

[GitHub] cloudstack issue #1948: [CLOUDSTACK-9793] Faster IP in subnet check

2017-02-17 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1948 Updated with the JIRA ticket. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1948: Faster IP in subnet check

2017-02-17 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1948 We have not entered one into JIRA, no. But we can. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...

2017-02-17 Thread ProjectMoon
Github user ProjectMoon commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1908#discussion_r101736186 --- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java --- @@ -175,6 +176,8 @@ @Inject private IPAddressDao

[GitHub] cloudstack issue #1943: CLOUDSTACK-9339: Send correct network type to router...

2017-02-17 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1943 I didn't actually find the other PR, otherwise I probably wouldn't have submitted this one. But I do think this is cleaner, and more centralized. There's no real harm in having both

[GitHub] cloudstack pull request #1948: Faster IP in subnet check

2017-02-17 Thread ProjectMoon
GitHub user ProjectMoon opened a pull request: https://github.com/apache/cloudstack/pull/1948 Faster IP in subnet check This change removes the conversion from IPNetwork to list in one of the router scripts. This makes the router faster at processing static NAT rules, which can

[GitHub] cloudstack pull request #1943: CLOUDSTACK-9339: Send correct network type to...

2017-02-15 Thread ProjectMoon
GitHub user ProjectMoon opened a pull request: https://github.com/apache/cloudstack/pull/1943 CLOUDSTACK-9339: Send correct network type to router config This forces the network type (nw_type) of the IP address being sent into router configuration scripts to be lowercase. All

[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...

2017-02-10 Thread ProjectMoon
Github user ProjectMoon commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1908#discussion_r100535848 --- Diff: setup/db/db/schema-4920to41000.sql --- @@ -62,3 +62,4 @@ INSERT INTO `cloud`.`role_permissions` (`uuid`, `role_id`, `rule`, `permission

[GitHub] cloudstack pull request #1898: CLOUDSTACK-8862: Lock on volume before attemp...

2017-02-08 Thread ProjectMoon
Github user ProjectMoon closed the pull request at: https://github.com/apache/cloudstack/pull/1898 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1898: CLOUDSTACK-8862: Lock on volume before attempting to...

2017-02-08 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1898 Closed in favor of #1900 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1900: CLOUDSTACK-8862: Introduced new state attaching for ...

2017-02-02 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1900 @anshul1886 I have not delved too deeply into the state machine transition code, though I understand the basics of how it works. I think `synchronized` + state transition should be enough

[GitHub] cloudstack issue #1900: CLOUDSTACK-8862: Introduced new state attaching for ...

2017-02-02 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1900 @anshul1886 I am fine with putting both commits on either PR. If you are unopposed we can just stick it on mine? --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack issue #1623: CLOUDSTACK-9317: Enable/disable static NAT associate...

2017-01-17 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1623 Closed in favor of https://github.com/apache/cloudstack/pull/1908 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request #1623: CLOUDSTACK-9317: Enable/disable static NAT as...

2017-01-17 Thread ProjectMoon
Github user ProjectMoon closed the pull request at: https://github.com/apache/cloudstack/pull/1623 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1908: CLOUDSTACK-9317: Fixed disable static nat on leaving...

2017-01-17 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1908 Thanks for adding the missing parts. Here is the PR that was open against 4.8 for this, which I guess can be closed now: https://github.com/apache/cloudstack/pull/1623 I guess

[GitHub] cloudstack issue #1450: CLOUDSTACK-9317: Enable/disable static NAT associate...

2017-01-12 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1450 @jayapalu Can you post this in the new version of the fix? (And possibly re-test, if you were using an older version) --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request #1898: CLOUDSTACK-8862: Lock on volume before attemp...

2017-01-09 Thread ProjectMoon
GitHub user ProjectMoon opened a pull request: https://github.com/apache/cloudstack/pull/1898 CLOUDSTACK-8862: Lock on volume before attempting to attach it. It is possible to attach a single volume to multiple instances by running the commands close to one another. In KVM

[GitHub] cloudstack issue #1617: Changed UsageEventUtils to UsageEventEmitter and mad...

2016-12-01 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1617 We are in the process of fixing the conflicts. The rebase worked fine, but we have to rewrite one of the new unit tests to not use the `UsageEventEmitter`. --- If your project is set up

[GitHub] cloudstack issue #1566: [CLOUDSTACK-9645] Followup fix for #1162: Add suppor...

2016-12-01 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1566 Updated to latest master, and a JIRA ticket now exists. https://issues.apache.org/jira/browse/CLOUDSTACK-9645 --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack issue #1622: [CLOUDSTACK-9644] Adding missing bits field to Templ...

2016-12-01 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1622 Updated to latest master, and a JIRA ticket has been created. https://issues.apache.org/jira/browse/CLOUDSTACK-9644 --- If your project is set up for it, you can reply

[GitHub] cloudstack issue #1618: Now returning os info with the list snapshot respons...

2016-12-01 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1618 Updated to latest master, and now with a JIRA ticket. https://issues.apache.org/jira/browse/CLOUDSTACK-9643 --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack issue #1559: CLOUDSTACK-9280: System VM volumes can be expunged i...

2016-11-23 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1559 @rhtyd, in my opinion the two commits are functionally separate enough that they should remain separate (and this might have been asked for in one of the various previous incarnations

[GitHub] cloudstack issue #1618: Now returning os info with the list snapshot respons...

2016-11-22 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1618 Code review issues have been addressed, with the exception of combining the Guest OS ID/VM Instance ID into a join method on VolumeDao. There was some compilation failure in the F5 plugin

[GitHub] cloudstack pull request #1618: Now returning os info with the list snapshot ...

2016-11-22 Thread ProjectMoon
Github user ProjectMoon commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1618#discussion_r89097671 --- Diff: server/src/com/cloud/api/ApiResponseHelper.java --- @@ -157,6 +156,7 @@ import org.apache.cloudstack.usage.Usage; import

[GitHub] cloudstack issue #1559: CLOUDSTACK-9280: System VM volumes can be expunged i...

2016-11-21 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1559 Addressed the comments. For some reason the tests for VolumeDataFactoryImpl were being skipped. Will try to see why. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack issue #1559: CLOUDSTACK-9280: System VM volumes can be expunged i...

2016-11-21 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1559 Updated to latest 4.8. Will also address the comments too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1618: Now returning os info with the list snapshot respons...

2016-11-21 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1618 Rebased to latest master. The comments will also be addressed soon, hopefully. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack issue #1622: Adding missing bits field to TemplateResponse

2016-11-21 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1622 Rebased to latest master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1623: CLOUDSTACK-9317: Enable/disable static NAT associate...

2016-11-21 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1623 Updated to latest 4.8. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1566: Followup fix for #1162: Add support for not (re)star...

2016-11-21 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1566 Rebased to latest master. Should probably rebuild the packages. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1744: CLOUDSTACK-9183: bash: /opt/cloud/bin/getRouterAlert...

2016-11-02 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1744 In the JIRA ticket, it's at least reported that this is happening on 4.8 as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request #1607: SSVM downloader now handles redirects properl...

2016-11-01 Thread ProjectMoon
Github user ProjectMoon closed the pull request at: https://github.com/apache/cloudstack/pull/1607 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1607: SSVM downloader now handles redirects properly.

2016-11-01 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1607 Closed in favor of #1746. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request #1746: SSVM downloader now handles redirects properl...

2016-11-01 Thread ProjectMoon
GitHub user ProjectMoon opened a pull request: https://github.com/apache/cloudstack/pull/1746 SSVM downloader now handles redirects properly. New version of #1607, opened against 4.9 so it can be forward merged. **Original Description** Previously it was using

[GitHub] cloudstack pull request #1622: Adding missing bits field to TemplateResponse

2016-10-21 Thread ProjectMoon
GitHub user ProjectMoon reopened a pull request: https://github.com/apache/cloudstack/pull/1622 Adding missing bits field to TemplateResponse This pull request adds a bits field for template size, and sets it equal to ISO size. You can merge this pull request into a Git repository

[GitHub] cloudstack pull request #1622: Adding missing bits field to TemplateResponse

2016-10-21 Thread ProjectMoon
Github user ProjectMoon closed the pull request at: https://github.com/apache/cloudstack/pull/1622 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack pull request #1622: Adding missing bits field to TemplateResponse

2016-10-21 Thread ProjectMoon
Github user ProjectMoon closed the pull request at: https://github.com/apache/cloudstack/pull/1622 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1622: Adding missing bits field to TemplateResponse

2016-10-21 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1622 Build failed due to running out of disk space. Will re-trigger. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request #1622: Adding missing bits field to TemplateResponse

2016-10-21 Thread ProjectMoon
GitHub user ProjectMoon reopened a pull request: https://github.com/apache/cloudstack/pull/1622 Adding missing bits field to TemplateResponse This pull request adds a bits field for template size, and sets it equal to ISO size. You can merge this pull request into a Git repository

[GitHub] cloudstack issue #1622: Adding missing bits field to TemplateResponse

2016-10-21 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1622 This has been rebased to the latest master, and the code review suggestions applied. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack issue #1623: CLOUDSTACK-9317: Enable/disable static NAT associate...

2016-10-21 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1623 This one hasn't been rebased in quite a while, so the packages produced will be rather old. Going to rebase this against latest 4.8. --- If your project is set up for it, you can reply

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-10-21 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1624 The commits have been squashed, commit message updated to make sense (I think; let me know if it's not right), and rebased against latest 4.8. --- If your project is set up for it, you can

[GitHub] cloudstack issue #1607: SSVM downloader now handles redirects properly.

2016-10-21 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1607 This one hasn't been rebased in quite a while, so the packages produced will be rather old. Going to rebase this against latest master. --- If your project is set up for it, you can reply

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-10-13 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1624 No code changes, just updating the commits under it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-10-13 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1624 This branch has been rebased to latest 4.8. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1559: CLOUDSTACK-9280: System VM volumes can be expunged i...

2016-10-12 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1559 Looks like Travis worked this time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request #1559: CLOUDSTACK-9280: System VM volumes can be exp...

2016-10-12 Thread ProjectMoon
GitHub user ProjectMoon reopened a pull request: https://github.com/apache/cloudstack/pull/1559 CLOUDSTACK-9280: System VM volumes can be expunged if no SSVM exists. This commit adds a special SSVM endpoint which simply returns true for all operations sent to it, without

[GitHub] cloudstack pull request #1559: CLOUDSTACK-9280: System VM volumes can be exp...

2016-10-12 Thread ProjectMoon
Github user ProjectMoon closed the pull request at: https://github.com/apache/cloudstack/pull/1559 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1559: CLOUDSTACK-9280: System VM volumes can be expunged i...

2016-10-12 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1559 The OOBM power off test keeps failing. I've run the test locally with the simulator and it succeeds fine. Going to try to kick Travis again to see if it works (third time's the charm

[GitHub] cloudstack pull request #1559: CLOUDSTACK-9280: System VM volumes can be exp...

2016-10-11 Thread ProjectMoon
GitHub user ProjectMoon reopened a pull request: https://github.com/apache/cloudstack/pull/1559 CLOUDSTACK-9280: System VM volumes can be expunged if no SSVM exists. This commit adds a special SSVM endpoint which simply returns true for all operations sent to it, without

[GitHub] cloudstack pull request #1559: CLOUDSTACK-9280: System VM volumes can be exp...

2016-10-11 Thread ProjectMoon
Github user ProjectMoon closed the pull request at: https://github.com/apache/cloudstack/pull/1559 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1559: CLOUDSTACK-9280: System VM volumes can be expunged i...

2016-10-07 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1559 This pull request has been updated with another commit that fixes a bug where volumes cannot be expunged because the loading of the volume fails to find a primary data store (despite

[GitHub] cloudstack pull request #1624: Fixes regarding VOLUME_DELETE events resultin...

2016-09-17 Thread ProjectMoon
Github user ProjectMoon closed the pull request at: https://github.com/apache/cloudstack/pull/1624 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack pull request #1624: Fixes regarding VOLUME_DELETE events resultin...

2016-09-17 Thread ProjectMoon
GitHub user ProjectMoon reopened a pull request: https://github.com/apache/cloudstack/pull/1624 Fixes regarding VOLUME_DELETE events resulting from account deletion New version of #1491. **Original Description** New version of #1373, but updated for the 4.7 branch

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-09-02 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1624 We can have someone test it. Are you looking for results of a manual test, reproduction tests, or something automated? A manual test is probably the best from our side because we don't

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-09-01 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1624 Looks like it's ready for merging now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-09-01 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1624 The pull request has been rebased. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-09-01 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1624 Alright. I'll rebase it once #1654 has been merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-08-29 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1624 Have rebased to latest 4.8. Travis build failed with what looks like `Unable to execute /home/travis/build/apache/cloudstack/developer/target/db/templates.simulator.sql: Unknown column

[GitHub] cloudstack pull request #1624: Fixes regarding VOLUME_DELETE events resultin...

2016-08-29 Thread ProjectMoon
GitHub user ProjectMoon reopened a pull request: https://github.com/apache/cloudstack/pull/1624 Fixes regarding VOLUME_DELETE events resulting from account deletion New version of #1491. **Original Description** New version of #1373, but updated for the 4.7 branch

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-08-29 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1624 Jenkins build log has vanished into 404 oblivion. Will see what happened with Travis (https://travis-ci.org/apache/cloudstack/builds/154436801). --- If your project is set up for it, you

[GitHub] cloudstack pull request #1624: Fixes regarding VOLUME_DELETE events resultin...

2016-08-29 Thread ProjectMoon
Github user ProjectMoon closed the pull request at: https://github.com/apache/cloudstack/pull/1624 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1623: CLOUDSTACK-9317: Enable/disable static NAT associate...

2016-08-29 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1623 Yeah. Unfortunately I have not had any time to work on the pull requests lately. When I have time I will reopen it against 4.9. --- If your project is set up for it, you can reply

[GitHub] cloudstack issue #1635: CLOUDSTACK-9451

2016-08-24 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1635 All hypervisors are affected by this, since the parameter is just not passed into the VM Manager. That means its effects don't work at all anywhere. :) I will try to review it to tomorrow

[GitHub] cloudstack pull request #1661: Export UUID for zone creation event completio...

2016-08-24 Thread ProjectMoon
GitHub user ProjectMoon opened a pull request: https://github.com/apache/cloudstack/pull/1661 Export UUID for zone creation event completion. Action events have support for exporting their "first class entities" over the event bus, if it's turned on. This wo

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-08-23 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1624 Has been rebased against latest 4.8 and the `TODO` comments removed. The map was left alone though. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request #1624: Fixes regarding VOLUME_DELETE events resultin...

2016-08-23 Thread ProjectMoon
Github user ProjectMoon commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1624#discussion_r75853547 --- Diff: server/test/com/cloud/user/AccountManagerImplTest.java --- @@ -231,6 +253,73 @@ public void cleanup() { CallContext.unregister

[GitHub] cloudstack issue #1623: CLOUDSTACK-9317: Enable/disable static NAT associate...

2016-08-23 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1623 It's been amended and rebased. I still haven't had time to add a new DAO method to the IP address DAO. I can work on that now though. When is the RC being cut? --- If your project is set

[GitHub] cloudstack issue #1632: Honor the forced parameter for stopVirtualMachine ap...

2016-08-11 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1632 I thought it was: new features -> master, bug fixes -> oldest supported release branch? 4.7 is no longer supported but as far as I know 4.8 is still supported (I could be

[GitHub] cloudstack issue #1632: Honor the forced parameter for stopVirtualMachine ap...

2016-08-11 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1632 It goes all the way back to 4.7. Isn't the oldest supported release currently 4.8 at the moment? If so, it should be opened against 4.8, right? --- If your project is set up for it, you

[GitHub] cloudstack issue #1622: Adding missing bits field to TemplateResponse

2016-08-08 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1622 Rebased to latest master, though I still haven't checked into the Jenkins issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request #1618: Now returning os info with the list snapshot ...

2016-08-08 Thread ProjectMoon
GitHub user ProjectMoon reopened a pull request: https://github.com/apache/cloudstack/pull/1618 Now returning os info with the list snapshot response This commit adds the ID and display name of the OS on the volume. You can merge this pull request into a Git repository by running

[GitHub] cloudstack pull request #1617: Changed UsageEventUtils to UsageEventEmitter ...

2016-08-08 Thread ProjectMoon
GitHub user ProjectMoon reopened a pull request: https://github.com/apache/cloudstack/pull/1617 Changed UsageEventUtils to UsageEventEmitter and made it injectable An updated version of #1191, against the master branch. This also updates the HypervisorTemplateAdapter test slightly

[GitHub] cloudstack pull request #1618: Now returning os info with the list snapshot ...

2016-08-08 Thread ProjectMoon
Github user ProjectMoon closed the pull request at: https://github.com/apache/cloudstack/pull/1618 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack pull request #1617: Changed UsageEventUtils to UsageEventEmitter ...

2016-08-08 Thread ProjectMoon
Github user ProjectMoon closed the pull request at: https://github.com/apache/cloudstack/pull/1617 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1622: Adding missing bits field to TemplateResponse

2016-08-05 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1622 Will check it out on Monday. Very weird that the end of the build is not an error specifically. Just "ending due to build failure" or some such. The first excep

[GitHub] cloudstack pull request #1622: Adding missing bits field to TemplateResponse

2016-08-05 Thread ProjectMoon
GitHub user ProjectMoon reopened a pull request: https://github.com/apache/cloudstack/pull/1622 Adding missing bits field to TemplateResponse This pull request adds a bits field for template size, and sets it equal to ISO size. You can merge this pull request into a Git repository

[GitHub] cloudstack pull request #1622: Adding missing bits field to TemplateResponse

2016-08-05 Thread ProjectMoon
Github user ProjectMoon closed the pull request at: https://github.com/apache/cloudstack/pull/1622 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack pull request #1607: SSVM downloader now handles redirects properl...

2016-08-05 Thread ProjectMoon
GitHub user ProjectMoon reopened a pull request: https://github.com/apache/cloudstack/pull/1607 SSVM downloader now handles redirects properly. Previously it was using the HttpClient to make an initial request to an ISO. This would follow redirects. Then it would make another

[GitHub] cloudstack pull request #1607: SSVM downloader now handles redirects properl...

2016-08-05 Thread ProjectMoon
Github user ProjectMoon closed the pull request at: https://github.com/apache/cloudstack/pull/1607 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1622: Adding missing bits field to TemplateResponse

2016-08-05 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1622 Will check the smoke tests for Marvin. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1623: CLOUDSTACK-9317: Enable/disable static NAT associate...

2016-08-05 Thread ProjectMoon
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1623 JIRA ticket is CLOUDSTACK-9317. Have not run the Marvin tests, but will do so. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request #1623: CLOUDSTACK-9317: Enable/disable static NAT as...

2016-08-05 Thread ProjectMoon
Github user ProjectMoon commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1623#discussion_r73664374 --- Diff: server/src/com/cloud/network/IpAddressManagerImpl.java --- @@ -1698,6 +1698,22 @@ public String acquireGuestIpAddress(Network network

[GitHub] cloudstack pull request #1607: SSVM downloader now handles redirects properl...

2016-08-05 Thread ProjectMoon
GitHub user ProjectMoon reopened a pull request: https://github.com/apache/cloudstack/pull/1607 SSVM downloader now handles redirects properly. Previously it was using the HttpClient to make an initial request to an ISO. This would follow redirects. Then it would make another

[GitHub] cloudstack pull request #1607: SSVM downloader now handles redirects properl...

2016-08-05 Thread ProjectMoon
Github user ProjectMoon closed the pull request at: https://github.com/apache/cloudstack/pull/1607 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack pull request #1624: Fixes regarding VOLUME_DELETE events resultin...

2016-08-02 Thread ProjectMoon
GitHub user ProjectMoon opened a pull request: https://github.com/apache/cloudstack/pull/1624 Fixes regarding VOLUME_DELETE events resulting from account deletion New version of #1491. **Original Description** New version of #1373, but updated for the 4.7 branch

  1   2   3   >