[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...

2017-04-13 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1278 @rafaelweingartner Sorry for the late reply. But it seems you have misunderstood me here. I am not pointing finger here. I was just trying to point out that there may be developer concern

[GitHub] cloudstack pull request #1282: CLOUDSTACK-9200: Fixed failed to delete snaps...

2017-04-13 Thread anshul1886
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/1282 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...

2017-04-13 Thread anshul1886
GitHub user anshul1886 reopened a pull request: https://github.com/apache/cloudstack/pull/1867 CLOUDSTACK-9706: Added snapshots cleanup in start and storage GC thre… …ad if they are failed to cleanup during DeleteSnapshot command You can merge this pull request into a Git

[GitHub] cloudstack pull request #1282: CLOUDSTACK-9200: Fixed failed to delete snaps...

2017-04-13 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1282#discussion_r111531779 --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java --- @@ -245,6 +245,12 @@ public boolean

[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...

2017-04-13 Thread anshul1886
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/1867 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1941: CLOUDSTACK-8663: Fixed various issues to allow VM sn...

2017-04-13 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1941 @karuturi Raised #2043 to remove the test which is no longer needed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request #2043: CLOUDSTACK-9876: Removed test test_01_test_vm...

2017-04-13 Thread anshul1886
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/2043 CLOUDSTACK-9876: Removed test test_01_test_vm_volume_snapshot As we no longer have that restriction and now after fix for CLOUDSTACK-8663 we allow VM and volume snapshots to exist together

[GitHub] cloudstack pull request #1853: CLOUDSTACK-9696: Fixed Virtual Router deploym...

2017-03-19 Thread anshul1886
GitHub user anshul1886 reopened a pull request: https://github.com/apache/cloudstack/pull/1853 CLOUDSTACK-9696: Fixed Virtual Router deployment failing if there are… … no shared resources available and has access to resources through parent domain heirarachy You can

[GitHub] cloudstack pull request #1853: CLOUDSTACK-9696: Fixed Virtual Router deploym...

2017-03-19 Thread anshul1886
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/1853 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1867: CLOUDSTACK-9706: Added snapshots cleanup in start an...

2017-03-17 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1867 @koushik-das Failing tests doesn't seems to be related to this patch. Rebased against latest master to trigger the build. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack issue #1853: CLOUDSTACK-9696: Fixed Virtual Router deployment fai...

2017-03-17 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1853 @koushik-das Made the changes as per review comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request #1853: CLOUDSTACK-9696: Fixed Virtual Router deploym...

2017-03-17 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1853#discussion_r106632802 --- Diff: server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java --- @@ -584,105 +583,64 @@ private void checkForNonDedicatedResources

[GitHub] cloudstack pull request #1853: CLOUDSTACK-9696: Fixed Virtual Router deploym...

2017-03-17 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1853#discussion_r106632584 --- Diff: server/src/com/cloud/dc/dao/DedicatedResourceDaoImpl.java --- @@ -312,6 +317,65 @@ public DedicatedResourceVO findByHostId(Long hostId

[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...

2017-03-17 Thread anshul1886
GitHub user anshul1886 reopened a pull request: https://github.com/apache/cloudstack/pull/1867 CLOUDSTACK-9706: Added snapshots cleanup in start and storage GC thre… …ad if they are failed to cleanup during DeleteSnapshot command You can merge this pull request into a Git

[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...

2017-03-17 Thread anshul1886
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/1867 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1867: CLOUDSTACK-9706: Added snapshots cleanup in start an...

2017-03-16 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1867 @koushik-das Made the changes as per review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...

2017-03-16 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1867#discussion_r106388631 --- Diff: server/src/com/cloud/storage/StorageManagerImpl.java --- @@ -1078,6 +1082,16 @@ public void cleanupStorage(boolean recurring

[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...

2017-03-16 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1867#discussion_r106387626 --- Diff: server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java --- @@ -1181,6 +1181,17 @@ public boolean configure(String name, Map<Str

[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...

2017-03-16 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1867#discussion_r106387348 --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/SnapshotObject.java --- @@ -191,7 +191,8 @@ public void processEvent

[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...

2017-03-16 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1867#discussion_r106386503 --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java --- @@ -194,18 +194,22 @@ protected

[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...

2017-03-16 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1867#discussion_r106385035 --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/SnapshotObject.java --- @@ -191,7 +191,8 @@ public void processEvent

[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...

2017-03-16 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1867#discussion_r106384378 --- Diff: server/src/com/cloud/storage/StorageManagerImpl.java --- @@ -1078,6 +1082,16 @@ public void cleanupStorage(boolean recurring

[GitHub] cloudstack pull request #1853: CLOUDSTACK-9696: Fixed Virtual Router deploym...

2017-03-16 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1853#discussion_r106381321 --- Diff: server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java --- @@ -584,105 +583,64 @@ private void checkForNonDedicatedResources

[GitHub] cloudstack pull request #1853: CLOUDSTACK-9696: Fixed Virtual Router deploym...

2017-03-16 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1853#discussion_r106380082 --- Diff: server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java --- @@ -584,105 +583,64 @@ private void checkForNonDedicatedResources

[GitHub] cloudstack pull request #1853: CLOUDSTACK-9696: Fixed Virtual Router deploym...

2017-03-16 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1853#discussion_r106378310 --- Diff: server/src/com/cloud/dc/dao/DedicatedResourceDaoImpl.java --- @@ -312,6 +317,65 @@ public DedicatedResourceVO findByHostId(Long hostId

[GitHub] cloudstack issue #1269: CLOUDSTACK-8867: Added retry logic to reconnect to h...

2017-03-16 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1269 @GabrielBrascher The other method is there for legacy purposes and is no longer get used in Cloudstack. This was getting used in 2.x versions for UI. Some third party tool might be using

[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...

2017-03-14 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1278 @rafaelweingartner stop start destroy etc all methods related to virtual router code have these parameters? Questions there is why are they not removed in the first place when

[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...

2017-03-14 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1278 @nvazquez @rafaelweingartner @GabrielBrascher, That method is called from multiple places. There are many places where we can do these kind of changes. I would prefer to have those kind

[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier

2017-03-10 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/669 @DaanHoogland @rafaelweingartner Will have a look at the proposed changes and get back to you. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request #868: CLOUDSTACK-8894: Restrict vGPU enabled VMs dyn...

2017-03-09 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/868#discussion_r105116946 --- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java --- @@ -1535,6 +1535,19 @@ private boolean upgradeRunningVirtualMachine(Long vmId, Long

[GitHub] cloudstack issue #1269: CLOUDSTACK-8867: Added retry logic to reconnect to h...

2017-03-09 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1269 @GabrielBrascher @alexandrelimassantana I kept it that way for readability as console proxy code is hard to debug. --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack issue #1282: CLOUDSTACK-9200: Fixed failed to delete snapshot if ...

2017-03-09 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1282 @swill Added the return true statement. @rhtyd Snapshot in Allocated state means nothing is done for that snapshot so only deletion from DB is needed. --- If your project is set up

[GitHub] cloudstack issue #1868: CLOUDSTACK-9707: While using hostid parameter, vm ge...

2017-03-09 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1868 @ustcweizhou I think default value should be false. As it tells the user to make informed decision instead of misleading according to original purpose of parameter. @sateesh-chodapuneedi

[GitHub] cloudstack issue #1868: CLOUDSTACK-9707: While using hostid parameter, vm ge...

2017-03-08 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1868 @ustcweizhou Added the global setting allow.deploy.vm.if.deploy.on.given.host.fails to control the behaviour. --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack issue #793: CLOUDSTACK-8827: Move the VM snapshots stuck in trans...

2017-03-08 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/793 @koushik-das @sateesh-chodapuneedi @ramkatru @karuturi @rhtyd Regarding unit tests, I can't see any useful tests can be written here which I have already specified the reason for. Also we

[GitHub] cloudstack issue #793: CLOUDSTACK-8827: Move the VM snapshots stuck in trans...

2017-03-08 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/793 @rhtyd Rebased the branch to latest master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #793: CLOUDSTACK-8827: Move the VM snapshots stuck in trans...

2017-03-08 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/793 @serg38 That case is already handled. Issue arises if management server goes down then we didn't get chance to clean things up. --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request #793: CLOUDSTACK-8827: Move the VM snapshots stuck i...

2017-03-08 Thread anshul1886
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/793 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack pull request #793: CLOUDSTACK-8827: Move the VM snapshots stuck i...

2017-03-08 Thread anshul1886
GitHub user anshul1886 reopened a pull request: https://github.com/apache/cloudstack/pull/793 CLOUDSTACK-8827: Move the VM snapshots stuck in transitional states to stable states during managment server restart i.e. If snapshot in creating state move it to Error state

[GitHub] cloudstack pull request #669: Made the adding new keyboard language support ...

2017-03-07 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r104846603 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java --- @@ -0,0 +1,59

[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...

2017-03-07 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1278 @rafaelweingartner, Yes we can agree on those changes. But with additional description when the CallContext.current().getCallingAccount() call is made then it is setting the proper context

[GitHub] cloudstack issue #1868: CLOUDSTACK-9707: While using hostid parameter, vm ge...

2017-03-07 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1868 @ustcweizhou, Is it looking good to you now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request #803: CLOUDSTACK-8833: Fixed Generating url and migr...

2017-03-07 Thread anshul1886
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/803 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack pull request #803: CLOUDSTACK-8833: Fixed Generating url and migr...

2017-03-07 Thread anshul1886
GitHub user anshul1886 reopened a pull request: https://github.com/apache/cloudstack/pull/803 CLOUDSTACK-8833: Fixed Generating url and migrate volume to another storage , resulting two entry in UI and listvolume is not working for that volume Update the volume id

[GitHub] cloudstack pull request #868: CLOUDSTACK-8894: Restrict vGPU enabled VMs dyn...

2017-03-07 Thread anshul1886
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/868 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack pull request #868: CLOUDSTACK-8894: Restrict vGPU enabled VMs dyn...

2017-03-07 Thread anshul1886
GitHub user anshul1886 reopened a pull request: https://github.com/apache/cloudstack/pull/868 CLOUDSTACK-8894: Restrict vGPU enabled VMs dynamic scaling if new service offering has different vGPU type It fixes the bug https://issues.apache.org/jira/browse/CLOUDSTACK-8894

[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...

2017-03-06 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1278 @rafaelweingartner, Basically CallContext.current().getCallingAccount(); is setting the proper context which is later used. If you have observed in code all the api calls have a similar call

[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...

2017-03-05 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1278 @GabrielBrascher @rafaelweingartner, Please go through deployment planner code. Deployment planner decides the VM placement and virtual router also goes through that. Deployment planners

[GitHub] cloudstack pull request #1845: CLOUDSTACK-9689: [Hyper-V] Fixed VM console i...

2017-03-05 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1845#discussion_r104339191 --- Diff: services/console-proxy-rdp/rdpconsole/src/main/java/streamer/apr/AprSocketSource.java --- @@ -103,44 +103,46 @@ public void poll(boolean

[GitHub] cloudstack pull request #1269: CLOUDSTACK-8867: Added retry logic to reconne...

2017-03-05 Thread anshul1886
GitHub user anshul1886 reopened a pull request: https://github.com/apache/cloudstack/pull/1269 CLOUDSTACK-8867: Added retry logic to reconnect to host on connection termination to console It also improves handling of sessions to hypervisor in console proxy https

[GitHub] cloudstack pull request #1269: CLOUDSTACK-8867: Added retry logic to reconne...

2017-03-05 Thread anshul1886
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/1269 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1868: CLOUDSTACK-9707: While using hostid parameter, vm ge...

2017-03-02 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1868 @ustcweizhou, Actually I am restoring to old behaviour of 3.x release which got changed to current behaviour because of bug. --- If your project is set up for it, you can reply

[GitHub] cloudstack issue #1865: CLOUDSTACK-9705: Unauthenticated API allows Admin pa...

2017-03-02 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1865 @koushik-das, This method is there so that it only gets called when the call is made through 8096 port. Other parameters processing is done at common place. --- If your project is set up

[GitHub] cloudstack issue #1868: CLOUDSTACK-9707: While using hostid parameter, vm ge...

2017-03-02 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1868 @ustcweizhou, In my opinion we should not do that as that way we are giving them option of silently deploying VM on some host which he might not be aware of. As after specifying host he

[GitHub] cloudstack pull request #1278: CLOUDSTACK-9198: Virtual router gets deployed...

2017-03-01 Thread anshul1886
GitHub user anshul1886 reopened a pull request: https://github.com/apache/cloudstack/pull/1278 CLOUDSTACK-9198: Virtual router gets deployed in disabled Pod While starting the router, send the user from the callingContext instead of defaulting to System user. https

[GitHub] cloudstack pull request #1278: CLOUDSTACK-9198: Virtual router gets deployed...

2017-03-01 Thread anshul1886
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/1278 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...

2017-03-01 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1278 @abhinandanprateek @koushik-das That change is intentional to allow admin users to deploy VM on disabled. Ticket which shows that it is intentional https://issues.apache.org/jira/browse

[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...

2017-03-01 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1278 @abhinandanprateek #1860 should take care of last host id scenario. Other case of user specifying host, should we not allow deploying VM in disabled Pod? That's a separate issue by the way

[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...

2017-02-28 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1278 @abhinandanprateek, Yes they are using same deployment planner. But VR was getting created in disabled Pod but not regular VM because for VR deployment system user context was getting set

[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...

2017-02-28 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1278 @abhinandanprateek, That's the behaviour we disallow VM to be deployed in disabled Pod. But Virtual router was getting deployed as it was getting called through system user for which we

[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...

2017-02-28 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1278 @rhtyd , Rebased against laster master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1269: CLOUDSTACK-8867: Added retry logic to reconnect to h...

2017-02-28 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1269 @rhtyd , Rebased against latest master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #868: CLOUDSTACK-8894: Restrict vGPU enabled VMs dynamic sc...

2017-02-28 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/868 @rhtyd, Rebased against latest master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #803: CLOUDSTACK-8833: Fixed Generating url and migrate vol...

2017-02-28 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/803 @rhtyd Rebased against latest master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1977: fixed the merge conflict on merging #1941

2017-02-27 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1977 LGTM. This change occurs due to code around that are gets diverged in master and 4.9 with merge of PR #1727. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier

2017-02-27 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/669 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier

2017-02-26 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/669 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier

2017-02-23 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/669 @karuturi, We can merge this now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1941: CLOUDSTACK-8663: Fixed various issues to allow VM sn...

2017-02-23 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1941 @GabrielBrascher, Those tests failure are not related to this PR and seems to be failing most of the time and reported as intermittent failures. @rhtyd @karuturi @serg38, We have already

[GitHub] cloudstack issue #1941: CLOUDSTACK-8663: Fixed various issues to allow VM sn...

2017-02-23 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1941 @koushik-das, That PR is still not merged. @karuturi @rhtyd This PR has LGTM now. Can we merge it? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request #803: CLOUDSTACK-8833: Fixed Generating url and migr...

2017-02-22 Thread anshul1886
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/803 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack pull request #803: CLOUDSTACK-8833: Fixed Generating url and migr...

2017-02-22 Thread anshul1886
GitHub user anshul1886 reopened a pull request: https://github.com/apache/cloudstack/pull/803 CLOUDSTACK-8833: Fixed Generating url and migrate volume to another storage , resulting two entry in UI and listvolume is not working for that volume Update the volume id

[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier

2017-02-22 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/669 @sureshanaparti, Can you have a look at this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...

2017-02-22 Thread anshul1886
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/1867 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...

2017-02-22 Thread anshul1886
GitHub user anshul1886 reopened a pull request: https://github.com/apache/cloudstack/pull/1867 CLOUDSTACK-9706: Added snapshots cleanup in start and storage GC thre… …ad if they are failed to cleanup during DeleteSnapshot command You can merge this pull request into a Git

[GitHub] cloudstack pull request #672: Allow VM snapshots and volume snapshots to exi...

2017-02-22 Thread anshul1886
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/672 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier

2017-02-21 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/669 Added the missing license on one js file. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1900: CLOUDSTACK-8862: Introduced new state attaching for ...

2017-02-20 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1900 @karuturi @koushik-das @sateesh-chodapuneedi , I had analysed those failures and working on how to go about those. Issue here is that there are marvin tests which are for something which

[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...

2017-02-19 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1847 @karuturi, Done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...

2017-02-19 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1847 Ok, Doing that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...

2017-02-19 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1847 @karuturi Test failing is unrelated to this PR. === TestName: test_add_user_to_project | Status : EXCEPTION === === TestName: test_add_user_to_project | Status : EXCEPTION

[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...

2017-02-16 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1847 @karuturi @nvazquez , Added the marvin test from #1735. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...

2017-02-16 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1847 @nvazquez, Yeah I am fine with it. I will add the test from your PR to mine PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack issue #1941: CLOUDSTACK-8663: Fixed various issues to allow VM sn...

2017-02-15 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1941 @rhtyd That test is failing during cleanup to delete the template but there is no such change in PR which will come into picture while deletion of template. --- If your project is set up

[GitHub] cloudstack issue #1900: CLOUDSTACK-8862: Introduced new state attaching for ...

2017-02-15 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1900 Rebased with current master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request #669: Made the adding new keyboard language support ...

2017-02-15 Thread anshul1886
GitHub user anshul1886 reopened a pull request: https://github.com/apache/cloudstack/pull/669 Made the adding new keyboard language support easier https://issues.apache.org/jira/browse/CLOUDSTACK-8665 This branch has implemented following improvements in console proxy

[GitHub] cloudstack pull request #669: Made the adding new keyboard language support ...

2017-02-15 Thread anshul1886
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/669 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...

2017-02-15 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1847 @nvazquez What would you like to do? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...

2017-02-15 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1813#discussion_r101232184 --- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java --- @@ -3520,27 +3520,17 @@ public UserVmVO doInTransaction(TransactionStatus status

[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...

2017-02-15 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1813#discussion_r101231917 --- Diff: plugins/hypervisors/xenserver/test/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixRequestWrapperTest.java --- @@ -436,7

[GitHub] cloudstack issue #672: Allow VM snapshots and volume snapshots to exist toge...

2017-02-14 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/672 @rhtyd @karuturi Should I close this PR then? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #672: Allow VM snapshots and volume snapshots to exist toge...

2017-02-14 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/672 @rhtyd @karuturi @syed Raised #1941 against 4.9. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request #1941: CLOUDSTACK-8663: Fixed various issues to allo...

2017-02-14 Thread anshul1886
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/1941 CLOUDSTACK-8663: Fixed various issues to allow VM snapshots and volume snapshots to exist together Reverting VM to disk only snapshot in Xenserver corrupts VM Stale NFS

[GitHub] cloudstack issue #672: Allow VM snapshots and volume snapshots to exist toge...

2017-02-14 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/672 Resolving conflicts and rebasing the PR against 4.9 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack issue #672: Allow VM snapshots and volume snapshots to exist toge...

2017-02-14 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/672 @karuturi @rhtyd @syed PR #1829 is subset of this PR i.e. that contains the same fix as one commit of this PR. How to proceed with that? --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request #669: Made the adding new keyboard language support ...

2017-02-13 Thread anshul1886
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/669 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack pull request #669: Made the adding new keyboard language support ...

2017-02-13 Thread anshul1886
GitHub user anshul1886 reopened a pull request: https://github.com/apache/cloudstack/pull/669 Made the adding new keyboard language support easier https://issues.apache.org/jira/browse/CLOUDSTACK-8665 This branch has implemented following improvements in console proxy

[GitHub] cloudstack pull request #1900: CLOUDSTACK-8862: Introduced new state attachi...

2017-02-08 Thread anshul1886
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/1900 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack pull request #1900: CLOUDSTACK-8862: Introduced new state attachi...

2017-02-08 Thread anshul1886
GitHub user anshul1886 reopened a pull request: https://github.com/apache/cloudstack/pull/1900 CLOUDSTACK-8862: Introduced new state attaching for volume. This will… … make sure that other attach operation on same volume will fail gracefully without calling access calls

[GitHub] cloudstack pull request #1900: CLOUDSTACK-8862: Introduced new state attachi...

2017-02-07 Thread anshul1886
GitHub user anshul1886 reopened a pull request: https://github.com/apache/cloudstack/pull/1900 CLOUDSTACK-8862: Introduced new state attaching for volume. This will… … make sure that other attach operation on same volume will fail gracefully without calling access calls

  1   2   3   4   >