Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1955
@karuturi 3 x LGTM, testing successful. Ready for Merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1955
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1941
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1907
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1948
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1948
LGTM from borisstoyanov in a commit comment (acspr)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/351
tag:needslove
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/669
tag:needslove
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1885
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1946
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1956
LGTM by Rafael in commit review above (for acspr).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1915
We pulled this in and tested it alongside
https://github.com/apache/cloudstack/pull/1954
---
If your project is set up for it, you can reply to this email and have
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1858
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/977
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/977
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/977
@ustcweizhou If you rebase it, I'll get it tested. The last time I tested
this PR, it was looking really good. The only thing it needed was some
restriction so that it returned an error
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1606
I've added issue Jira CLOUDSTACK-9661 to track this.
https://issues.apache.org/jira/browse/CLOUDSTACK-9661
@leprechau @rhtyd
---
If your project is set up for it, you can
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1741
@jayapalu Can you expand on your findings regarding public ip order? Did
you pull in the latest PR with the fixes from @swill?
---
If your project is set up for it, you can reply
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1644
@jburwell We found an issue on Friday related to a use case related to
snapshot to template. We're working on it. More soon.
---
If your project is set up for it, you can reply to this email
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1645
@karuturi - So, note that this feature addition only affects KVM when
using RBD as the back-end storage.
---
If your project is set up for it, you can reply to this email and have your
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/872
Yeah, I think this one is dead unless it gets reworked into a new PR. We
might be able to help a bit on this one as well.
---
If your project is set up for it, you can reply to this email
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1645
I took a look at the code last night and it seems that we're no longer
specifying the source format when calling qemu-img convert. We're relying on
qemu-img's auto detection of source format
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1644
Pure RBD based revert is not supported today (plus it's really slow). The
way we do it is we snap to volume (clone), shut the vm down, then detach the
old disk and reattach the new disk
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1635
I'll let him comment on this, but If I recall, it had more to do with
implementation of force stopping with KVM rather than the lack of the parameter
being passing into the VM Manager
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1635
@ProjectMoon Jeff, could you help review this, as I believe you were the
first to point it out on the list.
From talking to Nathan, it sounds like we're not sure KVM is actually
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1645
Yeah, there seems to be some black magic going on here. We'll dig into this
a bit more.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1645
For reference, here are the DB entries:
---
If your project is set up for it, you can reply to this email
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1606
---
If your project is set up for it, you can reply to this email
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1606
---
If your project is set up for it, you can reply to this email
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1606
---
If your project is set up for it, you can reply to this email
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1606
---
If your project is set up for it, you can reply
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1606
---
If your project is set up for it, you can reply to this email
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1606
---
If your project is set up for it, you can reply to this email
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1606
---
If your project is set up for it, you can reply to this email
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1513#issuecomment-219874035
@swill Sure you haven't got some artifacts left behind from some other
testing? This is only a libvirt hook, so I can't imagine how the tests failing
above could
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1482#issuecomment-219555051
LGTM above from @DaanHoogland as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1482#issuecomment-219554704
I've done some basic testing of this patch adding and deleting ACLs and
rules within ACLs within VPCs.
LGTM
---
If your project is set up for it, you can
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-219137807
LGTM based on the manual testing above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-219137482
Kill the Master VR:
---
If your project
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-219137269
Add a new ACL, add a rule to it and apply it to a Tier:
---
If your project is set up for it, you can reply to this email
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1482#issuecomment-218835105
@remibergsma I'm porting this patch set into our 4.8 QA branch currently. I
noticed 709be45 is in here as well (force encap). Can you pull that out of this
set
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1482#issuecomment-218802890
@swill We'll pull this in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-218776521
@rhtyd With the agent in trace mode, I see this scrolling through very
rapidly:
2016-05-12 09:36:01,707 TRACE [utils.nio.NioConnection]
(pool-1-thread-1
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-218763389
@rhtyd I'll work on pulling some trace logs and a debugger on the agent if
the trace logs don't show anything.
For reference, These patches were on our QA
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-218611825
LGTM. Tested in hardware lab and works as designed.
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1474#issuecomment-218607576
LGTM. Tested in a hardware lab.
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1472#issuecomment-218607629
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1472#issuecomment-218592243
LGTM. Tested in a hardware lab.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-218473922
---
If your project is set up for it, you can
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-218473890
@rhtyd We're still seeing some odd behaviour related to the agent with this
PR (and PR1534) applied to 2 of our hardware labs. What we're seeing is 100%
cpu
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-218446038
Remi,
I'm seeing some issues with this PR, related to the way the VR scripts
utilize the argv file name for other uses. We spent a fair bit of time
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1519#issuecomment-217290619
Has anyone tested this with VPC VRs as of yet?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1472#issuecomment-217289669
We'll be pulling this one in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1513#issuecomment-216709951
Tested this in a hardware 4.8 lab: I was able to migrate VXLAN enabled VMs
between hosts as expected.
LGTM
---
If your project is set up for it, you
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1413#issuecomment-216517829
Well, the open version of it - PR 1483
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1413#issuecomment-216517631
I'm about to start testing this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1485#issuecomment-216516629
@swill This has 2 x LGTM. Simple change and probably doesn't require any
additional CI IMO.
This is Ready to Merge
---
If your project is set up for it, you
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1463#issuecomment-216508518
@swill 4 x LGTM + CI from Daan.
This is Ready to Merge
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1410#issuecomment-216507445
@ustcweizhou Could you rebase this to resolve the conflicts? I'll pull this
in for testing once you've had a chance to do that. Thanks!
---
If your project
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-216375175
I pulled this into a hardware lab on 4.8.1. I setup a number of fake
clients and hammered 8250. Prior to the patch the agents end up in a
disconnected state
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-216296997
@swill I'm a bit behind. I'm building this now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1524#issuecomment-215986875
Strangely enough, I just ran into this problem yesterday.I'll pull it in.
Thanks Remi!
---
If your project is set up for it, you can reply to this email
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1412#issuecomment-215874307
@ProjectMoon Can you open a new PR against 4.7 with this? We're really
only supporting 4.7.x onward.
Trivial packing change. LTGM
---
If your
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1473#issuecomment-215873345
This is a trivial config change for a smoke test. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1330#issuecomment-215872240
Team,
Where are we currently on this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1428#issuecomment-215860378
Interesting. I'll go digging into the code. I'm not that familiar with the
console proxy (yet).
---
If your project is set up for it, you can reply
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1428#issuecomment-215856646
@Slair1 Are you failing a ACS management server in addition to the MySQL
instance?
If so, make sure your Load Balancer is also moving the traffic
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1428#issuecomment-215840702
@Slair1 @dmabry @remibergsma
Could I get some review on this when you get a chance? I'd like to get this
PR moving.
---
If your project is set up
1 - 100 of 167 matches
Mail list logo
