GitHub user krissterckx opened a pull request:
https://github.com/apache/cloudstack-docs/pull/19
Updating The Nuage VSP Plugin Documentation for ACS 4.10 release
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/krissterckx
Github user krissterckx commented on the issue:
https://github.com/apache/cloudstack/pull/1912
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user krissterckx commented on the issue:
https://github.com/apache/cloudstack/pull/1904
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user krissterckx commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@rhtyd can we merge in ? Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user krissterckx commented on the issue:
https://github.com/apache/cloudstack/pull/1579
Volumes test (test_create_volume_under_domain) is only failure ; unrelated
to this PR
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply
Github user krissterckx commented on the issue:
https://github.com/apache/cloudstack/pull/1579
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user krissterckx commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@rhtyd Travis is happy
findbugs fails at globodns though (not due to this PR)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user krissterckx commented on the issue:
https://github.com/apache/cloudstack/pull/1579
Thanks @rhtyd , I resubmitted
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user krissterckx commented on the issue:
https://github.com/apache/cloudstack/pull/1579
Hi @rhtyd
as #1806 got merged, can a travis re-run be initiated ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user krissterckx commented on the issue:
https://github.com/apache/cloudstack/pull/1578
Thanks @karuturi
Kris
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user krissterckx commented on the issue:
https://github.com/apache/cloudstack/pull/1578
@jburwell @rhtyd
I would appreciate your feedback.
This PR is pending from early June, and we have more PR's pending.
Thanks,
Cheers
Kris Sterckx
Github user krissterckx commented on the issue:
https://github.com/apache/cloudstack/pull/1578
Hi @jburwell appreciating your view based on the comments addressed.
Thanks
Kris
---
If your project is set up for it, you can reply to this email and have your
reply
Github user krissterckx commented on the issue:
https://github.com/apache/cloudstack/pull/1578
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user krissterckx commented on the issue:
https://github.com/apache/cloudstack/pull/1578
LGTM
Code is good, tests are good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user KrisSterckx commented on the issue:
https://github.com/apache/cloudstack/pull/1585
@swill, you prefer i close and reopen? Thx
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-221666486
Thanks @swill and all involved !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-221394563
Thanks all folks, that gives the needed LGTM votes!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-221087524
@rhtyd, @koushik-das, @remibergsma, @abhinandanprateek, @rafaelweingartner
anyone wants to further review ? We would like votes :)
Thanks
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-221023752
Travis CI failure : Is it a known issue ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack/pull/1553#issuecomment-221024596
@DaanHoogland moreover it is proven in Nuage lab to resolve the issues we
had
---
If your project is set up for it, you can reply to this email and have your
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-220667799
Thanks @swill. Folks, pls review :)
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-220576106
Yes, correct, and thanks @DaanHoogland.
Could you initiate for more reviews; or anything i can do?
Thx
---
If your project is set up
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-220394412
Hi @DaanHoogland
The architecture is
`cloudstack ---cmp--> nuage-vsp-acs-client ---cfg-->
Nuage VSP pl
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-220326489
@DaanHoogland to your question :
We are embarking full CloudStack build automation as that gives us
cloudstack-nuagevsp-plugin <> nuagevsp-clie
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-210464551
Hi @DaanHoogland is this PR still in the candidate list of 4.9.0 ?
If there is anything that I & the team can facilitate in doing, pls let me
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack-docs/pull/14#issuecomment-168966438
@terbolous OK thanks - is that something you will take up ? Thanks
---
If your project is set up for it, you can reply to this email and have your
reply
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack-docs/pull/14#issuecomment-168938400
Thanks @nlivens and @runseb !
Additional question i have : How does this end up now at
http://docs.cloudstack.apache.org/en/latest/ ?
thanks
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack-docs/pull/14#issuecomment-168614046
Hi all, @runseb
what should do I to get attention to this PR ?
Happy New Year, all !
Kris
---
If your project is set up for it, you can
GitHub user KrisSterckx opened a pull request:
https://github.com/apache/cloudstack-docs/pull/14
Inclusion of Nuage-VSP plugin
Documentation for the 4.7.0 Nuage-VSP plugin
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-157825620
Thanks @remibergsma and all reviewers - This is great. This is a great
add to CloudStack and a great milestone for Nuage Networks. CloudStack + SDN
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-153367941
@jburwell @remibergsma Pls note all again that the changes to core are
very minimal and are limited to convenience extensions only. I would expect
running
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-153373302
@jburwell we have added unit testing and Marvin tests, and we posted the
results of Marvin in the Jira ticket, but in order to run the Marvin tests you
need
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-153036347
Hi
@jburwell can you pls approve if the PR looks good to you now ?
@remibergsma, can you pls suggest how we can continue ? Thanks
Kris
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-152114217
@jburwell thanks for intensive review. How does it look like? :) thanks
---
If your project is set up for it, you can reply to this email and have your
reply
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-150258402
@remibergsma how can we continue pls ? Could you run Travis again ? Can we
do anything ? Thanks
---
If your project is set up for it, you can reply
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-149321626
@jburwell do you approve the PR ? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-148123443
@remibergsma @jburwell thanks for all help and detailed review. Most
comments have been addressed. Could we set for the remaining ones to take in
next release
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-147174211
Hi @remibergsma , The rebase is committed. Thanks.
(The cloudstack-pull-requests jenkins project is disabled though?)
---
If your project is set up
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-147179219
@remibergsma OK done now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-145488778
I would like to bring attention to the reviewers that only a few CS core
extensions were made - all other modifications are NuageVsp plugin internal,
for Nuage
40 matches
Mail list logo
