[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-09-16 Thread nnesic
Github user nnesic commented on the issue: https://github.com/apache/cloudstack/pull/1624 @blueorangutan kick --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack pull request #1624: Fixes regarding VOLUME_DELETE events resultin...

2016-09-12 Thread nnesic
Github user nnesic commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1624#discussion_r78407479 --- Diff: server/src/com/cloud/user/AccountManagerImpl.java --- @@ -761,6 +774,17 @@ protected boolean cleanupAccount(AccountVO account, long

[GitHub] cloudstack pull request #1589: Fixing erraneous guest_os_hypervisor mappings

2016-06-10 Thread nnesic
GitHub user nnesic opened a pull request: https://github.com/apache/cloudstack/pull/1589 Fixing erraneous guest_os_hypervisor mappings We noticed some discrepancies in the guest_os_hypervisor mappings, specifically Other PV being mapped to CentOS on Xenserver, Ubuntu 10.04

[GitHub] cloudstack pull request: [CLOUDSTACK-9003] Resource Naming Policie...

2016-04-26 Thread nnesic
Github user nnesic commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1492#discussion_r61122746 --- Diff: api/src/com/cloud/naming/ResourceNamingPolicyManager.java --- @@ -0,0 +1,32 @@ +// Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request: Fixes regarding VOLUME_DELETE events resu...

2016-04-14 Thread nnesic
Github user nnesic commented on the pull request: https://github.com/apache/cloudstack/pull/1491#issuecomment-209922376 @koushik-das We are mostly working with 4.7 version, where other volume usage events get emitted correctly. We haven't investigated the behavior on master yet

[GitHub] cloudstack pull request: Fixes regarding VOLUME_DELETE events resu...

2016-04-14 Thread nnesic
Github user nnesic commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1491#discussion_r59707938 --- Diff: server/src/com/cloud/user/AccountManagerImpl.java --- @@ -761,6 +774,17 @@ protected boolean cleanupAccount(AccountVO account, long

[GitHub] cloudstack pull request: Changed UsageEventUtils to UsageEventEmit...

2016-04-13 Thread nnesic
Github user nnesic closed the pull request at: https://github.com/apache/cloudstack/pull/1191 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: Usage event fixes for deleted accounts

2016-02-18 Thread nnesic
Github user nnesic closed the pull request at: https://github.com/apache/cloudstack/pull/924 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: Changed UsageEventUtils to UsageEventEmit...

2015-12-08 Thread nnesic
GitHub user nnesic opened a pull request: https://github.com/apache/cloudstack/pull/1191 Changed UsageEventUtils to UsageEventEmitter and made it injectable Refactored code to make the UsageEventEmitter injectable. Fixed unit tests where required, but otherwise no changes

[GitHub] cloudstack pull request: Usage event fixes for deleted accounts

2015-11-19 Thread nnesic
Github user nnesic commented on the pull request: https://github.com/apache/cloudstack/pull/924#issuecomment-158052503 Hello, how is the review on this going? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: Shuffling the password to avoid having a ...

2015-11-10 Thread nnesic
GitHub user nnesic opened a pull request: https://github.com/apache/cloudstack/pull/1058 Shuffling the password to avoid having a subset of characters in fixed positions. Related to CLOUDSTACK-9052. I am shuffling the characters in the password, to avoid having a certain

[GitHub] cloudstack pull request: Fixed user_vm_view to only display keypai...

2015-10-29 Thread nnesic
GitHub user nnesic opened a pull request: https://github.com/apache/cloudstack/pull/1006 Fixed user_vm_view to only display keypairs belonging to the account. The user_vm_view displayes the keypair information by joining vm_details with ssh_keypairs on the key value exclusively

[GitHub] cloudstack pull request: Usage event fixes for deleted accounts

2015-10-14 Thread nnesic
Github user nnesic commented on the pull request: https://github.com/apache/cloudstack/pull/924#issuecomment-148138708 I added two unit tests to check that the account manager adheres to its new responsibility of emitting the usage events for root volumes of instances which were

[GitHub] cloudstack pull request: Usage event fixes for deleted accounts

2015-10-12 Thread nnesic
GitHub user nnesic opened a pull request: https://github.com/apache/cloudstack/pull/924 Usage event fixes for deleted accounts Fixes regarding usage event emission. UsageEventUtils was previously not checking deleted accounts, which meant that if an account was deleted

[GitHub] cloudstack pull request: Usage event fixes for deleted accounts

2015-10-12 Thread nnesic
Github user nnesic commented on the pull request: https://github.com/apache/cloudstack/pull/924#issuecomment-147469015 Hi, could you please re-trigger the build, since it seems to have crashed? --- If your project is set up for it, you can reply to this email and have your reply