Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1935
@rafaelweingartner thanks for reviewing again! Minor refactor pushed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1935#discussion_r110421451
--- Diff: server/test/com/cloud/user/DomainManagerImplTest.java ---
@@ -134,4 +164,69 @@ public void testFindDomainByIdOrPathValidId
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1935#discussion_r110421376
--- Diff: server/src/com/cloud/user/DomainManagerImpl.java ---
@@ -273,82 +284,145 @@ public boolean deleteDomain(long domainId, Boolean
cleanup
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1879
Thanks @sureshanaparti! I tested scenarios and work as expected!
I attach some screenshots:
- Test scenario 1: Enable HA after VR created, stop VR, start VR.
![vr1](https
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1944
Please ommit my last comment, we were using commons-beanutils version 1.8.3
instead of 1.9.2
LGTM
[root@ussarlabcsmgt41 cloudstack]# cat /tmp//MarvinLogs//DVIXST
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1918
LGTM for testing. Tested on Vmware 6.0, I attach some screenshots for test
scenarios, in which vm was deployed using service offering, infinite loop was
executed to increase CPU utilization
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1935
@borisstoyanov I've rebased master branch, can we re-run tests on this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1944
Hi @rhtyd, thanks for this great improvement! Along with @serg38 we've been
testing in our env and got some failures on `listHostsMetrics` and
`listVolumeMetrics
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/2021
@karuturi sure, done! I rebased master and pushed, now Travis passes!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/2019
LGTM, travis failure is not related to this PR, it is fixed in #2021
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/2021
Thanks @borisstoyanov, I made little refactor due to failure, can you
please re kick tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user nvazquez opened a pull request:
https://github.com/apache/cloudstack/pull/2021
CLOUDSTACK-9854: Fix test_primary_storage test failure due to live migration
Fix for test_primary_storage integration tests on simulator.
When finding storage pool migration options
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1994
@karuturi Travis is now failing as it doesn't find key "nfs2"
2017-03-24 17:33:45,621 - CRITICAL - EXCEPTION:
test_03_migration_options_storage_tags: ['Traceback (most r
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1994
@karuturi I refactored last marvin test which was failing on Travis. These
are results in our env:
[root@ussarlabcsmgt41 cloudstack]# cat /tmp//MarvinLogs//4GSNSY/results.txt
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1994
Thanks @mike-tutkowski! I pushed force to kick off Travis again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1994
Thanks @serg38, we are using `mgtSvr` details provided in .cfg file, should
we use these for Marvin too?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1994
@karuturi I added marvin tests to simulate tests performed by
@mike-tutkowski.
This are results in our env:
[root@ussarlabcsmgt41 cloudstack]# cat /tmp//MarvinLogs//011CTF
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1994#discussion_r106724343
--- Diff:
engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java ---
@@ -77,4 +92,71 @@ public void deleteTags(long poolId
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1994
Hi @karuturi, I've been working on marvin tests, I hope posting them today
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1994#discussion_r106311985
--- Diff:
engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java ---
@@ -77,4 +92,71 @@ public void deleteTags(long poolId
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1994#discussion_r106303439
--- Diff:
engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java ---
@@ -77,4 +92,71 @@ public void deleteTags(long poolId
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1994#discussion_r106002237
--- Diff:
engine/schema/test/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImplTest.java
---
@@ -0,0 +1,151 @@
+// Licensed
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1994#discussion_r105998903
--- Diff:
engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java ---
@@ -77,4 +92,71 @@ public void deleteTags(long poolId
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1994#discussion_r105992671
--- Diff:
engine/schema/test/com/cloud/storage/dao/StoragePoolTagsDaoImplTest.java ---
@@ -0,0 +1,105 @@
+// Licensed to the Apache Software
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1994#discussion_r105990460
--- Diff:
engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java ---
@@ -77,4 +90,68 @@ public void deleteTags(long poolId
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1994#discussion_r105989477
--- Diff:
engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java ---
@@ -77,4 +90,68 @@ public void deleteTags(long poolId
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1879
@sureshanaparti I pulled the latest code and repeated the first test
scenario, got the same failure: `Message: The setting of vmConfig is invalid
for cluster CLD100.`. I attach the full
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1278
Hi @rafaelweingartner @anshul1886 @GabrielBrascher,
I've read this PR's comments several times and I think I could understand
@anshul1886's point. Please correct me if I'm wrong
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1918
@jayakarteek @rafaelweingartner what about retrieving CPU performance
metric for usage using
[PerfomanceManager](https://pubs.vmware.com/vsphere-60/index.jsp#com.vmware.wssdk.apiref.doc
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1994#discussion_r105797159
--- Diff:
engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java
---
@@ -409,15 +460,13 @@ public StoragePoolVO
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1994#discussion_r105796872
--- Diff:
engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java ---
@@ -77,4 +90,71 @@ public void deleteTags(long poolId
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1994#discussion_r105796786
--- Diff:
engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java ---
@@ -77,4 +90,71 @@ public void deleteTags(long poolId
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1994#discussion_r105796076
--- Diff:
engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java ---
@@ -77,4 +90,71 @@ public void deleteTags(long poolId
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1994
@rafaelweingartner I pushed changes and squashed my commits as it could be
easier to review. I also added unit tests for new methods
---
If your project is set up for it, you can reply
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1994
@mike-tutkowski awesome, thanks for testing this PR!
@rafaelweingartner thanks for reviewing, I'll work on changes proposed
@karuturi sure, I'll work on it, thanks
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1994
@serg38 actually is not being used anymore, I'll add removalof the view on
last commit
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1994
Hi @rafaelweingartner, you're right, it was basically that fix.
I've pushed another commit due to issue reported by @mike-tutkowski in
mailing list:
I have an NFS SR as primary
GitHub user nvazquez opened a pull request:
https://github.com/apache/cloudstack/pull/1994
CLOUDSTACK-9827: Storage tags stored in multiple places
Issue description: https://issues.apache.org/jira/browse/CLOUDSTACK-9827
### Fixes
- Create Primary Storage: Persist tags
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1879
@sureshanaparti sure, we use version 6.0.0, build 3634794
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1879
Sure @serg38, after enabling HA on cluster, stopping VR and the starting VR
we got this exception on ESXi 6:
2017-03-06 12:18:14,654 ERROR [cloud.vm.VmWorkJobDispatcher]
(Work-Job
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1961
That's great! Thanks @borisstoyanov for your help!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1961
@borisstoyanov I refactored marvin test to migrate a detached disk instead
of vm's root volume as it was before. Can you please test it again in your env?
---
If your project is set up
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1961
@borisstoyanov actually disk is not being dettached from vm before
migrating it, it is using vm's ROOT disk, it can be done on Vmware by setting
`livemigrate='true'` to migrate command. I'll
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1961#discussion_r103932149
--- Diff: test/integration/smoke/test_snapshots.py ---
@@ -275,7 +275,7 @@ def
test_02_list_snapshots_with_removed_data_store(self
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1961
Hi @karuturi @rhtyd @borisstoyanov,
I've pushed a new commit for fixing `test_snapshots.py` failure. Can you
please run tests against Vmware and Kvm?
These were results in our env
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1935
Hi @rafaelweingartner, I've refactored the code instead of using
`rollBackState` as static. I think that using static variable could lead to a
problem if new methods are invoked from another
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1961
@karuturi @borisstoyanov next step will be updating Marvin's folder
`test_data.py` file and configure an url for key "nfs2" similar as it was done
for "nfs", this way it
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1935#discussion_r102556528
--- Diff: server/test/com/cloud/user/DomainManagerImplTest.java ---
@@ -134,4 +164,67 @@ public void testFindDomainByIdOrPathValidId
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1961
@borisstoyanov great, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user nvazquez opened a pull request:
https://github.com/apache/cloudstack/pull/1961
Fix for test_snapshots.py using nfs2 instead of nfs template
Fix for marvin test failure introduced in #1847
Cc: @borisstoyanov @rhtyd @karuturi
You can merge this pull request
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1935#discussion_r102531132
--- Diff: server/src/com/cloud/user/DomainManagerImpl.java ---
@@ -273,82 +289,133 @@ public boolean deleteDomain(long domainId, Boolean
cleanup
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1935#discussion_r102529801
--- Diff: server/src/com/cloud/user/DomainManagerImpl.java ---
@@ -273,82 +289,133 @@ public boolean deleteDomain(long domainId, Boolean
cleanup
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1935#discussion_r102531047
--- Diff: server/test/com/cloud/user/DomainManagerImplTest.java ---
@@ -134,4 +164,67 @@ public void testFindDomainByIdOrPathValidId
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1935#discussion_r102530895
--- Diff: server/src/com/cloud/user/DomainManagerImpl.java ---
@@ -273,82 +289,133 @@ public boolean deleteDomain(long domainId, Boolean
cleanup
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1935
@rafaelweingartner no problem, I should have mentioned about changing the
variable to static. I'll work on your last comments :)
---
If your project is set up for it, you can reply
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1847
@borisstoyanov @rhtyd I was checking BlueOrangutan logs:
In `test_primary_storage_8NPG5G\runinfo.txt` lines 27-30, there's PS
creation:
2017-02-20 11:03:59,678 - DEBUG
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1935
@rafaelweingartner I think I got your point, I tried to keep code as
similar as it was before, by declaring `rollBackState` as static class variable
on line 114. This way inner `finally` block
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1935
@rafaelweingartner thanks for reviewing! I extracted code to new methods
and also added unit tests for them
---
If your project is set up for it, you can reply to this email and have your
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1935#discussion_r102264841
--- Diff: server/src/com/cloud/user/DomainManagerImpl.java ---
@@ -273,79 +274,97 @@ public boolean deleteDomain(long domainId, Boolean
cleanup
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1935#discussion_r102265306
--- Diff: server/src/com/cloud/user/DomainManagerImpl.java ---
@@ -273,79 +274,97 @@ public boolean deleteDomain(long domainId, Boolean
cleanup
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1935#discussion_r102265150
--- Diff: server/src/com/cloud/user/DomainManagerImpl.java ---
@@ -273,79 +274,97 @@ public boolean deleteDomain(long domainId, Boolean
cleanup
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1735
Closing this PR as #1847 includes this changes in a simpler way
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user nvazquez closed the pull request at:
https://github.com/apache/cloudstack/pull/1735
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1847
@anshul1886 great, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1847
Hi @anshul1886,
I've deployed and tested your PR by replicating issue we had in our
environment with Vmware and passed successfully! I think your solution is much
cleaner and simpler than
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1918
@rafaelweingartner I checked 'objProps' object and it doesn't contain the
property. However, I think it can be easily retrieved by adding
"summary.config.cpuReservation" on array at
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@karuturi sure, done! Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1918
@rafaelweingartner please ommit my last comment, service offering didn't
use reserve CPU, so it didn't limit CPU speed to 500Mhz, it used all the
available frecuency of the CPU instead
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1918
@rafaelweingartner sorry for the last example, actually I think we've found
a bug on change service offering, as I've been using that instance for changing
its service offering when it had vm
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1918
Hi @jayakarteek @rafaelweingartner,
I confirm issue, I tested using an instance with 1 CPU 500Mhz. I'll add
screenshots for cases when CPU utilization is low and high:
First
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1727
Great, thanks @borisstoyanov!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1727
Thanks @borisstoyanov! Can we test it against Vmware?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1938
Thanks @swill!
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1913#discussion_r100543231
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
---
@@ -1577,11 +1577,15 @@ public Answer
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@rafaelweingartner @koushik-das @karuturi
Great, I've re-targeted PR to master branch. Thanks for your help!
---
If your project is set up for it, you can reply to this email and have your
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@rafaelweingartner excellent, I added both test cases on
`VMSnapshotManagerTest`, thanks!
@koushik-das thanks for pointing that out, I agree with you that db changes
should be in `schema
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1727
Hi @rafaelweingartner! Thanks a lot for your review! As usual, your
comments are really valuable.
I agree with you on the points you've mentioned and I've refactored the PR
based on them
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1905
@karuturi thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1767
@karuturi @rafaelweingartner thanks! I closed Jira ticket 9379
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1905
@karuturi regarding tests done, we've compared the number of delete tasks
sent to Vmware hypervisor on expunging a vm with `N` vm snapshots before and
after this optimization, reducing from `N
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1905
Hi @karuturi,
On Vmware, step 2 reduces tasks sent to hypervisor by sending only one task
which actually deletes vm snapshots and the vm itself instead of sending one
for each vm snapshot
GitHub user nvazquez opened a pull request:
https://github.com/apache/cloudstack/pull/1935
CLOUDSTACK-9764: Delete domain failure due to Account Cleanup task
It was noticed in production environments that `deleteDomain` task failed
for domains with multiple accounts and resources
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1905
@karuturi sure, done!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user nvazquez opened a pull request:
https://github.com/apache/cloudstack/pull/1913
CLOUDSTACK-9752: [Vmware] Optimization of volume attachness to vm
## Description
This optimization aims to reduce volume attach slowness due to vmdk files
search on datastore before
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1905
@ozhanrk nice, then this PR shouldn't affect your workflow
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1905
Hi @ozhanrk,
In this PR, vm snapshots get deleted when the instance gets deleted from
hypervisor, on task sent by the vm cleanup thread. Can it be possible that you
were referring
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1727
@serg38 done, I reverted DB changes to `schema-490to4910.sql`, thanks!
@koushik-das thanks for reviewing! I refactored PR according to your review
---
If your project is set up for it, you
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r96295051
--- Diff: engine/schema/src/com/cloud/vm/UserVmDetailVO.java ---
@@ -80,4 +80,8 @@ public boolean isDisplay() {
return display
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r96294598
--- Diff: setup/db/db/schema-490to4910.sql ---
@@ -71,3 +71,17 @@ INSERT IGNORE INTO `cloud`.`guest_os_hypervisor`
(uuid,hypervisor_type, hypervis
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r96294371
--- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java ---
@@ -707,16 +802,41 @@ private UserVm orchestrateRevertToVMSnapshot(Long
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r96294242
--- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java ---
@@ -350,6 +368,24 @@ public VMSnapshot allocVMSnapshot(Long vmId, String
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r96294332
--- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java ---
@@ -643,6 +679,65 @@ else if (jobResult instanceof Throwable
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r96294219
--- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java ---
@@ -338,10 +354,12 @@ public VMSnapshot allocVMSnapshot(Long vmId, String
GitHub user nvazquez opened a pull request:
https://github.com/apache/cloudstack/pull/1905
CLOUDSTACK-9738: Optimize vm expunge process for instances with vm snapshots
## Description
It was noticed that expunging instances with many vm snapshots took a look
of time
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1735
@mike-tutkowski @anshul1886 thanks for your comments! I'll work on them!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1747
@rhtyd Done, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1735#discussion_r94412144
--- Diff:
api/src/org/apache/cloudstack/api/command/user/snapshot/ListSnapshotsCmd.java
---
@@ -115,8 +115,10 @@ public void execute
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1847
Hi @anshul1886,
We addressed the same issue along with @serg38 in PR #1735. We proposed a
way to fix the problem on it.
---
If your project is set up for it, you can reply to this email
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1767
Hi @rhtyd @koushik-das @ustcweizhou,
I refactored this PR removing previously created API commands, only adding
an optional parameter (`cleanupdetails`) on `updateVirtualMachine
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1858
+1 happy holidays!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
1 - 100 of 389 matches
Mail list logo
