[GitHub] cloudstack issue #2037: CLOUDSTACK-9871: Set SQL Mode in SQL Session for MyS...

2017-04-12 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/2037 Do you know if this have an impact if we still use MySQL 5.6 or MySQL 5.5 on another host and have CloudStack installed on Ubuntu or CentOS 7 ? --- If your project is set up for it, you can

[GitHub] cloudstack issue #1834: CLOUDSTACK-9679:Allow master user to manage subordin...

2017-04-04 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1834 @pdumbre @karuturi @syed I thinks this introduce an issue where a domain admin cannot get a template by id. a domain admin can list feature template and get a template via `ids

[GitHub] cloudstack issue #1582: CLOUDSTACK-9408 for the move away from download.clou...

2017-03-14 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1582 Effectively we are due for an updated systemvm for strongswan + jdk8 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request #:

2017-02-27 Thread pdion891
Github user pdion891 commented on the pull request: https://github.com/apache/cloudstack/commit/fa85151be962824cc88776a0264e1ac6ef90560c#commitcomment-21080945 In server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java: In server/src/com/cloud/vm/snapshot

[GitHub] cloudstack issue #1919: CLOUDSTACK-9763: set ssh public key when creating vm...

2017-02-27 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1919 This is usefull when using VPC. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack-www pull request #34: Remove link to “planet.apache.org” and ...

2017-02-13 Thread pdion891
Github user pdion891 commented on a diff in the pull request: https://github.com/apache/cloudstack-www/pull/34#discussion_r100800298 --- Diff: content/about.html --- @@ -79,7 +78,7 @@ Get Involved Developers Mailing

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

2017-02-13 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack-www/pull/34 Let's change the model but not in this PR ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

2017-02-13 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack-www/pull/34 sorry, so yeah, no html in the PR, only in asf-site when merge is aprouve, than html generated by the commiter merging the PR. make sense? since `content` folder already exist, no need

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

2017-02-13 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack-www/pull/34 I haven't follow this whole thread but shouldn't we not include .html files in PR and master branch and only push them in the asf-site branch once approved ? this would make master and PR

[GitHub] cloudstack-docs-admin issue #41: 50% of the doc strings are translated into ...

2017-02-04 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack-docs-admin/pull/41 @lmrv I've extract the PR diff file from github, but there is no information about you in the git commis, you name and email address. I think you just need to do follow

[GitHub] cloudstack pull request #:

2017-02-03 Thread pdion891
Github user pdion891 commented on the pull request: https://github.com/apache/cloudstack/commit/eabf862ba9751bcdbe18a6cc9b91f2ae48472cab#commitcomment-20741478 In setup/db/db/schema-4910to4920.sql: In setup/db/db/schema-4910to4920.sql on line 217: could it be possible

[GitHub] cloudstack issue #1928: Update hypervisor capabilities for xenserver 7

2017-02-03 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1928 Please merge it into master as well, it also mean we need to make sure master does have the same file `setup/db/db/schema-4920to4930.sql` too. We will do some testing around xenserver7

[GitHub] cloudstack issue #1928: Update hypervisor capabilities for xenserver 7

2017-02-02 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1928 I think this should be push into master as well to make sure it will exist in future version. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

2017-02-02 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack-www/pull/34 we have builds.cloudstack.org, but we would need to validate how to push files on webserver which I think the current case if a pull process. --- If your project is set up for it, you can

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

2017-02-02 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack-www/pull/34 The website is not build via jenkins yet. manual for now :-S --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

2017-02-02 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack-www/pull/34 Hi, I think we miss-managed our repo. The original idea was to have only source files in the master branch for the website, and when the PR is aprouve we build it in the asf-site branch

[GitHub] cloudstack pull request #1921: Dockerfile: Upgrade base distro to Ubuntu 16....

2017-01-30 Thread pdion891
GitHub user pdion891 opened a pull request: https://github.com/apache/cloudstack/pull/1921 Dockerfile: Upgrade base distro to Ubuntu 16.04, fix support for JDK8 Fix current broken build introduce with JDK upgrade from #1888 of docker simulator because of missing dependencies

[GitHub] cloudstack-docs-admin issue #41: 50% of the doc strings are translated into ...

2017-01-30 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack-docs-admin/pull/41 LGTM, I'll merge this PR this week... Thanks a lot @lmrv for the translation ! --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack-docs-admin pull request #41: 50% of the doc strings are translate...

2017-01-30 Thread pdion891
Github user pdion891 commented on a diff in the pull request: https://github.com/apache/cloudstack-docs-admin/pull/41#discussion_r98378667 --- Diff: source/locale/fr/LC_MESSAGES/virtual_machines.po --- @@ -0,0 +1,2188 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request #:

2017-01-29 Thread pdion891
Github user pdion891 commented on the pull request: https://github.com/apache/cloudstack/commit/e6cc78f531d0201aed004fd9e003a1ae2ab9a816#commitcomment-20657409 In tools/docker/Dockerfile: In tools/docker/Dockerfile on line 25: unfortunately it doesn't work because add-apt

[GitHub] cloudstack-docs-admin issue #41: 50% of the doc strings are translated into ...

2017-01-29 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack-docs-admin/pull/41 Hi @lmrv, since the last commit, if I try to build the project in `fr` there is an issue with `virtual_machines.mo`: I've run `make gettext` which worked fined

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-01-28 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1813 Quickly tested with 4.10 pre jdk8 and it work creating vm and resize the root volume on XenServer 6.5. tested using lvmiscsi and SolidFire storage plugins. --- If your project is set up

[GitHub] cloudstack-www issue #33: Updated the 2017 conference details

2017-01-27 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack-www/pull/33 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack-www issue #33: Updated the 2017 conference details

2017-01-26 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack-www/pull/33 otherwise, LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack-www issue #33: Updated the 2017 conference details

2017-01-26 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack-www/pull/33 Can you take the oportunity to upgrade the Year in this page too ? https://github.com/apache/cloudstack-www/blob/master/source/layouts/layout.erb#L131 --- If your project is set up

[GitHub] cloudstack issue #1797: CLOUDSTACK-9630: Cannot use listNics API as advertis...

2017-01-25 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1797 Have you tested as @jburwell comments, `broadcasturi` cannot be part of the response for user, only for root-admin. Does this PR make `broadcasturi` visible to users? --- If your project

[GitHub] cloudstack issue #1797: CLOUDSTACK-9630: Cannot use listNics API as advertis...

2017-01-24 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1797 as it been confirmed the the attribute `broadcasturi = vlan://743` is only visible as admin and not as user? because the example have it. --- If your project is set up for it, you can reply

[GitHub] cloudstack-docs-admin issue #41: 50% of the doc strings are translated into ...

2017-01-10 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack-docs-admin/pull/41 Also, I think we need to keep the `Makefile` with an empty `SPHINXOPS` So the default build will be for english version and RTD.org will detect the translation files and will do them

[GitHub] cloudstack-docs-admin issue #41: 50% of the doc strings are translated into ...

2017-01-10 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack-docs-admin/pull/41 @lmrv , I've quickly reviewed the translated content. but I'm wondering why the `make.sh` file is removed? --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack-docs-admin issue #41: 50% of the doc strings are translated into ...

2017-01-03 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack-docs-admin/pull/41 @rhtyd @swill @jburwell, Does any of you would know if the header file is correct, for .po files? I think the copyright line must be removed, ``` # SOME

[GitHub] cloudstack-docs-admin issue #41: 50% of the doc strings are translated into ...

2017-01-03 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack-docs-admin/pull/41 Hi @lmrv, I've built the site in FR and reviewing the doc... So far I've only found a minor issue: header of .po files are improper, it should be the apache2 license

[GitHub] cloudstack-docs-admin issue #40: index.po and ui.po translated in FR

2016-12-23 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack-docs-admin/pull/40 @lmrv I think you are now at 50% completed, right ? could it be possible to update this PR so we cloud merge this first step ? Continue the Good work !! --- If your project

[GitHub] cloudstack issue #1858: README: Happy Christmas, happy holidays!

2016-12-22 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1858 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1769: tools: fix Dockerfile

2016-12-09 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1769 Hi @resmo, I've made some changes on the Docker file so it might not be possible to merge this PR in the current state. Thanks! --- If your project is set up for it, you can reply

[GitHub] cloudstack issue #1815: Fix docker image build for cloudstack-management

2016-12-09 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1815 Thanks @rhtyd ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1815: Fix docker image build for cloudstack-management

2016-12-06 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1815 Thanks @rhtyd, let merge it so we have the simulator back online on docker hub and let's improve our Docker images... @jburwell, @rhtyd , do I merge it or you do it? I'm just wondering

[GitHub] cloudstack issue #1815: Fix docker image build for cloudstack-management

2016-12-05 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1815 @sebgoa , I agree with you, it's just the easiest way to have a cloudstack with simulator preconfigured ready to work. We should not use package for the image management also. I've

[GitHub] cloudstack issue #1435: Dockerfile4.9

2016-12-02 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1435 This PR is not valid anymore replaced by Squashed: #1815 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request #1435: Dockerfile4.9

2016-12-02 Thread pdion891
Github user pdion891 closed the pull request at: https://github.com/apache/cloudstack/pull/1435 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request #1815: Fix docker image build for cloudstack-managem...

2016-12-02 Thread pdion891
GitHub user pdion891 opened a pull request: https://github.com/apache/cloudstack/pull/1815 Fix docker image build for cloudstack-management CLOUDSTACK-9651 Fix Docker images build for 4.10.0.0: - simulator - marvin - management_centos6 You can merge

[GitHub] cloudstack pull request #1814: fix docker images build

2016-12-02 Thread pdion891
Github user pdion891 closed the pull request at: https://github.com/apache/cloudstack/pull/1814 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request #1814: fix docker images build

2016-12-02 Thread pdion891
GitHub user pdion891 opened a pull request: https://github.com/apache/cloudstack/pull/1814 fix docker images build CLOUDSTACK-9651; Fix Docker images build for: - cloudstack-simulator - cloudstack-management - marvin Updated for version 4.10.0.0

[GitHub] cloudstack issue #1435: Dockerfile4.9

2016-12-01 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1435 I've retested the management server, it work with Jenkins as the build is back online. @jburwell, do you know if there is a way to squash a commit within the same PR ? --- If your

[GitHub] cloudstack issue #1435: Dockerfile4.9

2016-11-30 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1435 Hi @jburwell, do you think we can merge this in master or you are in a code freeze for 4.10.0.0 ? Thanks, --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack issue #1435: Dockerfile4.9

2016-11-30 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1435 @resmo I've updated the PR. I've tested the simulator and marvin. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1769: tools: fix Dockerfile

2016-11-30 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1769 ok, I'll update the PR and merge it I think the PR go all required LGTM. I'll confirmed with John, in case he is in a code freeze period. --- If your project is set up for it, you can reply

[GitHub] cloudstack issue #1769: tools: fix Dockerfile

2016-11-30 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1769 @resmo could you do a PR on top of #1435 ? or this have to be merged first? so we can get your chances and some of mine. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack issue #1769: tools: fix Dockerfile

2016-11-30 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1769 So, should we go forward and merge #1435 + #1769 to master? I might just need to rebase and update version number of the current commit. With those 2 PR, we would have master back

[GitHub] cloudstack issue #1769: tools: fix Dockerfile

2016-11-24 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1769 Could you look if it conflict with #1435 ? Because I made a pull request to automatically increment version in docker file when changing release of master via ```tools/build/setnextversion.sh

[GitHub] cloudstack issue #1684: CLOUDSTACK-9489: the new config vars that are added ...

2016-11-23 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1684 btw, I don't think this PR should be backport since it would change behavior for someone that would upgrade from 4.x.x to 4.9.0 or 4.9.x(that would include this PR) --- If your project

[GitHub] cloudstack issue #1684: CLOUDSTACK-9489: the new config vars that are added ...

2016-11-22 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1684 I haven't retested recently but the upgrade path will need documentation update I think because of the ``commands.properties``. Otherwise it's LGTM for me too. --- If your project

[GitHub] cloudstack issue #1692: Fix Smoke Test Failures

2016-10-20 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1692 Could it be possible this PR is specific to blueorangutan tests or they are to fix marvin tests too? we could be able to test if marvin, need to know how for blueorangutan. Since

[GitHub] cloudstack issue #1706: CLOUDSTACK-9500: remove the IP from the databag if i...

2016-10-12 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1706 Hi @remibergsma, We found this issue CLOUDSTACK-9500 where Public IP's is not removed from a VR when the Public IP is release. this cause routing issues because the arp table

[GitHub] cloudstack-docs-admin issue #40: index.po and ui.po translated in FR

2016-10-01 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack-docs-admin/pull/40 Hi @lmrv, I've look at your test site, those the page https://cloudstack.le-morvan.com/4.8/service_offerings.html translation is completed? because I see it half in english

[GitHub] cloudstack issue #1684: CLOUDSTACK-9489: the new config vars that are added ...

2016-10-01 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1684 I've re-perform my upgrade test this morning with this PR, I just add to change ``dynamic.apichecker.enabled`` value have the authentication working, so nothing else have to change

[GitHub] cloudstack issue #1684: CLOUDSTACK-9489: the new config vars that are added ...

2016-09-30 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1684 @rhtyd I agree with you for the documentation part. For sure in-place upgrade must be transparent to user and not required manual steps. --- If your project is set up for it, you can

[GitHub] cloudstack issue #872: Strongswan vpn feature

2016-09-29 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/872 in case of HTTPs issue registering the template http://objects-east.cloud.ca/v1/5ef827605f884961b94881e928e7a250/swill/systemvm64template-master-4.6.0-xen.vhd.bz2 can be use. --- If your

[GitHub] cloudstack issue #1684: CLOUDSTACK-9489: the new config vars that are added ...

2016-09-29 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1684 Thanks @abhinandanprateek. So I guest it's an LGTM for this PR but it's not solving the whole issue for CLOUDSTACK-9489 which is configuration inconsistency between fresh install and upgrade

[GitHub] cloudstack issue #1684: CLOUDSTACK-9489: the new config vars that are added ...

2016-09-28 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1684 Thanks @rhtyd, @jburwell @abhinandanprateek for the clarifications. Look like doing the ``update cloud.configuration set value='true' where name='dynamic.apichecker.enabled';`` fixe

[GitHub] cloudstack issue #1684: CLOUDSTACK-9489: the new config vars that are added ...

2016-09-27 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1684 @abhinandanprateek did you ran a fresh install of 4.9.x or did an upgrade from example 4.4.4 ? The way I'm testing is as follow, in case I do something wrong: 1) ``git

[GitHub] cloudstack issue #1684: CLOUDSTACK-9489: the new config vars that are added ...

2016-09-26 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1684 @dagsonstebo for your scenario 2 can you get the count of global settings ? via cloudmonkey as admin: ``` list configurations ``` You should have a count of about 468

[GitHub] cloudstack issue #1684: CLOUDSTACK-9489: the new config vars that are added ...

2016-09-26 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1684 @dagsonstebo, did you upgrade to 4.9 ? So far, I had no authentication issue upgrading to 4.7. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack issue #1684: CLOUDSTACK-9489: the new config vars that are added ...

2016-09-26 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1684 @abhinandanprateek I did replace the following 4 settings by the original values. But after restarting jetty I'm unable to login, but this time the behavior is a bit different, it look like

[GitHub] cloudstack issue #1684: CLOUDSTACK-9489: the new config vars that are added ...

2016-09-25 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1684 upgrade from 4.7.0 to 4.9.0.1 not working with same error: ``` WARN [o.a.c.s.a.PBKDF2UserAuthenticator] (qtp204585401-22:ctx-9e4c5615) (logid:1ca9f551) The stored password for admin

[GitHub] cloudstack issue #1684: CLOUDSTACK-9489: the new config vars that are added ...

2016-09-25 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1684 I've applied this fix to 4.7.0 and I got the upgrade from 4.4.4 working. but when I upgrade 4.4.4 to this PR I end with inability to logon into the UI. --- If your project is set up

[GitHub] cloudstack issue #1684: CLOUDSTACK-9489: the new config vars that are added ...

2016-09-25 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1684 Unfortunately, Authentication is not working after an upgrade. the configration table as been updated but login is not working anymore. Upgrade test from 4.4.4 to the PR (4.9), I can

[GitHub] cloudstack issue #1684: CLOUDSTACK-9489: the new config vars that are added ...

2016-09-25 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1684 I will test this PR, allow me few days.. This will be ported into master as well right? Thanks --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #872: Strongswan vpn feature

2016-09-15 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/872 @jayapalu do you have a configuration example of strongswan for the remote management VPN? I would validate that the generated configuration will work with Windows and OSx clients

[GitHub] cloudstack issue #1658: Added an additional JSON diff output to the ApiXmlDo...

2016-09-09 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1658 lgtm, that's usefull --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack-docs-admin issue #40: index.po and ui.po translated in FR

2016-08-24 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack-docs-admin/pull/40 @lmrv if you have a chance to update all files copyright header, to must have the apache2 v2 license header. Thanks --- If your project is set up for it, you can reply

[GitHub] cloudstack-docs-admin issue #40: index.po and ui.po translated in FR

2016-08-24 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack-docs-admin/pull/40 @lmrv This is a great start! I'm willing to merge this PR, but it's a work in progress so it will not be visible on the main site until the translation is mostly completed

[GitHub] cloudstack-docs-admin issue #40: index.po and ui.po translated in FR

2016-08-23 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack-docs-admin/pull/40 I'll review this PR, give me few days... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1599: Marvin: Fix codegenerator to work with API discovery

2016-08-18 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1599 The code seams to make sense. I like the idea of api auto-discovery so it's a LGTM I guest. I'm a bit out of context on this one but if it's usefull lets merge it. Cheers

[GitHub] cloudstack issue #1638: CLOUDSTACK-9456: Use Spring 4 and Java 8

2016-08-16 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1638 Make sense, thanks, I hope it will get thru then to add support for Ubuntu 16.04 for the management server host and KVM. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack issue #1638: CLOUDSTACK-9456: Use Spring 4 and Java 8

2016-08-16 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1638 Shouldn't we consider doing a 5.0.0 release that would support Java 8 or we want to go Java8 at 4.10.0 ? Otherwise I can't review, but I should be able to help on testing

[GitHub] cloudstack issue #1619: Add the Transifex config for next version of CS (4.1...

2016-08-15 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1619 LGTM, Does this command most be run every build or one time per branch only ? Shouldn't we document this process in the building doc or the wiki ? Thanks! --- If your

[GitHub] cloudstack issue #1619: Add the Transifex config for next version of CS (4.1...

2016-08-13 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1619 Does those files actually exist? otherwise how do we generate those files? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack issue #1628: updated contributing.md

2016-08-13 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1628 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack-docs-rn pull request #29: 4.9

2016-08-13 Thread pdion891
Github user pdion891 closed the pull request at: https://github.com/apache/cloudstack-docs-rn/pull/29 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #872: Strongswan vpn feature

2016-08-12 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/872 JIRA reference: https://issues.apache.org/jira/browse/CLOUDSTACK-8682 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack-docs-admin issue #36: OSPF: WIP formatting documentation for ospf

2016-08-11 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack-docs-admin/pull/36 @agneya2001 , any update on the merge of your code in the upstream ? I'm keeping this PR open until the actual code get merge into master Regards, --- If your project

[GitHub] cloudstack issue #1630: Add projectid to project details page

2016-08-08 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1630 I've added some more information in the project detail page as on following screenshot: ![prj1](https://cloud.githubusercontent.com/assets/5923502/17500440/995a4420-5da3-11e6-947e

[GitHub] cloudstack issue #1054: CLOUDSTACK-8818: Use MySQL native connector with Pyt...

2016-08-08 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1054 ok, thanks, I will make sure the doc reflect that. thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1054: CLOUDSTACK-8818: Use MySQL native connector with Pyt...

2016-08-08 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1054 Are you saying it's not like CentOS which require to install mysq-connector-python from mysql repo [1], on ubuntu the package would have not been renamed ? [1] https://github.com

[GitHub] cloudstack-docs-rn pull request #29: 4.9

2016-08-08 Thread pdion891
GitHub user pdion891 opened a pull request: https://github.com/apache/cloudstack-docs-rn/pull/29 4.9 Please confirm it make sense to add a new package repo for the MySQL driver. You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] cloudstack issue #1629: CLOUDSTACK-9449: Fix typo in user role description

2016-08-07 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1629 Hum, This is a change to a file for an upgrade SQL to a release that is already GA. I think it would be preferable to get it into the 490_to_4100 file to avoid divergence between

[GitHub] cloudstack-www pull request #28: website update for 4.9 and page template ch...

2016-08-07 Thread pdion891
GitHub user pdion891 opened a pull request: https://github.com/apache/cloudstack-www/pull/28 website update for 4.9 and page template changes This PR update the site for the 4.9.0 release and also add change on the way page get generated. versions for download and archives

[GitHub] cloudstack issue #1054: CLOUDSTACK-8818: Use MySQL native connector with Pyt...

2016-08-06 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1054 Could it be possible the file ``debian/control`` should be updated to depend on mysql-connector-python deb package instead of python-mysql.connector ? I have this PR ready

[GitHub] cloudstack pull request #:

2016-08-06 Thread pdion891
Github user pdion891 commented on the pull request: https://github.com/apache/cloudstack/commit/3315eb5420e1b2cedf906aeb709740efc2f08cfd#commitcomment-18549608 Look like [building deb package](http://builds.apachecloudstack.net/job/package-master-deb/) fail because changelog

[GitHub] cloudstack pull request #:

2016-08-06 Thread pdion891
Github user pdion891 commented on the pull request: https://github.com/apache/cloudstack/commit/4347776ac6ef9ae86fb016862f4a6b2376f8319a#commitcomment-18549598 In setup/db/db/schema-481to490.sql: In setup/db/db/schema-481to490.sql on line 473: Forget about the missing field

[GitHub] cloudstack-docs-install pull request #30: update for 4.9.0

2016-08-06 Thread pdion891
GitHub user pdion891 opened a pull request: https://github.com/apache/cloudstack-docs-install/pull/30 update for 4.9.0 * Upgrade release to 4.9.0; * update library for building from source. * Include PR #28 and #29. * fixes some confusion about nfs, to help #27

[GitHub] cloudstack pull request #1630: Add projectid to project details page

2016-08-06 Thread pdion891
GitHub user pdion891 opened a pull request: https://github.com/apache/cloudstack/pull/1630 Add projectid to project details page Display the project ID on the details view of a project. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cloudstack-docs-install issue #27: make sure we use the same nfs paths. /pri...

2016-08-06 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack-docs-install/pull/27 Hi @bugoff, thanks for rising the source of confusion about nfs shares. Although, you change from ``/primary`` to ``/mnt/primary`` but quickly looking at the page other

[GitHub] cloudstack pull request #:

2016-08-05 Thread pdion891
Github user pdion891 commented on the pull request: https://github.com/apache/cloudstack/commit/4347776ac6ef9ae86fb016862f4a6b2376f8319a#commitcomment-18546909 In setup/db/db/schema-481to490.sql: In setup/db/db/schema-481to490.sql on line 473: Role User description is for root

[GitHub] cloudstack-docs issue #18: Removed support for Citrix XenServer

2016-08-01 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack-docs/pull/18 Is this for a part of a particular version of CloudStack, or it never been supported? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack-docs-admin issue #39: corrected a typo

2016-06-29 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack-docs-admin/pull/39 lgtm ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1582: CLOUDSTACK-9408 for the move away from download.clou...

2016-06-13 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1582 if we are to replace the old default template centos5, would it be possible on the new one to support user-data, ssh keys and password reset? so it would help exposing cloudstack capabilities

[GitHub] cloudstack issue #1435: Dockerfile4.9

2016-06-09 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1435 @runseb I agree, images must be smaller. for the simulator, it's kind of usefull to have everything in it but it's not container best practice for sure. other images, we could probably use

[GitHub] cloudstack issue #1435: Dockerfile4.9

2016-06-08 Thread pdion891
Github user pdion891 commented on the issue: https://github.com/apache/cloudstack/pull/1435 @swill, @runseb does one of you could LGTM or comment thanks, --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: Dockerfile4.9

2016-05-31 Thread pdion891
Github user pdion891 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1435#discussion_r65180940 --- Diff: tools/docker/Dockerfile.centos6 --- @@ -18,14 +18,16 @@ FROM centos:6 MAINTAINER "Apache CloudStack&

  1   2   3   >