Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/1980
Nice @rhtyd LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/2015
@sudhansu7 Thanks for the fix. We need to update the unit test as well.
Please check:
```
diff --git
a/cosmic-core/utils/src/test/java/com/cloud/utils/ssh
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/1889
Nice work @rashmidixit, tested it and works great! LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/2003
@swill FYI if you look for `first_i_p` as seen in the json on the Python
side, then on the Java side it's called `firstIP`, as the gson lib replaces
every capital with an underscore
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/1999
@resmo we use this i production so @ustcweizhou is right. From a test
environment I just made some screenshots to demonstrate this. It's actually
prety cool :-)
This VM is part
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/1980
@rhtyd Looks great! Shall we do the same for the VPC routers, so that the
overviews look the same?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/1955
Tested it manually, works great. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/1198
@ustcweizhou If you find some time to submit PRs for restartVPC+cleanup
which does the router rebuild in sequence that would be awesome. Happy to help
testing! Thanks!
---
If your project
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/1768
@marcaurele Nice improvement, thanks! Tested it and works as you described.
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/1953
Tested it, works as expected! LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/1953
Thanks @sureshanaparti will test it soon!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/1878
@sureshanaparti Thanks for the info!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/1878
@sureshanaparti why do the mac addresses need to be the same on both
routers? We're also executing arpings to update our neighbours. Networking wise
there is no need for them to be the same
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/1955
Nice work @kiwiflyer @dmabry, thanks! Will give it a go soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/1953
Thanks for the fix!
Although I think that after id=25 stuff breaks on KVM, as the code
generates a deviceName that is invalid. Id 25 results in vdz, after that it
continues
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/1943
This issue was also handled in this PR:
https://github.com/apache/cloudstack/pull/1821/files although that was done on
the Python side. This seems cleaner. Should we keep both fixes? Won't
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/1934
What about signed S3 urls that people may supply? If you want to register a
template and have it download from a S3 bucket, you need to specify a signed
url to provide the authentication
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1934#discussion_r100702832
--- Diff: utils/src/main/java/com/cloud/utils/UriUtils.java ---
@@ -200,37 +198,27 @@ public static String getUpdateUri(String url, boolean
encrypt
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/1870
@nitin-maharana Can you please double check this PR? Lots of tests are
failing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/1697
LGTM Tested it, works as expected! Was confused a bit, but it works fine on
KVM. It seems `XenserverSnapshotStrategy` is also used to handle KVM snapshots.
---
If your project is set up
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1908#discussion_r99469241
--- Diff: core/src/com/cloud/agent/api/routing/NetworkElementCommand.java
---
@@ -38,6 +38,7 @@
public static final String
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/1907
LGTM We run this code in production without issues for a few months now
(https://github.com/MissionCriticalCloud/cosmic/pull/114)
---
If your project is set up for it, you can reply
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/1741
@PaulAngus Sounds like an old bug? This PR was supposed to fix it and is
merged: https://github.com/apache/cloudstack/pull/1483
---
If your project is set up for it, you can reply
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/1741
@swill OK, check. Shouldn't be dependent on hypervisor type I'd say.
Anyway, when I find some time I'll spin master and have a look. All I can say
is that we run quite a bunch of them
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/1741
@PaulAngus Out of curiosity, why wouldn't rVPCs work properly on XenServer?
As far as I know it works fine, but I may have missed your point.
---
If your project is set up for it, you can
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/1706
@pdion891 Sorry for being late to the party. We've seen this issue too and
resolved it in a different way. Removing the ip from the databag probably won't
work too well, as it is used
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/1706
@pdion891 saw your msg only now. Will have a look when I find some time.
Thx!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/1580
PEP8 recommends max line length of 79, why bump it to 150? That doesn't
help in readability IMO. And yes, I know many other tests are crappy formatted
too. But since you state it's PEP8
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/1596
@anshul1886 Ok, thanks. I think we should close that old one, shouldn't we?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/1596
Same approach as proposed in #925, although both address different
problems. I'd say let's test this stuff and get it in to resolve these issues.
We may want to look to the other PR as well
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/1595
Thanks @rhtyd nice fix. Tested it and LGTM.
Before:
![screen shot 2016-06-23 at 21 45 41
pm](https://cloud.githubusercontent.com/assets/1630096/16317719/c5662704-398c-11e6-92e4
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/1547
Can you also run one against advanced please @swill?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/1547
@wido FYI all Python code is shared between basic/advanced and router/vpc
so it's important to test both. Will try to look into it again in the next
days. Not saying it's broken, just want
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/1547
I see some tests failing on VPCs:
```
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL
test_02_redundant_VPC_default_routes
```
Will rebuild from scratch to see
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/1531
Yeah, LGTM now with the changes. I didn't test a build, as I've no setup to
do that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/1531
@wido Let's bump Debian to 7.11 and let's not bump the systemvm template
version, as nothing changed that requires users to replace all routers.
---
If your project is set up for it, you
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/1572
Thanks @wido will have a look
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/1581
@pdube Thanks, will give it a try soon
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1531#discussion_r65813321
--- Diff: tools/appliance/definitions/systemvmtemplate/definition.rb ---
@@ -27,15 +27,15 @@
architectures = {
:i386
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1531#discussion_r65813268
--- Diff:
tools/appliance/definitions/systemvmtemplate/configure_systemvm_services.sh ---
@@ -19,7 +19,7 @@
set -e
set -x
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1531#discussion_r65813255
--- Diff: tools/appliance/definitions/systemvmtemplate/definition.rb ---
@@ -27,15 +27,15 @@
architectures = {
:i386
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1581#discussion_r65601112
--- Diff:
core/test/com/cloud/agent/api/routing/SetNetworkACLCommandTest.java ---
@@ -0,0 +1,34 @@
+package com.cloud.agent.api.routing
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/866
@ustcweizhou Would be great to see a PR for that ð thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1575#discussion_r65183997
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/set_redundant.py ---
@@ -1,47 +0,0 @@
-#!/usr/bin/python
--- End diff
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1568#issuecomment-222315777
Hi @dsclose The passwd server should not run on the backup router, the same
counts for dnsmasq. Cloud-init will get the passwd from the server it got the
ip
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1471#issuecomment-221888640
@nlivens We shouldn't wait more than 2s, because that means the interface
is not there and will not come yet. Currently it's horribly slow because every
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1297#discussion_r64153911
--- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java ---
@@ -2451,6 +2455,21 @@ public UserVm updateVirtualMachine(long id, String
displayName
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1482#issuecomment-220845474
@swill Some parts need to be rewritten so that won't be on time I'm afraid.
---
If your project is set up for it, you can reply to this email and have your
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1555#discussion_r64134773
--- Diff: systemvm/scripts/config_ssl.sh ---
@@ -167,7 +169,7 @@ then
fi
if [ ! -f "$customPrivKey" ]
then
-
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1555#issuecomment-220778455
It seems that even without a custom SSL cert, one needs this PR to be able
to download from other https sites (as the realhostip one is always loaded
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1555#discussion_r64134745
--- Diff: systemvm/scripts/config_ssl.sh ---
@@ -123,6 +123,8 @@ customCACert=
publicIp=
hostName=
keyStore=$(dirname $0)/certs
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1555#issuecomment-220767434
Thanks @milamberspace! I was also looking into this and hacked around a
bit. Your solution is nice! Now when a custom cert is used, the other CAs are
also
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1471#issuecomment-219944851
@swill Thanks for running the tests again. The error is `Failed to delete
network` so that's cleanup related. The failed one, is that the one that
randomly
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-219432167
@swill I can only reproduce the loadbalance errors, not the others. When I
look at the errors I doubt they are related. They work fine for me. But anyway
Github user remibergsma closed the pull request at:
https://github.com/apache/cloudstack/pull/1404
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user remibergsma closed the pull request at:
https://github.com/apache/cloudstack/pull/1421
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1542#issuecomment-219206665
KVM also has this feature and there you can enable/disable it in the
agent.properties file (ant not per VM). We should try to make the code as
generic
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-219037267
Pushed the fix and the tests now pass:
```
[root@cs2 cloudstack]# cat /tmp//MarvinLogs/test_network_7VU0DJ/results.txt
Test for port forwarding
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1486#issuecomment-219031280
Resolved conflict
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1471#issuecomment-219029943
@jburwell Had a look at the `wait_until` method and I don't think it will
work well here. The problem is that when the router restarts, it has the full
config
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1520#issuecomment-219027354
LGTM, running this in prod for about a month now. See link above for
screenshots.
---
If your project is set up for it, you can reply to this email and have
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-219005330
@swill @kiwiflyer I run the integration tests over night and they look much
better now. I only see some test fail in `smoke/test_network.py` that seem to
have
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1471#issuecomment-218854911
@jburwell Thanks, I'll look into that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1482#issuecomment-218852007
@kiwiflyer I'll see if I can get it out completely ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1486#issuecomment-218783498
Force pushed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-218595232
Worked with @swill and @kiwiflyer and found the issue: one bit was missing
in the backport from Cosmic. Will look into that tomorrow.
---
If your project
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1524#issuecomment-216064935
@kiwiflyer Sorry but this seems to have issues. We run this in prod with
Cosmic but apparently some other patch is missing here in order for this to
work
Github user remibergsma closed the pull request at:
https://github.com/apache/cloudstack/pull/1524
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1421#issuecomment-216030620
Force pushed again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1486#issuecomment-216030568
Also force pushed this one again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1524#issuecomment-216030504
Force pushed a final time, else I give up on this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1524#issuecomment-216030450
This time around Jenkins is happy and Travis times out :-s
```
No output has been received in the last 10m0s, this potentially indicates a
stalled build
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1524#issuecomment-215991817
Jenkins error says: `Unable to instrument project`, seems like a workspace
issue or such.
---
If your project is set up for it, you can reply to this email
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1421#issuecomment-215988060
@swill force pushed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1486#issuecomment-215988010
@swill force pushed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1482#issuecomment-215987980
@swill conflict resolved
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1473#issuecomment-215987371
@swill Force pushed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1524
KVM: Fix plugging ip addresses to the wrong interface
Fix for KVM, where the public ip would be added to the guest network.
Reason is because it used 'broadcastUrl' as an index, which
Github user remibergsma closed the pull request at:
https://github.com/apache/cloudstack/pull/1475
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1520#issuecomment-215143007
@swill more details here:
https://github.com/MissionCriticalCloud/cosmic-plugin-hypervisor-kvm/pull/16
---
If your project is set up for it, you can reply
Github user remibergsma closed the pull request at:
https://github.com/apache/cloudstack/pull/1476
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1402#issuecomment-211818185
@alexandrelimassantana @swill Thanks guys, fixed it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-211094168
@jayapalu The strongswan service is now started automatically on all
systemvms (including console proxy and seconday storage vm). I think we should
start
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-209893539
@nlivens Please add a description because this confuses me ;-) You guys go
the non-oss way? :-(
---
If your project is set up for it, you can reply
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-209020597
@rafaelweingartner +1 to remove all that stuff
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1488#issuecomment-208819704
@wido Great!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-208817879
@jayapalu Please talk to @swill before merge.
I'll also have another look at it and see if I can get it to work this time.
---
If your project is set
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-208794882
@swill force pushed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1473#issuecomment-208795627
@swill force pushed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1483#issuecomment-208794235
@swill force pushed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1486#issuecomment-208793335
@swill force pushed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1486
Reimplement router.redundant.vrrp.interval setting
Global setting `router.redundant.vrrp.interval` is not used any more and it
is now set to a hardcoded 1.
This results
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1485
Set default networkDomain to empty instead of username
The 10th field of `createUserAccount` is `networkDomain` (See
`AccountService.java`) and it is set to a var named `admin`, which
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1483
CLOUDSTACK-9287 - Fix unique mac address per rVPC router
This is work by @wilderrodrigues, see PR #1413 It contains important fixes
and I think it needs to be included so I send the PR
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1482
Restore iptables at once using iptables-restore instead of calling iptables
numerous times
This makes handling the firewall rules about 50-60 times faster because it
is generated
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-207251541
Travis error is unrelated obviously:
```
No output has been received in the last 10m0s, this potentially indicates a
stalled build or something wrong
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1477
When no zone name is available display a default
When a zone name is available, the previous behaviour is still there:
