[GitHub] cloudstack issue #1980: CLOUDSTACK-9805: Display VR list in network details
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1980 Nice @rhtyd LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2015: CLOUDSTACK-9843 : Performance improvement of SSHHelp...
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/2015
@sudhansu7 Thanks for the fix. We need to update the unit test as well.
Please check:
```
diff --git
a/cosmic-core/utils/src/test/java/com/cloud/utils/ssh/SshHelperTest.java
b/cosmic-core/utils/src/test/java/com/cloud/utils/ssh/SshHelperTest.java
index c7282c426..b9b7213c8 100644
--- a/cosmic-core/utils/src/test/java/com/cloud/utils/ssh/SshHelperTest.java
+++ b/cosmic-core/utils/src/test/java/com/cloud/utils/ssh/SshHelperTest.java
@@ -126,6 +126,5 @@ public class SshHelperTest {
Mockito.verify(conn).openSession();
PowerMockito.verifyStatic();
-Thread.sleep(Mockito.anyLong());
}
}
```
Test `openConnectionSessionTest` passes again for me after above change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1889: CLOUDSTACK-9718: Revamp the dropdown showing lists o...
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1889 Nice work @rashmidixit, tested it and works great! LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/2003 @swill FYI if you look for `first_i_p` as seen in the json on the Python side, then on the Java side it's called `firstIP`, as the gson lib replaces every capital with an underscore and then the lowercase letter. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1999: CLOUDSTACK-9600: listVirtualMachines: add VPC ID to ...
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1999 @resmo we use this i production so @ustcweizhou is right. From a test environment I just made some screenshots to demonstrate this. It's actually prety cool :-) This VM is part of 4 VPCs:  Network details show VPCid:  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1980: CLOUDSTACK-9805: Display VR list in network details
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1980 @rhtyd Looks great! Shall we do the same for the VPC routers, so that the overviews look the same? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1955 Tested it manually, works great. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1198: CLOUDSTACK-9114: restartnetwork with cleanup should ...
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1198 @ustcweizhou If you find some time to submit PRs for restartVPC+cleanup which does the router rebuild in sequence that would be awesome. Happy to help testing! Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1768 @marcaurele Nice improvement, thanks! Tested it and works as you described. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1953: CLOUDSTACK-9794: Unable to attach more than 14 devic...
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1953 Tested it, works as expected! LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1953: CLOUDSTACK-9794: Unable to attach more than 14 devic...
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1953 Thanks @sureshanaparti will test it soon! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC ...
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1878 @sureshanaparti Thanks for the info! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC ...
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1878 @sureshanaparti why do the mac addresses need to be the same on both routers? We're also executing arpings to update our neighbours. Networking wise there is no need for them to be the same. I've seen it on other parts of the code as well and I really wonder why we do this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1955 Nice work @kiwiflyer @dmabry, thanks! Will give it a go soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1953: CLOUDSTACK-9794: Unable to attach more than 14 devic...
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/1953
Thanks for the fix!
Although I think that after id=25 stuff breaks on KVM, as the code
generates a deviceName that is invalid. Id 25 results in vdz, after that it
continues with caracters like `{` etc. The default for KVM seems to be 32 (as
defined here:
https://github.com/apache/cloudstack/blob/87ef8137534fa798101f65c6691fcf71513ac978/setup/db/db/schema-452to460.sql#L422).
See:
https://github.com/apache/cloudstack/blob/master/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java#L591
So we either limit it to 25, or improve the code to generate valid device
names above id 25. What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1943: CLOUDSTACK-9339: Send correct network type to router...
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1943 This issue was also handled in this PR: https://github.com/apache/cloudstack/pull/1821/files although that was done on the Python side. This seems cleaner. Should we keep both fixes? Won't really hurt I'd say. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1934: [CLOUDSTACK-9772] Template: perform a HEAD request t...
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1934 What about signed S3 urls that people may supply? If you want to register a template and have it download from a S3 bucket, you need to specify a signed url to provide the authentication. But that signature is valid for either GET or HEAD requests, not both. When you use S3 as secondary storage, you automatically get a GET pre-signed url from CloudStack that you cannot use to register it as a new template. Something to think about.. See: http://stackoverflow.com/questions/15717230/pre-signing-amazon-s3-urls-for-both-head-and-get-verbs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1934: [CLOUDSTACK-9772] Template: perform a HEAD re...
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1934#discussion_r100702832
--- Diff: utils/src/main/java/com/cloud/utils/UriUtils.java ---
@@ -200,37 +198,27 @@ public static String getUpdateUri(String url, boolean
encrypt) {
}
// Get the size of a file from URL response header.
-public static Long getRemoteSize(String url) {
-Long remoteSize = (long)0;
+public static long getRemoteSize(String url) {
--- End diff --
@marcaurele I think this needs to be changed back to Long, or else the
method cannot be found as it is called with type Long.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1870: CLOUDSTACK-9708: Router deployment failed due to two...
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1870 @nitin-maharana Can you please double check this PR? Lots of tests are failing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1697: CLOUDSTACK-4858 Honors the snapshot.backup.rightafte...
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1697 LGTM Tested it, works as expected! Was confused a bit, but it works fine on KVM. It seems `XenserverSnapshotStrategy` is also used to handle KVM snapshots. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...
Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1908#discussion_r99469241 --- Diff: core/src/com/cloud/agent/api/routing/NetworkElementCommand.java --- @@ -38,6 +38,7 @@ public static final String VPC_PRIVATE_GATEWAY = "vpc.gateway.private"; public static final String FIREWALL_EGRESS_DEFAULT = "firewall.egress.default"; public static final String ROUTER_MONITORING_ENABLE = "router.monitor.enable"; +public static final String NETWORK_PUB_LAST_IP = "newtork.public.last.ip"; --- End diff -- typo? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1907: Fix public IPs not being removed from the VR when de...
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1907 LGTM We run this code in production without issues for a few months now (https://github.com/MissionCriticalCloud/cosmic/pull/114) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1741: Updated StrongSwan VPN Implementation
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1741 @PaulAngus Sounds like an old bug? This PR was supposed to fix it and is merged: https://github.com/apache/cloudstack/pull/1483 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1741: Updated StrongSwan VPN Implementation
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1741 @swill OK, check. Shouldn't be dependent on hypervisor type I'd say. Anyway, when I find some time I'll spin master and have a look. All I can say is that we run quite a bunch of them without serious issues. But obviously the code base diverged quite a bit in the past year. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1741: Updated StrongSwan VPN Implementation
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1741 @PaulAngus Out of curiosity, why wouldn't rVPCs work properly on XenServer? As far as I know it works fine, but I may have missed your point. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1706: CLOUDSTACK-9500: remove the IP from the databag if i...
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1706 @pdion891 Sorry for being late to the party. We've seen this issue too and resolved it in a different way. Removing the ip from the databag probably won't work too well, as it is used to deprovision the old ip address from the router. This is what works well for us instead: https://github.com/MissionCriticalCloud/cosmic/pull/114/files --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1706: CLOUDSTACK-9500: remove the IP from the databag if i...
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1706 @pdion891 saw your msg only now. Will have a look when I find some time. Thx! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1580 PEP8 recommends max line length of 79, why bump it to 150? That doesn't help in readability IMO. And yes, I know many other tests are crappy formatted too. But since you state it's PEP8 complaint I suggest to do it fully :-) Does that test take >7 hours? Wow. Do you have any metrics on why that takes so long? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1596: CLOUDSTACK-9353: [XenServer] Fixed VM migration with...
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1596 @anshul1886 Ok, thanks. I think we should close that old one, shouldn't we? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1596: CLOUDSTACK-9353: [XenServer] Fixed VM migration with...
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1596 Same approach as proposed in #925, although both address different problems. I'd say let's test this stuff and get it in to resolve these issues. We may want to look to the other PR as well, although we cannot merge both without some tweaks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1595: ui: show resize volume button to all users
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1595 Thanks @rhtyd nice fix. Tested it and LGTM. Before:  After:  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1547 Can you also run one against advanced please @swill? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1547 @wido FYI all Python code is shared between basic/advanced and router/vpc so it's important to test both. Will try to look into it again in the next days. Not saying it's broken, just want to be careful. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1547 I see some tests failing on VPCs: ``` test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL test_02_redundant_VPC_default_routes ``` Will rebuild from scratch to see if it fails again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1531: systemvmtemplate: fix build and upgrade to debian 7....
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1531 Yeah, LGTM now with the changes. I didn't test a build, as I've no setup to do that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1531: systemvmtemplate: fix build and upgrade to debian 7....
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1531 @wido Let's bump Debian to 7.11 and let's not bump the systemvm template version, as nothing changed that requires users to replace all routers. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1572 Thanks @wido will have a look --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1581: CLOUDSTACK-9404 Fixed ordering of network ACL rules ...
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1581 @pdube Thanks, will give it a try soon --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1531: systemvmtemplate: fix build and upgrade to de...
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1531#discussion_r65813321
--- Diff: tools/appliance/definitions/systemvmtemplate/definition.rb ---
@@ -27,15 +27,15 @@
architectures = {
:i386 => {
:os_type_id => 'Debian',
-:iso_file => 'debian-7.9.0-i386-netinst.iso',
-:iso_src =>
'http://cdimage.debian.org/cdimage/archive/7.9.0/i386/iso-cd/debian-7.9.0-i386-netinst.iso',
-:iso_md5 => 'e101a11ddb31f85acef542df1a49bf57',
+:iso_file => 'debian-7.10.0-i386-netinst.iso',
+:iso_src =>
'http://cdimage.debian.org/cdimage/archive/7.10.0/i386/iso-cd/debian-7.10.0-i386-netinst.iso',
+:iso_md5 => '7fa97966e31afc705b3e115906cbcaa5',
--- End diff --
Is i386 still being used?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1531: systemvmtemplate: fix build and upgrade to de...
Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1531#discussion_r65813268 --- Diff: tools/appliance/definitions/systemvmtemplate/configure_systemvm_services.sh --- @@ -19,7 +19,7 @@ set -e set -x -CLOUDSTACK_RELEASE=4.6.0 +CLOUDSTACK_RELEASE=4.9.0 --- End diff -- Browsed merged PRs but nothing is merged that requires this. Or do I miss something? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1531: systemvmtemplate: fix build and upgrade to de...
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1531#discussion_r65813255
--- Diff: tools/appliance/definitions/systemvmtemplate/definition.rb ---
@@ -27,15 +27,15 @@
architectures = {
:i386 => {
:os_type_id => 'Debian',
-:iso_file => 'debian-7.9.0-i386-netinst.iso',
-:iso_src =>
'http://cdimage.debian.org/cdimage/archive/7.9.0/i386/iso-cd/debian-7.9.0-i386-netinst.iso',
-:iso_md5 => 'e101a11ddb31f85acef542df1a49bf57',
+:iso_file => 'debian-7.10.0-i386-netinst.iso',
+:iso_src =>
'http://cdimage.debian.org/cdimage/archive/7.10.0/i386/iso-cd/debian-7.10.0-i386-netinst.iso',
+:iso_md5 => '7fa97966e31afc705b3e115906cbcaa5',
--- End diff --
You can bump it to 7.11 now ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1581: CLOUDSTACK-9404 Fixed ordering of network ACL...
Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1581#discussion_r65601112 --- Diff: core/test/com/cloud/agent/api/routing/SetNetworkACLCommandTest.java --- @@ -0,0 +1,34 @@ +package com.cloud.agent.api.routing; --- End diff -- @pdube Jenkins fails because this file has no license. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #866: CLOUDSTACK-8751 minimise downtime of network when net...
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/866 @ustcweizhou Would be great to see a PR for that ð thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: systemvm - Python code cleanup
Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1575#discussion_r65183997 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/set_redundant.py --- @@ -1,47 +0,0 @@ -#!/usr/bin/python --- End diff -- This is called from `test/systemvm/test_update_config.py`. Not sure what it does and if it works, but at least it is referenced there. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9385 - Ensure passwd srvr is r...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1568#issuecomment-222315777 Hi @dsclose The passwd server should not run on the backup router, the same counts for dnsmasq. Cloud-init will get the passwd from the server it got the ip address from (on the direct ip, not the vip) so it is not needed. It's a nice idea to have "redundancy" here but it will lead to unexpected problems. Imagine a VM starting and getting the passwd from the master, which marks it as sent. Then the VM restarts and a failover had taken place. Now it gets the same password from the new master (old backup, which has not been marked as retrieved). If a user had changed the password manually, it is now being reset to the previous one. We had this going in in production for a while and it confuses users a lot. Keep it simple, run on the master only. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Lower the time we wait for interfaces to ...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1471#issuecomment-221888640 @nlivens We shouldn't wait more than 2s, because that means the interface is not there and will not come yet. Currently it's horribly slow because every command send to the router will try to see if the interface is there and wait. All those waits together really add up. Especially when restarting. I really think we should keep it like this since it already tries 2 times now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...
Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1297#discussion_r64153911 --- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java --- @@ -2451,6 +2455,21 @@ public UserVm updateVirtualMachine(long id, String displayName, String group, Bo isDynamicallyScalable = vm.isDynamicallyScalable(); } +// Get default guest network in Basic zone +DataCenterVO zone = _dcDao.findById(vm.getDataCenterId()); +Network defaultNetwork = _networkModel.getExclusiveGuestNetwork(zone.getId()); + +boolean isVmWare = (vm.getHypervisorType() == HypervisorType.VMware); --- End diff -- Small detail: Please check the spelling of VMware, I see lots of different variations and believe VMware is the right one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1482#issuecomment-220845474 @swill Some parts need to be rewritten so that won't be on time I'm afraid. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...
Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1555#discussion_r64134773 --- Diff: systemvm/scripts/config_ssl.sh --- @@ -167,7 +169,7 @@ then fi if [ ! -f "$customPrivKey" ] then - printf "priviate key file is not exist\n" + printf "private key file is not exist\n" --- End diff -- English is hard hehe --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1555#issuecomment-220778455 It seems that even without a custom SSL cert, one needs this PR to be able to download from other https sites (as the realhostip one is always loaded). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...
Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1555#discussion_r64134745 --- Diff: systemvm/scripts/config_ssl.sh --- @@ -123,6 +123,8 @@ customCACert= publicIp= hostName= keyStore=$(dirname $0)/certs/realhostip.keystore +defaultJavaKeyStoreFile=/etc/ssl/certs/java/cacerts +defaultJavaKeyStorePass=changeit --- End diff -- Those are the defaults of the OS, so Debian in this case. The passwd is the default one from Java itself. I see no reason now why you should want that to be configurable. It is possible with a global settings, then passing that via cmd_line to the vm and read it here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1555#issuecomment-220767434 Thanks @milamberspace! I was also looking into this and hacked around a bit. Your solution is nice! Now when a custom cert is used, the other CAs are also available and we're able to verify certificates again. Tested it, works fine so LGTM. The only remaining issue I see is that I cannot connect to servers that require TLSv1.2. Need to look into that further and see if it's something on the SSVM or something on the remote server. But let's merge this as with this PR the situation when using a custom cert and when not using a cert are the same. By the way, for already running environments, you can do this to import the missing certs: ``` defaultJavaKeyStoreFile=/etc/ssl/certs/java/cacerts defaultJavaKeyStorePass=changeit keyStore=/usr/local/cloud/systemvm/certs/realhostip.keystore storepass="vmops.com" keytool -importkeystore -srckeystore $defaultJavaKeyStoreFile -destkeystore $keyStore -srcstorepass $defaultJavaKeyStorePass -deststorepass $storepass ``` Result: ``` root@s-2-VM:~# keytool -importkeystore -srckeystore $defaultJavaKeyStoreFile -destkeystore $keyStore -srcstorepass $defaultJavaKeyStorePass -deststorepass $storepass Import command completed: 172 entries successfully imported, 0 entries failed or cancelled ``` Ping @swill --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Lower the time we wait for interfaces to ...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1471#issuecomment-219944851 @swill Thanks for running the tests again. The error is `Failed to delete network` so that's cleanup related. The failed one, is that the one that randomly? Can't think of a way that it is related to the change in this PR. It looks OK to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Make the generated json files unique to p...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1470#issuecomment-219432167 @swill I can only reproduce the loadbalance errors, not the others. When I look at the errors I doubt they are related. They work fine for me. But anyway, no more time available for me to work on this unfortunately. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: prevent RTNETLINK errors as we were itera...
Github user remibergsma closed the pull request at: https://github.com/apache/cloudstack/pull/1404 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: zip the processed json files so we save d...
Github user remibergsma closed the pull request at: https://github.com/apache/cloudstack/pull/1421 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9379: Support nested virtualiz...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1542#issuecomment-219206665 KVM also has this feature and there you can enable/disable it in the agent.properties file (ant not per VM). We should try to make the code as generic as possible, instead of implementing it like this IMHO. Why do you want to control this per VM by the way? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Make the generated json files unique to p...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1470#issuecomment-219037267 Pushed the fix and the tests now pass: ``` [root@cs2 cloudstack]# cat /tmp//MarvinLogs/test_network_7VU0DJ/results.txt Test for port forwarding on source NAT ... === TestName: test_01_port_fwd_on_src_nat | Status : SUCCESS === ok Test for port forwarding on non source NAT ... === TestName: test_02_port_fwd_on_non_src_nat | Status : SUCCESS === ok Test for reboot router ... === TestName: test_reboot_router | Status : SUCCESS === ok Test for Router rules for network rules on acquired public IP ... === TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : SUCCESS === ok Test for Router rules for network rules on acquired public IP ... === TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS === ok Test for Router rules for network rules on acquired public IP ... === TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : SUCCESS === ok -- Ran 6 tests in 1519.164s OK ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Reimplement router.redundant.vrrp.interva...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1486#issuecomment-219031280 Resolved conflict --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Lower the time we wait for interfaces to ...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1471#issuecomment-219029943 @jburwell Had a look at the `wait_until` method and I don't think it will work well here. The problem is that when the router restarts, it has the full config in `/etc/cloudstack/*.json` but several interfaces are not yet available as they are plugged later. By using `wait_ultil` and try every 2s for max of 15s, we get the old behaviour of having to wait 15s in case the interface is not there. When the interface _is_ there, it will go through almost immediately. I propose to keep it like this as I've seen it speedup start times quite a bit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CPU socket count reporting correction
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1520#issuecomment-219027354 LGTM, running this in prod for about a month now. See link above for screenshots. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Make the generated json files unique to p...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1470#issuecomment-219005330 @swill @kiwiflyer I run the integration tests over night and they look much better now. I only see some test fail in `smoke/test_network.py` that seem to have the same root cause. Will look into that tonight. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Lower the time we wait for interfaces to ...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1471#issuecomment-218854911 @jburwell Thanks, I'll look into that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1482#issuecomment-218852007 @kiwiflyer I'll see if I can get it out completely ;-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Reimplement router.redundant.vrrp.interva...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1486#issuecomment-218783498 Force pushed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Make the generated json files unique to p...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1470#issuecomment-218595232 Worked with @swill and @kiwiflyer and found the issue: one bit was missing in the backport from Cosmic. Will look into that tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: KVM: Fix plugging ip addresses to the wro...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1524#issuecomment-216064935 @kiwiflyer Sorry but this seems to have issues. We run this in prod with Cosmic but apparently some other patch is missing here in order for this to work properly. Unfortunately I have no more time to work on this now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: KVM: Fix plugging ip addresses to the wro...
Github user remibergsma closed the pull request at: https://github.com/apache/cloudstack/pull/1524 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: zip the processed json files so we save d...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1421#issuecomment-216030620 Force pushed again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Reimplement router.redundant.vrrp.interva...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1486#issuecomment-216030568 Also force pushed this one again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: KVM: Fix plugging ip addresses to the wro...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1524#issuecomment-216030504 Force pushed a final time, else I give up on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: KVM: Fix plugging ip addresses to the wro...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1524#issuecomment-216030450 This time around Jenkins is happy and Travis times out :-s ``` No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself. ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: KVM: Fix plugging ip addresses to the wro...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1524#issuecomment-215991817 Jenkins error says: `Unable to instrument project`, seems like a workspace issue or such. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: zip the processed json files so we save d...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1421#issuecomment-215988060 @swill force pushed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Reimplement router.redundant.vrrp.interva...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1486#issuecomment-215988010 @swill force pushed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1482#issuecomment-215987980 @swill conflict resolved --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Bump ssh retries to prevent false positiv...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1473#issuecomment-215987371 @swill Force pushed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: KVM: Fix plugging ip addresses to the wro...
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1524 KVM: Fix plugging ip addresses to the wrong interface Fix for KVM, where the public ip would be added to the guest network. Reason is because it used 'broadcastUrl' as an index, which turned out not to be unique in all cases and was overwritten. This resulted in the public ip address being added to the wrong interface (see screenshots). Problem:  After patch:  The `192.168.23.0/24` range is used as 'public' in this lab. You can merge this pull request into a Git repository by running: $ git pull https://github.com/remibergsma/cloudstack fix/libvirt-interfaces Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1524.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1524 commit 4f3b0f56cbb9e1e16182109c797fcceff578d7ea Author: Remi Bergsma <git...@remi.nl> Date: 2016-04-30T18:13:44Z KVM: Fix plugging ip addresses to the wrong interface --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Remove unused images
Github user remibergsma closed the pull request at: https://github.com/apache/cloudstack/pull/1475 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CPU socket count reporting correction
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1520#issuecomment-215143007 @swill more details here: https://github.com/MissionCriticalCloud/cosmic-plugin-hypervisor-kvm/pull/16 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix deleting template from UI
Github user remibergsma closed the pull request at: https://github.com/apache/cloudstack/pull/1476 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Check the existence of 'forceencap' param...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1402#issuecomment-211818185 @alexandrelimassantana @swill Thanks guys, fixed it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Strongswan vpn feature
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-211094168 @jayapalu The strongswan service is now started automatically on all systemvms (including console proxy and seconday storage vm). I think we should start it only on-demand? Currently testing it, will take some more time but I'll report back. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1494#issuecomment-209893539 @nlivens Please add a description because this confuses me ;-) You guys go the non-oss way? :-( --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Remove unused images
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1475#issuecomment-209020597 @rafaelweingartner +1 to remove all that stuff --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: agent: Enable IPv6 connectivity for KVM A...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1488#issuecomment-208819704 @wido Great! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Strongswan vpn feature
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-208817879 @jayapalu Please talk to @swill before merge. I'll also have another look at it and see if I can get it to work this time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Remove unused images
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1475#issuecomment-208794882 @swill force pushed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Bump ssh retries to prevent false positiv...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1473#issuecomment-208795627 @swill force pushed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9287 - Fix unique mac address ...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1483#issuecomment-208794235 @swill force pushed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Reimplement router.redundant.vrrp.interva...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1486#issuecomment-208793335 @swill force pushed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Reimplement router.redundant.vrrp.interva...
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1486 Reimplement router.redundant.vrrp.interval setting Global setting `router.redundant.vrrp.interval` is not used any more and it is now set to a hardcoded 1. This results in a failover from master->backup when the backup doesn't hear from the master in ~3.6sec. This is a bit too tight, as we've seen failovers during live migrations. We could reproduce it in about half of the cases. Setting this to setting to 2 (tested it by hardcoding it in the systemvms) gives twice as much time and we didn't see issues any more. Instead of updating the hardcoded setting from 1 to 2, I reimplemented the global setting by sending it to the router with the cmd_line, as the non-VPC router also does. Background: Why is the maximum failover time in the example 3.6 seconds? This comes from the advertisement interval and the skew time. The default advertisement interval is 1 second (configurable in keepalived.conf). The skew time helps to keep everyone from trying to transition at once. It is a number between 0 and 1, based on the formula (256 - priority) / 256 As defined in the RFC, the backup must receive an advertisement from the master every (3 * advert_int) + skew_time seconds. If it doesn't hear anything from the master, it takes over. With a backup router priority of 100 (as in the example), the failover will happen at most 3.6 seconds after the master goes down. Source: http://www.hollenback.net/KeepalivedForNetworkReliability You can merge this pull request into a Git repository by running: $ git pull https://github.com/remibergsma/cloudstack reimplement-vrrp-setting-47 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1486.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1486 commit c33358db848faf8c8891e00e0100a2627b177407 Author: Remi Bergsma <git...@remi.nl> Date: 2016-03-23T15:33:20Z Have rVPCs use the router.redundant.vrrp.interval setting It defaults to 1, which is hardcoded in the template: ./cosmic/cosmic-core/systemvm/patches/debian/config/opt/cloud/templates/keepalived.conf.templ As non-VPC redundant routers use this setting, I think it makes sense to use it for rVPCs as well. We also need a change to pickup the cmd_line parameter and use it in the Python code that configures the router. commit 408478413ad0469265dfa0ce9101d6337f558ab2 Author: Remi Bergsma <git...@remi.nl> Date: 2016-03-23T15:56:54Z Configure rVPC for router.redundant.vrrp.interval advert_int setting --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Set default networkDomain to empty instea...
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1485 Set default networkDomain to empty instead of username The 10th field of `createUserAccount` is `networkDomain` (See `AccountService.java`) and it is set to a var named `admin`, which is the user name. So, the first user that is created in a domain that links to LDAP, creates the account within the domain, and sets the `networkDomain` field to the username. All next users are created in the same account. Then we have the situation that in domain SBP we have a user `rbergsma` that logs in first, gets an account created and then (unless you override) all VMs started in the SBP domain will have network domain `rbergsma`. That is highly confusing and not what is should be. The `linkDomainToLdap` api call has no `networkDomain` field, so I propose to make this field empty (set it to null). It's a sting and null / empty is allowed. One can also specify the networkDomain when creating a VPC and also there it is allowed to be null. When te networkDomain is needed (and is not set in the domain and not in the VPC) it is constructed by using `guest.domain.suffix` so there always is a networkDomain to be used. It makes more sense to manually set it on a domain level, or specify it on the VPC and in the final case end up with something that is clearly generated (like cs342cloud.local) rather than the username of someone else. You can merge this pull request into a Git repository by running: $ git pull https://github.com/remibergsma/cloudstack fix-ldap-default-domain Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1485.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1485 commit 9e1859ee2bbe82ad742c30cd9ca9aa7393d34f36 Author: Remi Bergsma <git...@remi.nl> Date: 2016-04-10T17:50:32Z Set default networkDomain to empty instead of username The 10th field of createUserAccount is 'networkDomain' (AccountService.java) and it is set to a var named 'admin', which is the user name. So, the first user that is created in a domain that links to LDAP, creates the account within the domain, and sets the 'networkDomain' field to the username. All next users are created in the same account. Then we have the situation that in domain SBP we have a user 'rbergsma' that logs in first, gets an account created and then (unless you override) all VMs started in the SBP domain will have network domain 'rbergsma'. That is highly confusing and not what is should be. linkDomainToLdap api call has no 'networkDomain' field, so I propose to make this field empty (set it to null). It's a sting and null / empty is allowed. One can also specify the networkDomain when creating a VPC and also there it is allowed to be null. When te networkDomain is needed (and is not set in the domain and not in the VPC) it is constructed by using guest.domain.suffix so there always is a netWork domain to be used. It makes more sense to manually set it on a domain level, or specify it on the VPC and in the final case end up with something that is clearly generated (like cs342cloud.local) rather than the username of someone else. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9287 - Fix unique mac address ...
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1483 CLOUDSTACK-9287 - Fix unique mac address per rVPC router This is work by @wilderrodrigues, see PR #1413 It contains important fixes and I think it needs to be included so I send the PR again. You can merge this pull request into a Git repository by running: $ git pull https://github.com/remibergsma/cloudstack pr1413-wilder-47 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1483.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1483 commit f921ec686bcf339968040c57bf0ae9fceffd8fed Author: Wilder Rodrigues <wrodrig...@schubergphilis.com> Date: 2016-02-13T11:59:20Z CLOUDSTACK-9287 - Generate new mac address if router is redundant and nic profile exists commit d93b008deb2ced326b314fefbe11511d798be5e8 Author: Wilder Rodrigues <wrodrig...@schubergphilis.com> Date: 2016-02-13T14:48:30Z CLOUDSTACK-9287 - Put private gateway interface down on backup router commit 250be376e879b6c43792fdb5af0f5c49747689da Author: Wilder Rodrigues <wrodrig...@schubergphilis.com> Date: 2016-02-13T16:29:14Z CLOUDSTACK-9287 - Add integration test to cover the private gw interface/mac address issues commit 057b54aa3e8a462b3ced9b53d7a55dd5a64a0e4e Author: Remi Bergsma <git...@remi.nl> Date: 2016-02-14T13:39:53Z CLOUDSTACK-9287 - Make sure private gw interface is not used for default gw commit 6a767732f959186e95c71d31a2ed49bb67a85473 Author: Remi Bergsma <git...@remi.nl> Date: 2016-02-14T17:09:03Z CLOUDSTACK-9287 - Bring up the private gw interface on state change to master commit 850fb1a557b8eec04de79124fea5b6f923530d66 Author: Wilder Rodrigues <wrodrig...@schubergphilis.com> Date: 2016-02-17T06:16:23Z CLOUDSTACK-9287 - Check if the nic profile has already been removed from a certain router - In case of redundant VPCs, the ACL items are revoked in the first iteration. Since the econd iteration is needed in order to remove the private network, we have to check if the nic profile is gone before trying to revoke the ACL items again, which would throw a NPE. - Some variable extraction in order to ease debugging. commit c41edc1fe62cf92ab85c59c6da4dced9e626d961 Author: Wilder Rodrigues <wrodrig...@schubergphilis.com> Date: 2016-02-17T06:31:39Z CLOUDSTACK-9287 - Refactor the interface state configuration - This also refactors the CsAddress in order to offer better readability in a couple of methods. commit 0e91468964b3b256497fa9dac50c63f9235ca102 Author: Wilder Rodrigues <wrodrig...@schubergphilis.com> Date: 2016-02-17T06:33:48Z CLOUDSTACK-9287 - Add integration test to cover the private gateway related changes commit 78bbd498e7c7cb58570025b85d02c8ff921065d5 Author: Wilder Rodrigues <wrodrig...@schubergphilis.com> Date: 2016-02-17T15:07:34Z CLOUDSTACK-9287 - Fix RVR public interface commit ffd8fdb45debe1ddcdf7c6706725cd26d4742cf2 Author: Wilder Rodrigues <wrodrig...@schubergphilis.com> Date: 2016-02-17T15:43:16Z CLOUDSTACK-9287 - Improve test by checking if pvt gw is removed and fix typos --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1482 Restore iptables at once using iptables-restore instead of calling iptables numerous times This makes handling the firewall rules about 50-60 times faster because it is generated in memory and then loaded once. It's work by @borisroman see PR #1400. Reopened it here because I think this is a great improvement. You can merge this pull request into a Git repository by running: $ git pull https://github.com/remibergsma/cloudstack iptables-fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1482.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1482 commit 0f75042566b7cc72666708485bdaa9337721e9fe Author: Boris Schrijver <bschrij...@schubergphilis.com> Date: 2016-02-01T14:57:26Z Add iptables copnversion script. Source: https://raw.githubusercontent.com/sl0/conv/master/iptables_converter.py commit b857f79fcb14b9594840e483cfcf0e4c0fac2f6b Author: Boris Schrijver <bschrij...@schubergphilis.com> Date: 2016-02-01T14:58:27Z Restore iptables at once using iptables-restore instead of calling iptables numerous times commit 69e9348900e6337a16788a54283d5c9ee3b7a221 Author: Boris Schrijver <bschrij...@schubergphilis.com> Date: 2016-02-03T14:30:19Z Remove duplicate spaces, and thus duplicate rules. commit eb9706b6558d5113000a6c10d861308fbc8cd692 Author: Boris Schrijver <bschrij...@schubergphilis.com> Date: 2016-02-03T15:15:28Z Wait for dnsmasq to finish restart commit 18d5cd285536954403cf5eec64024e5909e55d41 Author: Boris Schrijver <bschrij...@schubergphilis.com> Date: 2016-02-05T20:04:06Z Do not load previous firewall rules as we replace everyhing anyway commit 709be45cf0f32bacc54ec2384be9e54bd62a5acf Author: Boris Schrijver <bschrij...@schubergphilis.com> Date: 2016-02-05T20:06:53Z Check the existence of 'forceencap' parameter before use commit 30741a3309da346f324a8f365cb6ef8e1aab39d8 Author: Boris Schrijver <bschrij...@schubergphilis.com> Date: 2016-02-05T20:11:59Z Split the cidr lists so we won't hit the iptables-resture limits --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Remove unused images
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1475#issuecomment-207251541 Travis error is unrelated obviously: ``` No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself. ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: When no zone name is available display a ...
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1477 When no zone name is available display a default When a zone name is available, the previous behaviour is still there:  When there is no zone name, it used to display an empty name (where you had to click on to see details):  With this change, a default name `All` is displayed (because this happens when S3 storage is used that is region wide aka all zones):  Region wide S3:  FYI: Screenshot shows 'All', later renamed to 'All Zones', see code. You can merge this pull request into a Git repository by running: $ git pull https://github.com/remibergsma/cloudstack 47_default_zone_name_s3 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1477.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1477 commit aead9f4ff43ea79107e2b870ab49fcf2f3fd7a0d Author: Remi Bergsma <git...@remi.nl> Date: 2016-04-07T19:57:17Z When no zone name is available display a default Backport from Cosmic --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fix deleting template from UI
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1476 Fix deleting template from UI It failed because zoneid was zero. Added a check for it and only send it when it makes sense. With zoneid:  Without:  Both result in:  You can merge this pull request into a Git repository by running: $ git pull https://github.com/remibergsma/cloudstack 47_fix_del_template_s3 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1476.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1476 commit 503afad7d22ccf105eef1c19bf8ff5729209ca19 Author: Remi Bergsma <git...@remi.nl> Date: 2016-04-07T19:52:57Z Fix deleting template from UI Backport from Cosmic --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Remove unused images
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1475 Remove unused images We really don't need this, do we? Check your own cloud, it's there...  You can merge this pull request into a Git repository by running: $ git pull https://github.com/remibergsma/cloudstack 47_unused_image Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1475.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1475 commit 3961ac24188a676482f75a71e1ba31e3f462481f Author: Remi Bergsma <git...@remi.nl> Date: 2016-04-07T19:49:06Z Remove unused images --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: 47 private gw initial config
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1474
47 private gw initial config
When initialising a VPC router we need to know which IP/device corresponds
to a private gateway. This is to solve a problem when stop/starting a VPC
router (which gets the private gateway config as a guest network and as a
result breaks the functionality). You read it right, the private gateway is
sent as type=guest after reboot and type=public initially.
Before this change, you could add a private gw to a running router but you
couldn't restart it (it would mix up the tiers). Now the private gateway is
detected properly and it works just fine.
Booting without private gateway:
```
root@r-167-VM:~# cat /etc/cloudstack/cmdline.json
{
"config": {
"baremetalnotificationapikey":
"V2l1u3wKJVan01h8kq63-5Y5Ia3VLEW1v_Z6i-31QIRJXlt5vkqaqf6DVcdK0jP3u79SW6X9pqJSLSwQP2c2Rw",
"baremetalnotificationsecuritykey":
"OXI16srCrxFBi-xOtEwcYqwLlMfSFTlTg66YHtXBBqR7HNN1us3HP5zWOKxfVmz4a3C1kUNLPrUH13gNmZlu4w",
"disable_rp_filter": "true",
"dns1": "8.8.8.8",
"domain": "cs2cloud",
"eth0ip": "169.254.0.42",
"eth0mask": "255.255.0.0",
"host": "192.168.22.61",
"name": "r-167-VM",
"port": "8080",
"privategateway": "None",
"redundant_router": "false",
"template": "domP",
"type": "vpcrouter",
"vpccidr": "10.0.0.0/24"
},
"id": "cmdline"
```
Booting with private gateway:
```
root@r-167-VM:~# cat /etc/cloudstack/cmdline.json
{
"config": {
"baremetalnotificationapikey":
"V2l1u3wKJVan01h8kq63-5Y5Ia3VLEW1v_Z6i-31QIRJXlt5vkqaqf6DVcdK0jP3u79SW6X9pqJSLSwQP2c2Rw",
"baremetalnotificationsecuritykey":
"OXI16srCrxFBi-xOtEwcYqwLlMfSFTlTg66YHtXBBqR7HNN1us3HP5zWOKxfVmz4a3C1kUNLPrUH13gNmZlu4w",
"disable_rp_filter": "true",
"dns1": "8.8.8.8",
"domain": "cs2cloud",
"eth0ip": "169.254.2.227",
"eth0mask": "255.255.0.0",
"host": "192.168.22.61",
"name": "r-167-VM",
"port": "8080",
"privategateway": "10.201.10.1",
"redundant_router": "false",
"template": "domP",
"type": "vpcrouter",
"vpccidr": "10.0.0.0/24"
},
"id": "cmdline"
```
And:
```
cat cmdline
vpccidr=10.0.0.0/24 domain=cs2cloud dns1=8.8.8.8 privategateway=10.201.10.1
template=domP name=r-167-VM eth0ip=169.254.2.227 eth0mask=255.255.0.0
type=vpcrouter disable_rp_filter=true
baremetalnotificationsecuritykey=OXI16srCrxFBi-xOtEwcYqwLlMfSFTlTg66YHtXBBqR7HNN1us3HP5zWOKxfVmz4a3C1kUNLPrUH13gNmZlu4w
baremetalnotificationapikey=V2l1u3wKJVan01h8kq63-5Y5Ia3VLEW1v_Z6i-31QIRJXlt5vkqaqf6DVcdK0jP3u79SW6X9pqJSLSwQP2c2Rw
host=192.168.22.61 port=8080
```
Logs:
```
2016-02-24 20:08:45,723 DEBUG
[c.c.n.r.VpcVirtualNetworkApplianceManagerImpl]
(Work-Job-Executor-4:ctx-458d4c52 job-1402/job-1403 ctx-d5355fca)
(logid:5772906c) Set privategateway field in cmd_line.json to 10.201.10.1
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/remibergsma/cloudstack
47_private_gw_initial_config
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1474.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1474
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
