Github user sverrirab commented on the issue:
https://github.com/apache/cloudstack/pull/1634
+1 from me (for what it's worth)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user sverrirab commented on the issue:
https://github.com/apache/cloudstack/pull/1633
adding the python-argparse dependency is fine by me. I have not tested
that combination though.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user sverrirab commented on the issue:
https://github.com/apache/cloudstack/pull/1633
The reason for my suggestion is that I don't think anyone should be running
python 2.6 in production. The last update for it was in 2008 so I would
consider it risky at this point
Github user sverrirab commented on the issue:
https://github.com/apache/cloudstack/pull/1633
The updated script that now depends on python 2.7 (or python 2.6 + argparse
I assume) is replacing the perl installation requirement that was there before.
Would it not be the correct
Github user sverrirab closed the pull request at:
https://github.com/apache/cloudstack/pull/1526
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user sverrirab commented on the pull request:
https://github.com/apache/cloudstack/pull/1533#issuecomment-221026255
everything looking good now it seems - time to merge @swill ?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user sverrirab commented on the pull request:
https://github.com/apache/cloudstack/pull/1533#issuecomment-220644228
Rebased the PR to latest master and reverted the relevant commit
(64b72a5c5a410f41bd869cc9d40807d888e05055.). I think we should be good to go
@swill
Github user sverrirab commented on the pull request:
https://github.com/apache/cloudstack/pull/1533#issuecomment-219751032
@wido I just pushed an update that addresses the comments from @jburwell
tested this locally as well of course
---
If your project is set up
Github user sverrirab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1533#discussion_r62309904
--- Diff: scripts/vm/hypervisor/kvm/patchviasocket.py ---
@@ -0,0 +1,80 @@
+#!/usr/bin/env python
+# Licensed to the Apache Software Foundation
GitHub user sverrirab opened a pull request:
https://github.com/apache/cloudstack/pull/1533
Convert patchviasocket to python (removes perl dependency for KVM agent)
As requested here: https://github.com/apache/cloudstack/pull/1495
No scripts are using perl so that install
Github user sverrirab commented on the pull request:
https://github.com/apache/cloudstack/pull/1495#issuecomment-216233064
Created new PR on master: https://github.com/apache/cloudstack/pull/1526
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user sverrirab opened a pull request:
https://github.com/apache/cloudstack/pull/1526
Add perl-modules as install dependency for cloudstack-agent
Required to run perl scripts that configure networking for VMs.
That script fails silently if this is not installed
Github user sverrirab commented on the pull request:
https://github.com/apache/cloudstack/pull/1495#issuecomment-214783340
do you want this change as a new PR against master or just the rewritten
script in python on master?
---
If your project is set up for it, you can reply
Github user sverrirab commented on the pull request:
https://github.com/apache/cloudstack/pull/1495#issuecomment-210485675
I agree that this is not a good approach but it is the current one and it
is broken. How about we commit this fix and I submit a new PR to master with a
new
GitHub user sverrirab opened a pull request:
https://github.com/apache/cloudstack/pull/1495
Add perl-modules as install dependency for cloudstack-agent
Required to run perl scripts that configure networking for VMs.
You can merge this pull request into a Git repository by running
GitHub user sverrirab opened a pull request:
https://github.com/apache/cloudstack/pull/1490
Installing bzip2 since it is required for extracting templates
If you do not install bzip2, then installing templates that are bzip2
compressed will result in Cloudstack not being able
16 matches
Mail list logo
